Minetest logo

IRC log for #minetest-dev, 2019-05-26

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:12 Fritigern joined #minetest-dev
00:17 OxE7 joined #minetest-dev
00:20 OxE7` joined #minetest-dev
00:23 OxE7`` joined #minetest-dev
00:42 Cornelia joined #minetest-dev
00:46 paramat joined #minetest-dev
00:51 OxE7` joined #minetest-dev
01:42 reductum joined #minetest-dev
01:56 OxE7`` joined #minetest-dev
01:58 OxE7 joined #minetest-dev
02:01 pauloue joined #minetest-dev
02:15 OxE7` joined #minetest-dev
02:25 OxE7`` joined #minetest-dev
02:29 reductum joined #minetest-dev
02:37 OxE7` joined #minetest-dev
03:13 luk3yx joined #minetest-dev
03:39 OxE7`` joined #minetest-dev
04:18 OxE7` joined #minetest-dev
04:47 Fritigern joined #minetest-dev
07:03 Krock joined #minetest-dev
07:33 YuGiOhJCJ joined #minetest-dev
08:01 Krock Will push fix for #5739 in 30 minutes https://krock-works.uk.to/u/patches/0001-Fix-persistent-brighten-after-damage-again-5739.patch
08:01 ShadowBot https://github.com/minetest/minetest/issues/5739 -- player texture brightens on damage
08:04 Krock references are fancy pointers; but sometimes a copy is required when it involves one of the value-swapped variables
08:39 AntumDeluge joined #minetest-dev
08:50 Krock pushing...
08:50 Krock done
09:57 OxE7`` joined #minetest-dev
10:17 Fixer joined #minetest-dev
10:19 OxE7` joined #minetest-dev
11:49 proller joined #minetest-dev
13:05 Wuzzy joined #minetest-dev
13:44 proller joined #minetest-dev
14:07 p_gimeno late but :+1:
14:09 p_gimeno a faster, shorter and more robust fix might have been to use updateTextures(std::string(m_previous_texture_modifier))
14:09 p_gimeno but "more robust" would be debatable
14:12 Krock ofc, that's manual string copying, the other possibility
14:14 p_gimeno the advantage being that it's only done when needed
14:15 Krock this function is called so rarely that it makes no difference at all in performance
14:15 p_gimeno that way it would be guarded against attempts to optimize the declarations, though, which is why it feels a bit more robust
14:17 p_gimeno anyway, it's good as is. MT *really* needs comments of this kind all over the code.
14:20 p_gimeno I've been looking into #8552 but Irrlicht makes thing really, REALLY difficult
14:20 ShadowBot https://github.com/minetest/minetest/issues/8552 -- Rotate player view based on the rotation of entity player is atatched to
14:23 p_gimeno basically, attaching the camera scene node to the player does not affect the rotation, which is itself a WTF; there's a setViewMatrixAffector but it multiplies in the wrong order to be useful
14:24 p_gimeno maybe setting setViewMatrixAffector to View^-1 * HeadMatrix * View would fix things but that's three matrix multiplications
14:27 p_gimeno (and an inverse)
14:37 proller joined #minetest-dev
15:01 Foz joined #minetest-dev
15:02 kaeptmblaubaer joined #minetest-dev
15:24 chAndrei joined #minetest-dev
15:43 Ruslan1 joined #minetest-dev
15:54 Gael-de-Sailly joined #minetest-dev
16:20 OxE7`` joined #minetest-dev
16:35 Beton joined #minetest-dev
17:43 calcul0n joined #minetest-dev
18:38 paramat joined #minetest-dev
19:12 paramat rubenwardy is game#2365 correct? (1 line CDB-related PR)
19:12 ShadowBot https://github.com/minetest/minetest_game/issues/2365 -- Capitalize author in game.conf to match ContentDB by pauloue
19:13 rubenwardy Its the correct capitalisation, but it shouldn't matter if the engine is fixed
19:13 rubenwardy Still worth having anyway
19:15 paramat ok thanks
19:15 paramat will merge
19:17 paramat merging game#2366 too
19:17 ShadowBot https://github.com/minetest/minetest_game/issues/2366 -- wool to make use of global dye.dyes by Zweihorn
19:34 ensonic joined #minetest-dev
21:38 proller joined #minetest-dev
22:19 OxE7` joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext