Minetest logo

IRC log for #minetest-dev, 2019-04-04

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:35 ANAND joined #minetest-dev
00:43 paramat joined #minetest-dev
01:18 Miner_48er joined #minetest-dev
02:03 Cornelia joined #minetest-dev
02:33 ssieb joined #minetest-dev
02:44 Lord_Vlad joined #minetest-dev
03:43 Lia joined #minetest-dev
04:25 paramat joined #minetest-dev
06:01 kaeza joined #minetest-dev
06:55 ANAND #8443 anyone? It literally adds 2 lines.
06:55 ShadowBot https://github.com/minetest/minetest/issues/8443 -- Add deprecation warnings for ObjectRef:get/set_attribute by ClobberXD
06:56 ANAND Trivial PR #8438 has already been approved by paramat (just one additional char added :P). Does it require another approval?
06:57 ShadowBot https://github.com/minetest/minetest/issues/8438 -- Change sign of pitch angle in debug menu by ClobberXD
07:06 ensonic joined #minetest-dev
08:14 Beton joined #minetest-dev
08:43 karamel joined #minetest-dev
08:56 proller joined #minetest-dev
09:00 karamel_ joined #minetest-dev
09:47 Darcidride joined #minetest-dev
10:01 oil_boi_minetest joined #minetest-dev
10:23 twoelk joined #minetest-dev
10:49 twoelk|2 joined #minetest-dev
10:50 Fixer joined #minetest-dev
10:52 twoelk|2 left #minetest-dev
10:52 proller joined #minetest-dev
10:54 twoelk joined #minetest-dev
10:55 calcul0n_ joined #minetest-dev
11:17 Wuzzy joined #minetest-dev
11:21 ANAND Trivial README PR: #8449
11:21 ShadowBot https://github.com/minetest/minetest/issues/8449 -- README: Remove inaccurate info about RUN_IN_PLACE by ClobberXD
11:23 proller joined #minetest-dev
11:26 Megaf joined #minetest-dev
12:42 Megaf_ joined #minetest-dev
13:18 * twoelk lazily tries to raise a hand o_
13:20 fluxflux joined #minetest-dev
14:39 behalebabo joined #minetest-dev
14:52 behalebabo joined #minetest-dev
15:03 kaeza joined #minetest-dev
15:12 behalebabo joined #minetest-dev
15:24 behalebabo joined #minetest-dev
15:25 behalebabo joined #minetest-dev
15:48 Foz joined #minetest-dev
16:12 argyle77 joined #minetest-dev
16:32 ANAND_ joined #minetest-dev
16:35 ANAND_ joined #minetest-dev
17:03 p_gimeno Regression fix: https://gitlab.com/pgimeno/minetest/merge_requests/5
17:05 sfan5 haven't kept up with the "accept PRs from non-github" discussion, but I don't think any of this will work in practice unless someone creates a counterpart PR on github
17:05 p_gimeno I'm no longer on github, though, so that can't be me
17:05 p_gimeno there were a few proposals in the issue
17:06 p_gimeno currently I'm sending the MR against my own repository, because the MT repository in GH has merge requests disabled
17:06 p_gimeno in GL*
17:15 sofar we don't accept PRs though GL, it's just a one way mirror
17:15 p_gimeno I know that's how it currently is, but there's #7901
17:16 ShadowBot https://github.com/minetest/minetest/issues/7901 -- Accepting PRs/patches from non-Github users
17:19 sofar I have to click 5 times to see your change on GL
17:19 sofar not an improvement
17:19 sofar (overall I find GL confusing... very confusing)
17:20 p_gimeno I know, I personally prefer notabug (gogs). But it's still an improvement, in that you _can_ see my change
17:21 p_gimeno I chose GL because several MT developers are already registered there, so it's easier for them to comment.
17:23 p_gimeno not sure how you come up with 5 clicks though, from the link above you can click on the 'Changes' tab (1 click)
17:33 sofar there is no "Changes" tab
17:33 sofar https://gitlab.com/pgimeno/minetest/merge_requests/5 -> I went here
17:34 sofar holy cow there is
17:34 sofar see? this is why I fricken hate gitlab's interface
17:34 p_gimeno between the thumbs and the edit pane
17:34 p_gimeno yeah I know
17:35 sofar Most important element? hidden at the bottom, wasting away between shit that's irrelevant
17:35 p_gimeno https://notabug.org/pgimeno/minetest/pulls/4 if you prefer
17:37 p_gimeno GL seems to have taken ideas from the already confusing bitbucket, and made them even more confusing
17:37 p_gimeno rants apart, I can submit to both GL and NotABug if that helps in any way
17:40 sofar nope
17:40 sofar the problem is that the discussion thread is just as important to keep and maintain as the patch itself
17:40 sofar if we allow PRs on gitlab, we'd have 2 places for discussion
17:41 sofar that is totally unacceptable imho
17:41 sofar there are 2 ways out:
17:41 sofar 1) self-hosted
17:41 sofar 2) mailinglist
17:42 sofar anything else is going to do worse and split discussion threads and cause people to not be able to partake
17:44 p_gimeno there was a suggestion of using a bot, I guess that bot can synchronize discussions
17:45 sofar please no
17:46 sofar we all know bots break and are time intensive, and if they break silently...
17:46 sofar plus really it is just an excuse to a proper solution
17:52 behalebabo joined #minetest-dev
18:07 behalebabo joined #minetest-dev
18:09 behalebabo joined #minetest-dev
18:23 ssieb joined #minetest-dev
18:34 Unarelith joined #minetest-dev
18:54 Cornelia joined #minetest-dev
18:55 twoelk left #minetest-dev
19:07 Darcidride joined #minetest-dev
19:17 ensonic joined #minetest-dev
19:19 Cornelia joined #minetest-dev
20:23 ensonic joined #minetest-dev
20:33 benrob0329 joined #minetest-dev
20:35 proller joined #minetest-dev
20:43 chacha joined #minetest-dev
21:10 paramat joined #minetest-dev
21:13 paramat wil merge #8438 in 15 mins
21:13 ShadowBot https://github.com/minetest/minetest/issues/8438 -- Change sign of pitch angle in debug menu by ClobberXD
21:14 paramat simple PR #8440 any opinions?
21:14 ShadowBot https://github.com/minetest/minetest/issues/8440 -- Android settings: Use opaque leaves instead of fancy by paramat
21:15 paramat #8417 is a simple bugfix so i might merge it later as trivial if no objections, there will be a follow-up PR for codestyle and other improvements
21:15 ShadowBot https://github.com/minetest/minetest/issues/8417 -- Stabilise 'day night ratio' to fix object brightness flicker by paramat
21:15 benrob0329 joined #minetest-dev
21:33 GreenDimond joined #minetest-dev
21:41 paramat merging #8438
21:41 ShadowBot https://github.com/minetest/minetest/issues/8438 -- Change sign of pitch angle in debug menu by ClobberXD
21:47 DI3HARD139 joined #minetest-dev
21:51 diemartin joined #minetest-dev
21:54 Edgy1 joined #minetest-dev
21:54 Edgy1 joined #minetest-dev
22:17 Edgy1 joined #minetest-dev
22:24 Edgy1 joined #minetest-dev
22:29 paramat merging #8417
22:29 ShadowBot https://github.com/minetest/minetest/issues/8417 -- Stabilise 'day night ratio' to fix object brightness flicker by paramat
22:29 Edgy1 joined #minetest-dev
22:29 Edgy1 joined #minetest-dev
22:47 kaeza joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext