| Time |
Nick |
Message |
| 00:09 |
rubenwardy |
although, I can't work out how to get a list of translators |
| 00:31 |
paramat |
could always do that later, merge this now? |
| 00:33 |
|
p_gimeno joined #minetest-dev |
| 00:36 |
rubenwardy |
sure |
| 00:40 |
paramat |
merging |
| 00:40 |
VanessaE |
aw, I didn't make the list :P |
| 00:42 |
|
p_gimeno joined #minetest-dev |
| 00:43 |
paramat |
ok, all blockers cleared! RC2 tomorrow hopefully |
| 00:44 |
|
GreenDimond joined #minetest-dev |
| 00:52 |
|
p_gimeno joined #minetest-dev |
| 01:23 |
|
pauloue joined #minetest-dev |
| 01:32 |
kaeza |
Yay I'm still there :D |
| 01:36 |
|
kaeza joined #minetest-dev |
| 02:02 |
VanessaE |
2019-02-16 03:00:59: ERROR[Main]: ModError: Runtime error from mod '*builtin*' in callback on_mods_loaded(): ...ocal/share/minetest/builtin/profiler/instrumentation.lua:64: attempt to concatenate field 'mod' (a nil value) |
| 02:02 |
VanessaE |
um??? |
| 02:05 |
p_gimeno |
is there a traceback? |
| 02:05 |
VanessaE |
yes |
| 02:05 |
p_gimeno |
that'd be useful |
| 02:05 |
VanessaE |
https://pastebin.ubuntu.com/p/cn9NfDCTsP/ |
| 02:06 |
VanessaE |
disabling the profiler by the config is enough to let it start. |
| 02:07 |
p_gimeno |
thanks, looking |
| 02:07 |
p_gimeno |
5.0.0? |
| 02:07 |
VanessaE |
mmhmm |
| 02:07 |
VanessaE |
master HEAD pulled half an hour ago. |
| 02:08 |
VanessaE |
(actually, an hour and a half ago) |
| 02:09 |
p_gimeno |
reproduced here |
| 02:17 |
p_gimeno |
hm, core.get_current_modname() is returning nil at some point, and that's causing a crash |
| 02:23 |
paramat |
ah perhaps stabar changes related |
| 02:24 |
paramat |
https://github.com/minetest/minetest/commit/eea1fdaf2574fec38316527cfc463ff2427c5775 |
| 02:30 |
p_gimeno |
seems so |
| 02:33 |
paramat |
i'll make an issue |
| 02:33 |
paramat |
one for smalljoker |
| 02:34 |
p_gimeno |
it's fixed by reverting that, so it's definitely related |
| 02:35 |
paramat |
thanks |
| 02:41 |
paramat |
p_gimeno did you reproduce it just with mtg and no optional mods? |
| 02:49 |
p_gimeno |
that's right, just turning on the profiler |
| 02:50 |
rubenwardy |
Looks like it's the last change |
| 02:50 |
rubenwardy |
I suggest adding a nil check for it |
| 02:50 |
rubenwardy |
It's because something is registered when no more is active |
| 02:50 |
p_gimeno |
rubenwardy: tried adding a nil check, that isn't enough |
| 02:50 |
rubenwardy |
In register on mods loaded |
| 02:51 |
p_gimeno |
ah |
| 03:00 |
|
Cornelia joined #minetest-dev |
| 03:01 |
paramat |
made an issue |
| 04:53 |
|
paramat joined #minetest-dev |
| 04:55 |
paramat |
nerzhul, for when you return, has the use of updatepo in merged #8230 caused any issues which need sorting out? |
| 04:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/8230 -- Update minetest.conf.example and settings strings and locale files by Wuzzy2 |
| 05:38 |
|
ichoquo0Aigh9ie joined #minetest-dev |
| 05:38 |
|
bobby joined #minetest-dev |
| 05:39 |
|
TC04 joined #minetest-dev |
| 06:02 |
|
T^4im joined #minetest-dev |
| 07:01 |
|
GreenDimond_ joined #minetest-dev |
| 07:25 |
|
twoelk left #minetest-dev |
| 07:29 |
nerzhul |
no, but it should not be merged as a regular commit user |
| 08:57 |
|
fwhcat joined #minetest-dev |
| 09:16 |
|
fwhcat joined #minetest-dev |
| 09:22 |
|
Beton joined #minetest-dev |
| 09:36 |
|
nolsen joined #minetest-dev |
| 10:14 |
|
kaeza joined #minetest-dev |
| 10:25 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:08 |
|
entuland joined #minetest-dev |
| 11:09 |
|
entuland_ joined #minetest-dev |
| 11:21 |
|
Krock joined #minetest-dev |
| 11:43 |
|
DI3HARD139 joined #minetest-dev |
| 12:05 |
|
Fixer joined #minetest-dev |
| 12:07 |
Krock |
working on alternative fix for #8237 |
| 12:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/8237 -- Profiler error caused by recent statbars commit |
| 12:35 |
|
kaeptmblaubaer joined #minetest-dev |
| 12:44 |
|
kaeptmblaubaer joined #minetest-dev |
| 12:44 |
|
kaeptmblaubaer joined #minetest-dev |
| 12:45 |
|
kaeptmblaubaer joined #minetest-dev |
| 12:51 |
|
kaeza joined #minetest-dev |
| 13:03 |
|
YuGiOhJCJ joined #minetest-dev |
| 13:06 |
|
proller joined #minetest-dev |
| 13:21 |
Krock |
wtf lint https://travis-ci.org/minetest/minetest/jobs/494193292 |
| 13:55 |
|
fwhcat joined #minetest-dev |
| 14:02 |
|
kaeptmblaubaer joined #minetest-dev |
| 14:11 |
|
proller joined #minetest-dev |
| 14:22 |
|
fwhcat joined #minetest-dev |
| 14:25 |
|
kaeptmblaubaer joined #minetest-dev |
| 14:27 |
|
kaeptmblaubaer joined #minetest-dev |
| 15:14 |
|
entuland_ joined #minetest-dev |
| 15:23 |
|
entuland_ joined #minetest-dev |
| 15:24 |
|
entuland_ joined #minetest-dev |
| 15:25 |
|
entuland_ joined #minetest-dev |
| 16:06 |
p_gimeno |
I'm having an issue with checkboxes, where the checkbox affected by clicks is the checkbox below the one I'm trying to click, see https://user-images.githubusercontent.com/4267396/52902075-f6e8ed00-320b-11e9-994e-62fc41556d8a.png |
| 16:07 |
p_gimeno |
it's happening on 0.4.16 as well, so I wonder whether to report it at all |
| 16:07 |
p_gimeno |
should I file a report? |
| 16:21 |
|
kaeptmblaubaer joined #minetest-dev |
| 16:24 |
Krock |
so it happens with 5.0.0-dev and on other DEs as well? |
| 16:51 |
p_gimeno |
DEs? |
| 16:53 |
p_gimeno |
desktop environments? |
| 17:01 |
Krock |
well yes, or Window managers. I've heard of constant spinning in-game with some combinations |
| 17:05 |
p_gimeno |
no idea, it's happening to me for a long time |
| 17:06 |
p_gimeno |
I don't use a DE, and I use WindowMaker as WM |
| 17:07 |
p_gimeno |
confirmed in 0.4.15 as well |
| 17:08 |
p_gimeno |
that's a different computer with 32-bit Debian Wheezy, also with wmaker, |
| 17:08 |
p_gimeno |
-, |
| 17:15 |
p_gimeno |
switching to IceWM doesn't change anything |
| 17:21 |
|
Edgy1 joined #minetest-dev |
| 17:53 |
|
GreenDimond joined #minetest-dev |
| 17:57 |
|
p_gimeno joined #minetest-dev |
| 17:57 |
|
Ruslan1 joined #minetest-dev |
| 18:07 |
|
RichardTheTurd joined #minetest-dev |
| 18:20 |
|
DI3HARD139 joined #minetest-dev |
| 18:48 |
|
proller joined #minetest-dev |
| 18:49 |
|
Gael-de-Sailly joined #minetest-dev |
| 18:56 |
|
entuland joined #minetest-dev |
| 19:15 |
jas_ |
how about resizing the minetest window? does that change anything? |
| 19:17 |
|
Krock joined #minetest-dev |
| 19:17 |
|
jas_ joined #minetest-dev |
| 19:34 |
|
entuland joined #minetest-dev |
| 19:36 |
|
paramat joined #minetest-dev |
| 19:38 |
paramat |
yes lint is funny |
| 19:41 |
|
paramat joined #minetest-dev |
| 19:44 |
paramat |
Krock and all. shall we perhaps just merge #8239 for 5.0.0 since it's simpler? |
| 19:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/8239 -- Fix profiler crash by pauloue |
| 19:45 |
Krock |
yes sure. as a temporary solution it's fine |
| 19:46 |
Krock |
my PR is to clean up the mess behind |
| 19:46 |
p_gimeno |
jas_: not substantially, no |
| 19:47 |
paramat |
personally i'd prefer a simple fix to avoid possible complications |
| 19:47 |
Krock |
paramat: I think we should use "??" in the place there |
| 19:47 |
Krock |
since it's what Minetest returns with get_last_run_mod when nothing's known |
| 19:48 |
Krock |
if you agree, I can quickly change that to merge afterwards |
| 19:51 |
nerzhul |
good job guys |
| 19:54 |
Krock |
btw, what's the difference between milestone and projects? |
| 19:55 |
paramat |
yes i agree |
| 19:56 |
paramat |
project is just a way to clearly visually organise. what matters is the 'blocker' label. nilestones are not necessarily blockers |
| 19:56 |
paramat |
*milestones |
| 19:56 |
paramat |
heh |
| 19:57 |
cheapie |
Krock: As a user, I think I'd rather see "unknown" than "??" |
| 19:58 |
cheapie |
Though "after init" is fine too, I think. |
| 19:59 |
Krock |
cheapie: *after init*, if even. Otherwise it's confusing |
| 20:00 |
paramat |
feel free to merge |
| 20:00 |
Krock |
merging in 5' |
| 20:01 |
Krock |
cheapie: I can improve this all together in the other PR for 5.1.0 |
| 20:01 |
Krock |
5.0.0 should already be out for a long time |
| 20:01 |
Krock |
the translations also need to be re-run, nerzhul |
| 20:02 |
cheapie |
If someone wants to make the profiler work properly for stuff registered via WorldEdit's //lua command, then that can probably be done at some point. Doesn't sound too high-priority to me as I think this'll at least make it not crash. |
| 20:02 |
paramat |
nerzhul rubenwardy sfan5 ShadowNinja sofar please can RC2 now be created (after 8239 is merged)? |
| 20:02 |
Krock |
well, they need to re-run in a while if they already got the new strings to translate from Wuzzy's last commit |
| 20:03 |
Krock |
cheapie: registrations are not thought to be used outside of the initial code block because it wrecks stuff easily. at least item registrations don't crash (I think) |
| 20:03 |
|
reductum joined #minetest-dev |
| 20:04 |
Krock |
and modders might expect the callback is un-registered at some point, which is somewhat false. |
| 20:04 |
cheapie |
Krock: I'm not sure about 5.x, but back in 0.4.x I could register chat commands and such via //lua but only if the profiler was disabled. |
| 20:04 |
Krock |
same in 5.0 |
| 20:05 |
Krock |
merging #8239 |
| 20:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/8239 -- Fix profiler crash by pauloue |
| 20:05 |
cheapie |
What I'm trying to say is that, with #8239, I should hopefully be able to do that even with the profiler on. I don't care if it profiles them correctly. |
| 20:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/8239 -- Fix profiler crash by pauloue |
| 20:06 |
Krock |
is possible now |
| 20:07 |
cheapie |
Possible now that 8239 is merged, yes :P |
| 20:08 |
GreenDimond |
remove it from the projects page x) |
| 20:09 |
Krock |
paramat: mixing milestones and project is confusing for me. either the one or the other |
| 20:09 |
Krock |
projects should rather be release-independent |
| 20:19 |
paramat |
project is a useful way to have a visual overview of blockers, so i think a project can be used for anything, release or not. managing this release would have been much more difficult for me another way |
| 20:20 |
paramat |
but sure i don't mind not using milestones |
| 20:21 |
GreenDimond |
So will the actual release happen if RC2 is successful for like a week or something? |
| 20:23 |
paramat |
i suggest test RC2 for a week ... ? |
| 20:24 |
paramat |
then hopefully release next weekend |
| 20:30 |
GreenDimond |
cool |
| 20:31 |
paramat |
Shara just a weekend reminder for game#2311 |
| 20:31 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2311 -- Kelp, coral sounds: Add missing 'footstep'. Use quiet 'dig', 'dug' by paramat |
| 20:34 |
Krock |
paramat: maybe a new function would be helpful there |
| 20:34 |
Krock |
for water plant sounds |
| 20:36 |
Shara |
paramat: thanks. |
| 20:36 |
paramat |
hmm maybe |
| 20:36 |
paramat |
Krock did you test game#2310 ? if so i'll merge |
| 20:36 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2310 -- fix sfinv hotbar offset. by NathanSalapat |
| 20:40 |
|
Miner_48er joined #minetest-dev |
| 20:45 |
Krock |
paramat: yes. before, there was a weird shadow underneath the inventory slots |
| 20:45 |
paramat |
ok will merge soon |
| 20:45 |
|
Miner_48er joined #minetest-dev |
| 20:45 |
Krock |
it's now gone. maybe we could consider removing those images since they are largely (entirely?) covered by the slots |
| 20:46 |
Krock |
or was that intended, rubenwardy ? |
| 20:49 |
|
Miner_48er joined #minetest-dev |
| 20:49 |
paramat |
merging it |
| 20:55 |
|
fwhcat joined #minetest-dev |
| 20:58 |
|
Miner_48er joined #minetest-dev |
| 21:17 |
paramat |
thanks, merging game#2311 |
| 21:17 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2311 -- Kelp, coral sounds: Add missing 'footstep'. Use quiet 'dig', 'dug' by paramat |
| 21:34 |
nerzhul |
g o ahead for RC2, i hope the latest |
| 22:00 |
|
Fixer joined #minetest-dev |
| 22:21 |
|
Fixer_ joined #minetest-dev |
| 22:34 |
|
paramat joined #minetest-dev |
| 22:57 |
|
entuland joined #minetest-dev |
| 23:58 |
|
argyle77 joined #minetest-dev |
