| Time |
Nick |
Message |
| 00:00 |
p_gimeno |
VanessaE: that's going a bit off topic, it's a question of preferences, I always use 'l' to list which does ls -lA to make sure I don't miss anything important from any dir I look. And yes, it was that way and it was pissing, for lack of a standard that solved it. |
| 00:01 |
p_gimeno |
it's a bit like saying, why not install minetest in /minetest by default? why /usr/bin? |
| 00:03 |
VanessaE |
no, the comparison is more like "why systemd over sysvinit" |
| 00:03 |
VanessaE |
and the answer is "because it works and has worked just fine for decades" |
| 00:03 |
T4im |
i suspect you can just set the XDG evironment variable to your home dir to have the old behavior, VanessaE |
| 00:04 |
T4im |
it makes it configurable and standardized, that's the point behind it |
| 00:04 |
Fixer |
is XDG finally adopted by everyone? |
| 00:04 |
p_gimeno |
um, no, it's about following a directory organization standard or not following it; it's more like /usr/bin vs /mydir. /usr/bin is an established standard, and .local/share is a standard in the process of being established. |
| 00:04 |
T4im |
not all, but significantly many, Fixer |
| 00:04 |
Fixer |
potentially I would like ~/.config/minetest more, but without that ./local/share/ crap |
| 00:05 |
Fixer |
remember /bin vs /usr/bin holy war? |
| 00:06 |
p_gimeno |
also what T4im said about configurability, you can even place that stuff in a separate partition if you wish |
| 00:07 |
T4im |
if you wanted to go all the way you would probably move world/ games/ mods/ textures/ into .local/share and minetest.conf, client/, debug.txt into .config/ |
| 00:08 |
T4im |
well, maybe not that way exactly, but similar |
| 00:28 |
|
ANAND joined #minetest-dev |
| 01:15 |
|
ANAND joined #minetest-dev |
| 04:51 |
|
Player-2 joined #minetest-dev |
| 06:34 |
|
Beton joined #minetest-dev |
| 07:25 |
nerzhul |
i need to take time for some reviews |
| 07:58 |
|
Krock joined #minetest-dev |
| 08:07 |
|
Megaf joined #minetest-dev |
| 08:08 |
|
ichoquo0Aigh9ie joined #minetest-dev |
| 08:39 |
|
proller joined #minetest-dev |
| 08:44 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:06 |
|
Fixer joined #minetest-dev |
| 10:13 |
|
Fixer_ joined #minetest-dev |
| 10:17 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:36 |
|
Krock joined #minetest-dev |
| 11:41 |
|
calcul0n joined #minetest-dev |
| 12:01 |
|
Fixer joined #minetest-dev |
| 12:16 |
|
T4im joined #minetest-dev |
| 13:22 |
|
jas_ joined #minetest-dev |
| 14:02 |
|
Ruslan1 joined #minetest-dev |
| 14:23 |
|
Wuzzy joined #minetest-dev |
| 15:12 |
|
Beton_ joined #minetest-dev |
| 15:34 |
|
paramat joined #minetest-dev |
| 16:45 |
|
Cornelia joined #minetest-dev |
| 18:46 |
|
proller joined #minetest-dev |
| 18:51 |
|
proller joined #minetest-dev |
| 18:58 |
Krock |
nice PR, paramat. Will test. However, it's neither high priority nor a blocker for a new release since it's just a setting interface which doesn't prevent from gameplay |
| 18:59 |
paramat |
#7819 |
| 18:59 |
paramat |
hmm |
| 18:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/7819 -- Advanced settings: Fix noise parameter flags by paramat |
| 19:00 |
paramat |
i see it as embarassing to have settings broken like this for a major release, so yeah borderline but i think blocker is reasonable |
| 19:02 |
Krock |
Blocker and High Priority should just be applied for bug issues and bugfix PRs which prevent players from playing the game |
| 19:03 |
Krock |
whereas Blocker is above "High Priority" and can prevent a release |
| 19:03 |
paramat |
i disagree, the game can be played with serious bugs that should block to avoid an embarassingly broken release |
| 19:05 |
paramat |
i don't think there can be a specific condition for a blocker. anyway hopefully it will be merged and fixed soon |
| 19:05 |
Krock |
yet it doesn't prevent players from playing. Barely anyone out there (*looks at mobile users*) tweak noise settings (if settings at all) |
| 19:06 |
Krock |
Minetest 5.0 would be great to have it bug-free, but that's simply not possible unless we'll stay in this state forever |
| 19:06 |
Krock |
testing the PR now |
| 19:08 |
paramat |
for me 'blocker' means 'must be resolved before next release' and can be anything |
| 19:09 |
paramat |
hmm but noise params, it is borderline. ok will remove |
| 19:10 |
paramat |
done |
| 19:12 |
|
proller joined #minetest-dev |
| 19:15 |
Krock |
local function handle_change_setting_buttons(this, fields) should already do that |
| 19:18 |
paramat |
? |
| 19:18 |
Krock |
L900-908 |
| 19:21 |
Krock |
the checkboxes table is updated there with the new values |
| 19:27 |
|
Icedream joined #minetest-dev |
| 19:27 |
paramat |
interesting. however in testing the PR does fix the bug, will investigate this |
| 19:27 |
paramat |
maybe the bug is in 900-908 instead |
| 19:28 |
paramat |
ah, no .. |
| 19:29 |
paramat |
900-908 is only run when clicking the checkboxes, i added a print statement there to check. the PR fixes the setting up of the 'checkboxes' table when you open the edit formspec |
| 19:30 |
paramat |
my code is in the function that is run when an edit formspec is first opened. see last comments in the issue |
| 19:33 |
paramat |
you can see the code at L677 (in master) that is missing for noise params |
| 19:41 |
paramat |
remove #7789 from blockers? |
| 19:41 |
ShadowBot |
https://github.com/minetest/minetest/issues/7789 -- 5.0.0 Android: The reset singleplayer world function doesn't work properly, it calls /bin/rm which doesn't exist |
| 19:45 |
Krock |
Annoying, but not a crash. High Priority nonetheless due to the large amount of mobile players |
| 19:45 |
paramat |
yeah |
| 19:46 |
paramat |
after much discussion #7784 seems in quite a good state now |
| 19:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/7784 -- Android settings: Develop adaptive HUD/GUI scaling, font size by paramat |
| 19:47 |
paramat |
it will probably get tuned in future of course, but i feel it might be mergeable |
| 19:48 |
Krock |
oh I see. create_change_setting_formspec sets the "checkboxes" defaults, whereas handle_change_setting_buttons updates them on click |
| 19:49 |
paramat |
yes |
| 19:51 |
paramat |
rubenwardy please could you complete #7766 ? |
| 19:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/7766 -- Add setting to filter non-free packages by rubenwardy |
| 19:53 |
Krock |
from what I see you could integrate "checkboxes[checkbox_name] = is_enabled" into the upper loop, since the table is empty in that case |
| 20:02 |
paramat |
which upper loop? |
| 20:03 |
Krock |
line 626 |
| 20:03 |
paramat |
the loop immediately above only loops through the enabled flags, not all |
| 20:03 |
Krock |
>since the table is empty in that case |
| 20:03 |
Krock |
nil values are also handled like false |
| 20:04 |
paramat |
oh i see |
| 20:04 |
paramat |
hmm maybe |
| 20:05 |
p_gimeno |
I know nobody asked me, but I'd call #7819 trivial |
| 20:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/7819 -- Advanced settings: Fix noise parameter flags by paramat |
| 20:06 |
paramat |
anyway yes will consider that |
| 20:06 |
Krock |
p_gimeno: me too. trivial bugfix |
| 20:06 |
paramat |
but the others need to be set to false, not nil |
| 20:07 |
Krock |
why? where does it check for "false"? |
| 20:08 |
Krock |
I only see checks against the string "true" or whether it's non-nil or non-false |
| 20:09 |
paramat |
i think it's fine as it is, i can't see any simplification (yet) |
| 20:09 |
paramat |
'-- to get false if nil' i assume that's necessary |
| 20:10 |
p_gimeno |
false or flags[name] |
| 20:10 |
Krock |
maybe a historic leftover. the current code does not require false anywhere |
| 20:11 |
p_gimeno |
err, flags[name] or false |
| 20:12 |
paramat |
well, you might be right, investigating |
| 20:13 |
paramat |
https://github.com/minetest/minetest/blob/2586a70492370d706f8cab615a328abd609a9ba4/builtin/mainmenu/dlg_settings_advanced.lua#L837 |
| 20:13 |
paramat |
that suggests you're right |
| 20:14 |
paramat |
anyway ok will do |
| 20:18 |
paramat |
it might be for consistency because 'checkboxes' is set to true or false here https://github.com/minetest/minetest/blob/2586a70492370d706f8cab615a328abd609a9ba4/builtin/mainmenu/dlg_settings_advanced.lua#L904 |
| 20:19 |
paramat |
i think i prefer leaving it as it is |
| 20:20 |
paramat |
it's also more readable |
| 20:21 |
paramat |
anyway will merge later unless objections |
| 20:23 |
p_gimeno |
I guess that #6898 is going to wait until 6.0+ :( |
| 20:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack by pgimeno |
| 20:47 |
paramat |
dev is like running in syrup currently |
| 20:47 |
paramat |
merging #7819 |
| 20:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/7819 -- Advanced settings: Fix noise parameter flags by paramat |
| 20:53 |
paramat |
merged |
| 21:35 |
|
proller joined #minetest-dev |
| 22:30 |
|
YuGiOhJCJ joined #minetest-dev |
| 22:44 |
|
Ruslan1 joined #minetest-dev |
| 22:51 |
|
behalebabo joined #minetest-dev |
| 22:58 |
|
Andrej1 joined #minetest-dev |
| 23:30 |
|
BakerPrime left #minetest-dev |
