| Time |
Nick |
Message |
| 02:02 |
|
ANAND joined #minetest-dev |
| 02:19 |
|
YuGiOhJCJ joined #minetest-dev |
| 07:45 |
|
longerstaff13_ joined #minetest-dev |
| 07:45 |
|
Icedream- joined #minetest-dev |
| 07:50 |
|
twoelk joined #minetest-dev |
| 07:52 |
|
ssieb joined #minetest-dev |
| 08:16 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:43 |
|
Gael-de-Sailly joined #minetest-dev |
| 10:36 |
|
Fixer joined #minetest-dev |
| 11:10 |
|
twoelk joined #minetest-dev |
| 13:24 |
|
lisac_ joined #minetest-dev |
| 13:53 |
|
twoelk joined #minetest-dev |
| 14:01 |
|
lisac_ joined #minetest-dev |
| 14:07 |
|
lisac__ joined #minetest-dev |
| 14:15 |
|
lisac_ joined #minetest-dev |
| 14:15 |
|
twoelk left #minetest-dev |
| 14:59 |
|
CBugDCoder joined #minetest-dev |
| 15:03 |
|
antims joined #minetest-dev |
| 16:04 |
|
Krock joined #minetest-dev |
| 16:29 |
|
CrazyDave joined #minetest-dev |
| 16:29 |
|
CrazyDave left #minetest-dev |
| 16:54 |
|
lisac joined #minetest-dev |
| 17:07 |
|
Fixer joined #minetest-dev |
| 17:26 |
|
CrazyDave joined #minetest-dev |
| 18:14 |
Krock |
ServerEnvironment::getObjectsInsideRadius looks up all active objects and pushes their ID to the given vector. Nothing wrong with that, but wouldn't it be faster to pass the SAO pointer directly to the vector? |
| 18:15 |
Krock |
Wherever the function is used, there's always another lookup to convert the ID to an SAO object |
| 18:15 |
Krock |
it's not safe for concurrent actions, but the server is singlethreaded there AFAIK |
| 18:22 |
Krock |
So wouldn't it be faster to rename it to ...Unsafe() and to return a vector of SAOs instead? The functions where it's used would require a mutex anyway if it were multithreaded |
| 18:37 |
|
paramat joined #minetest-dev |
| 18:39 |
paramat |
shall we merge #6825 ? rubenwardy |
| 18:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/6825 -- Smooth yaw by SmallJoker |
| 18:43 |
paramat |
merging #7567 in a minute |
| 18:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/7567 -- VoxelManip: Abort if an argument is missing instead of silently doing nothing by HybridDog |
| 18:50 |
paramat |
merging |
| 18:52 |
nerzhul |
Krock if i remember it's used in emergethreads no ? |
| 18:52 |
nerzhul |
server mutlithreading is heavy complicated, i did some study later this year and previous year and everything turns around environment |
| 18:55 |
paramat |
merged |
| 18:59 |
paramat |
#7599 is updated, i would like to merge it asap, Krock could you check it? |
| 18:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/7599 -- lua_api.txt: Improve code block format by pauloue |
| 19:00 |
|
Foz joined #minetest-dev |
| 19:01 |
Krock |
nerzhul: emergethreads are more for mapgen & block loading. If the would access the active objects concurrent with the server then we'd have more errors |
| 19:01 |
Krock |
*if the server would |
| 19:19 |
Krock |
paramat: the doc PR looks good overall, but it's more of a concept question of what's ebst |
| 19:19 |
Krock |
*best |
| 19:22 |
|
CBugDCoder joined #minetest-dev |
| 19:34 |
paramat |
i'll merge it once fixed if no objections |
| 19:36 |
paramat |
and, i'll merge smooth yaw in a few hours unless requested not to |
| 19:37 |
Krock |
ok |
| 19:40 |
nerzhul |
Krock there was a reason for having ids there, but i cannot remember which, i already looked at your idea and something was blocking me, but maybe the code is now enough mature for a transition |
| 19:45 |
Krock |
the player list/vector getter in the network also returns session_t, but we end up converting it from the session_t back to a RemotePlayer in combination with mutex anyway |
| 19:49 |
|
numzero joined #minetest-dev |
| 20:32 |
|
CrazyDave left #minetest-dev |
| 20:35 |
|
Cornelia joined #minetest-dev |
| 20:51 |
nerzhul |
yes but it's different in network |
| 20:52 |
nerzhul |
in one side you get the player in the other side the session |
| 21:08 |
|
Taoki joined #minetest-dev |
| 21:08 |
|
Cornelia joined #minetest-dev |
| 21:55 |
paramat |
merging #6825 in 15 mins |
| 21:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/6825 -- Smooth yaw by SmallJoker |
| 22:10 |
|
Fixer joined #minetest-dev |
| 22:23 |
paramat |
merging |
| 22:27 |
paramat |
merged |
| 23:27 |
|
ANAND joined #minetest-dev |
| 23:45 |
|
ANAND_ joined #minetest-dev |
