| Time |
Nick |
Message |
| 00:35 |
|
behalebabo joined #minetest-dev |
| 01:02 |
|
paramat joined #minetest-dev |
| 01:22 |
* BillyS |
tries to figure out how to set up a custom mapgen for a minetest game |
| 01:24 |
|
ANAND joined #minetest-dev |
| 01:28 |
|
proller__ joined #minetest-dev |
| 01:32 |
paramat |
best discuss that in a different channel |
| 01:33 |
BillyS |
k |
| 01:43 |
|
twoelk|2 joined #minetest-dev |
| 01:48 |
|
twoelk left #minetest-dev |
| 02:08 |
|
AndroBuilder joined #minetest-dev |
| 02:15 |
paramat |
nickolas360 you can view logs of this channel here http://irc.minetest.net/minetest-dev/2018-05-25 perhaps you can link zistack to this to see the discussion on your suggestion |
| 02:31 |
|
Cornelia joined #minetest-dev |
| 03:25 |
|
zorman2000 joined #minetest-dev |
| 03:28 |
|
paramat joined #minetest-dev |
| 03:32 |
|
Tmanyo joined #minetest-dev |
| 03:41 |
|
ANAND joined #minetest-dev |
| 08:46 |
|
lisac joined #minetest-dev |
| 09:17 |
|
Gael-de-Sailly joined #minetest-dev |
| 09:27 |
|
cx384 joined #minetest-dev |
| 10:42 |
|
Krock joined #minetest-dev |
| 10:48 |
|
entuland joined #minetest-dev |
| 10:52 |
Krock |
Will push trivial fix for #7374 in ~30 minutes https://pastebin.com/raw/k20rg77C |
| 10:52 |
ShadowBot |
https://github.com/minetest/minetest/issues/7374 -- Formspec shown from another formspec is not being handled properly |
| 10:54 |
entuland |
nice, that will come in handy for sure |
| 10:55 |
entuland |
I found out about that yesterdady, and the way that issue is getting tested seems to confirm it: showing another formspec correctly closes any shown one, there is no need to invoke the close function (actually it seems to make things worse cause the call to the close function will close any newly shown form at the return from the receive fields handler) |
| 11:02 |
|
Amaz joined #minetest-dev |
| 11:04 |
Krock |
I also suspected something like this when he reported it first but the issue report and simplified version of the code finally showed it very clearly |
| 11:05 |
|
Fixer joined #minetest-dev |
| 11:30 |
|
Krock joined #minetest-dev |
| 11:34 |
Krock |
pushing.. |
| 11:39 |
|
VargaD joined #minetest-dev |
| 11:59 |
|
Guest9860 joined #minetest-dev |
| 12:03 |
|
Beton joined #minetest-dev |
| 12:48 |
|
Lunatrius joined #minetest-dev |
| 12:53 |
|
Gundul joined #minetest-dev |
| 13:18 |
|
kurennon joined #minetest-dev |
| 13:18 |
kurennon |
Hi! Wanted to go through the code and comment as much as I can with Doxygen comments. In the style guide you said that you expect them in the header files. Any preference as to the style of the comments? |
| 13:18 |
kurennon |
I noticed on the dev wiki it said the page on docs was out of date, and to ask on here. |
| 13:18 |
kurennon |
Also, how would you prefer the commits get split up? One for each file documented? |
| 13:30 |
|
ANAND joined #minetest-dev |
| 14:11 |
|
Foz joined #minetest-dev |
| 14:27 |
|
kurennon joined #minetest-dev |
| 14:32 |
|
DI3HARD139 joined #minetest-dev |
| 14:35 |
|
zorman2000 joined #minetest-dev |
| 14:38 |
|
ANAND joined #minetest-dev |
| 14:50 |
|
jcalve joined #minetest-dev |
| 15:09 |
|
p_gimeno joined #minetest-dev |
| 15:38 |
|
paramat joined #minetest-dev |
| 15:43 |
paramat |
hi kurennon maybe this PR helps answer? #1963 also see discussion on doxygen here http://irc.minetest.net/minetest-dev/2014-12-16#i_4065832 |
| 15:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/1963 -- Add doxygen comments to itemdef.h by MinerDad7 |
| 15:44 |
Krock |
Fixed IRC log link: http://irc.minetest.net/minetest-dev/2014-12-16#i_4065832 |
| 15:45 |
paramat |
core devs: see kurennon's questions earlier |
| 15:46 |
paramat |
also, 1 PR per file would be too many PRs, however best not let any 1 PR get too big. so several files per PR? |
| 15:53 |
Krock |
he said a commit per file. |
| 15:54 |
Krock |
surely it would be helpful to have it a bit structured - may it be by file name or the code area (server env, scripting engine, render, ..) |
| 15:58 |
paramat |
oh yes. still 1 commit per file seems a little too much |
| 16:22 |
|
troller joined #minetest-dev |
| 17:06 |
paramat |
#7355 fairly simple |
| 17:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/7355 -- Mapgen flags: Add 'biomes' global mapgen flag by paramat |
| 17:23 |
|
Cornelia joined #minetest-dev |
| 17:31 |
kurennon |
Just for clarification, *she. Thanks for linking the PR, It's good to know the style. |
| 17:31 |
kurennon |
I'll try and use my best judgment then, as to how big the commits should be |
| 17:32 |
kurennon |
Maybe one commit for bigger files, but throw in a couple small ones together. |
| 17:41 |
paramat |
yes seems good |
| 17:47 |
Krock |
oh sorry. *she. IMO I don't know if it's necessary to mention: the comments should be keet short but precise if possible. |
| 17:47 |
paramat |
there was some discussion about doxygen a while back but i can't find it, maybe it was in IRC |
| 17:48 |
Krock |
paramat, it's probably the corrected link I've sent here shortly after your initial message |
| 17:49 |
paramat |
aha http://irc.minetest.net/minetest-dev/2018-03-10#i_5249578 |
| 17:49 |
paramat |
it was a team discussion |
| 17:50 |
Krock |
ah, that one. Indeed, it's a bit more up to date |
| 17:50 |
paramat |
kurennon ^ |
| 17:51 |
paramat |
hmm that discussion seemed a little opposed to doxygen |
| 17:52 |
paramat |
currently i'm actually neutral about doxygen comments |
| 17:52 |
Krock |
well great. we can discuss this again but at least after then it'll be denoted in the guideline dev wiki article |
| 17:53 |
paramat |
also see http://doxy.minetest.net/ |
| 17:55 |
paramat |
more discussion http://irc.minetest.net/minetest-dev/2018-03-10#i_5249725 |
| 17:57 |
kurennon |
Ok, so try and stay away from self-documenting functions, etc is kinda the consensus as of now? |
| 17:58 |
paramat |
nerzhul rubenwardy sfan5 any thoughts about doxygen comments? |
| 17:59 |
sfan5 |
my opinion has not changed |
| 17:59 |
sfan5 |
documenting non-obvious functions (in doxygen style) is fine with me |
| 18:04 |
|
Krock joined #minetest-dev |
| 18:18 |
|
Wuzzy joined #minetest-dev |
| 18:24 |
|
Player-2 joined #minetest-dev |
| 20:05 |
|
entuland_ joined #minetest-dev |
| 20:17 |
nerzhul |
+1 |
| 20:56 |
|
troller joined #minetest-dev |
| 20:58 |
|
behalebabo joined #minetest-dev |
| 21:10 |
|
Tmanyo joined #minetest-dev |
| 21:13 |
|
paramat joined #minetest-dev |
| 21:21 |
|
reductum joined #minetest-dev |
| 21:37 |
|
indiana joined #minetest-dev |
| 21:39 |
|
entuland joined #minetest-dev |
| 21:45 |
|
Tmanyo joined #minetest-dev |
| 22:05 |
|
Gael-de-Sailly joined #minetest-dev |
| 22:49 |
|
reductum joined #minetest-dev |
| 23:48 |
|
paramat joined #minetest-dev |
| 23:56 |
|
Tmanyo joined #minetest-dev |
