Time |
Nick |
Message |
00:18 |
|
Lone-Star joined #minetest-dev |
00:29 |
|
sofar joined #minetest-dev |
00:33 |
|
paramat joined #minetest-dev |
01:20 |
|
Guest60049 joined #minetest-dev |
01:31 |
|
Player-2 joined #minetest-dev |
01:42 |
|
Tmanyo joined #minetest-dev |
01:52 |
paramat |
game#2128 |
01:52 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2128 -- TNT: Raise cost of TNT by adding a TNT stick crafting stage by paramat |
02:14 |
|
Foz joined #minetest-dev |
02:40 |
|
Tmanyo joined #minetest-dev |
03:01 |
|
AndroBuilder joined #minetest-dev |
03:53 |
|
Darcidride_ joined #minetest-dev |
03:54 |
|
Darcidride__ joined #minetest-dev |
03:54 |
|
YuGiOhJCJ joined #minetest-dev |
05:09 |
|
ssieb joined #minetest-dev |
05:35 |
|
Foz joined #minetest-dev |
06:30 |
|
Guest60049 joined #minetest-dev |
07:00 |
|
Guest60049 joined #minetest-dev |
07:11 |
|
proller joined #minetest-dev |
07:57 |
|
proller joined #minetest-dev |
08:27 |
|
Gael-de-Sailly joined #minetest-dev |
08:50 |
|
longerstaff13 joined #minetest-dev |
09:05 |
|
rdococ joined #minetest-dev |
09:15 |
|
lisac joined #minetest-dev |
09:57 |
|
proller joined #minetest-dev |
10:30 |
|
proller joined #minetest-dev |
11:08 |
|
entuland joined #minetest-dev |
11:10 |
|
Fixer joined #minetest-dev |
11:22 |
|
longerstaff13-m joined #minetest-dev |
11:33 |
|
Krock joined #minetest-dev |
11:38 |
|
troller joined #minetest-dev |
11:44 |
|
rdococ joined #minetest-dev |
11:49 |
|
Genshin joined #minetest-dev |
11:55 |
|
troller joined #minetest-dev |
11:55 |
|
Emperor_Genshin joined #minetest-dev |
12:11 |
|
Emperor_Genshin joined #minetest-dev |
12:24 |
|
troller joined #minetest-dev |
12:48 |
|
Raven261 joined #minetest-dev |
12:49 |
|
lisac_ joined #minetest-dev |
12:51 |
|
troller joined #minetest-dev |
12:58 |
|
Beton joined #minetest-dev |
13:01 |
|
DI3HARD139 joined #minetest-dev |
13:17 |
|
SilverLuke joined #minetest-dev |
13:46 |
|
proller__ joined #minetest-dev |
13:58 |
|
lumberJ joined #minetest-dev |
14:19 |
|
Cornelia joined #minetest-dev |
14:24 |
|
Raven262 joined #minetest-dev |
14:25 |
|
lisac__ joined #minetest-dev |
14:28 |
|
proller__ joined #minetest-dev |
14:39 |
Krock |
so, 0.4.17-dev seems to compile with C++03 now - at least mostly |
14:42 |
|
crazyR joined #minetest-dev |
14:43 |
|
popey_ joined #minetest-dev |
14:43 |
Krock |
however, the Win32/64 and OS X build scripts are currently broken: https://travis-ci.org/minetest/minetest/builds/381081541 |
14:46 |
|
dmurph joined #minetest-dev |
14:46 |
|
Flitzpiepe joined #minetest-dev |
14:51 |
|
Wayward_One joined #minetest-dev |
14:53 |
|
ensonic joined #minetest-dev |
14:53 |
|
popey_ joined #minetest-dev |
15:02 |
|
popey_ joined #minetest-dev |
15:03 |
|
proller__ joined #minetest-dev |
15:13 |
nerzhul |
Krock nice job |
15:13 |
nerzhul |
Krock i think sfan5 removed the blob from its server |
15:16 |
|
Ruslan1 joined #minetest-dev |
15:20 |
rubenwardy |
please may you look into the clang-tidy job at some point? As our resident CI expert |
15:21 |
rubenwardy |
it fails randomly. Even if it's travis being unreliable (Which I doubt) there's probably a work around |
15:21 |
rubenwardy |
if not, then it should be removed as the build failing randomly is more damaging than the lints it gives |
15:25 |
|
ensonic joined #minetest-dev |
15:28 |
nerzhul |
it failed randomly due to some travis instability sometimes |
15:28 |
nerzhul |
but if you show me a job maybe i can verify there is no problem in the CI step |
15:29 |
rubenwardy |
see my reorder PR |
15:29 |
rubenwardy |
not sure if that's because the steps are actually dependent |
15:30 |
nerzhul |
which steps ? |
15:33 |
|
Guest60049 joined #minetest-dev |
15:36 |
|
crazyR joined #minetest-dev |
15:37 |
|
popey_ joined #minetest-dev |
15:38 |
|
davisonio joined #minetest-dev |
15:40 |
|
proller__ joined #minetest-dev |
15:46 |
Krock |
nerzhul, when would the best meeting time be for you? |
16:10 |
|
proller__ joined #minetest-dev |
16:11 |
|
longerstaff13 joined #minetest-dev |
16:12 |
|
proller__ joined #minetest-dev |
16:14 |
|
Guest60049 joined #minetest-dev |
16:24 |
|
paramat joined #minetest-dev |
16:25 |
paramat |
Krock nerzhul nore rubenwardy sfan5 Shara sofar meeting in 35 mins? or would 1h35mins be better for anyone? |
16:25 |
Krock |
both fine |
16:26 |
paramat |
i'm here from now on |
16:26 |
rubenwardy |
here |
16:41 |
|
Emperor_Genshin joined #minetest-dev |
16:42 |
|
Player-2 joined #minetest-dev |
16:51 |
|
proller__ joined #minetest-dev |
17:02 |
Krock |
paramat, probably wait an hour - in hope a few more devs will be online then |
17:03 |
paramat |
yeah |
17:03 |
paramat |
should be better for nerzhul |
17:34 |
|
Beton_ joined #minetest-dev |
17:35 |
paramat |
will merge game#2130 in 15mins |
17:35 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2130 -- Kelp: Add 'paramtype = light' to avoid black plantlike extension by paramat |
17:43 |
|
Emperor_Genshin joined #minetest-dev |
17:47 |
|
Emperor_Genshin1 joined #minetest-dev |
17:55 |
|
Foz joined #minetest-dev |
17:56 |
paramat |
merging |
17:57 |
paramat |
done |
17:59 |
Krock |
nerzhul, paramat, rubenwardy, sfan5, Shara, sofar: Meeting starts in a minute. Again the same link as last time: https://github.com/orgs/minetest/teams/engine/discussions/10 |
18:02 |
Krock |
Okay - 0.4.17 again. What's left over to do? |
18:04 |
Krock |
The majority of builds work - the other are failing due to missing files (even the GitLab pipeline seems to struggle) |
18:08 |
|
Emperor_Genshin joined #minetest-dev |
18:08 |
paramat |
the failed builds seem to be due to travis errors |
18:09 |
Krock |
exactly. compiling works in theory but our services fail |
18:09 |
paramat |
failed connection to 'minetest.kitsunemimi.pw' |
18:10 |
Krock |
this means that either our build script is outdated or sfan5 deleted the required files |
18:10 |
paramat |
and 1 build fails with '/Users/travis/.travis/job_stages: line 166: shell_session_update: command not found' |
18:11 |
|
Cornelia joined #minetest-dev |
18:11 |
|
Emperor_Genshin joined #minetest-dev |
18:11 |
paramat |
but it seems c++03 changes are done? |
18:12 |
paramat |
did c++11 stuff creep in accidently or were we planning to have 0.4.17 as c++11? |
18:13 |
Krock |
it's stuff that was backported from our C++11 master branch |
18:14 |
paramat |
seems accidental then, |
18:14 |
Krock |
and nerzhul is against bumping it to C++11 in order to keep it bugfix-only and harder to backport more advanced features |
18:15 |
paramat |
but i guess mainly it's so android 0.4.17 works |
18:17 |
paramat |
lets see what we can do over the weekend, but hopefully freeze within the next week |
18:18 |
paramat |
hmm it seems people are around more during the week actually |
18:19 |
paramat |
or maybe sunday is better for meetings |
18:21 |
paramat |
no objections to #7019 |
18:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/7019 -- Colorize command parameters and privilege names by Wuzzy2 |
18:23 |
paramat |
but yeah, let's discuss when people are around. i support having meetings but it's funny how quiet they usually are, like quieter than most other times :) |
18:24 |
paramat |
makes me wonder if there's any point having a fixed time |
18:24 |
paramat |
as it tends to then create disappointment |
18:26 |
paramat |
no opinion on PR7011 |
18:28 |
paramat |
keeping 0.4.17 c++03 is fine for me, it's good if it helps android work. i had the impression c++11 was a 0.5 thing anyway |
18:30 |
rubenwardy |
Shouldn't be too much work to change to 03 |
18:30 |
paramat |
game#2128 updated |
18:30 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2128 -- TNT: Raise cost of TNT by adding a TNT stick crafting stage by paramat |
18:31 |
Cornelia |
One of these days I'll get in on MT dev.. one of these days... :P |
18:32 |
sfan5 |
Krock, i deleted those files |
18:32 |
sfan5 |
there's already a TODO in the backports pr for me to update thes |
18:32 |
sfan5 |
e |
18:32 |
Krock |
oh I see! |
18:35 |
* sofar |
& working outside today, waves |
18:35 |
Krock |
well so #7019 - any other opinions? |
18:35 |
ShadowBot |
https://github.com/minetest/minetest/issues/7019 -- Colorize command parameters and privilege names by Wuzzy2 |
18:36 |
* Krock |
waves sofar |
18:36 |
Krock |
paramat, if it looks good to you (code quality ok, working) then feel free to approve it |
18:37 |
Krock |
rubenwardy, right it's not too much but still unnecessary work to do - sadly. |
18:38 |
rubenwardy |
Isn't cpp11 one of the breaking changes thoughm |
18:42 |
paramat |
i can't be bothered to code review the colorize PR =) sorry. prioritising |
18:42 |
paramat |
unnecessary? thought it was to get android working |
18:44 |
sfan5 |
the c++03 changes are not needed for android and don't help in any way with 0.5 either |
18:44 |
paramat |
i'll just mention again: i bumped all old (> 2 years) feature requests which have no core dev support, please go through these if you can, they're all labelled under 'possible close' |
18:45 |
paramat |
hm then why? |
18:45 |
paramat |
oh you said above |
18:46 |
paramat |
can't see any practical reason then :) |
18:54 |
Krock |
So should we also add https://github.com/minetest/minetest/commit/4bb41a19dc ? |
18:55 |
Krock |
protection from CSM is what servers wanted - since the flavours (or however they are called now) are 0.5.0 only, this seems worthy to backport |
18:57 |
|
Guest60049 joined #minetest-dev |
18:58 |
paramat |
seems to me it should be backported |
19:04 |
|
Lia joined #minetest-dev |
19:25 |
Krock |
paramat, actually I quite like that paper idea. It would add some complexity to crafting |
19:29 |
|
Emperor_Genshin joined #minetest-dev |
19:36 |
|
Emperor_Genshin1 joined #minetest-dev |
19:37 |
paramat |
hm the issue is 27 paper for 1 TNT, or, very messy recipes |
19:40 |
|
fwhcat joined #minetest-dev |
19:42 |
nerzhul |
it was never the contract, but we wait months and months to release... |
19:42 |
nerzhul |
rubenwardy cpp11 was the main breaking change |
19:45 |
paramat |
yes that's why it seems natural for 0.4.17 to be c++03 |
19:46 |
nerzhul |
yeah |
19:46 |
nerzhul |
backporting fix is not difficult and it seems we fixed all C++03 points |
19:46 |
nerzhul |
android compiler on 0.4.X branch doesn't support C++11 if i remember |
19:46 |
paramat |
yeah it's done now |
19:46 |
paramat |
ah |
19:47 |
paramat |
so it does help android |
19:47 |
nerzhul |
we use the old compiler instead of clang if i'm correct |
19:47 |
nerzhul |
yes, and it helps the old distros |
19:47 |
nerzhul |
and recent too |
19:49 |
paramat |
ok so we just need to sort out the failing builds and/or travis, to know if we can freeze |
19:49 |
Krock |
or rather: freeze as soon it's fixed and the last remaining commit backported |
19:50 |
nerzhul |
the compilation is okay, the problem is sfan5 dropped old windowns & mac osx blobs to compile them |
19:50 |
nerzhul |
(with the CI |
19:50 |
Krock |
) |
19:50 |
nerzhul |
then it's good as those releases are done by himself and a more recent compiler is not a problem for windows build, it was only on linux & bsd builds |
19:52 |
|
Emperor_Genshin joined #minetest-dev |
19:53 |
|
Emperor_Genshin2 joined #minetest-dev |
19:55 |
|
Gael-de-Sailly joined #minetest-dev |
19:56 |
|
Ruslan1 joined #minetest-dev |
19:59 |
|
Emperor_Genshin joined #minetest-dev |
20:02 |
|
Guest60049 joined #minetest-dev |
20:06 |
|
Emperor_Genshin1 joined #minetest-dev |
20:17 |
|
Emperor_Genshin joined #minetest-dev |
20:19 |
|
Emperor_Genshin2 joined #minetest-dev |
20:27 |
|
Emperor_Genshin joined #minetest-dev |
20:40 |
|
popey joined #minetest-dev |
20:58 |
|
Emperor_Genshin1 joined #minetest-dev |
21:08 |
|
longerstaff13_ joined #minetest-dev |
21:08 |
|
longerstaff13_ joined #minetest-dev |
21:41 |
|
paramat joined #minetest-dev |
22:06 |
|
Guest60049 joined #minetest-dev |
22:14 |
|
YuGiOhJCJ joined #minetest-dev |
22:43 |
|
YuGiOhJCJ joined #minetest-dev |
22:55 |
rubenwardy |
merging #7302 in 20m |
22:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/7302 -- Add screenshots to online repository browser by rubenwardy |
23:01 |
Fixer |
this has one approval, don't let it die https://github.com/minetest/minetest/pull/6898 |
23:01 |
Fixer |
those too https://github.com/minetest/minetest/labels/One%20approval |
23:02 |
paramat |
we won't forget about PRs with 1 approval :) |
23:25 |
rubenwardy |
done |
23:36 |
|
longerstaff13-m joined #minetest-dev |