Minetest logo

IRC log for #minetest-dev, 2018-04-19

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:25 troller joined #minetest-dev
00:35 paramat joined #minetest-dev
01:05 Icedream joined #minetest-dev
01:25 Icedream joined #minetest-dev
01:37 Player-2 joined #minetest-dev
02:11 AndroBuilder joined #minetest-dev
03:02 Fritigern joined #minetest-dev
03:27 ssieb joined #minetest-dev
03:29 troller joined #minetest-dev
03:32 troller joined #minetest-dev
03:42 troller joined #minetest-dev
03:44 troller joined #minetest-dev
03:47 troller joined #minetest-dev
03:59 troller joined #minetest-dev
04:41 YuGiOhJCJ joined #minetest-dev
06:15 Lone-Star joined #minetest-dev
08:28 Darcidride joined #minetest-dev
09:16 Fixer joined #minetest-dev
09:19 ANAND joined #minetest-dev
09:45 Gael-de-Sailly joined #minetest-dev
09:54 Wuzzy joined #minetest-dev
10:18 Andrej11 joined #minetest-dev
10:22 Andrej1 joined #minetest-dev
10:25 Andrej11 joined #minetest-dev
10:28 Andrej1 joined #minetest-dev
10:32 Andrej11 joined #minetest-dev
10:39 Andrej1 joined #minetest-dev
10:44 IcyDiamond joined #minetest-dev
11:02 Andrej11 joined #minetest-dev
11:07 Raven262 joined #minetest-dev
11:14 ANAND_ joined #minetest-dev
11:40 lumberJ joined #minetest-dev
11:50 troller joined #minetest-dev
12:43 Andrej1 joined #minetest-dev
12:50 Andrej1 joined #minetest-dev
13:10 Raven262 joined #minetest-dev
13:35 antims joined #minetest-dev
14:00 JDCodeIt joined #minetest-dev
14:51 Lunatrius joined #minetest-dev
15:18 rubenwardy will fix the linter and merge later today if no objections #7226
15:18 ShadowBot https://github.com/minetest/minetest/issues/7226 -- Add online content library by rubenwardy
15:40 twoelk joined #minetest-dev
16:04 JDCodeIt Checking the class structure - if Camera is only used by Client and Client uses Camera - should Client just inherit Camera?
16:05 sfan5 I don't think class hierachies are supposed to work that way
16:05 rubenwardy no lol
16:05 rubenwardy that breaks cohesion
16:05 JDCodeIt Why is there a two way reference?
16:06 rubenwardy it's essentially a component
16:06 rubenwardy but not really, as client isn't an ECS
16:06 JDCodeIt If Camera will only be used by Client, could Client not initialize Camera without the need for Camera to tap into Client?
16:07 rubenwardy Client should own Camera, and pass a pointer to itself to allow camera to call back
16:07 rubenwardy although not sure why it needs to
16:08 JDCodeIt What I saw was some further down classes from Client needing Environment, which Client has, but Camera doesn't
16:09 JDCodeIt It just seems weird that a used class is tapping back into the class that is using it.
16:10 rubenwardy it's pretty common to have that
16:10 rubenwardy in an ideal would you'd use an interface, however
16:10 rubenwardy ideal meaning pure OOP
16:11 rubenwardy Camera is the class that manages the camera scene node and pointed thing, including first and third person modes, right?
16:11 JDCodeIt Well I guess if Client is exposing Environment public, then c'est la vie
16:11 sfan5 thankfully mt is not written in java
16:12 rubenwardy Java sucks
16:12 JDCodeIt .. OG
16:14 rubenwardy could be helpful to go through each class and add comments specifying the lifetime of it, and making sure it's followed
16:20 Krock joined #minetest-dev
16:21 Krock wow sfan5, that was quick
16:21 sfan5 happened to see it and it's a trivial PR just as the label says
16:22 Krock I'm not sure if a LuaJIT-only benchmark makes it trivial
16:23 sfan5 I doubt plain lua gives a different result
16:23 rubenwardy does the lack of ending newline make a different?
16:23 rubenwardy *ce
16:23 rubenwardy there's no trailing new line now
16:23 rubenwardy I doubt it will
16:24 Krock that's an empty line which would be skipped on read anyway
16:24 Krock https://github.com/SmallJoker/minetest/blob/9d5d0a83a644cf87ead60d068f749e7b359c2905/builtin/game/auth.lua#L19
16:24 Krock * L18
16:30 Krock will merge #7252 in 5 minutes
16:30 ShadowBot https://github.com/minetest/minetest/issues/7252 -- Builtin auth handler: Speed up file writing by SmallJoker
16:33 JDCodeIt CLANG_TIDY build died?
16:34 rubenwardy ignore clang tidy
16:34 rubenwardy it's broke
16:34 Krock broke or broken?
16:35 rubenwardy it broke, it is
16:35 rubenwardy in'it
16:35 Krock :D whatever. merging...
16:41 JDCodeIt Does that help with the large auth file leak problem, or not?
16:54 Krock JDCodeIt, what leak problem?
16:55 Krock "leak" as in "vulnerability", "accessible data", ..
17:00 JDCodeIt I thought I saw something open on the Issues list, no?
17:00 JDCodeIt Yes #6783
17:00 ShadowBot https://github.com/minetest/minetest/issues/6783 -- Large auth.txt file causes Lua ServerThread to leak memory and hang the CPU.
17:06 Krock it could be that my PR reduced that a little if Lua doesn't free the (apparently) old string instantly which was used to create the new one
17:08 Krock I wouldn't call that a leak - it's just poor resource management
17:11 JDCodeIt Fixes #5334 also?
17:11 ShadowBot https://github.com/minetest/minetest/issues/5334 -- Auth.txt causing large lag spikes (Reduce frequency of disk writes?)
17:11 JDCodeIt I think you hit three birds there.
17:11 Krock three birds with one shot. that's a nice rate if you ask me
17:14 JDCodeIt Even with a target rich environment...
17:31 fwhcat joined #minetest-dev
17:40 proller__ joined #minetest-dev
17:54 JDCodeIt But then it is seriously broken, right?
17:55 rubenwardy Lua really should optimise that kinda thing under the hood
17:55 rubenwardy like, on a .. actually store it in a table
17:55 JDCodeIt Back to the question of Camera and client - can Camera operate on its own if Client hands it a pointer to its environment?  Just seems cleaner than Camera going back through Client to get a public member
17:55 rubenwardy then only concat when the string is read
17:55 rubenwardy that sounds better, if it only needs env
18:05 Player-2 joined #minetest-dev
18:40 Gael-de-Sailly joined #minetest-dev
18:44 rubenwardy merging #7226 in 20 minutes
18:44 ShadowBot https://github.com/minetest/minetest/issues/7226 -- Add online content library by rubenwardy
18:51 Lunatrius joined #minetest-dev
19:10 paramat joined #minetest-dev
19:11 rubenwardy done
19:13 paramat please can anyone approve #7244 ? code is trivial but it does need a concept approval
19:13 ShadowBot https://github.com/minetest/minetest/issues/7244 -- Mgvalleys: Use shared tunnel / cavern code instead of internal by paramat
19:13 paramat wow good work
19:17 ssieb joined #minetest-dev
19:23 Krock Shara, is that "ok" an official approval? "LGTM" is already accepted as one
19:29 Shara If it was, I'd have put something in the PR itself
19:29 Shara Having no issue with something isn't the same as approving it :P
19:30 Shara Plus it's not something I should approve anyway
19:30 paramat ^
19:32 paramat it's just that her opinion is important here due to the concerns
19:36 rubenwardy my memory fails me, is an int initialized as 0 by default?
19:37 rubenwardy ah, no it's not
19:53 paramat game#2110 at last
19:53 ShadowBot https://github.com/minetest/minetest_game/issues/2110 -- Rebalance bronze and steel tools, swap ore depths by paramat
19:54 book` joined #minetest-dev
19:59 proller joined #minetest-dev
20:04 Gael-de-Sailly joined #minetest-dev
20:08 Icedream joined #minetest-dev
20:09 SilverLuke joined #minetest-dev
20:09 rubenwardy next PR: #7253
20:09 ShadowBot https://github.com/minetest/minetest/issues/7253 -- Add updating to online content repository by rubenwardy
20:10 rubenwardy now working on screenshots (ew)
20:11 rubenwardy Minetest needs a picasso style  image_url[]
20:11 rubenwardy would be glorious
21:13 Cornelia joined #minetest-dev
21:44 JDCodeIt
21:45 rubenwardy quality conversation there ^
21:52 fwhcat joined #minetest-dev
22:04 paramat will merge game#2110 in an hour or so
22:04 ShadowBot https://github.com/minetest/minetest_game/issues/2110 -- Rebalance bronze and steel tools, swap ore depths by paramat
22:36 proller joined #minetest-dev
22:38 SilverLuke joined #minetest-dev
22:43 JDCodeIt joined #minetest-dev
22:44 JDCodeIt Hi all, what version of Irrlicht are we aiming to work with in 0.5.0?
22:47 rubenwardy paramat: when starting a world with singlenode https://media.discordapp.net/attachments/369123162039910401/436658406187728927/unknown.png
22:53 paramat rubenwardy what game?
22:53 rubenwardy a custom one
22:53 rubenwardy idk
22:53 paramat ok
22:53 rubenwardy it's octacian
22:53 rubenwardy he doesn't have the aliases obviously
22:53 rubenwardy but he shouldn't need them for singlenode
22:53 paramat yes that's why
22:53 sofar custom game 101: define mapgen aliases that are needed?
22:54 paramat it's because singlenode uses the shared biome code
22:54 paramat this issue has come up before, not easy to solve, might be best to make that a warning instead
22:55 paramat hm but i'll lok into somehow disabling that for singelnode
22:55 paramat *singlenode
22:55 paramat *look
22:56 paramat will put on todo list
23:00 paramat see #1840
23:00 ShadowBot https://github.com/minetest/minetest/issues/1840 -- Singlenode: Failed to resolve 'mapgen_water_source'
23:01 paramat i think downgrade to warning, it's a bit alarming and happens often with custom games
23:01 paramat i'll reopen the issue to remind me
23:02 rubenwardy shouldn't be needed for singlenode
23:02 paramat yes, but see hmmmm's answer
23:06 paramat it's also not a problem to have some mapgen aliases missing, which will happen often with custom games
23:06 proller joined #minetest-dev
23:15 paramat i'll downgrade the message so nothing appears in terminal, so that games don't look broken
23:28 twoelk left #minetest-dev
23:35 Player-2 joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext