| Time |
Nick |
Message |
| 00:08 |
Fixer |
what happened? |
| 00:08 |
Fixer |
just take it easy |
| 00:10 |
paramat |
we are =) |
| 00:14 |
Fixer |
be glad Linus Torvalds is not commenting on minetest |
| 00:22 |
rubenwardy |
fwiw, paramat: kilbith and Wuzzy were wrong in that issue |
| 00:22 |
rubenwardy |
#include <cmath> does add stuff to the std namespace |
| 00:22 |
rubenwardy |
it just doesn't add min / max - that's in algorithms |
| 00:22 |
rubenwardy |
that's an easy mistake to make (I've done it) |
| 00:22 |
rubenwardy |
*algorithms rather than maths |
| 00:23 |
rubenwardy |
https://gcc.gnu.org/onlinedocs/libstdc%2B%2B/libstdc%2B%2B-html-USERS-3.4/cmath-source.html |
| 00:34 |
paramat |
std::min/max and fmin/fmax have differnt requirements, easy to forget. doesn't matter to k, it's a chance to attack |
| 00:44 |
|
Gael-de-Sailly joined #minetest-dev |
| 01:45 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:05 |
paramat |
later i'll merge #7070 #7100 |
| 02:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/7070 -- Biomes: Add X and Z biome limits / Getv3intfield: Fix logic of return bool by paramat |
| 02:05 |
ShadowBot |
https://github.com/minetest/minetest/issues/7100 -- Gennotify docs: Clarify returned positions for decorations by paramat |
| 02:06 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:34 |
paramat |
#7104 updated |
| 02:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/7104 -- Spawn level: Add 'get_spawn_level(x, z)' API by paramat |
| 02:58 |
|
YuGiOhJCJ joined #minetest-dev |
| 03:06 |
|
paramat joined #minetest-dev |
| 03:13 |
paramat |
now merging #7070 #7100 |
| 03:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/7070 -- Biomes: Add X and Z biome limits / Getv3intfield: Fix logic of return bool by paramat |
| 03:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/7100 -- Gennotify docs: Clarify returned positions for decorations by paramat |
| 03:25 |
paramat |
merged, <100 PRs again |
| 03:58 |
|
AndroBuilder joined #minetest-dev |
| 04:10 |
|
Cornelia joined #minetest-dev |
| 04:24 |
|
behalebabo joined #minetest-dev |
| 04:27 |
|
paramat joined #minetest-dev |
| 04:33 |
paramat |
merging #7115 |
| 04:33 |
ShadowBot |
https://github.com/minetest/minetest/issues/7115 -- Lua_api.txt: Split long lines part 1 by paramat |
| 04:38 |
paramat |
merged |
| 05:13 |
|
ssieb joined #minetest-dev |
| 05:27 |
|
Darcidride_ joined #minetest-dev |
| 05:28 |
|
Darcidride__ joined #minetest-dev |
| 07:33 |
nerzhul |
Hello, when somes get time i pushed another cleanup patchset https://github.com/minetest/minetest/pull/7114 |
| 09:35 |
|
Lone-Star joined #minetest-dev |
| 11:52 |
|
Fixer joined #minetest-dev |
| 12:00 |
|
Wuzzy joined #minetest-dev |
| 12:01 |
|
Gael-de-Sailly joined #minetest-dev |
| 12:16 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:35 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:53 |
|
YuGiOhJCJ joined #minetest-dev |
| 13:45 |
|
srifqi joined #minetest-dev |
| 13:46 |
|
Beton joined #minetest-dev |
| 14:34 |
|
Krock joined #minetest-dev |
| 14:45 |
|
Gael-de-Sailly joined #minetest-dev |
| 15:10 |
|
srifqi joined #minetest-dev |
| 15:19 |
|
srifqi left #minetest-dev |
| 15:34 |
Megaf |
sfan5: thanks for reviewing my PR, I will be reviewing your review now. |
| 15:44 |
Megaf |
rubenwardy: Shara: https://github.com/minetest/minetest.github.io/pull/121#pullrequestreview-102684694 |
| 15:44 |
Megaf |
!tell paramat https://github.com/minetest/minetest.github.io/pull/121#pullrequestreview-102684694 |
| 15:44 |
ShadowBot |
Megaf: O.K. |
| 15:44 |
Megaf |
!title |
| 15:44 |
ShadowBot |
Channel description improvements 2. by Megaf · Pull Request #121 · minetest/minetest.github.io · GitHub |
| 15:54 |
Megaf |
sfan5: is that better? https://github.com/minetest/minetest.github.io/pull/121/files#diff-5cc5127841b3b9e922b2cb7fdc182cfdR18 |
| 15:54 |
Megaf |
"Main channel where everyone is welcome to discuss the game or request support." |
| 16:03 |
|
YuGiOhJCJ joined #minetest-dev |
| 16:04 |
|
YuGiOhJCJ joined #minetest-dev |
| 16:45 |
sfan5 |
Megaf: yes that's better |
| 16:46 |
Megaf |
"Main channel where everyone is welcome to discuss the game or request support." or "Main channel for general game and engine discussion or support" |
| 16:47 |
Megaf |
because |
| 16:47 |
Megaf |
16:15 <Krock> Megaf, in what channels is someone not welcome? (regarding web PR) |
| 16:47 |
Megaf |
16:16 <Megaf> Krock: open to suggestions :) |
| 16:47 |
Megaf |
16:16 <Krock> Main channel for general game and engine discussion or support. |
| 16:47 |
Megaf |
valid point ^ |
| 16:50 |
Krock |
Could someone please spend about 15 minutes to review/test #6787 ? Testing code exists (allows side-by-side comparison of PR and non-PR builds) |
| 16:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/6787 -- textarea[], field[]: Unify function, fix wrong fallback text by SmallJoker |
| 16:51 |
Krock |
non-member testing is also welcome ofc |
| 17:22 |
|
Taoki_1 joined #minetest-dev |
| 17:33 |
|
Icedream joined #minetest-dev |
| 17:45 |
|
Taoki joined #minetest-dev |
| 18:11 |
|
Darcidride joined #minetest-dev |
| 18:27 |
|
Icedream joined #minetest-dev |
| 18:30 |
|
ssieb joined #minetest-dev |
| 19:13 |
|
paramat joined #minetest-dev |
| 19:21 |
|
RobbieF joined #minetest-dev |
| 19:29 |
|
Taoki joined #minetest-dev |
| 20:03 |
paramat |
#7104 updated as requested, retested |
| 20:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/7104 -- Spawn level: Add 'get_spawn_level(x, z)' API by paramat |
| 20:15 |
|
Taoki_1 joined #minetest-dev |
| 21:05 |
nerzhul |
Krock okay for me |
| 21:05 |
nerzhul |
if someone can take time to review https://github.com/minetest/minetest/pull/7114 ? |
| 21:17 |
paramat |
looking at the voxelarea stuff |
| 21:23 |
nerzhul |
yeah each commit is independant |
| 21:25 |
Krock |
nerzhul, only doc issues from my side. the other code looks good |
| 21:26 |
Krock |
nerzhul, thanks for your textarea PR review |
| 21:27 |
nerzhul |
Krock nice, i will fix that doc issue, paramat thanks for the 6th commit |
| 21:30 |
nerzhul |
Krock doc is fixed, if it's okay to you, please add your approval :) if okay i will merge after travis pass |
| 21:31 |
rubenwardy |
is there a key co-ordinate to view the next commit when in the PR files changed mode? |
| 21:31 |
rubenwardy |
or do I just have to use the drop down |
| 21:32 |
nerzhul |
if i'm correct the only way is to use the dropdown |
| 21:33 |
rubenwardy |
I'm not sure on the point of going from 3 s16s to a v3s16 when it's not used |
| 21:33 |
rubenwardy |
well, it's cleaner but I wonder if it affects performance |
| 21:34 |
rubenwardy |
oh nvm |
| 21:34 |
rubenwardy |
you do use it |
| 21:34 |
nerzhul |
:p |
| 21:34 |
rubenwardy |
I blame github's indentation XD |
| 21:35 |
rubenwardy |
oh no, nvm, it's not 8 spaces like in gists \o/ |
| 21:38 |
rubenwardy |
does getNodeNoCheck really not accept a v3s16? |
| 21:38 |
nerzhul |
inline MapNode getNodeNoCheck(v3s16 p, bool *valid_position) |
| 21:38 |
nerzhul |
=> return getNodeNoCheck(p.X, p.Y, p.Z, valid_position); |
| 21:38 |
rubenwardy |
hmmm |
| 21:38 |
rubenwardy |
it reads better to use that, and inline makes it no slower |
| 21:39 |
nerzhul |
i can add this yes it's a good idea |
| 21:42 |
|
RobbieF left #minetest-dev |
| 21:44 |
nerzhul |
rubenwardy it's pushed, i didn't notice this call heh |
| 21:52 |
rubenwardy |
lol |
| 21:52 |
rubenwardy |
getFreeServerActiveObjectId() is quite a funny algorithm |
| 21:59 |
rubenwardy |
is addActiveObject called both when an entity is spawned, and when the entity's mapblock becomes active? |
| 22:01 |
Krock |
where funny = "agh, the hell is this inefficient" |
| 22:01 |
nerzhul |
sorry i don't remember, but i'm sure if it's not the only to audit some old server code we can find some strange things :d |
| 22:02 |
rubenwardy |
everything entity related sucks |
| 22:02 |
rubenwardy |
might be worth looking at n0's entity spatial partition PR |
| 22:02 |
rubenwardy |
although my concern is that it duplicates code which already exists for AreaStore |
| 22:04 |
rubenwardy |
addActiveObject seems to only be called by minetest.add_entity |
| 22:06 |
rubenwardy |
#6587 |
| 22:06 |
ShadowBot |
https://github.com/minetest/minetest/issues/6587 -- Optimize entity-entity collision by numberZero |
| 22:08 |
rubenwardy |
wtf |
| 22:08 |
rubenwardy |
void getStaticData(std::string *result) const { *result = ""; } |
| 22:10 |
rubenwardy |
ah, CLion's just lying about no derivatives |
| 22:10 |
rubenwardy |
something about Minetest's source code kills CLion |
| 22:11 |
nerzhul |
rubenwardy yes clion sometimes tells wrong thing in C++ code in inheritance, but it's enhanced in recent versions |
| 22:11 |
rubenwardy |
commits 1-4 ok, now checking 5 |
| 22:11 |
rubenwardy |
gmmm |
| 22:11 |
rubenwardy |
I'm only a version behind |
| 22:13 |
rubenwardy |
up to date now |
| 22:15 |
Calinou |
rubenwardy: try an EAP build maybe? |
| 22:15 |
Calinou |
(early access preview) |
| 22:15 |
rubenwardy |
turned out it was lying to me |
| 22:23 |
rubenwardy |
http://doxy.minetest.net/classServer__coll__graph.svg |
| 22:23 |
rubenwardy |
interesting to see |
| 22:24 |
rubenwardy |
worth doing the Saturday meetings again? |
| 22:26 |
paramat |
it seemed people can't commit to certain times, which is fine and understandble, MT has to fit around RL |
| 22:27 |
paramat |
then at unexpected times devs would be around :] |
| 22:27 |
nerzhul |
merging #7114 (unsquashed) |
| 22:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/7114 -- Code cleanup: fixes + performance updates by nerzhul |
| 22:27 |
rubenwardy |
getting your commit count up? XD |
| 22:27 |
nerzhul |
ty Krock, paramat and ruben for review |
| 22:27 |
rubenwardy |
just kidding :D |
| 22:28 |
|
BakerPrime joined #minetest-dev |
| 22:35 |
Krock |
rubenwardy, doing meetings sounds good to process the current open PRs :) |
| 22:35 |
rubenwardy |
yeah |
| 22:37 |
rubenwardy |
I really need to familiarise myself with Minetest's graphics |
| 22:37 |
rubenwardy |
in particular meshgen |
| 22:37 |
rubenwardy |
there's lots of important PRs I just don't understand |
| 22:37 |
|
proller joined #minetest-dev |
| 22:41 |
rubenwardy |
oooh, new clion splashscreen |
| 22:45 |
|
Gael-de-Sailly joined #minetest-dev |
| 22:59 |
rubenwardy |
so, 75 PRs in a few months? |
| 22:59 |
rubenwardy |
\o/ |
| 22:59 |
rubenwardy |
#7099 |
| 23:00 |
ShadowBot |
https://github.com/minetest/minetest/issues/7099 -- Add formspec theming using prepended strings by rubenwardy |
| 23:00 |
paramat |
but yes i can so meetings |
| 23:04 |
paramat |
#7104 is an easy one |
| 23:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/7104 -- Spawn level: Add 'get_spawn_level(x, z)' API by paramat |
| 23:07 |
rubenwardy |
will merge #6787 in 10 |
| 23:07 |
ShadowBot |
https://github.com/minetest/minetest/issues/6787 -- textarea[], field[]: Unify function, fix wrong fallback text by SmallJoker |
| 23:08 |
rubenwardy |
paramat, done |
| 23:12 |
paramat |
thanks |
| 23:13 |
paramat |
i'll merge 7104 tonight with my next lua.api long line fix PR |
| 23:14 |
rubenwardy |
nice |
| 23:15 |
rubenwardy |
stupid run in place |
| 23:15 |
rubenwardy |
alias cmt="cmake . -DRUN_IN_PLACE=1 -DBUILD_CLIENT=1 -DBUILD_SERVER=0 && make -$ |
| 23:15 |
rubenwardy |
* alias cmt="cmake . -DRUN_IN_PLACE=1 -DBUILD_CLIENT=1 -DBUILD_SERVER=0 && make -j3" |
| 23:16 |
rubenwardy |
now run in place will never revert itself again |
| 23:25 |
rubenwardy |
merged |
| 23:31 |
paramat |
ugh forgot docs again |
| 23:31 |
rubenwardy |
lol |
| 23:31 |
rubenwardy |
make sure to note about returning nil |
| 23:32 |
rubenwardy |
also, when will biome manager be nil? |
| 23:32 |
rubenwardy |
if it should never be nil, even during loading, then you should use FATAL_ERROR_IF rather than returning nil to the API |
| 23:34 |
paramat |
not sure, copying hmmmm's code |
| 23:34 |
|
DI3HARD139 joined #minetest-dev |
| 23:35 |
paramat |
might leave docs until after my next lua_api long line PR |
| 23:49 |
|
paramat joined #minetest-dev |
| 23:50 |
Megaf |
!title https://github.com/minetest/minetest.github.io/pull/121/commits/8dcd5e43d085152b323345fd1cce1fbd91e20ec4 |
| 23:50 |
ShadowBot |
Megaf: Channel description improvements 2. by Megaf · Pull Request #121 · minetest/minetest.github.io · GitHub |
| 23:55 |
Fixer |
rubenwardy: 75 half-rotten PRs... sadly |
