| Time |
Nick |
Message |
| 00:11 |
|
Tmanyo joined #minetest-dev |
| 00:39 |
paramat |
game#2022 |
| 00:39 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2022 -- Remove grasses, ferns from flower spread ABM (remove from flora group) |
| 01:07 |
paramat |
rubenwardy see https://github.com/minetest/minetest/issues/6736#issuecomment-358156393 no wonder CSM was so poorly developed, no explanation of what was going on |
| 01:08 |
paramat |
CSM death formspec should be reverted |
| 01:09 |
paramat |
new rule: non-trivial PRs have to have a clear non-technical description of what they do |
| 01:10 |
paramat |
otherwise no merge |
| 01:16 |
paramat |
^ celeron55 |
| 01:28 |
paramat |
there's not even a 2nd approval linked for #5094 |
| 01:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/5094 -- CSM: Add method to display a formspec and callbacks by red-001 |
| 01:37 |
paramat |
#5093 also has no description and no linked approval |
| 01:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/5093 -- CSM: Add on_death callback by nerzhul |
| 01:37 |
paramat |
no wonder CSM was a disaster |
| 01:54 |
|
EvergreenTree joined #minetest-dev |
| 02:32 |
|
EvergreenTree joined #minetest-dev |
| 02:49 |
paramat |
10 CSM PRs without linked approval #6924 |
| 02:49 |
ShadowBot |
https://github.com/minetest/minetest/issues/6924 -- CSM PRs without apparent approval |
| 03:40 |
|
EvergreenTree joined #minetest-dev |
| 05:35 |
|
compunerd joined #minetest-dev |
| 07:03 |
|
nerzhul joined #minetest-dev |
| 08:17 |
|
thePalindrome joined #minetest-dev |
| 08:34 |
Hijiri |
any reviews for #6688 |
| 08:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/6688 -- Custom particle generators for particle spawners by raymoo |
| 08:34 |
Hijiri |
it has a cool issue number too |
| 09:00 |
|
Darcidride joined #minetest-dev |
| 09:42 |
|
nerzhul joined #minetest-dev |
| 10:47 |
|
pgimeno joined #minetest-dev |
| 12:01 |
|
YuGiOhJCJ joined #minetest-dev |
| 12:23 |
|
Fixer joined #minetest-dev |
| 13:18 |
|
EvergreenTree joined #minetest-dev |
| 13:26 |
red-001 |
paramat every single one of those was a PR to the CSM branch |
| 13:28 |
red-001 |
which was then merged with master through #5088 which I may add you personally approved |
| 13:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/5088 -- Client side scripting/modding by nerzhul |
| 13:38 |
red-001 |
and most of those PRs are API's so you have a clear description of what they do in the API documentation |
| 13:46 |
nerzhul |
red-001, yeah i commented the issue |
| 13:46 |
red-001 |
I really don't see why you are complaining about this now, it seems unreasonable to do that when you had almost two months to find and point out any issues with it and it was merged almost a year ago |
| 13:46 |
nerzhul |
red-001, +1 |
| 13:47 |
red-001 |
I'm all for fixing issues with CSM but this seems more like a witchhunt then anything else |
| 13:47 |
red-001 |
as for reverting the death formspec I don't really have a strong opinion on it |
| 13:48 |
Shara |
It came up yesterday because someone reported a method of crashing servers using CSM. |
| 13:49 |
Shara |
But thankfully it doesn't actually crash servers. |
| 13:51 |
red-001 |
that's an interesting method then |
| 13:52 |
Shara |
It looks like it from the player's point of view, but the server is still running. |
| 13:52 |
Shara |
Person making the issue obviously didn't test very well |
| 13:53 |
red-001 |
I guess they just crashed the client or got it disconnected then? |
| 13:53 |
red-001 |
we disconnect for violating the protocol in some ways iirc |
| 13:55 |
Shara |
Don't know. I just tested it to check if there was a real issue. |
| 13:55 |
Shara |
And it was neither a server crash, not to do with an MTG mod like they claimed. |
| 13:55 |
Shara |
nor* |
| 13:56 |
nerzhul |
Shara, if someone crash server with CSM it mean just server should be fixed (core or mods) |
| 13:56 |
nerzhul |
CSM is just a client tool, if server crash it's server stability responibility not client, whereas client is rogue or not |
| 13:56 |
red-001 |
it does but we should avoid making it easy |
| 13:56 |
nerzhul |
if you send a rogue HTTP request to a webserver and it crash, do you fix the HTTP client or the server ? |
| 13:57 |
nerzhul |
red-001, and it's a good thing, because if it's a coreside issue we can fix it and reproduce it easily. If it's in mods it's responbility of the srever owner to fix mods or send a mod upstream request |
| 13:58 |
Shara |
nerzhul: I'm aware |
| 13:58 |
red-001 |
Shara, did it get filled on github? |
| 13:58 |
red-001 |
I don't see any issue that seems like it |
| 13:58 |
Shara |
Yes, already close. Check MTG |
| 13:58 |
red-001 |
ah I was checking core |
| 13:58 |
Shara |
I think the code was removed though since it was a potential server crasher |
| 13:59 |
nerzhul |
just remove all code, no crash then :p |
| 13:59 |
Shara |
:P |
| 14:00 |
red-001 |
Shara, do you still have the code? |
| 14:00 |
Shara |
Sure, will send you it |
| 14:00 |
|
ThomasMonroe joined #minetest-dev |
| 14:07 |
red-001 |
nerzhul, are packets sent on their own or are they grouped together? |
| 14:35 |
|
nore joined #minetest-dev |
| 15:02 |
nerzhul |
red-001, network packet you mean ? each chunk is sent when ready |
| 15:02 |
nerzhul |
the sending order should be respected but the reception depend on network |
| 15:15 |
|
nerzhul joined #minetest-dev |
| 15:19 |
|
twoelk joined #minetest-dev |
| 16:45 |
|
Gael-de-Sailly joined #minetest-dev |
| 16:46 |
|
nerzhul joined #minetest-dev |
| 17:33 |
|
Krock joined #minetest-dev |
| 17:45 |
|
EvergreenTree joined #minetest-dev |
| 18:09 |
pgimeno |
what's the tab width for Lua code? 4? |
| 18:11 |
pgimeno |
that's not specified in the style guide |
| 18:13 |
pgimeno |
it's important wrt the character limit - a literal interpretation of the style guide would be 1 tab = 1 character (because the line limit says characters, not columns) |
| 18:25 |
pgimeno |
Krock: re your first objection, it's not published to mods, only to the main menu, see the function in context: https://github.com/pgimeno/minetest/blob/distinguish-mods-in-modpacks/builtin/common/misc_helpers.lua#L549 . I'll happily move it if that's not deemed adequate. |
| 18:28 |
Krock |
well, we have a common file in mainmenu for such functions, so putting the function into the misc_helpers file is not the best choice IMO |
| 18:29 |
pgimeno |
ok, I'll move it |
| 18:29 |
Krock |
almost all functions in misc_helpers are documented and usable for the mod API. Mainmenu-only stuff does not fit in there. Thanks. |
| 18:30 |
pgimeno |
thank you for the review :) |
| 18:35 |
Krock |
np. it works good. sadly we can't keep the backwards compat for older clients there. any non-"true" will be recognized as disabeld |
| 18:36 |
pgimeno |
yeah |
| 18:36 |
pgimeno |
there is a workaround |
| 18:37 |
pgimeno |
instead of using root directory names of game, world, mods, cmods, using non-zero numbers: 1, 2, 3, 4 |
| 18:37 |
pgimeno |
that works as true |
| 18:37 |
pgimeno |
but it was too ugly |
| 18:38 |
pgimeno |
e.g. load_mod_cottages = 3.dreambuilder -- core.is_yes() returns true for that one |
| 18:38 |
Krock |
indeed, it is. |
| 18:39 |
pgimeno |
Krock: would that function make more sense in modmgr.lua, since it's related to mod management? |
| 18:41 |
Krock |
it's used in modmgr and dlg_config_world.lua. If modmgr is loaded first, then there's technically no problem by moving it there |
| 18:42 |
Krock |
yes, it would be possible. Do what you prefer.. |
| 18:42 |
pgimeno |
yeah, technically it's OK, I asked because it's not related to other aspects of mainmenu so it sounded like it would fit there better |
| 19:01 |
|
nerzhul joined #minetest-dev |
| 19:11 |
|
EvergreenTree joined #minetest-dev |
| 19:15 |
|
ThomasMonroe joined #minetest-dev |
| 19:20 |
pgimeno |
Maybe the note at the end of this sentence should be copied to the Lua style guide? |
| 19:20 |
pgimeno |
"Try to keep lines under 80 characters. It's okay if it goes over by a few, but 90 character lines or larger are definitely unacceptable. (note: this column count assumes 4-space indents)" |
| 19:22 |
pgimeno |
(that's from the C++ style guide) |
| 19:25 |
|
Darcidride_ joined #minetest-dev |
| 20:33 |
|
ThomasMonroe joined #minetest-dev |
| 22:18 |
|
clavi joined #minetest-dev |
| 22:26 |
|
EvergreenTree joined #minetest-dev |
| 22:43 |
|
twoelk left #minetest-dev |
| 23:42 |
|
Tmanyo joined #minetest-dev |
