| Time |
Nick |
Message |
| 00:52 |
Megaf |
Confirmed. |
| 00:52 |
Megaf |
https://github.com/minetest/minetest/labels/One%20approval |
| 01:02 |
|
torgdor joined #minetest-dev |
| 01:24 |
|
twoelk left #minetest-dev |
| 01:45 |
|
Xio joined #minetest-dev |
| 01:52 |
|
Icedream joined #minetest-dev |
| 02:16 |
paramat |
weird bug https://github.com/minetest/minetest_game/issues/1959#issuecomment-350413062 |
| 02:23 |
|
EvergreenTree joined #minetest-dev |
| 02:59 |
|
torgdor joined #minetest-dev |
| 03:07 |
|
paramat joined #minetest-dev |
| 03:48 |
|
paramat joined #minetest-dev |
| 04:44 |
paramat |
sofar #6696 is excellent, see my comment, hope you can +1 |
| 04:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/6696 -- Update light decoding table size by numberZero |
| 05:11 |
|
Icedream joined #minetest-dev |
| 05:11 |
|
fireglow joined #minetest-dev |
| 05:11 |
|
basicer joined #minetest-dev |
| 05:11 |
|
red-001 joined #minetest-dev |
| 05:11 |
|
thatgraemeguy joined #minetest-dev |
| 05:11 |
|
TC01 joined #minetest-dev |
| 05:11 |
|
garywhite joined #minetest-dev |
| 05:14 |
|
paramat joined #minetest-dev |
| 05:14 |
|
jas_ joined #minetest-dev |
| 05:14 |
|
thePalindrome joined #minetest-dev |
| 05:14 |
|
Vadtec joined #minetest-dev |
| 05:14 |
|
celeron55 joined #minetest-dev |
| 05:14 |
|
exio4 joined #minetest-dev |
| 05:15 |
|
Xio joined #minetest-dev |
| 05:15 |
|
lisac joined #minetest-dev |
| 05:15 |
|
Taoki joined #minetest-dev |
| 05:15 |
|
torgdor joined #minetest-dev |
| 05:15 |
|
troller joined #minetest-dev |
| 05:15 |
|
ashtrayoz joined #minetest-dev |
| 05:15 |
|
Dumbeldor joined #minetest-dev |
| 05:15 |
|
nore joined #minetest-dev |
| 05:19 |
|
nyuszika7h_ joined #minetest-dev |
| 05:24 |
paramat |
#6744 is fine (with my fix) just needs another +1, simple array -> vector stuff |
| 05:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/6744 -- Use std::vector instead of dynamic C-Array by adrido |
| 05:39 |
|
KaadmY joined #minetest-dev |
| 05:39 |
|
sofar joined #minetest-dev |
| 05:59 |
|
Fritigern joined #minetest-dev |
| 06:36 |
|
silwol joined #minetest-dev |
| 07:45 |
|
book` joined #minetest-dev |
| 07:51 |
|
Hunterz joined #minetest-dev |
| 08:04 |
|
Etzos[m] joined #minetest-dev |
| 08:23 |
|
nerzhul joined #minetest-dev |
| 09:05 |
|
fireglow[m] joined #minetest-dev |
| 09:17 |
|
fireglow[m] joined #minetest-dev |
| 09:21 |
|
Krock joined #minetest-dev |
| 09:24 |
|
silwol joined #minetest-dev |
| 09:24 |
|
Etzos[m] joined #minetest-dev |
| 10:18 |
|
basicer joined #minetest-dev |
| 10:51 |
|
Darcidride joined #minetest-dev |
| 10:53 |
|
Krock joined #minetest-dev |
| 10:54 |
|
ensonic joined #minetest-dev |
| 11:03 |
|
Darcidride joined #minetest-dev |
| 11:10 |
|
Darcidride joined #minetest-dev |
| 11:25 |
|
nerzhul joined #minetest-dev |
| 11:30 |
|
Fixer joined #minetest-dev |
| 11:36 |
|
Raven262 joined #minetest-dev |
| 12:14 |
|
EvergreenTree joined #minetest-dev |
| 12:15 |
|
Jordach joined #minetest-dev |
| 12:30 |
|
EvergreenTree joined #minetest-dev |
| 13:07 |
|
ensonic joined #minetest-dev |
| 13:26 |
|
CBugDCoder joined #minetest-dev |
| 13:30 |
nerzhul |
merging #6754 |
| 13:30 |
ShadowBot |
https://github.com/minetest/minetest/issues/6754 -- Pointed thing to face pos: Use 'eye height' object property by paramat |
| 13:34 |
nerzhul |
i suggest to merge #6738 i don't have time this weekend to check builtin integrity, this can be added a little bit later (from myself or another) and this PR is currently an improvement |
| 13:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/6738 -- CSM fixes: load mods after flavours & add flavour to block mod loading by nerzhul |
| 13:35 |
Krock |
nerzhul, I don't think there's any noticeable performance difference for these maximal 40 entries with the default chunk size |
| 13:35 |
nerzhul |
39 memory copy |
| 13:36 |
nerzhul |
i suggest to add a single resize first to prevent them |
| 13:36 |
nerzhul |
or use std::array |
| 13:42 |
Krock |
vector::reserve seems more suitable for this case, instead of resize. Otherwise we would end up with new initialized/constructed integers |
| 13:42 |
Krock |
arrays are fine too, but requires manual counting of the entries again |
| 13:43 |
Krock |
nvm |
| 13:46 |
nerzhul |
Krock, no manual counting, std::array has a .length or .size operator |
| 13:47 |
|
ThomasMonroe joined #minetest-dev |
| 13:51 |
Krock |
nerzhul, .size and .max_size are both the same. There's no re-allocating after constructing the array. 40 initialized integers will most likely have any value. It's not known how many actual floors/ceilings there are without counting them manually |
| 13:52 |
ThomasMonroe |
Krock you seen paramat? |
| 13:52 |
Krock |
or am I somewhat mistaken here? |
| 13:54 |
Krock |
ThomasMonroe, last message in this channel was around 05:24 (AM) UTC. Just wait a few hours, he'll possibly come online soon |
| 13:55 |
ThomasMonroe |
ok, I won't be on then, could you tell him that #6701 is finished |
| 13:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/6701 -- Debug output looks strange |
| 13:55 |
nerzhul |
if you use reserve yes, if you use resize no, because if i remember you cannot access to non pushed storage |
| 13:55 |
ThomasMonroe |
oops, I meant #6702 |
| 13:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/6702 -- Adjusted the debug info according to issue #6701 by ThomasMonroe314 |
| 13:55 |
Megaf |
[13:30:18] <nerzhul> merging #6754 |
| 13:56 |
Megaf |
o |
| 13:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/6754 -- Pointed thing to face pos: Use 'eye height' object property by paramat |
| 13:56 |
Megaf |
o/ |
| 13:56 |
nerzhul |
Megaf, hmm, okay |
| 13:56 |
Megaf |
that's just a celebration thing :P |
| 14:00 |
Megaf |
Now I'm confused |
| 14:00 |
Megaf |
yesterday was mentioned that one way that devs can see if the community like or now a suggestion or PR is by the community voting with thumbs up and down |
| 14:00 |
nerzhul |
coredevs, i have an answer from Jetbrains, how many wants Clion license ? (Krock, sfan5 , sofar , nore ?) |
| 14:01 |
nore |
nerzhul: what's Clion? |
| 14:01 |
Megaf |
so yesterday I gave thumbs up to some PRs that I thought were nice and ok to be merged. |
| 14:01 |
nerzhul |
the better cross systems C++ IDE from jetbrains |
| 14:01 |
nore |
ah |
| 14:01 |
Megaf |
So I was asked to remove my thumbs up of approval because is a tool that should be used only by devs. I understand that. But it's not very, intuitive. |
| 14:01 |
nerzhul |
it's not free i know, but we can apply for OSS and i did it |
| 14:02 |
nore |
no, I shouldn't really need it |
| 14:02 |
sfan5 |
hm will need to think about that |
| 14:02 |
nerzhul |
okay, as you like it's free i can ask them, it has many integration you can compile on WIndows, macosx, linux, use GCC or clang, it integrate Cmake, clang, clang-format, clang-tidy, valgrind, gdb, lldb and more it's very very useful |
| 14:03 |
nerzhul |
Clang 6.0 will default to C++14 next year :o |
| 14:03 |
Krock |
surely a nice IDE but I've already got a working setup here. Maybe later |
| 14:38 |
|
Jordach joined #minetest-dev |
| 15:19 |
|
Raven262 joined #minetest-dev |
| 15:38 |
|
rubenwardy joined #minetest-dev |
| 16:15 |
rubenwardy |
I'd recommend CLion, it's really nice (apart from some linting issues). I don't need a license though |
| 17:23 |
|
EvergreenTree joined #minetest-dev |
| 18:07 |
nerzhul |
rubenwardy, linting is customizable |
| 18:25 |
rubenwardy |
the problem I'm having is it doesn't like operator overloading |
| 18:25 |
rubenwardy |
it's been filed to their issue tracker |
| 19:00 |
|
EvergreenTree joined #minetest-dev |
| 19:11 |
Krock |
nerzhul, 16 is 0x10. You used 0xF by accident in #6738 |
| 19:11 |
ShadowBot |
https://github.com/minetest/minetest/issues/6738 -- CSM fixes: load mods after flavours & add flavour to block mod loading by nerzhul |
| 19:19 |
Krock |
if we used C's strtol() function to convert the string setting to a u64, hexadecimal notation would be possible too |
| 19:21 |
|
Jordach joined #minetest-dev |
| 19:23 |
sfan5 |
^ would make it much easier to use, agree |
| 19:24 |
|
Player_2 joined #minetest-dev |
| 19:39 |
nerzhul |
Krock, oops |
| 19:51 |
|
numzero joined #minetest-dev |
| 20:18 |
sofar |
Krock is the falcon |
| 20:20 |
|
CBugDCoder joined #minetest-dev |
| 20:22 |
Krock |
sofar, sorry what? |
| 20:22 |
rubenwardy |
falcon - good at spotting things |
| 20:22 |
rubenwardy |
isn't the phrase a hawk though? |
| 20:22 |
rubenwardy |
idk |
| 20:22 |
Krock |
ah, in that context |
| 20:23 |
nerzhul |
Krock, fix is pushed |
| 20:30 |
Krock |
nerzhul, good. Is disabled client modding a problem? writing to to warningstream isn't necessary. perhaps infostream - if at all? |
| 20:31 |
nerzhul |
possible |
| 20:32 |
Krock |
functionality is fine |
| 20:33 |
|
ensonic joined #minetest-dev |
| 20:45 |
|
fwhcat joined #minetest-dev |
| 22:05 |
|
Foz joined #minetest-dev |
| 22:07 |
|
Raven262 joined #minetest-dev |
| 22:18 |
|
AntumDeluge joined #minetest-dev |
| 23:41 |
|
tranquility_ joined #minetest-dev |
| 23:53 |
|
Jordach joined #minetest-dev |
