Time |
Nick |
Message |
00:01 |
|
bigfoot547 joined #minetest-dev |
00:26 |
|
AntumDeluge joined #minetest-dev |
00:46 |
|
est31 joined #minetest-dev |
00:53 |
|
Tmanyo joined #minetest-dev |
01:15 |
|
Fritigern joined #minetest-dev |
02:07 |
|
Sokomine_ joined #minetest-dev |
02:28 |
|
Sokomine joined #minetest-dev |
04:59 |
|
est31 joined #minetest-dev |
05:05 |
|
Hunterz joined #minetest-dev |
05:29 |
|
Natechip joined #minetest-dev |
05:47 |
|
nerzhul joined #minetest-dev |
05:57 |
nerzhul |
hello, merging #6341 |
05:57 |
ShadowBot |
https://github.com/minetest/minetest/issues/6341 -- Fix mistake when calling on_priv_grant/revoke, and document them by rubenwardy |
06:07 |
nerzhul |
nore, does the translations have CSM bindings ? |
06:07 |
nerzhul |
if not, please port bindings to CSM permitting CSM mods to translate their stringzs |
06:08 |
nore |
nerzhul: hmm, I think so |
06:08 |
nore |
but their files won't be loaded |
06:08 |
nore |
I mean, translation files |
06:08 |
nerzhul |
where did you declare the translator binding ? (cpp side) |
06:08 |
nore |
oh it's in Lua only |
06:09 |
nerzhul |
oh, S and minetest.get_translator are not C++ bindings ? |
06:09 |
nerzhul |
they are in builtin ? |
06:09 |
nore |
yes, they are in misc_helpers.lua IIRC |
06:10 |
nore |
but I think gettext would be better for CSM |
06:10 |
nore |
don't you think so? |
06:10 |
nerzhul |
okay and misc_helper is loaded by builtin , then CSM have the binding |
06:11 |
nore |
yes |
06:11 |
nerzhul |
gettext needs compiled .po |
06:11 |
nerzhul |
and we don't load any other PO than core po |
06:11 |
nore |
but since translation files are loaded as media, I don't think CSM translation files will be loaded |
06:11 |
nerzhul |
erf, can you find a way to inject that for CSM ? |
06:12 |
nore |
hmmmm I need to think about how this can be done |
06:12 |
nerzhul |
(preview mod embedded in the tree is what you need for your tests) |
06:12 |
nore |
unfortunately I don't know much about CSM |
06:12 |
nerzhul |
the CSM preview mod contains each call of CSM , you can add one funciton or translate one text in the current preview mod to show it works :p |
06:12 |
nerzhul |
CSM is like SSM, but it's client side |
06:13 |
nore |
hmmm I'll try then |
06:13 |
nerzhul |
you should just enable prview mod, and code heh |
06:13 |
nerzhul |
i don't know how you did the loading part, but i think you should have a similar function in the ClientModApi part to inject them :) |
06:14 |
nore |
hmmm for the loading part I just added the files to the media files |
06:14 |
nerzhul |
nice, thanks, CSM should not be forgotten, there are too many things to finish on it heh |
06:14 |
nerzhul |
it should not be diffucult to retrieve the media addition binding from client then :p |
06:14 |
nore |
nah, should be ok |
06:14 |
nore |
btw, can client-side mods have custom textures, etc. too? |
06:15 |
nerzhul |
not atm |
06:15 |
nerzhul |
but if your code works nicely for translations, you can extend in another PR to make this possible |
06:15 |
nore |
heh |
06:16 |
nerzhul |
this will permit custom Hud to use local resources (maybe it's possible but i can't remember) |
07:19 |
|
nerzhul joined #minetest-dev |
07:23 |
|
lisac joined #minetest-dev |
08:23 |
|
Megaf joined #minetest-dev |
08:25 |
|
Darcidride joined #minetest-dev |
10:44 |
|
est31 left #minetest-dev |
10:45 |
|
est31 joined #minetest-dev |
10:56 |
|
est31 left #minetest-dev |
10:58 |
|
proller joined #minetest-dev |
11:19 |
|
proller joined #minetest-dev |
11:37 |
|
ThomasMonroe joined #minetest-dev |
11:54 |
|
CalebDavis joined #minetest-dev |
12:09 |
|
YuGiOhJCJ joined #minetest-dev |
12:16 |
|
Fixer joined #minetest-dev |
12:41 |
|
RobbieF joined #minetest-dev |
12:56 |
|
srifqi joined #minetest-dev |
13:23 |
|
antims joined #minetest-dev |
13:45 |
|
Hunterz joined #minetest-dev |
14:06 |
|
Wuzzy joined #minetest-dev |
14:06 |
|
juhdanad joined #minetest-dev |
14:21 |
|
Natechip joined #minetest-dev |
14:48 |
|
proller joined #minetest-dev |
15:06 |
|
troller joined #minetest-dev |
15:06 |
srifqi |
Anybody had problems while translating key name? Because there seems a lot translator confused when doing that. Should we translate those key name? I mean, I know some keyboard layout has different name for buttons, but majority of language just not translating those keys. I just read those comments on those keys translations on Weblate. |
15:20 |
|
twoelk joined #minetest-dev |
15:25 |
red-001 |
yeah key names must be confusing to translators |
15:26 |
red-001 |
they lack context |
15:33 |
|
paramat joined #minetest-dev |
15:49 |
|
lisac_ joined #minetest-dev |
15:59 |
|
juhdanad joined #minetest-dev |
16:02 |
|
Beton joined #minetest-dev |
16:02 |
|
Beton joined #minetest-dev |
16:06 |
|
troller joined #minetest-dev |
16:16 |
|
troller joined #minetest-dev |
16:24 |
|
Fixer joined #minetest-dev |
16:27 |
|
Megaf joined #minetest-dev |
16:36 |
|
troller joined #minetest-dev |
16:55 |
|
nerzhul joined #minetest-dev |
16:58 |
|
Errante joined #minetest-dev |
16:58 |
|
Errante left #minetest-dev |
16:59 |
nerzhul |
this javascript nodejs fanboy is anoying |
17:00 |
paramat |
6343? |
17:01 |
paramat |
that PR leaves me speechless :] |
17:04 |
|
RobbieF left #minetest-dev |
17:07 |
|
Krock joined #minetest-dev |
17:12 |
nerzhul |
hi Krock |
17:12 |
nerzhul |
rubenwardy are you around ? |
17:13 |
nerzhul |
paramat, 6343 it's more constructive than the JS boy but i don't see any interest currently to do an alliance with terasology, this guy seems to be a libre enthusiast but not a terasology dev |
17:14 |
nerzhul |
but i agree having a terasology beautiful world is just a nice must have |
17:15 |
nerzhul |
i don't see any terasology issue about inetest, seems useless :) |
17:22 |
paramat |
ok, different person. 'constructive' is not a word i would use for 6343 :] |
17:24 |
paramat |
maybe #6319 can be merged, not sure it needs to wait? |
17:24 |
nerzhul |
merging #5493, forgot it yesterday |
17:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/6319 -- Bump minimal protocol version to 36 by SmallJoker |
17:24 |
ShadowBot |
https://github.com/minetest/minetest/issues/5493 -- Formspec: Add options to set background color and opacity (fullscreen mode + default mode) by nerzhul |
17:24 |
nerzhul |
paramat, i merge it too |
17:25 |
paramat |
good |
17:25 |
sfan5 |
you're making dev builds wholly incompatible :( |
17:25 |
Krock |
oh noes! |
17:25 |
sfan5 |
i know its inevitable but imo it would be better to merge it close before 0.5 release |
17:25 |
Krock |
a week before feature freeze? |
17:25 |
nerzhul |
sfan5, the problem with a such thing, in some cycle if you don't do it early you cannot devel on it :( |
17:26 |
sfan5 |
sure we can do development |
17:26 |
nerzhul |
also it prevent production server owner to use this broken branch |
17:26 |
sfan5 |
if you have an incompatible pr you want merged you can merge the bump pr first |
17:26 |
sfan5 |
hm that's a valid point |
17:26 |
paramat |
we have incompatibility already |
17:26 |
nerzhul |
yeah, the collision box is interesting when connecting to 0.4.16 server :p |
17:26 |
sfan5 |
paramat: but it's not quite "unable to play at all" |
17:27 |
nerzhul |
it is |
17:27 |
sfan5 |
i don't object to merging this pr, just raising my concerns |
17:27 |
nerzhul |
when you have a tunnel with 2 node height you cannot walk properly :p |
17:27 |
sfan5 |
(i already approvied it after all) |
17:27 |
sfan5 |
-i |
17:27 |
nerzhul |
sfan5, your comment on #6343 ? |
17:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/6343 -- Initial compatibility layer diagram by brylie |
17:28 |
sfan5 |
nerzhul: *muffled laughter* |
17:28 |
nerzhul |
and also #6335 (Krock nore sofar rubenwardy too) |
17:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/6335 -- Drop dstack from engine |
17:28 |
nerzhul |
oh sofar added a :+1: |
17:28 |
sfan5 |
me too now |
17:28 |
nerzhul |
nice, i will prepare a PR |
17:30 |
nerzhul |
when do you think we should start backport fixes to stable-0.4 ? i started listing the interesting commit in 0.4.17 project, but do you prefer a 0.4.17 release in october with fixes, and a 0.5.0 later? |
17:31 |
nerzhul |
or both at the same time (seems complicated to handle, but not impossible) |
17:31 |
sfan5 |
.17 first 0.5 later |
17:31 |
nerzhul |
seems less risky |
17:31 |
nerzhul |
maybe we can try that for october or the beginning of november ? |
17:31 |
sfan5 |
so we can make it clear to users and server owners that .17 is only a bugfix release and its support ends right here + the continuation with 0.5 |
17:32 |
sfan5 |
yea |
17:32 |
nerzhul |
0.5.0 is not finished yet, i don't know if you have a roadmap idea before closing this milestone ? |
17:33 |
nerzhul |
personnaly i want the Hud CSM PR to be re-reviewed, finished, and merged, permitting CSM to be more useful, and add NPCSao base permitting minetest_game to start adding mobs (if mtg devs agreed) |
17:35 |
nerzhul |
if nobody knows, we have a nice overflow in the HP transmission code :) |
17:35 |
nerzhul |
hp is u16, but transmitted as u8 over network |
17:36 |
Krock |
why not rangelim it? |
17:36 |
Krock |
would be a temporary solution |
17:36 |
nerzhul |
why limit hp to 255 ? |
17:36 |
nerzhul |
:) |
17:37 |
nerzhul |
#6334 permits to fix the overflow, and is compatible with previous protocol bump |
17:37 |
ShadowBot |
https://github.com/minetest/minetest/issues/6334 -- Network proto handlers/container fixes by nerzhul |
17:37 |
Krock |
but u16 is a nice thing now that we have settable HP |
17:38 |
nerzhul |
if one or more coredev agree this PR fixes the HP transmissions problem, by breaking the packet transmission, but we can do it as we rose min_version 10 mins ago :p and some float/double problems + a buffer/sharedbuffer unittest (wrong unittest container) |
17:39 |
nerzhul |
maybe raising HP to u32 can be an option in this release, as we can now set the HP, permitting modders to implement leveling :) |
17:39 |
paramat |
my TODO list for 0.5.0 has enough to keep me busy until december, i was thinking perhaps release 0.5.0 around mid-late december as we often do, or later |
17:40 |
nerzhul |
paramat, yeah if we release 0.4.17 in october/november a release for christmas or january can be nice |
17:42 |
nerzhul |
Krock, do you think you can port your HP changes to make breath use the same model ? |
17:44 |
Krock |
little more effort for breath but it works the same way |
17:48 |
nerzhul |
nice |
17:54 |
paramat |
maybe wait until i merge #6340 since breath property may conflict |
17:54 |
ShadowBot |
https://github.com/minetest/minetest/issues/6340 -- Zoom: Move to a new player object property by paramat |
18:03 |
nerzhul |
the breath property PR is not coded, :p |
18:03 |
nerzhul |
it seems you have a conflict on your pr |
18:17 |
jas_ |
https://gist.github.com/jastevenson303/d08e8e22d86cf0ff4629e730cbcbdb9d |
18:17 |
jas_ |
nerzhul: ? |
18:18 |
nerzhul |
jas_, :o |
18:18 |
nerzhul |
looking for this, it seems it's in the network bump pr |
18:19 |
jas_ |
yes, just pulled |
18:19 |
nerzhul |
let me 2 min to compile and fix |
18:20 |
jas_ |
no rush really, please by all means, take your time |
18:20 |
nerzhul |
oh it's a typo in Krock commit |
18:20 |
jas_ |
oh |
18:20 |
nerzhul |
a c |
18:20 |
nerzhul |
:p |
18:20 |
nerzhul |
pushing the typo fix |
18:20 |
jas_ |
okie doke, thanks |
18:23 |
nerzhul |
merging #6334 in ~10 mins |
18:23 |
ShadowBot |
https://github.com/minetest/minetest/issues/6334 -- Network proto handlers/container fixes by nerzhul |
18:26 |
|
troller joined #minetest-dev |
18:27 |
Krock |
nerzhul, oops. wasn't travis done when it got merged? o.o |
18:29 |
|
DI3HARD139 joined #minetest-dev |
18:30 |
nerzhul |
no, but no problem, it's fixed :) |
18:31 |
|
Beton_ joined #minetest-dev |
19:01 |
|
YuGiOhJCJ joined #minetest-dev |
19:02 |
|
book` joined #minetest-dev |
19:03 |
nerzhul |
paramat, can you review trivial doc fix #6345 please ? |
19:03 |
ShadowBot |
https://github.com/minetest/minetest/issues/6345 -- Documentation for 'slippery' node group by bendeutsch |
19:04 |
|
RichardTheTurd joined #minetest-dev |
19:04 |
paramat |
will do |
19:04 |
nerzhul |
sfan5, sofar #6346 is now published to remove dstack :) when you get time please review (code removal only :p) |
19:04 |
ShadowBot |
https://github.com/minetest/minetest/issues/6346 -- Remove DSTACK support by nerzhul |
19:06 |
|
kaeza joined #minetest-dev |
19:16 |
paramat |
6345 is fine |
19:20 |
|
MoNTE48 joined #minetest-dev |
19:24 |
|
CalebDavis joined #minetest-dev |
19:29 |
|
Fritigern joined #minetest-dev |
19:43 |
nerzhul |
ty paramat, merging in ~ 5 mins |
19:47 |
|
Player_2 joined #minetest-dev |
19:59 |
|
fwhcat joined #minetest-dev |
20:07 |
|
paramat joined #minetest-dev |
20:51 |
|
proller joined #minetest-dev |
21:09 |
|
troller joined #minetest-dev |
21:11 |
|
twoelk left #minetest-dev |
21:39 |
|
H4mlet joined #minetest-dev |
22:28 |
|
bigfoot547 joined #minetest-dev |
22:50 |
|
YuGiOhJCJ joined #minetest-dev |
22:56 |
|
paramat joined #minetest-dev |
23:10 |
|
est31 joined #minetest-dev |
23:46 |
paramat |
#6340 updated, rebased and tested |
23:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/6340 -- Zoom: Move enabling zoom to a new player object property by paramat |