Time |
Nick |
Message |
00:18 |
|
proller joined #minetest-dev |
00:20 |
|
paramat joined #minetest-dev |
00:23 |
paramat |
now merging game#514 game#623 |
00:23 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/514 -- Added option to disable bed's night skip by LeMagnesium |
00:23 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/623 -- XPanes: Remove ugly def. by Rui914 |
00:32 |
paramat |
complete |
00:34 |
|
cg_ joined #minetest-dev |
00:50 |
|
Puma_rc joined #minetest-dev |
00:56 |
|
eugd left #minetest-dev |
01:24 |
waressearcher2 |
paramat: little tweaks ? |
01:25 |
paramat |
i decided to review some old PRs and found 2 that could be merged |
01:40 |
|
paramat left #minetest-dev |
01:59 |
|
lordfingle joined #minetest-dev |
02:17 |
cg_ |
i was chatting with VanessaE and i think this will help some of the issues of entities being outside of the map bounds |
02:17 |
cg_ |
https://github.com/minetest/minetest/pull/3211 |
02:18 |
OldCoder |
cg_, thank you |
02:18 |
cg_ |
i just hope someone thinks its a good idea |
02:19 |
cg_ |
it only handels drops but that to is an issue |
02:19 |
VanessaE |
cg_: fix your scale, you got extra 0's in those figures. |
02:19 |
cg_ |
extra zeros? |
02:19 |
cg_ |
shit |
02:19 |
VanessaE |
-309012, 309027 so 309010 |
02:19 |
VanessaE |
s/3090/309/g |
02:22 |
cg_ |
lol sorry code was good comment wasnt |
02:37 |
|
EUGD joined #minetest-dev |
02:38 |
EUGD |
anyone around who wants to bs about VAEs? |
02:39 |
EUGD |
like; why not just make environment hold multiple maps? |
02:45 |
|
EUGD joined #minetest-dev |
03:26 |
|
Fritigern joined #minetest-dev |
03:59 |
|
EUGD joined #minetest-dev |
04:15 |
|
EUGD joined #minetest-dev |
04:16 |
EUGD |
http://dev.minetest.net/TODO#Envlock_Scope_Reduction |
04:16 |
EUGD |
Add a thin abstraction layer for atomic operation intrinsics. |
04:16 |
EUGD |
what. |
04:28 |
|
Miner_48er joined #minetest-dev |
04:34 |
|
EUGD joined #minetest-dev |
05:13 |
hmmmm |
that's already been done |
05:17 |
EUGD |
what does it mean? |
05:18 |
hmmmm |
exactly what it says |
05:18 |
hmmmm |
there's no trickery |
05:18 |
hmmmm |
shadowninja added them not too long ago, we just need to start using them |
05:38 |
|
EUGD joined #minetest-dev |
05:38 |
EUGD |
literally wtf does that mean 'atomic operation intrinsics', those sure are words |
05:42 |
|
EUGD joined #minetest-dev |
05:53 |
|
EUGD left #minetest-dev |
05:53 |
|
Hunterz joined #minetest-dev |
06:21 |
|
CraigyDavi joined #minetest-dev |
06:44 |
hmmmm |
intrinsic functions for atomic operations |
06:44 |
hmmmm |
an intrinsic function is a function call recognized by the compiler and replaced with one or more instructions directly |
06:45 |
hmmmm |
an atomic operation is an operation that works on memory operands and locks the memory bus for the duration, preventing race conditions from occuring |
06:45 |
hmmmm |
what's there not to get? you could have figured that out from googling |
06:47 |
|
Krock joined #minetest-dev |
07:52 |
|
nrzkt joined #minetest-dev |
08:37 |
|
Ardonel joined #minetest-dev |
08:42 |
|
Amaz joined #minetest-dev |
08:44 |
|
Fritigern joined #minetest-dev |
09:02 |
|
proller joined #minetest-dev |
09:20 |
|
Elinvention joined #minetest-dev |
09:29 |
|
ElectronLibre joined #minetest-dev |
09:46 |
|
julienrat joined #minetest-dev |
09:46 |
|
julienrat left #minetest-dev |
09:47 |
|
Soni joined #minetest-dev |
10:25 |
|
Puma_rc joined #minetest-dev |
10:27 |
|
ElectronLibre joined #minetest-dev |
10:39 |
|
Krock joined #minetest-dev |
11:10 |
|
Player_2 joined #minetest-dev |
11:58 |
|
proller joined #minetest-dev |
12:29 |
|
nrzkt joined #minetest-dev |
12:29 |
|
julienrat joined #minetest-dev |
14:18 |
|
est31 joined #minetest-dev |
14:39 |
est31 |
in theory #3211 isn't needed, this commit should have taken care of it: https://github.com/minetest/minetest/commit/f61f817b9c170942a5b3ce3591125c2191645cd0 |
14:39 |
ShadowBot |
https://github.com/minetest/minetest/issues/3211 -- added much needed pos limits to drops by pinkysnowman |
14:39 |
est31 |
but somehow it doesnt ... |
14:39 |
* est31 |
researches |
14:46 |
est31 |
I see, the problem is the implementation of core.spawn_item |
14:48 |
est31 |
and partly the fact that the boundary isn't "strict" |
15:00 |
|
proller joined #minetest-dev |
15:12 |
est31 |
ohhh, interesting... |
15:13 |
est31 |
it seems that if you put an entity into the CPT_IGNORE filled blocks at the map border, it will bloat the console with the errors like "ERROR[Server]: ServerEnv: Trying to store id=20 statically but block (1934,1,7) already contains 142 objects. Forcing delete." |
15:13 |
est31 |
finally a good way to reproduce!!! |
15:16 |
|
hmmmm joined #minetest-dev |
15:17 |
|
CraigyDavi joined #minetest-dev |
15:25 |
|
technics joined #minetest-dev |
15:28 |
est31 |
what are your thoughts hmmmm about #3211 |
15:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/3211 -- added much needed pos limits to drops by pinkysnowman |
15:28 |
est31 |
I'd think this is enough for the start: https://github.com/est31/minetest/commit/b47d16ac4113ac5fedc8051e3bef2dba29a7dd38 |
15:29 |
est31 |
then the above error has to be fixed as well ofc |
15:31 |
est31 |
small rewordings: https://github.com/est31/minetest/commit/a48694776ce28afa809610ca1a9f0feb5ca9c16d |
15:33 |
|
proller joined #minetest-dev |
15:38 |
nrzkt |
WARNING |
15:38 |
nrzkt |
next commit will be the 5000, it should be a great commit. CHAMPAGNE ! |
15:38 |
nrzkt |
or not. |
15:38 |
est31 |
that above commit isn't too great |
15:38 |
nrzkt |
:'( |
15:39 |
est31 |
propose another one from the PR list if you want :) |
15:39 |
est31 |
it fixes an issue only partially, but at least that part is a mostly proper fix |
15:39 |
nrzkt |
xD |
15:40 |
est31 |
#3211 fixes the problem only partially as well, but additionally not properly. |
15:40 |
ShadowBot |
https://github.com/minetest/minetest/issues/3211 -- added much needed pos limits to drops by pinkysnowman |
15:41 |
Krock |
Just find a typo and use that as our holy 5000th commit |
15:41 |
est31 |
lol |
15:52 |
|
julienrat joined #minetest-dev |
16:09 |
|
Amaz joined #minetest-dev |
16:13 |
|
Hunterz joined #minetest-dev |
16:26 |
|
julienrat joined #minetest-dev |
16:27 |
|
H-H-H joined #minetest-dev |
16:29 |
|
julienrat left #minetest-dev |
16:30 |
kahrl |
found the typo: https://github.com/minetest/minetest/blob/0cde03254a6564eaec21603e9add4f14e6c2fe52/src/server.cpp#L301 |
16:31 |
est31 |
chararacters lol |
16:35 |
|
EUGD joined #minetest-dev |
16:38 |
kahrl |
wow, that typo was introduced in 2011 (commit abd106bac). Then moved around by various people (including me) to about 4 other files in the history of minetest, and no one noticed |
16:39 |
kahrl |
perhaps c55 was thinking about cataracts when he wrote this :P |
16:40 |
est31 |
and in the same commit, he even wrote it right |
16:40 |
est31 |
lol |
16:47 |
est31 |
kahrl, you want to push it? |
16:51 |
|
Soni joined #minetest-dev |
16:52 |
|
paramat joined #minetest-dev |
16:53 |
Krock |
Yes, please push that typo fix :D |
16:53 |
paramat |
i'll merge game#314 later |
16:53 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/314 -- Add protection support to seed placement and hoeing by codeandfix |
17:00 |
est31 |
kahrl, everybody else, can you have a look at https://github.com/est31/minetest/commit/035b5683fa040c4fd0e98b7237c3161d496d0d8b |
17:01 |
|
nrzkt joined #minetest-dev |
17:01 |
est31 |
nrzkt, too can you look at https://github.com/est31/minetest/commit/035b5683fa040c4fd0e98b7237c3161d496d0d8b |
17:01 |
|
julienrat joined #minetest-dev |
17:02 |
|
Calinou joined #minetest-dev |
17:05 |
|
Robert_Zenz joined #minetest-dev |
17:07 |
nrzkt |
est31: seems good but i think maybe another should review this sensible code |
17:22 |
|
MinetestForFun joined #minetest-dev |
17:26 |
paramat |
sfan5 please could you review/approve game#420 ? small commit |
17:26 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/420 -- Adding bones' drop feature by LeMagnesium |
17:26 |
sfan5 |
paramat: +1 |
17:26 |
paramat |
thanks |
17:31 |
|
ElectronLibre joined #minetest-dev |
17:39 |
|
julienrat joined #minetest-dev |
18:00 |
|
Soni joined #minetest-dev |
18:08 |
|
cg_ joined #minetest-dev |
18:08 |
|
cg_ left #minetest-dev |
18:20 |
|
Miner_48er joined #minetest-dev |
18:28 |
|
eugd joined #minetest-dev |
18:47 |
|
paramat left #minetest-dev |
18:54 |
|
julienrat joined #minetest-dev |
18:56 |
|
DFeniks joined #minetest-dev |
19:31 |
|
julienrat joined #minetest-dev |
19:35 |
|
Player_2 joined #minetest-dev |
19:45 |
est31 |
!c 1933*16 |
19:45 |
ShadowBot |
est31: math calc <math expression> |
19:45 |
est31 |
!c 1933 * 16 |
19:45 |
ShadowBot |
est31: math calc <math expression> |
19:45 |
est31 |
!g 1933 * 16 |
19:45 |
ShadowBot |
est31: Error: invalid version |
19:46 |
est31 |
damn ShadowBot |
19:50 |
nrzkt |
!c "16+16" |
19:50 |
ShadowBot |
nrzkt: math calc <math expression> |
19:50 |
nrzkt |
!c 16+16 |
19:50 |
ShadowBot |
nrzkt: math calc <math expression> |
19:51 |
nrzkt |
strange |
19:52 |
Calinou |
!c + 16 16 |
19:52 |
ShadowBot |
Calinou: math calc <math expression> |
19:53 |
Krock |
ShadowBot claims MTB's commands :< |
19:53 |
ShadowBot |
Krock: Error: Missing ">". You may want to quote your arguments with double quotes in order to prevent extra brackets from being evaluated as nested commands. |
19:53 |
Krock |
</Krock> |
19:53 |
|
Amaz joined #minetest-dev |
19:55 |
|
paramat joined #minetest-dev |
19:58 |
paramat |
now merging game 314 and 420 |
19:59 |
est31 |
paramat, can you also have a look at #3212 |
19:59 |
ShadowBot |
https://github.com/minetest/minetest/issues/3212 -- get_biome_id lua function by duane-r |
19:59 |
est31 |
(once you are done) |
19:59 |
paramat |
sure |
20:05 |
paramat |
merge complete |
20:09 |
paramat |
wooo down to 47 PRs |
20:13 |
|
DFeniks joined #minetest-dev |
20:13 |
eugd |
can we do mine? |
20:14 |
eugd |
https://github.com/minetest/minetest/pull/3199 |
20:14 |
|
notgonnaregister joined #minetest-dev |
20:16 |
notgonnaregister |
Hello. Am I interrupting any ongoing discussion? |
20:17 |
notgonnaregister |
Hopefully not. I was wondering if someone could help me out with a small problem when trying to build the "NMPR" version of minetest. |
20:18 |
paramat |
interruption is impossible on irc =) |
20:18 |
|
Fritigern joined #minetest-dev |
20:19 |
notgonnaregister |
Well, having someone talking about something else simultaneously can be just as annoying :) |
20:20 |
notgonnaregister |
Long time since I messed around with Cpp code, but I thought trying to figure out minetest's source code to some extent might be a good excercise |
20:22 |
notgonnaregister |
Though I get an error when trying to build, on main.h "JMutex does not name a type". Apparently just including jmutex.h ain't doing the trick. haven't really changed the code in any way, just the makefile |
20:22 |
notgonnaregister |
Any thoughts? |
20:23 |
hmmmm |
the "NMPR" version...? |
20:23 |
notgonnaregister |
It's what it's called on the wiki, under Core Architecture |
20:23 |
eugd |
he means minimalist version, right? |
20:23 |
eugd |
yeah |
20:24 |
eugd |
i think it's very, very old? and what the wiki says about it still being 'mostly the same' is dead wrong? |
20:24 |
hmmmm |
I don't see the string "NMPR" anywhere on that page.. |
20:24 |
eugd |
that's my impression about most things the wiki says about 'x is outdated but still worth glancing at' |
20:24 |
est31 |
there are tons of things in the codebase that didn't change since 2011/2010 |
20:24 |
notgonnaregister |
I just figured it would be a good way to start since jumping into the actual dev branch might be overwhelming |
20:24 |
hmmmm |
ah ok |
20:24 |
notgonnaregister |
I'm open to better suggestions |
20:25 |
hmmmm |
ahhh |
20:25 |
hmmmm |
Network Multiplayer Release |
20:25 |
hmmmm |
this is 100% unsupported btw |
20:26 |
notgonnaregister |
Yeah, I assumed. |
20:27 |
hmmmm |
JThread is a third party library |
20:27 |
|
Miner_48er joined #minetest-dev |
20:27 |
hmmmm |
no idea if it's included along with that source archive |
20:28 |
notgonnaregister |
It's not, neither is irrlicht. |
20:28 |
notgonnaregister |
Well, anyway |
20:28 |
est31 |
since SN's threading cleanup JThread is part of minetest |
20:28 |
est31 |
not external anymore |
20:28 |
|
younishd joined #minetest-dev |
20:28 |
notgonnaregister |
Would you recommend something better for a somewhat unskilled guy with about 5 years background of programming mostly corporate bullshit applications? |
20:29 |
notgonnaregister |
If something minimalistic exists, that is at least kinda-sorta similar to minetest, that'd be great. |
20:29 |
Krock |
https://github.com/minetest/minetest/blob/master/src/subgame.cpp#L88 |
20:29 |
Krock |
shouldn't this be ";"? |
20:30 |
est31 |
no |
20:30 |
est31 |
its PATH format |
20:30 |
Krock |
but PATHs are seperated by a semicolon |
20:31 |
est31 |
$ echo $PATH |
20:31 |
est31 |
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games |
20:31 |
est31 |
not on linux :) |
20:31 |
hmmmm |
notgonnaregister, why not just download and configure JThread? |
20:31 |
Krock |
C:\Dokumente und Einstellungen\All Users\Anwendungsdaten\Oracle\Java\javapath;C:\WINDOWS\system32;C |
20:31 |
Krock |
I think this needs a pull |
20:32 |
|
proller joined #minetest-dev |
20:33 |
notgonnaregister |
I did, it's pointing to the lib alright, it's not complaining when trying to include the headers (which it did initially). |
20:34 |
notgonnaregister |
But from your reactions I guess this is long forgotten code, so I aint gonna bother you much with this. I'll just try to iron out these little issues and if I can't, oh well. |
20:34 |
hmmmm |
it was very different in the 0.2.x days - modern minetest is practically an operating system |
20:35 |
hmmmm |
you can still get involved, just don't expect to understand everything |
20:35 |
notgonnaregister |
How much can I trust the dev wiki these days? |
20:35 |
hmmmm |
not much |
20:35 |
hmmmm |
read the source, that's the most current, up-to-date documentation |
20:36 |
celeron55 |
notgonnaregister: you need the older version of jthread |
20:36 |
notgonnaregister |
I see |
20:37 |
celeron55 |
1.2 that is |
20:37 |
notgonnaregister |
Thanks mate. |
20:38 |
celeron55 |
NMPR is mostly a historical curiosity but it might be useful for learning; i don't think checking it out is a bad idea |
20:39 |
notgonnaregister |
Well, I guess I'll mess around with the main branch if I can't get this working. I had no illusions of being able to contribute anything valuable, at least not for a pretty long time. The project just caught my eye that's all |
20:39 |
notgonnaregister |
But hey, who knows. |
20:39 |
notgonnaregister |
Thanks for the input guys. |
20:42 |
celeron55 |
minetest 0.3 doesn't build with irrlicht 1.8, on the other hand :P |
20:42 |
waressearcher2 |
or its irrlicht 1.8 doesn't build with minetest 0.3 |
20:43 |
waressearcher2 |
no, wait |
20:46 |
Krock |
waressearcher2, ehm no, Irrlicht does not depend on Minetest :P |
20:46 |
Krock |
#3214 |
20:46 |
ShadowBot |
https://github.com/minetest/minetest/issues/3214 -- Add environment variable MINETEST_WORLD_PATH by SmallJoker |
20:53 |
|
eugd joined #minetest-dev |
20:56 |
waressearcher2 |
is there any assempler lanugage used in minetest ? |
20:56 |
waressearcher2 |
assembler |
20:57 |
waressearcher2 |
I mean for games it is not unusual have code pieces in asm for optimisation purposes |
20:57 |
est31 |
no not that I knew |
20:58 |
VanessaE |
hard to imagine anyone would use assembler these days, except for a compiler of course. |
21:04 |
notgonnaregister |
It boggles my mind that Roller Coaster Tycoon was mostly written in assembly in the late 90s |
21:08 |
est31 |
yeey champagne! minetest commit 5k! |
21:08 |
|
proller joined #minetest-dev |
21:10 |
waressearcher2 |
5000 changes ? since when ? |
21:10 |
Krock |
\o/ PARTY HARD |
21:10 |
waressearcher2 |
Krock: call miley cyrus |
21:10 |
Krock |
waressearcher2: call justin bieber |
21:11 |
Krock |
And I hoped the 5000th commit would be a typo fix only |
21:11 |
est31 |
well, I've asked k ahrl he didnt push |
21:24 |
|
Siva joined #minetest-dev |
21:29 |
paramat |
for #3199 do we really need 'limit' and 'extent'? surely it's best for 'extent' to replace 'limit'? |
21:29 |
ShadowBot |
https://github.com/minetest/minetest/issues/3199 -- split map_generation_limit into x/y/z components by EUGD |
21:31 |
|
notgonnaregister left #minetest-dev |
21:33 |
est31 |
I too think its better to have an unified setting that is read depending on type |
21:34 |
est31 |
but I'd go with limit, because it wouldnt mean a change |
21:35 |
eugd |
re: maintaining limit was explicit demand of c55 |
21:35 |
eugd |
original version was much simpler |
21:36 |
paramat |
ah |
21:36 |
eugd |
just removed _limit and replaced with three new _limit_x, _limit_y, _limit_z |
21:37 |
eugd |
then in the comments there multiple people said to make it V3S16 so i did that |
21:37 |
eugd |
also about making one setting with automatically discerned type, i addressed that in the comments there |
21:38 |
eugd |
summary; don't wanna ;-) |
21:49 |
paramat |
why did c55 want the 2 systems running in parallel? it seems unecessary, slower and complex, hmmmm what do you think? |
21:49 |
eugd |
he wanted to retain backwards compatibility |
21:49 |
eugd |
said so, couldn't just drop setting |
21:50 |
eugd |
for anyone currently using |
21:50 |
est31 |
there is only a minimal speed penalty, because its only calculated once, at startup |
21:50 |
est31 |
thats the "static" modifier |
22:13 |
paramat |
detecting data type would keep compatibility, no problem. 'limit' is very new and very few use it so it's not that critical anyway. hmmmmm is the authority on mapgen |
22:14 |
eugd |
i am souring on the whole thing anyway |
22:14 |
|
H-H-H joined #minetest-dev |
22:14 |
eugd |
i think the direct route to VAEs is having multiple map (or map replacements) in environment |
22:15 |
eugd |
in which case map_size would be essential value as core part of object |
22:16 |
paramat |
even if the speed penalty is tiny, it's an ugly and unnecessary duplication. 'limit' and 'extent' will both be rarely used, and those who use 'limit' will prefer to have the control of 'extent'. sorry it took me a while to realise this |
22:22 |
paramat |
(this is not negative criticism about your PR btw) |
22:25 |
eugd |
none taken |
22:25 |
eugd |
i said the same thing |
22:25 |
eugd |
but *shrug* |
22:25 |
eugd |
"Copyright (C) 2010-2013 celeron55" |
22:38 |
eugd |
i really want to get input on this idea |
22:39 |
est31 |
https://github.com/est31/minetest/commit/90ebe80ec8e16a01747b0ceba8ed00e9d60c58e4 |
22:39 |
est31 |
can anybody review ^ |
22:48 |
eugd |
nope |
22:48 |
eugd |
can't even comprehend |
22:49 |
eugd |
well |
22:51 |
eugd |
it all seems straightforward? except the last bit |
22:51 |
eugd |
but i really just don't understand it |
23:00 |
|
EUGD joined #minetest-dev |
23:15 |
est31 |
I can explain it if you want |
23:29 |
|
EUGD joined #minetest-dev |
23:32 |
|
Kray_ joined #minetest-dev |
23:32 |
|
deltib_ joined #minetest-dev |
23:33 |
|
dzho joined #minetest-dev |
23:33 |
|
dzho joined #minetest-dev |
23:46 |
|
paramat left #minetest-dev |