| Time |
Nick |
Message |
| 00:00 |
cg72 |
Hmmmm is an ass hole and im about to get my strap-on and fuck his ass up bad!!! |
| 00:00 |
kilbith |
cg72: you don't to tell me "Fuck you" in all caps when i just give an opinion on a PR... |
| 00:00 |
kilbith |
you don't need* |
| 00:01 |
cg72 |
i do |
| 00:01 |
hmmmm |
I don't have ban privileges in -dev, can somebody else op me or ban cg72 |
| 00:01 |
shadowzone |
to be honest, all I wanted to do was help not start a fight. |
| 00:01 |
hmmmm |
thanks |
| 00:01 |
kilbith |
and stop insult people. |
| 00:01 |
cg72 |
if i was still 21 id google you irl and beat your as be happy i calmed down |
| 00:01 |
cg72 |
hmmmm has pissed me off from day one |
| 00:01 |
acerspyro |
cg72: STOP ramming on people. You're worse than the way you describe us. |
| 00:02 |
cg72 |
i am evil and dont care about it |
| 00:02 |
kilbith |
ShadowNinja ^ please. |
| 00:02 |
acerspyro |
I'm evil, too, mind you. |
| 00:02 |
acerspyro |
But I can live in society. |
| 00:02 |
cg72 |
hmmmm i love you <3 bye \o |
| 00:02 |
hmmmm |
;op |
| 00:02 |
|
cg72 left #minetest-dev |
| 00:02 |
acerspyro |
Ban |
| 00:03 |
shadowzone |
I got her to settle down |
| 00:03 |
acerspyro |
oh, nice |
| 00:03 |
kahrl |
can you tell her to go to freeminer, they're more open minded about pull requests |
| 00:03 |
acerspyro |
lol |
| 00:03 |
shadowzone |
She's there too |
| 00:04 |
acerspyro |
Poor them :D |
| 00:04 |
shadowzone |
lol |
| 00:04 |
VanessaE |
heh |
| 00:04 |
acerspyro |
is that crazy ginger? |
| 00:04 |
shadowzone |
I shouldn't laugh..but I am. |
| 00:04 |
shadowzone |
Yes it is. |
| 00:04 |
acerspyro |
ok |
| 00:04 |
hmmmm |
is fz72 on github == cg72? |
| 00:04 |
* acerspyro |
makes the link |
| 00:04 |
shadowzone |
nope |
| 00:04 |
shadowzone |
crazyginger72 |
| 00:06 |
acerspyro |
Girl who claims that hell, god and damn are not kid-friendly. |
| 00:06 |
hmmmm |
'cause if that is fz72, I guess he (or she) might be mad over this: https://github.com/minetest/minetest/pull/2016 |
| 00:06 |
acerspyro |
Uh, I'm no believer, but if it wouldn't be kid-friendly, it would not be in the bible... |
| 00:06 |
hmmmm |
did that come off as mean or something? |
| 00:07 |
acerspyro |
? |
| 00:07 |
shadowzone |
hmmmm, her github is crazyginger72 |
| 00:07 |
hmmmm |
gingers don't have souls |
| 00:08 |
VanessaE |
acerspyro: if the bible is kid friendly then I'm the Queen of England. :P |
| 00:08 |
acerspyro |
lol |
| 00:08 |
acerspyro |
Queen of England is also Queen of Canada, btw |
| 00:10 |
|
proller joined #minetest-dev |
| 00:10 |
VanessaE |
hmmmm: not even in the slightest |
| 00:11 |
acerspyro |
I don't believe in souls. |
| 00:11 |
acerspyro |
I calculate people in levels of bitchiness. |
| 00:11 |
acerspyro |
A negative level is good. |
| 00:11 |
crazyR |
in all fairness guys i can see her frustration as can many others. |
| 00:12 |
acerspyro |
? |
| 00:12 |
puhfa |
one word: circlejerk? |
| 00:12 |
crazyR |
" learn to read the damn api" <<--- sounds usefull to me |
| 00:12 |
crazyR |
not |
| 00:12 |
VanessaE |
where's it say that? |
| 00:13 |
acerspyro |
> he evidently gets off on butchering the code of a 12yo girl... |
| 00:13 |
acerspyro |
No age discrimination |
| 00:13 |
acerspyro |
Your code's bad, you get the same thing as others. |
| 00:14 |
VanessaE |
hmmmm: do me a favor - don't look at my code. the list of things wrong with it would end up longer than the code itself :P |
| 00:14 |
crazyR |
lol |
| 00:14 |
VanessaE |
(I *know* my code style sucks at times :) ) |
| 00:14 |
acerspyro |
lol |
| 00:14 |
acerspyro |
My code sucks at all times. |
| 00:14 |
acerspyro |
I'm a drunk coder. |
| 00:14 |
crazyR |
mines is worse than anybodies |
| 00:14 |
acerspyro |
No no no |
| 00:14 |
acerspyro |
Mine doesn't make sense :P |
| 00:14 |
crazyR |
but...most of the time it works. so im happy. |
| 00:15 |
acerspyro |
it works here too :D |
| 00:15 |
ShadowNinja |
hmmmm: You do have op privs. /msg ChanServ OP #minetest-dev |
| 00:15 |
acerspyro |
but it's very messy and has no comments. |
| 00:15 |
ShadowNinja |
[ChanServ] 3 hmmmm +AVot [modified 15w 5d 10h ago] |
| 00:15 |
ShadowNinja |
In fact you're one of only 4 accounts with op privileges. |
| 00:16 |
shadowzone |
may I point out that ChanServ is not here and that we do not have any ops? |
| 00:16 |
hmmmm |
yea I know |
| 00:16 |
hmmmm |
it's because I didn't authenticate |
| 00:16 |
shadowzone |
That also helps. |
| 00:16 |
hmmmm |
because freenode disconnected me and xchat didn't do the password |
| 00:17 |
hmmmm |
thing |
| 00:17 |
|
hmmmm joined #minetest-dev |
| 00:17 |
exio4 |
shadowzone, chanserv doesn't need to be in a channel go give op |
| 00:17 |
hmmmm |
see |
| 00:17 |
shadowzone |
cool |
| 00:27 |
TriBlade9 |
Merp |
| 00:27 |
shadowzone |
All I need to know is if anyone likes my pull request |
| 00:27 |
shadowzone |
meeble |
| 00:27 |
TriBlade9 |
Which number shadowzone? |
| 00:27 |
shadowzone |
#2135 |
| 00:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/2135 -- Added help tab to main menu by TheShadowZone12 |
| 00:28 |
TriBlade9 |
I do like the idea |
| 00:29 |
Wayward_One |
As do I |
| 00:30 |
TriBlade9 |
Good lord, that thing went to crap really fast. |
| 00:30 |
TriBlade9 |
People get so riled up so easily. |
| 00:31 |
TriBlade9 |
sapier: Space missing. |
| 00:31 |
exio4 |
make love not war |
| 00:31 |
TriBlade9 |
exio4 Make cake not war. |
| 00:36 |
acerspyro |
Make sex not war. |
| 00:37 |
TriBlade9 |
Nah, acerspyro, still cake. |
| 00:45 |
acerspyro |
creampie :D |
| 00:46 |
|
peacock486 joined #minetest-dev |
| 00:47 |
TriBlade9 |
cream *space* pie |
| 00:53 |
kilbith |
ShadowNinja: engine creditting should be based more on the quality of the PRs themselves than the rate of pushing. |
| 00:54 |
kilbith |
that'd be more logical |
| 00:57 |
acerspyro |
yeah |
| 00:57 |
hmmmm |
hrmm |
| 00:57 |
acerspyro |
Well, the amount of progress caused by the user |
| 00:57 |
hmmmm |
might i recommend that the text in the help tab not be hardcoded into the executable |
| 00:58 |
hmmmm |
shouldn't it be in some kind of help.txt that gets read? |
| 00:58 |
acerspyro |
lol |
| 00:58 |
acerspyro |
That is DUMB |
| 00:58 |
acerspyro |
also, I want colored chat |
| 00:58 |
acerspyro |
:3 |
| 00:58 |
kilbith |
a contributor that has re-written thousand of lines in the network sector one time in a trimestrial deserves more to be in credit than a random joe that has tweaked some values or add description here and there several times |
| 00:58 |
hmmmm |
i do too but it needs to be rebased |
| 00:59 |
hmmmm |
no idea what's going on with colored chat |
| 00:59 |
shadowzone |
hmmmm, cg72 is coming back to apologize |
| 00:59 |
hmmmm |
please no |
| 00:59 |
acerspyro |
lol |
| 00:59 |
hmmmm |
cg72 should not come back |
| 00:59 |
acerspyro |
hmmmm: so colored chat was supposed to be a thing? |
| 01:00 |
hmmmm |
yes... the pull request has been sitting there forever |
| 01:00 |
hmmmm |
i'm not sure what happened to it |
| 01:00 |
shadowzone |
Not all pull request are popular right away |
| 01:01 |
crazyR |
it happens all to often, great/good pull requests get forgotten. |
| 01:01 |
shadowzone |
to be honest, I didn't expect mine to get popular at all. |
| 01:02 |
shadowzone |
but I knew it was needed, so I made it |
| 01:03 |
hmmmm |
your pull request should not need to "get popular" |
| 01:03 |
hmmmm |
this is simply a problem with the process |
| 01:04 |
hmmmm |
i like the idea somebody had a while back of meeting every saturday at a certain time to go through as many pull requests as possible |
| 01:04 |
crazyR |
^ +1 |
| 01:04 |
shadowzone |
That would help |
| 01:04 |
hmmmm |
at this point too many have piled up and it's rather unwieldy |
| 01:05 |
hmmmm |
try to go through them and before too long you hit some that require interaction with that person and then it goes back to the 'pending' status |
| 01:06 |
crazyR |
it would certainly speed up development without sacrificing quality. but its all dependant on if anyone can be bothered |
| 01:06 |
crazyR |
i think it would also releive a lot of stress that developers go through when feeling like there efforts have been ignored |
| 01:07 |
hmmmm |
well |
| 01:07 |
hmmmm |
94 pull requests open, 1119 closed |
| 01:07 |
hmmmm |
i think that's a pretty good track record imho |
| 01:07 |
hmmmm |
there were times it was below 50 but those days i don't think as many people were around |
| 01:11 |
shadowzone |
Now I would be very happy if it gets merged, if not I'll work harder. |
| 01:17 |
diemartin |
oi nice... freenode is derping |
| 01:18 |
diemartin |
I wonder WhyTF HexChat didn't save my "Hide joins/parts" settings... |
| 01:18 |
shadowzone |
diemartin, yep.. |
| 01:19 |
kaeza |
<acerspyro> I'm a drunk coder. |
| 01:19 |
kaeza |
Ballmer peak? |
| 01:19 |
acerspyro |
no |
| 01:19 |
acerspyro |
Just attention issues |
| 01:20 |
|
cg72 joined #minetest-dev |
| 01:21 |
kaeza |
and just noticed this is -dev, not #minetest |
| 01:21 |
kaeza |
apologies for offtopic :P |
| 01:21 |
shadowzone |
lol |
| 01:23 |
cg72 |
EVERYONE!!!! I am sorry for my rude language in dev chat tonight ( or what ever time it is there where you are) the un professional actions of one person gat me very heated and none of you should have had to see that. and hmmmm i am sorry but you do need to learn to rave some respect for people, especially ones trying to better this project. Try telling them some constructive criticism next time please :) |
| 01:29 |
|
proller joined #minetest-dev |
| 01:31 |
kilbith |
ShadowNinja: can moderate that comment please ? https://github.com/minetest/minetest/pull/2135#issuecomment-70194673 |
| 01:31 |
kilbith |
i can't tolerate to be named "the other crap"... |
| 01:33 |
ShadowNinja |
kilbith: That inn't directed at you. |
| 01:33 |
T4im |
hmmmm: you are kwolekr right? https://github.com/minetest/minetest/blob/5aeeb219e3fc2f37d3996a3df3b660afcc5f7599/builtin/game/chatcommands.lua#L423 |
| 01:33 |
ShadowNinja |
isn't* |
| 01:33 |
acerspyro |
LOL |
| 01:33 |
T4im |
that one is crashing if someone would leave out pos1 |
| 01:33 |
acerspyro |
*cough* sorry :3 |
| 01:34 |
ShadowNinja |
hmmmm: Maybe string.match is best after all, that looks even worse. |
| 01:34 |
T4im |
regex seems a safe way |
| 01:35 |
T4im |
safer* |
| 01:35 |
kaeza |
FWIW, pos_to_string does not require the parens |
| 01:35 |
kaeza |
err, string_to_pos |
| 01:46 |
|
paramat joined #minetest-dev |
| 01:47 |
hmmmm |
T4im, why's that? |
| 01:47 |
hmmmm |
ShadowNinja: Yeah, :( |
| 01:48 |
shadowzone |
wow |
| 01:49 |
shadowzone |
hmmmm, she apologized |
| 01:49 |
shadowzone |
She said she was sorry |
| 01:49 |
hmmmm |
Yeah, I know, but I said don't bother, it's done |
| 01:49 |
shadowzone |
abuse of privs |
| 01:49 |
hmmmm |
I just don't want cg72 to come back here and start up another ruckus. |
| 01:50 |
hmmmm |
if cg72 wants to see what's going on in the channel, she can read the logs |
| 01:50 |
hmmmm |
but not interrupt development chat |
| 01:51 |
paramat |
a list of PRs that can possibly be closed: https://github.com/minetest/minetest/pull/1669 https://github.com/minetest/minetest/pull/1650 https://github.com/minetest/minetest/pull/1616 https://github.com/minetest/minetest/pull/1554 https://github.com/minetest/minetest/pull/1441 https://github.com/minetest/minetest/pull/1306 |
| 01:51 |
hmmmm |
unless cg72 has issues pertinent to development to discuss... i'd rather not let cg72 back in. she's proven (this far) that her presence in #minetest-dev does not help matters |
| 01:51 |
|
kaeza joined #minetest-dev |
| 01:52 |
|
DFeniks joined #minetest-dev |
| 01:53 |
acerspyro |
Would if be useful if I started doing GUI design mock-ups? |
| 01:54 |
hmmmm |
probably not |
| 01:54 |
acerspyro |
why not |
| 01:54 |
hmmmm |
if you're going to do the GUI... why not just start coding the GUI |
| 01:54 |
acerspyro |
Meh, sure, but imma do mockups first |
| 01:54 |
hmmmm |
there are formspecs |
| 01:55 |
acerspyro |
I know |
| 01:55 |
hmmmm |
overall, there's more talking about what needs to be done than there is getting stuff done |
| 01:55 |
acerspyro |
Everything will be relative to the height |
| 01:55 |
acerspyro |
Since the height is always smaller |
| 01:56 |
hmmmm |
mock-ups i'd say qualify as that. especially when the mockups will probably take just as much effort (if not more) than it would to actually code the formspecs for real |
| 01:56 |
acerspyro |
hmmmm: I'll check how the menu's done, and see what I can do |
| 01:56 |
hmmmm |
paramat: #1306 I don't know if we can close because it hasn't exactly been implemented, although it definitely needs a rebase |
| 01:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/1306 -- Fix line run on, making lua-api.txt more readable. by hoodedice |
| 01:57 |
acerspyro |
How do I sent the resulting patches, btw? |
| 01:57 |
acerspyro |
send* |
| 01:57 |
acerspyro |
fuck my typing |
| 01:57 |
hmmmm |
you can do a diff on the files in diff -ruN format |
| 01:57 |
hmmmm |
you can submit a pull request |
| 01:57 |
acerspyro |
I will also have images |
| 01:58 |
acerspyro |
oh, pull requests, forgot about those |
| 01:58 |
hmmmm |
you can make a gist |
| 01:58 |
hmmmm |
you can also just paste a link to the commit in your own repository you want to merge into upstream |
| 01:58 |
acerspyro |
When I get there, I'll need someone to explain to me how to make one :P |
| 01:59 |
TriBlade9 |
hmmmm, acerspyro I'm working on colored chat still. I'm attempting to rebase and making little progress. I haven't forgotten it :P |
| 01:59 |
T4im |
hmmmm: why regex matching seems safer to me? less error prone.. harder to break out I'd assume.. I would not want to test throwing random brackets at your split function in the parameters.. a regex would simply refuse :D |
| 01:59 |
|
Wayward_One joined #minetest-dev |
| 01:59 |
acerspyro |
TriBlade9: That would require a protocol change, no? |
| 02:00 |
acerspyro |
Which would finally throw off the unsupported iOS clients. |
| 02:00 |
acerspyro |
Fucking junks. |
| 02:01 |
TriBlade9 |
Nope acerspyro |
| 02:01 |
hmmmm |
T4im: I mean why did you say it would crash if pos1 wasn't specified |
| 02:01 |
acerspyro |
shit |
| 02:01 |
hmmmm |
if you're talking about string_to_pos's previous behavior of not accepting nil, I fixed that |
| 02:01 |
TriBlade9 |
It uses the same chat format, though it would make it harder to read if you weren't stripping out the format codes. |
| 02:01 |
T4im |
you'd try concatening a nil string |
| 02:01 |
|
Wayward_One joined #minetest-dev |
| 02:01 |
hmmmm |
aaaah |
| 02:01 |
acerspyro |
I want these clients eradicated!!! |
| 02:02 |
hmmmm |
ahhhhhh |
| 02:02 |
hmmmm |
shit |
| 02:02 |
TriBlade9 |
acers, I'm working on a webclient x] |
| 02:02 |
acerspyro |
No colored signs, bad controls, glitchy, buggy, and now won't support colored chat |
| 02:02 |
acerspyro |
Oh... Wow. |
| 02:02 |
hmmmm |
I forgot to fix that after I fixed the string_to_pos nil thing |
| 02:02 |
acerspyro |
That will be nice. |
| 02:02 |
hmmmm |
thank you t4im |
| 02:02 |
acerspyro |
TriBlade9: thanks |
| 02:02 |
TriBlade9 |
Not a 3D client, just a chat client |
| 02:02 |
hmmmm |
:( |
| 02:02 |
TriBlade9 |
Primarily for server administration use |
| 02:02 |
T4im |
no problem :) |
| 02:02 |
acerspyro |
I take that back |
| 02:02 |
acerspyro |
:P |
| 02:02 |
hmmmm |
TriBlade9: What's the problem with rebasing it exactly? |
| 02:02 |
acerspyro |
WebGL version of MineTest? |
| 02:02 |
hmmmm |
need any help maybe? |
| 02:02 |
TriBlade9 |
For any sort of webclient, it requires the server to be running additional software. |
| 02:03 |
TriBlade9 |
hmmmm I goofed up the rebase initally, and now it's just being annoying |
| 02:03 |
hmmmm |
oh |
| 02:03 |
TriBlade9 |
Additionally, sometimes I can get it to compile, but it crashes immediately with a segfault. |
| 02:03 |
TriBlade9 |
acers, I have written a WebGL voxel rendering library :3 |
| 02:03 |
hmmmm |
oh shit |
| 02:03 |
TriBlade9 |
But no texture or AO support. It uses Greedy Meshing though. |
| 02:03 |
hmmmm |
you're THAT guy? |
| 02:04 |
TriBlade9 |
Uhh no, probably not. |
| 02:04 |
hmmmm |
I saw the voxeljs engine |
| 02:04 |
hmmmm |
i think it's called that |
| 02:04 |
TriBlade9 |
I used code from a guy though |
| 02:04 |
hmmmm |
http://voxeljs.com/ this? |
| 02:04 |
TriBlade9 |
Nono, VoxelJS is based on THREE.js, Mine is Based on BABYLON.js |
| 02:04 |
hmmmm |
ahh |
| 02:04 |
TriBlade9 |
http://triblade9.github.io/CEWBS/example/examples/animation/index.html |
| 02:05 |
TriBlade9 |
http://triblade9.wc.lt/CEWBS/ <- Non grid-locked destruction/creation |
| 02:06 |
TriBlade9 |
Anyways, offtopic |
| 02:13 |
hmmmm |
what's the story on #1650? |
| 02:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/1650 -- Smoother player movement (Faster jumping, slight height boost) by TriBlade9 |
| 02:13 |
TriBlade9 |
O-o |
| 02:13 |
TriBlade9 |
Who dug up that PR? |
| 02:13 |
TriBlade9 |
I think that one was just dropped/closed because it didn't fit well with the way things are handled ATM. |
| 02:14 |
hmmmm |
okay then |
| 02:14 |
TriBlade9 |
I still think it feels way better, it just isn't easily configurable |
| 02:15 |
TriBlade9 |
hmmmm Darn, you ninja'd me. |
| 02:16 |
hmmmm |
i dunno |
| 02:16 |
hmmmm |
I'll have to test it out |
| 02:16 |
hmmmm |
if it's a big improvement then I'd say the effort to get it fitting correctly would be worth it |
| 02:16 |
TriBlade9 |
Nah, if it's a big deal, I'll find a better way to write it. |
| 02:17 |
TriBlade9 |
The sinking-into-a block is something I haven't noticed since 0.4.11 anyways, which was the main motivation behind the PR. |
| 02:21 |
|
Wayward_One joined #minetest-dev |
| 02:29 |
|
Wayward_One_ joined #minetest-dev |
| 02:31 |
TriBlade9 |
"I believe in options" - hmmmm/kwolekr 2015. |
| 02:31 |
hmmmm |
if you don't make options your users are going to get pissed off |
| 02:32 |
TriBlade9 |
Ik, I just think that quote goes in a signature somewhere |
| 02:32 |
hmmmm |
see: firefucks, gnome, everything from Red Hat in fact, KDE, ... |
| 02:34 |
TriBlade9 |
Yea |
| 02:38 |
acerspyro |
? |
| 02:38 |
acerspyro |
options? |
| 02:40 |
paramat |
cool, i only listed 1306 because lua-api.txt was recently cleaned up and lines shortened, however looking through the commit the cleanup of the inventory table and set_local_animation looks nice, i might even rebase this myself |
| 02:42 |
paramat |
yes sinking onto a node is an issue, step off a snow nodebox and it happens too |
| 02:45 |
|
Zeno` joined #minetest-dev |
| 02:58 |
hmmmm |
=/ |
| 03:00 |
hmmmm |
does anybody here run clearobjects every once in a while? |
| 03:00 |
shadowzone |
Yep |
| 03:01 |
Zeno` |
I haven't in ages because it takes hours on my database :( |
| 03:01 |
hmmmm |
oh nevermind |
| 03:01 |
hmmmm |
it only errors if it can't emerge a block listed as loadable |
| 03:01 |
hmmmm |
my question is dumb |
| 03:01 |
hmmmm |
so yeah it's legitimate to complain about that |
| 03:01 |
* Zeno` |
is confused |
| 03:02 |
hmmmm |
I was looking at clearAllObjects, where it errors if emergeBlock() == NULL |
| 03:03 |
hmmmm |
.. does anybody want objects to have a TTL? |
| 03:04 |
paramat |
hmmmmm 3D noise caves can be a little faster .. recently while experimenting with v5 tunnels i discovered non-eased noise actually improves the structure somehow, clearer, less mess and dither surfaces. also, sharp spiky jagged structure seems more suitable for tunnels, cracks and fissures. so, v7 tunnels are non-eased |
| 03:04 |
hmmmm |
how much does that improve the generation time though |
| 03:05 |
hmmmm |
i think i can get 3d noise a bit faster by refining that algorithm a bit more |
| 03:08 |
paramat |
i should profile it |
| 03:09 |
paramat |
non-eased is still preferable for caves and tunnels even if no faster |
| 03:10 |
hmmmm |
heh |
| 03:10 |
hmmmm |
I am actually using v5 caves in mapgen v6 |
| 03:11 |
paramat |
so i would like to unease v5 caves, for those reasons and because we recently learned the original was not eased |
| 03:11 |
|
Wayward_One_ joined #minetest-dev |
| 03:11 |
hmmmm |
well if you're going for accuracy, v5 is totally off |
| 03:12 |
paramat |
eased 3D noise for v5 terrain is good though |
| 03:13 |
Zeno` |
kahrl, regarding my comment... are you sure the code has a different result? |
| 03:14 |
Zeno` |
Because that's not what the current code does :/ Unless I'm going crazy again |
| 03:14 |
paramat |
i would like to unease the 'crumble' noise too (lava blob shapes) as with the original |
| 03:14 |
Zeno` |
oh |
| 03:14 |
Zeno` |
nvm |
| 03:15 |
TriBlade9 |
Are there any commits expected to be pulled into master soon? |
| 03:15 |
TriBlade9 |
Just wanna know if now is a good time for a hard rebase |
| 03:15 |
TriBlade9 |
*merged into master |
| 03:16 |
Zeno` |
actually, scratch the nvm |
| 03:16 |
hmmmm |
nope |
| 03:17 |
Zeno` |
kahrl? |
| 03:19 |
hmmmm |
VanessaE, are you around? |
| 03:19 |
hmmmm |
I need someone with a huge world |
| 03:19 |
Zeno` |
\\a will return \a in both versions AFAICT |
| 03:19 |
Zeno` |
My world is 14GB |
| 03:19 |
hmmmm |
yeah but how much of that is rollback.. |
| 03:20 |
Zeno` |
not including rollback |
| 03:20 |
hmmmm |
oh cool |
| 03:20 |
Zeno` |
just the leveldb directory |
| 03:20 |
paramat |
hmmmmm while i remember, how about i work on a modernised 'mgv6b' which is v6 base terrain plus all the new stuff. i doubt mgv6 can support old worlds *and* have all the new stuff |
| 03:20 |
hmmmm |
would you be willing to profile listAllLoadableBlocks? |
| 03:20 |
hmmmm |
paramat, ? |
| 03:20 |
hmmmm |
the 'new stuff'? |
| 03:20 |
paramat |
lol 'need someone with a huge world' |
| 03:21 |
Zeno` |
profile it how? |
| 03:21 |
hmmmm |
just see how many ms |
| 03:21 |
Zeno` |
oh ok |
| 03:21 |
hmmmm |
I'm trying to get an idea of how heavy it really is |
| 03:21 |
hmmmm |
looking for something approximate to a worst case scenario |
| 03:21 |
hmmmm |
also I'd like to hear from vanessae, still, since I think her world is sqlite3 |
| 03:22 |
Zeno` |
I'll have to reboot first (I'm in windows... please don't ask) |
| 03:22 |
hmmmm |
:/ |
| 03:22 |
hmmmm |
the only computer in my entire house that has windows installed on it not in a VM is my work laptop |
| 03:22 |
Zeno` |
pretty sure VE converted all her worlds to leveldb |
| 03:23 |
hmmmm |
and that's out of like 18 of them |
| 03:25 |
paramat |
um, new stuff: biome api, 3d noise caves, simpler code structure like v7 |
| 03:26 |
TriBlade9 |
I'm trying to do chat, but there's still about a million merge conflicts :/ |
| 03:26 |
hmmmm |
if caves were integrated a smarter way we could just swap in and out different version cavegens |
| 03:27 |
hmmmm |
"oh I'll have the v6 base terrain generator with v5 caves and ore veins, and a medium fry and a large coke" |
| 03:28 |
TriBlade9 |
NO SUGAR |
| 03:29 |
TriBlade9 |
And make sure there's no lactose in any of it. |
| 03:29 |
hmmmm |
https://www.youtube.com/watch?v=S0KlXjWa05Q |
| 03:31 |
VanessaE |
my worlds are all leveldb on the servers, and locally I still use sqlite since it just defaults to that |
| 03:31 |
paramat |
could each mapgen still have it's own specific set of cave noise parameters? that is essential |
| 03:31 |
hmmmm |
should |
| 03:31 |
hmmmm |
yeah I guess so |
| 03:32 |
hmmmm |
I want to compartmentalize terrain, caves, dungeons |
| 03:32 |
hmmmm |
we'd have to make defaults for each permutation of those, but yea it's doable |
| 03:32 |
paramat |
good |
| 03:33 |
hmmmm |
v6_dungeon_params = { np_wetness = { offset = 0, scale = ... |
| 03:33 |
hmmmm |
woooh |
| 03:33 |
TriBlade9 |
I'm getting to the point that I think rewriting the chat colors commit wouldn't be that bad |
| 03:33 |
TriBlade9 |
Merging is going terribly |
| 03:33 |
hmmmm |
i want to show people that settings groups are for any structured data, not just noiseparams |
| 03:33 |
hmmmm |
TriBlade9: I wouldn't doubt it, how much code is there really for colored chat? |
| 03:33 |
VanessaE |
biggest world is 7.3 GB in its map.db |
| 03:33 |
TriBlade9 |
Not that much, most of it is in new files. |
| 03:33 |
TriBlade9 |
Somehow it's really messed up though |
| 03:34 |
hmmmm |
:( |
| 03:34 |
paramat |
yeah settable dungeon parameters would be excellent |
| 03:34 |
TriBlade9 |
somewhere in the teens of files chnages |
| 03:36 |
TriBlade9 |
Can I make a new branch/PR? |
| 03:37 |
paramat |
for example v5 caves (which have a tiny spread) are totally unsuitable for the scale of v7 |
| 03:58 |
|
paramat left #minetest-dev |
| 04:09 |
|
Zeno` joined #minetest-dev |
| 04:19 |
|
diemartin joined #minetest-dev |
| 04:20 |
Zeno` |
https://gist.github.com/Zeno-/86d2cd841c0af2d03651 |
| 04:20 |
Zeno` |
would like to merge ^^^ |
| 04:21 |
Zeno` |
(fixes #2134) |
| 04:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/2134 -- index out of bounds at src/mapblock_mesh.cpp in finalColorBlend() |
| 04:33 |
Zeno` |
gist updated |
| 04:36 |
|
kaeza joined #minetest-dev |
| 04:37 |
Zeno` |
merged |
| 04:53 |
TriBlade9 |
Cross fingers please :L |
| 04:53 |
* VanessaE |
watches TriBlade9's computer melt down |
| 04:53 |
TriBlade9 |
>:U |
| 04:54 |
TriBlade9 |
Okay, who planted the hydrochloric acid in my cup? |
| 04:55 |
TriBlade9 |
Woot, no immedaite segfualt |
| 04:55 |
TriBlade9 |
Nvm. Immedaite segfault :/ |
| 04:56 |
VanessaE |
hey, at least it compiled. |
| 04:56 |
Zeno` |
Yes, compiling is enough |
| 04:56 |
Zeno` |
segfaults are a feature |
| 04:57 |
TriBlade9 |
Zeno`, It segfaults immediately on loading a world |
| 04:58 |
Zeno` |
Sounds exciting to me. Hence "feature" |
| 04:58 |
TriBlade9 |
Hehe, wanna help me then? x] |
| 04:58 |
TriBlade9 |
I know nothing about debugging C++ |
| 04:58 |
Zeno` |
It adds a whole new level to the game; stage 1 is the user had to fix the segfault |
| 04:59 |
Zeno` |
kind of like an adventure game |
| 04:59 |
Zeno` |
is there a PR? |
| 04:59 |
TriBlade9 |
Lol |
| 04:59 |
TriBlade9 |
Not yet, I'll push in a bit |
| 05:00 |
TriBlade9 |
I think I know where the general issue is, just no idea how to fix it |
| 05:04 |
kaeza |
lol "Could not open file of texture: c:develhomeDiegosrcminetestbuildminetestbin..gamesLord-of-the-Test-1411.00menuicon.png" |
| 05:05 |
Zeno` |
another new feature! |
| 05:05 |
kaeza |
I guess string escaping does not take into account that '\\' is the (native) directory separator on Windows :D |
| 05:07 |
kaeza |
actually, I think mainmenu should s:gsub("\\", "/") prior to putting into formspec |
| 05:07 |
kaeza |
or I'm looking in the wrong place |
| 05:08 |
Zeno` |
actually this is all very strange |
| 05:12 |
Zeno` |
are you using the latest head? |
| 05:12 |
Zeno` |
kaeza? |
| 05:14 |
kaeza |
nope, lemme recompile |
| 05:17 |
TriBlade9 |
Frick. This is gonna be a bigger rewrite than I though -_- |
| 05:17 |
TriBlade9 |
IGUIStaticText is more embedded now, need to tear it out and replace it half the time with just StaticText |
| 05:18 |
Zeno` |
http://codepad.org/bP6VCAkE |
| 05:18 |
|
chchjesus joined #minetest-dev |
| 05:18 |
Zeno` |
maybe they're not being escaped properly in the first place |
| 05:22 |
kaeza |
Zeno`, seems so. a simple `print` after a call to `formspec_escape` outputs "c:\\devel\\home\\Diego\\src\\minetest\\build\\minetest\\bin\\..\\games\\Lord-of-the-Test-1411.00\\menu\\icon.png" |
| 05:22 |
kaeza |
the unescape function then proceeds to nuke those backslashes |
| 05:23 |
Zeno` |
yes it will. Because in memory (before unescape) that string will look like "c:\devel\home\... |
| 05:23 |
Zeno` |
i.e. single backslashes |
| 05:23 |
kaeza |
yep |
| 05:23 |
kaeza |
formspec_escape should s/\\/\\\\/ |
| 05:23 |
Zeno` |
yep |
| 05:24 |
kaeza |
...or not |
| 05:24 |
Zeno` |
It must have been changed recently... |
| 05:25 |
kaeza |
that string is supposed to be used as-is in the formspec, so it gets a literal "foo\\bar" |
| 05:26 |
Zeno` |
this was first reported 6 days ago.. #2099 |
| 05:26 |
ShadowBot |
https://github.com/minetest/minetest/issues/2099 -- server flag icons dont show |
| 05:27 |
Zeno` |
Do you know where they are escaped? |
| 05:28 |
|
prozacgod joined #minetest-dev |
| 05:28 |
kaeza |
builtin/mainmenu/tab_singleplayer.lua:60 |
| 05:28 |
kaeza |
(that is for the game icons) |
| 05:29 |
kaeza |
replacing with `image = core.formspec_escape(gamemgr.games[i].menuicon_path:gsub("\\", "/"))` fixes the issue there, but I think the string is getting unscaped twice along the path |
| 05:30 |
kaeza |
or the unescape is broken (I'm still compiling; using last build) |
| 05:35 |
kaeza |
oh, and if anyone cares: src/script/lua_api/l_mainmenu.cpp:887:41: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] |
| 05:47 |
kaeza |
ooookay, nevermind... it's fixed on HEAD |
| 05:48 |
kaeza |
nothing to see here, move along |
| 05:49 |
kaeza |
and FWIW, that lockup when showing public server list still exists |
| 06:03 |
TriBlade9 |
^^ |
| 06:22 |
ShadowNinja |
kaeza: Yeah... I wasn't thinking and made unescape_string nuke ALL backslashes. Fixed today. |
| 06:23 |
kaeza |
ShadowNinja, ah I see |
| 06:23 |
kaeza |
well, glad it's fixed anyway :P |
| 06:26 |
|
Kalabasa joined #minetest-dev |
| 06:34 |
Zeno` |
ShadowNinja, why not put it back to how it was instead of having that extra conditional? |
| 06:35 |
Zeno` |
The compiler cannot even optimise that away :/ |
| 06:38 |
ShadowNinja |
Zeno`: Because std::strings are binary and will store a literal NUL if the string ends with a backslash otherwise. |
| 06:38 |
|
Hunterz joined #minetest-dev |
| 06:38 |
Zeno` |
yeah, that's ok |
| 06:40 |
Zeno` |
Or are you saying that storing \0 is bad? |
| 06:42 |
ShadowNinja |
Zeno`: Well, it's unexpected at least. |
| 06:42 |
Zeno` |
But it's a pretty common practice. |
| 06:42 |
ShadowNinja |
But this is like a 10ns optimization, it doesn't really matter. |
| 06:43 |
Zeno` |
Well, it's just kind of "kludgy" to read that's all. But, *shrug* |
| 06:44 |
TriBlade9 |
Hey Zeno`, Can I push now and have you take a look at it? |
| 06:44 |
ShadowNinja |
Zeno`: I mean .c_str() will return "abc\0\0". Inserted NUL plus string terminator NUL. |
| 06:44 |
ShadowNinja |
So NUL will be printed to the screen, which may or may not be silently ignored. |
| 06:45 |
Zeno` |
it won't, but anyway |
| 06:46 |
Zeno` |
TriBlade9, ? |
| 06:46 |
TriBlade9 |
I need some way to get around non-freetype builds using IGUIStaticText, and FreeType builds using StaticText (custom class) |
| 06:46 |
TriBlade9 |
Before the game.cpp refactor, it worked fine. Now, nope. |
| 06:47 |
Zeno` |
ShadowNinja, the C++ standard says differently. But if you want to be extra cautious then at least put the second conditional inside the first :P |
| 06:47 |
TriBlade9 |
The issue is that guitext_chat is now initialized long before determining which to use |
| 06:48 |
Zeno` |
ShadowNinja, i.e. http://codepad.org/dKGVa5Pa |
| 06:48 |
Zeno` |
err with proper indentation of course |
| 06:48 |
TriBlade9 |
Oops. Just fixed it on accident. Dafaq |
| 06:48 |
ShadowNinja |
Zeno`: s += '\0'; Doesn't add a NUL? I thought std::string was NUL-safe. But that optimization sounds good. |
| 06:49 |
ShadowNinja |
Zeno`: \0 is unprintable. check s.pop_back() or similar. |
| 06:49 |
TriBlade9 |
Hours of wracking my brain and I fix it accidentally -_- |
| 06:50 |
ShadowNinja |
(unescape("\\")[0] == '\0' && size == 1) |
| 06:50 |
Zeno` |
yep... unexpected |
| 06:51 |
Zeno` |
Yeah, ok. So leave it :) |
| 06:52 |
Zeno` |
err, with the second conditional inside the first... I find that much easier to read even if the optimisation is not worth it |
| 06:52 |
ShadowNinja |
Zeno`: Yeah, go ahead and add that. |
| 06:52 |
Zeno` |
Ok, will do so later |
| 06:53 |
TriBlade9 |
Testing Non-freetype, then will make a PR. |
| 06:54 |
TriBlade9 |
Non-Freetype is also good. :D |
| 06:55 |
Zeno` |
TriBlade9, are your changes available anywhere? |
| 06:55 |
TriBlade9 |
Making a PR now |
| 06:56 |
TriBlade9 |
https://github.com/TriBlade9/minetest/tree/chat_colors |
| 06:56 |
Zeno` |
if you don't want the PR just give me the link to the branch in your repo ;) |
| 06:56 |
Zeno` |
ok cool |
| 06:56 |
Zeno` |
I' |
| 06:56 |
TriBlade9 |
I is ninja |
| 06:56 |
Zeno` |
I'll compile it. Can't promise anything after that haha |
| 06:57 |
TriBlade9 |
Hehe |
| 06:58 |
Zeno` |
Does git am fail if there are whitespace errors? |
| 06:58 |
Zeno` |
grrr... I will apply instead |
| 06:59 |
Zeno` |
TriBlade9, fix the whitespace error before PR :) |
| 06:59 |
TriBlade9 |
Whitespace error? |
| 06:59 |
ShadowNinja |
Zeno`: No, but it complains. |
| 06:59 |
Zeno` |
/home/crobbins/minetest/.git/rebase-apply/patch:1352: trailing whitespace. |
| 06:59 |
TriBlade9 |
O-o |
| 06:59 |
Zeno` |
ShadowNinja, it seems to stop completely for me |
| 07:00 |
Zeno` |
git apply complains but continues |
| 07:00 |
TriBlade9 |
That's weird, all of my editors auto-strip trailing whitespace. |
| 07:00 |
ShadowNinja |
Zeno`: Hmmm, check man git-am for a flag or ootion then. |
| 07:00 |
ShadowNinja |
option* |
| 07:00 |
Zeno` |
I will. Thanks |
| 07:00 |
TriBlade9 |
Uhh, how does one fix that? :bad poker face: |
| 07:01 |
ShadowNinja |
TriBlade9: Check what's on that line in the patch, then edit that line in the code. |
| 07:02 |
TriBlade9 |
I don't even know how to get the patch o3o |
| 07:02 |
Zeno` |
https://github.com/TriBlade9/minetest/commit/b60f0341e2c1d62088e1861bbc79be2e4ddcfef8.patch |
| 07:03 |
TriBlade9 |
Huh, lemme check |
| 07:03 |
Zeno` |
unfortunately it doesn't have line numbers so you need to download it :( |
| 07:04 |
TriBlade9 |
Just did. |
| 07:04 |
TriBlade9 |
The line referred to has no trailing whitespace O-o |
| 07:05 |
Zeno` |
It's straight after &AbsoluteClippingRect); |
| 07:05 |
Zeno` |
there is a line with two tabs and nothing else on it |
| 07:05 |
Zeno` |
so it's really line 1358 of the patch |
| 07:06 |
Zeno` |
and there are 5 tabs, not 2 :) |
| 07:06 |
TriBlade9 |
Just checked it, but I didn't add that O_o |
| 07:06 |
TriBlade9 |
Owait, I see |
| 07:06 |
TriBlade9 |
Okay, recommitting |
| 07:06 |
Zeno` |
well, it compiles with no warnings, so that's a start |
| 07:07 |
TriBlade9 |
Yep, compiles and runs fine with both freetype enabled and disabled |
| 07:07 |
TriBlade9 |
Alright, if you re-download that commit it should be good |
| 07:07 |
Zeno` |
now I need people to talk! |
| 07:07 |
TriBlade9 |
./help ban |
| 07:08 |
TriBlade9 |
./help *command* |
| 07:08 |
TriBlade9 |
Shows the command name in color |
| 07:08 |
Zeno` |
hmm |
| 07:08 |
Zeno` |
do I need to add anything to minetest.conf? |
| 07:08 |
TriBlade9 |
No? You shouldn't need to |
| 07:08 |
TriBlade9 |
Did you build with or without freetype? |
| 07:09 |
Zeno` |
with |
| 07:09 |
Zeno` |
recompiling from scratch |
| 07:10 |
TriBlade9 |
If it didn't modify the builtin lua files, then you won't get anything different |
| 07:10 |
ShadowNinja |
TriBlade9: Did you add a reset token? |
| 07:10 |
TriBlade9 |
No, didn't get around to that yet. |
| 07:10 |
TriBlade9 |
I've spent most of my spare time just getting it to merge x] |
| 07:10 |
Zeno` |
ok I see colour |
| 07:10 |
ShadowNinja |
I think that's important because if we change the chat color to black everything will break. |
| 07:11 |
TriBlade9 |
I'm aware of that, just not sure how to do it yet. |
| 07:12 |
TriBlade9 |
I'll actually have to look at the code to implement that, instead of just bashing everything together and hoping it works. :P |
| 07:13 |
|
blaze joined #minetest-dev |
| 07:13 |
hintss |
xD |
| 07:13 |
TriBlade9 |
Hiya blaze |
| 07:13 |
blaze |
hi TriBlade9 |
| 07:13 |
ShadowNinja |
It would be great if this was really extensible and could theoretically do the crazy stuff you can do with MC's text insert thingy ststem. |
| 07:13 |
TriBlade9 |
Oh god, what have I done. I wrote MineTest instead of Minetest |
| 07:13 |
|
ImQ009 joined #minetest-dev |
| 07:13 |
TriBlade9 |
Please don't kill me. |
| 07:14 |
TriBlade9 |
ShadowNinja, it can already use the full range of hex colors :3 |
| 07:15 |
ShadowNinja |
TriBlade9: Yeah, but in MC you can set tooltips and even on-click events. |
| 07:15 |
TriBlade9 |
Hmm, for a reset token, I'm not sure exactly what it could do... |
| 07:15 |
Zeno` |
that'd be nice |
| 07:15 |
TriBlade9 |
I'll need to experiment a bit before I add a reset token. For now I just need to take a break and unplug my toilet. |
| 07:16 |
Zeno` |
ok, valgrind is clean as well. So that's the cursory check done |
| 07:16 |
TriBlade9 |
We also ought to decide on a more extensible delimiter than \vHEXXXX |
| 07:16 |
ShadowNinja |
So you can send Are you sure? {onclick="//y"}yes {onclick="//n"}no and the user can click instead of typing a command. |
| 07:16 |
|
Player_2 joined #minetest-dev |
| 07:16 |
Zeno` |
unplug it? It uses electricity? |
| 07:16 |
TriBlade9 |
ShadowNinja, that can come later :P |
| 07:16 |
TriBlade9 |
Zeno`, I pooped too big. Let's not talk about it. |
| 07:16 |
Zeno` |
good idea |
| 07:16 |
TriBlade9 |
Suffice it to say that I broke my plunger and my back already. |
| 07:17 |
TriBlade9 |
Hmm |
| 07:17 |
ShadowNinja |
MC actually uses JSON for that, which is a bit much IMO, but it is very extensible. |
| 07:17 |
TriBlade9 |
Perhaps {color:'xxxxxx'}? |
| 07:17 |
TriBlade9 |
Which would cause all {} to be eliminated from chat |
| 07:18 |
TriBlade9 |
Thus, if a new formatting code was added by a future client, it would render invisible on older clients, so long as they had support for {} tags. |
| 07:18 |
ShadowNinja |
TriBlade9: No, {} is too common (see, eg, /status) there has to be an uncommon prefix (like \0 or \v). |
| 07:19 |
TriBlade9 |
§ |
| 07:19 |
TriBlade9 |
? |
| 07:19 |
TriBlade9 |
J/k, is unicode even supported? |
| 07:19 |
ShadowNinja |
TriBlade9: No, and that's too hard to type. |
| 07:20 |
TriBlade9 |
Oh FYI, typing \vXXXXXX is escaped by default |
| 07:20 |
TriBlade9 |
So client's can't type colors without a mod providing a way |
| 07:20 |
TriBlade9 |
At least I think so... |
| 07:20 |
TriBlade9 |
lol, gotta go. Literally. |
| 07:24 |
|
selat joined #minetest-dev |
| 07:28 |
Zeno` |
reset token? |
| 07:28 |
|
CraigyDavi joined #minetest-dev |
| 07:29 |
Zeno` |
I take it that resets the colour to default when it is encountered? |
| 07:30 |
TriBlade9 |
Yes, if implemented, it ought to |
| 07:30 |
TriBlade9 |
Right now it defaults to white as a reset token. |
| 07:31 |
TriBlade9 |
Waaait. |
| 07:31 |
TriBlade9 |
How would the default color be determined? |
| 07:37 |
Zeno` |
Dunno :) |
| 07:37 |
Zeno` |
Well, at least it works |
| 07:37 |
Zeno` |
bbl |
| 07:43 |
TriBlade9 |
Hmm, I think for colored chat to work properly, client-side chat prediction might have to go bye bye |
| 07:49 |
TriBlade9 |
At least for colors in player messages |
| 08:00 |
|
nrzkt joined #minetest-dev |
| 08:05 |
|
blaze joined #minetest-dev |
| 08:39 |
|
Megal joined #minetest-dev |
| 08:43 |
nrzkt |
please commit #2137 |
| 08:43 |
ShadowBot |
https://github.com/minetest/minetest/issues/2137 -- Database_Dummy::deleteBlock : fix missing return by nerzhul |
| 08:45 |
|
cib0 joined #minetest-dev |
| 09:19 |
|
TriBlade9 joined #minetest-dev |
| 09:22 |
|
FR^2 joined #minetest-dev |
| 09:28 |
|
jin_xi joined #minetest-dev |
| 09:41 |
|
Amaz joined #minetest-dev |
| 09:41 |
|
leat joined #minetest-dev |
| 09:57 |
|
paramat joined #minetest-dev |
| 09:58 |
paramat |
okay hmmmm this is ready for review/merge #2123 |
| 09:58 |
ShadowBot |
https://github.com/minetest/minetest/issues/2123 -- Mgv7: New cave system with fewer large caves and new 3D noise tunnels by paramat |
| 09:58 |
|
paramat left #minetest-dev |
| 10:12 |
nrzkt |
#2137 and #2116 needs to be merged and #2116 too :) |
| 10:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/2137 -- Database_Dummy::deleteBlock : fix missing return by nerzhul |
| 10:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/2116 -- Optimize vertex calculations (maths), perf improvement by nerzhul |
| 10:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/2116 -- Optimize vertex calculations (maths), perf improvement by nerzhul |
| 10:12 |
nrzkt |
#2119, sorry... |
| 10:12 |
ShadowBot |
https://github.com/minetest/minetest/issues/2119 -- Rewrite client/server packet handling by nerzhul |
| 10:13 |
Kargaroc |
beep beep beep beep beep... beep beep beep beep beep... beep beep beep beep beep... beep beep beep beep beep... beep beep beep beep beep... |
| 10:33 |
|
cib0 joined #minetest-dev |
| 10:35 |
|
kilbith joined #minetest-dev |
| 10:37 |
|
proller joined #minetest-dev |
| 10:46 |
|
Zeno` joined #minetest-dev |
| 10:46 |
Zeno` |
will merge 2116 soon |
| 10:50 |
nrzkt |
Hi, good news |
| 10:50 |
nrzkt |
i also fixed a warning introduced in main... #2137 |
| 10:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/2137 -- Database_Dummy::deleteBlock : fix missing return by nerzhul |
| 10:54 |
Zeno` |
nrzkt, I will fix the whitespace issues manually just this once :p |
| 10:55 |
Zeno` |
yeah #2137 can be merged immediately |
| 10:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/2137 -- Database_Dummy::deleteBlock : fix missing return by nerzhul |
| 11:13 |
kilbith |
the style is fixed on #2119 too, ready for merge. |
| 11:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/2119 -- Rewrite client/server packet handling by nerzhul |
| 11:14 |
Zeno` |
I'm fine with 2119 |
| 11:14 |
Zeno` |
But for that one I'd like another dev to agree |
| 11:16 |
|
rubenwardy joined #minetest-dev |
| 11:28 |
|
T4im joined #minetest-dev |
| 11:30 |
|
Kalabasa joined #minetest-dev |
| 11:31 |
|
proller joined #minetest-dev |
| 11:41 |
|
chchjesus joined #minetest-dev |
| 11:48 |
|
iqualfragile joined #minetest-dev |
| 12:09 |
|
SudoAptGetPlay joined #minetest-dev |
| 12:20 |
|
rater193 joined #minetest-dev |
| 12:45 |
|
nrzkt joined #minetest-dev |
| 12:50 |
|
PilzAdam joined #minetest-dev |
| 12:51 |
|
Taoki joined #minetest-dev |
| 12:57 |
|
ImQ009 joined #minetest-dev |
| 13:00 |
|
nrzkt joined #minetest-dev |
| 13:09 |
|
VargaD joined #minetest-dev |
| 13:36 |
|
proller joined #minetest-dev |
| 13:50 |
|
gregorycu joined #minetest-dev |
| 14:03 |
|
impact joined #minetest-dev |
| 14:11 |
|
shadowzone joined #minetest-dev |
| 14:11 |
|
proller joined #minetest-dev |
| 14:21 |
|
crazyR joined #minetest-dev |
| 14:23 |
|
Taoki joined #minetest-dev |
| 14:40 |
|
TriBlade9 joined #minetest-dev |
| 14:44 |
|
Taoki joined #minetest-dev |
| 14:54 |
Zeno` |
can we close all pull requests and issue? |
| 14:55 |
Zeno` |
apart from maybe the last 30 |
| 15:01 |
sfan5 |
why would we do that |
| 15:02 |
Zeno` |
because 90% of the PRs need to be rebased and never will be |
| 15:06 |
|
ImQ009 joined #minetest-dev |
| 15:09 |
shadowzone |
I see my PR got really quiet. |
| 15:09 |
|
cib0 joined #minetest-dev |
| 15:13 |
|
Taoki joined #minetest-dev |
| 15:15 |
|
CraigyDavi joined #minetest-dev |
| 15:30 |
|
iqualfragile joined #minetest-dev |
| 15:41 |
|
kaeza joined #minetest-dev |
| 15:44 |
Zeno` |
sfan: is the main issue with #2135 the player image? |
| 15:44 |
ShadowBot |
https://github.com/minetest/minetest/issues/2135 -- Added help tab to main menu by TheShadowZone12 |
| 15:45 |
Zeno` |
sfan5 * |
| 15:45 |
sfan5 |
Zeno`: yup |
| 15:46 |
shadowzone |
I can remove it. |
| 15:46 |
|
DuDraig joined #minetest-dev |
| 15:46 |
Zeno` |
yep, remove it |
| 15:46 |
shadowzone |
I have no objections to removing anything that is of conflict |
| 15:47 |
shadowzone |
And I'll also change from fgettext to gettext for ShadowNinja |
| 16:18 |
|
Calinou joined #minetest-dev |
| 16:20 |
|
proller joined #minetest-dev |
| 16:20 |
|
diemartin joined #minetest-dev |
| 16:34 |
|
kilbith joined #minetest-dev |
| 16:34 |
shadowzone |
how's #2135 look now? |
| 16:34 |
ShadowBot |
https://github.com/minetest/minetest/issues/2135 -- Added help tab to main menu by TheShadowZone12 |
| 16:36 |
kilbith |
shadowzone: don't need to add the controls in that tab, they're already in the pause menu (typically where the player needs to know, ie. in game). |
| 16:36 |
|
Megaf joined #minetest-dev |
| 16:36 |
|
Hunterz joined #minetest-dev |
| 16:38 |
Zeno` |
They can't hurt being there |
| 16:38 |
kilbith |
that's just useless & redundant |
| 16:39 |
Zeno` |
Although they do need to change if the person is playing on Android :P |
| 16:39 |
VanessaE |
why not a separate formspec that pops up on clicking a "Help" button in both the pause menu and the main menu? |
| 16:39 |
kilbith |
^ |
| 16:39 |
VanessaE |
said formspec would contain all the help crap that's in the pause menu now, plus your stuiff |
| 16:39 |
VanessaE |
stuff* |
| 16:39 |
Zeno` |
that might be a good idea |
| 16:40 |
VanessaE |
shadowzone: ^^^^^^ |
| 16:40 |
shadowzone |
I saw |
| 16:41 |
SudoAptGetPlay |
I prefer vanessa's approach |
| 16:41 |
kilbith |
a button like that : [?] |
| 16:41 |
VanessaE |
that way there's zero redundancy, save for the button, and there's no reason to complain about a redundant button seeing as how we have a "change keys" menu in the Pause formspec as well as in the main menu |
| 16:41 |
Zeno` |
yeah, I agree |
| 16:41 |
kilbith |
agree too |
| 16:42 |
SudoAptGetPlay |
plus you can pop help help when you really need it : in-game |
| 16:42 |
VanessaE |
kilbith: I'd prefer to spell it out. I'm not too fond of iconic buttons in this context |
| 16:42 |
VanessaE |
SudoAptGetPlay: you mean the REAL help i.e. what shadowzone coded. exactly my thought |
| 16:43 |
SudoAptGetPlay |
yes |
| 16:43 |
kilbith |
now the question is : where do this button should be in the menu ? |
| 16:43 |
VanessaE |
shadowzone: you should be able to re-use 99% of your existing code when doing this, btw. |
| 16:43 |
shadowzone |
I understand that |
| 16:44 |
VanessaE |
kilbith: right below "Change Keys" in the Pause menu, and in the main menu just put it in the Singleplayer tab left of "Play" |
| 16:44 |
kilbith |
that sounds correct |
| 16:44 |
VanessaE |
though with that many buttons on the Pause menu and no side text, the buttons therein should be re-arranged |
| 16:45 |
* shadowzone |
now wonders why VanessaE is a previous contributer |
| 16:45 |
VanessaE |
(there would be six buttons then, which would make for a nice 2x3 layout if you spaced them closely together vertically) |
| 16:45 |
VanessaE |
shadowzone: because I don't contribute much to the engine, I focus primarily on Lua stuff. |
| 16:45 |
shadowzone |
Oh.. |
| 16:45 |
Zeno` |
that will require C++ changes though, won't it? |
| 16:46 |
VanessaE |
Zeno`: the pause formspec is Lua too isn't it? |
| 16:46 |
Zeno` |
I don't think it is :( |
| 16:46 |
VanessaE |
oh. |
| 16:46 |
Calinou |
it isn't |
| 16:46 |
Zeno` |
although it should be |
| 16:46 |
Calinou |
it should be :\ |
| 16:47 |
VanessaE |
well shadowzone can tweak the help formspec and main menu "Help" button, and you or someone else can re-arrange the Pause menu and include it there, then |
| 16:47 |
Zeno` |
Yeah, I can probably look at it tomorrow |
| 16:48 |
Zeno` |
Makes no sense that it's C++ anyway |
| 16:48 |
VanessaE |
Zeno`: different topic: self-extracting 7z? (see #minetest for another example of its necessity) |
| 16:48 |
shadowzone |
I saw that too |
| 16:49 |
kilbith |
when i see all that unused space in that formspec : https://lut.im/bbiR3G4I/OsUMfld0 i'm not even sure when need a button and a new formspec to put the basic help.. |
| 16:49 |
kilbith |
s/when:we |
| 16:50 |
VanessaE |
kilbith: well my idea includes re-arranging that pause menu so as to get rid of all that empty space and just fill it with buttons (including another Help button) |
| 16:50 |
kilbith |
just re-arrange the pause menu and put the infos that shadowzone has put |
| 16:50 |
kilbith |
has suggested* |
| 16:50 |
Zeno` |
kilbith, personally I think that a help tab / formspec (somewhere) is a good idea |
| 16:50 |
VanessaE |
too much info will fill smaller screens with unreadable text |
| 16:50 |
VanessaE |
better to keep the pause menu small and offer "Help" as a button for users who actually need it |
| 16:50 |
Zeno` |
the pause menu, especially if it's ported to Lua, can be changed easily |
| 16:51 |
shadowzone |
Maybe add a "help" button that'll open a formspec with what is displayed on the help tab |
| 16:51 |
VanessaE |
shadowzone: that's the idea |
| 16:51 |
shadowzone |
Ah, I got you now. |
| 16:52 |
kilbith |
there won't have a help tab, you have understood the idea of Vanessa, shadowzone |
| 16:52 |
VanessaE |
shadowzone: both the pause menu and singleplayer tab should have such a button, but zeno or someone will have to deal with the pause menu button since it's C++ |
| 16:52 |
kilbith |
you have not* |
| 16:52 |
VanessaE |
kilbith: actually she has understood perfectly. |
| 16:53 |
kilbith |
you suggested a bouton that leads to a new formspec, and get rid of that tab |
| 16:53 |
VanessaE |
she and zeno can work together to revise all three formspecs |
| 16:53 |
Zeno` |
gee, thanks :P |
| 16:53 |
shadowzone |
lol |
| 16:53 |
VanessaE |
:) |
| 16:54 |
kilbith |
VanessaE: a button -> formspec, instead of a tab, is that your idea ? |
| 16:55 |
kilbith |
houston ? |
| 16:56 |
shadowzone |
Yes, apollo 11? |
| 16:56 |
VanessaE |
in the main menu, yes |
| 16:56 |
VanessaE |
and the *same* formspec will be called forth from the pause menu also |
| 16:56 |
VanessaE |
just like with the keys menu |
| 16:56 |
kilbith |
so why do you agree on that : "Maybe add a "help" button that'll open a formspec with what is displayed on the help tab" ? |
| 16:57 |
kilbith |
if we add a button, there won't have a tab at all |
| 16:57 |
VanessaE |
kilbith: because I meant for shadowzone to keep the content she wrote for the *tab* and put it in a pop-up formspec accessible by button |
| 16:57 |
VanessaE |
that way she doesn't have to throw away all the code |
| 16:57 |
kilbith |
ooh my bad |
| 16:57 |
kilbith |
the content yes |
| 16:59 |
SudoAptGetPlay |
now I get it |
| 16:59 |
kilbith |
anyways, don't need to put the controls config. in help, in the pause menu, just under the 'change keys' formspec |
| 16:59 |
kilbith |
that'd be completely redundant |
| 16:59 |
shadowzone |
I will remove it if needed |
| 17:01 |
Zeno` |
don't remove anything yet. Wait to see what transpires tomorrow |
| 17:01 |
shadowzone |
Okay |
| 17:01 |
kilbith |
the chat commands helps are needed for sure |
| 17:01 |
|
exio4 joined #minetest-dev |
| 17:02 |
VanessaE |
kilbith: yes, and they'd go into the proposed formspec |
| 17:02 |
kilbith |
not sure for IRC links |
| 17:02 |
Zeno` |
kilbith, the keys shown in the pause menu are silly anyway |
| 17:02 |
VanessaE |
everything that's in the pause menu now would go in there |
| 17:02 |
Zeno` |
because they don't take into account if the user changed the defaults |
| 17:02 |
VanessaE |
even the build options can be put there probably |
| 17:03 |
kilbith |
i'd prefer keep only the display of the controls config in the 'change keys' formspec |
| 17:05 |
kilbith |
as for mentionning Inchra.net #minetest -> unofficial channel, to remove |
| 17:06 |
shadowzone |
But most of our Minetest servers are there, people might wanna go check it out.. |
| 17:06 |
kilbith |
it's simply not official, not a matter of frequentation |
| 17:07 |
kilbith |
btw, this channel is constantly, overfully flooded by several servers |
| 17:08 |
|
exio4 joined #minetest-dev |
| 17:15 |
|
SopaXorzTaker joined #minetest-dev |
| 17:15 |
SopaXorzTaker |
hi guys |
| 17:15 |
SopaXorzTaker |
can you help me fetching the info about the protocol |
| 17:15 |
SopaXorzTaker |
I can't find one |
| 17:17 |
ShadowNinja |
SopaXorzTaker: doc/protocol.txt and src/clientserver.h |
| 17:18 |
SopaXorzTaker |
protocol.txt is very old |
| 17:18 |
|
n4x joined #minetest-dev |
| 17:18 |
SopaXorzTaker |
and outdated |
| 17:23 |
|
acerspyro joined #minetest-dev |
| 17:38 |
|
hmmmm joined #minetest-dev |
| 17:50 |
|
rubenwardy joined #minetest-dev |
| 17:56 |
|
Krock joined #minetest-dev |
| 18:20 |
Krock |
#2095 this tiny change makes buttons display correctly again (see image, redcrab subgame) |
| 18:20 |
ShadowBot |
https://github.com/minetest/minetest/issues/2095 -- Display (sub)game icons again by SmallJoker |
| 18:20 |
Krock |
(updated) |
| 18:32 |
Krock |
eww. F10's font is tiny |
| 18:42 |
|
nrzkt joined #minetest-dev |
| 18:42 |
nrzkt |
bonsoir à tous |
| 18:42 |
rubenwardy |
#2095 |
| 18:42 |
ShadowBot |
https://github.com/minetest/minetest/issues/2095 -- Display (sub)game icons again by SmallJoker |
| 18:42 |
rubenwardy |
Yes! |
| 18:47 |
Krock |
hmm? |
| 18:47 |
nrzkt |
#2119 can be commited this week-end ? I'm working on a second patchset to cleanup packet handling and packet writing, but i need 2113 to be committed :) |
| 18:47 |
ShadowBot |
https://github.com/minetest/minetest/issues/2119 -- Rewrite client/server packet handling by nerzhul |
| 18:47 |
rubenwardy |
I'm unignored :) |
| 18:49 |
Krock |
nrzkt, I've seen it and the overview is kinda lost |
| 18:49 |
Krock |
nvm |
| 18:50 |
Krock |
I see you packed it into a single commit |
| 18:50 |
Krock |
Also, I hope you've tested the codes by playing on a server |
| 18:50 |
rubenwardy |
Yes, this is a commit that needs to be tested extensively. IMO |
| 19:01 |
nrzkt |
krock i cannot do more little commit |
| 19:01 |
Krock |
nvm = never mind |
| 19:15 |
nrzkt |
rubenwardy, please test this weekend, i play with my minetest server (stable) and there are no crash and protocol issue, i also tried 2hours of gaming (create & survival mode) with a stable client and a new server, and no problem |
| 19:16 |
kilbith |
i confirm, no problem with his server |
| 19:16 |
nrzkt |
the second patchset, after integrating this patchset will introduce a new interface to forge packets properly and replace the SharedBuffer for sending packets, using NetworkPacket |
| 19:42 |
|
compunerd joined #minetest-dev |
| 20:04 |
|
cib0 joined #minetest-dev |
| 20:04 |
|
roniz joined #minetest-dev |
| 20:18 |
sfan5 |
"ShadowNinja added the won't add label just now" wat |
| 20:19 |
sfan5 |
i agree with ShadowNinja on that one |
| 20:19 |
VanessaE |
to what? |
| 20:19 |
sfan5 |
but this wasn't discussed |
| 20:19 |
sfan5 |
#2138 |
| 20:19 |
ShadowBot |
https://github.com/minetest/minetest/issues/2138 -- Hide minetest version string by SmallJoker |
| 20:20 |
Krock |
^ discussion in chit-chat channel |
| 20:20 |
ShadowNinja |
sfan5: It was added intentionally, and the label can always be removed if a mojority decides otherwise. I'm not going to disscuss every label before I add it. |
| 20:21 |
ShadowNinja |
(the feature was added intentionaly) |
| 20:21 |
sfan5 |
i'm not requesting that you should discuss every label |
| 20:21 |
sfan5 |
but just saying "won't add" without anyone else looking at it seems kinda wrong |
| 20:22 |
|
nrzkt joined #minetest-dev |
| 20:22 |
|
CWz joined #minetest-dev |
| 20:23 |
|
CWz left #minetest-dev |
| 20:30 |
|
DFeniks joined #minetest-dev |
| 21:15 |
|
shadowzone joined #minetest-dev |
| 21:33 |
|
proller joined #minetest-dev |
| 21:44 |
|
OldCoder joined #minetest-dev |
| 21:47 |
|
n4x joined #minetest-dev |
| 21:49 |
|
Wayward_One joined #minetest-dev |
| 21:52 |
|
zat joined #minetest-dev |
| 21:52 |
|
shadowzone left #minetest-dev |
| 21:53 |
|
cib0 joined #minetest-dev |
| 21:55 |
|
acerspyro joined #minetest-dev |
| 21:56 |
|
Taoki joined #minetest-dev |
| 22:20 |
|
proller joined #minetest-dev |
| 22:28 |
|
impact joined #minetest-dev |
| 22:34 |
|
shadowzone joined #minetest-dev |
| 23:13 |
|
est31 joined #minetest-dev |
| 23:38 |
|
sapier joined #minetest-dev |
| 23:39 |
sapier |
ShadowNinja: I fear I can't use the google icons they're licensed cc by 2.5 |
| 23:39 |
acerspyro |
make your own |
| 23:39 |
acerspyro |
I can make some SVG icons |
| 23:40 |
sapier |
does irrlicht support svg ;-) |
| 23:40 |
acerspyro |
No, but I only make them in SVG |
| 23:40 |
acerspyro |
Then I export them to png |
| 23:40 |
sapier |
feel free to do it ;-) almost everyone is better in designing icons then me ;_) |
| 23:41 |
acerspyro |
What do you need |
| 23:42 |
sapier |
well at best a consistent icon pack ;-) ... let me do the changes I intend to do and post new screenshot so you see what is needed |
| 23:42 |
acerspyro |
ok |
| 23:51 |
sapier |
VanessaE: do you have time to make your servers test #2119? |
| 23:51 |
ShadowBot |
https://github.com/minetest/minetest/issues/2119 -- Rewrite client/server packet handling by nerzhul |
| 23:51 |
VanessaE |
soon but not right at the moment |
| 23:54 |
|
cib_ joined #minetest-dev |
| 23:56 |
|
Garmine joined #minetest-dev |
