| Time |
Nick |
Message |
| 00:38 |
|
SmugLeaf joined #minetest-dev |
| 00:50 |
|
Kray joined #minetest-dev |
| 00:50 |
|
NakedFury joined #minetest-dev |
| 00:50 |
|
hmmmm joined #minetest-dev |
| 00:50 |
|
e1z0 joined #minetest-dev |
| 00:50 |
|
lanxu joined #minetest-dev |
| 01:15 |
|
zat joined #minetest-dev |
| 02:17 |
|
Miner_48er joined #minetest-dev |
| 03:01 |
|
ImQ009 joined #minetest-dev |
| 03:07 |
|
AllegedlyDead joined #minetest-dev |
| 03:28 |
|
Weedy joined #minetest-dev |
| 03:28 |
|
Weedy joined #minetest-dev |
| 03:39 |
|
BrandonReese joined #minetest-dev |
| 03:57 |
|
SmugLeaf joined #minetest-dev |
| 03:57 |
|
SmugLeaf joined #minetest-dev |
| 05:14 |
|
Miner_48er joined #minetest-dev |
| 05:29 |
|
nore joined #minetest-dev |
| 05:31 |
|
AlexFa joined #minetest-dev |
| 06:04 |
|
blaise joined #minetest-dev |
| 06:54 |
|
AlexFa left #minetest-dev |
| 07:07 |
|
rsiska joined #minetest-dev |
| 07:09 |
|
proller joined #minetest-dev |
| 07:09 |
|
darkrose joined #minetest-dev |
| 07:52 |
|
proller joined #minetest-dev |
| 07:58 |
|
lanxu_ joined #minetest-dev |
| 07:58 |
|
Kray_ joined #minetest-dev |
| 08:02 |
|
e1z0_ joined #minetest-dev |
| 08:04 |
|
Miner_48er joined #minetest-dev |
| 08:04 |
|
proller joined #minetest-dev |
| 08:15 |
|
proller joined #minetest-dev |
| 08:33 |
|
proller joined #minetest-dev |
| 08:39 |
|
Calinou joined #minetest-dev |
| 08:50 |
|
proller joined #minetest-dev |
| 10:12 |
|
smoke_fumus joined #minetest-dev |
| 10:15 |
|
proller joined #minetest-dev |
| 10:25 |
|
Jordach joined #minetest-dev |
| 10:38 |
|
proller joined #minetest-dev |
| 10:40 |
|
PilzAdam joined #minetest-dev |
| 11:08 |
|
sfan5 joined #minetest-dev |
| 11:16 |
|
xiong joined #minetest-dev |
| 11:16 |
|
PilzAdam joined #minetest-dev |
| 11:18 |
|
Garmine joined #minetest-dev |
| 11:18 |
|
tomreyn joined #minetest-dev |
| 11:19 |
|
Garmine joined #minetest-dev |
| 11:20 |
|
e1z0 joined #minetest-dev |
| 11:21 |
|
Garmine joined #minetest-dev |
| 11:21 |
|
ImQ009 joined #minetest-dev |
| 11:21 |
|
Garmine joined #minetest-dev |
| 11:22 |
|
Garmine joined #minetest-dev |
| 11:22 |
|
Garmine joined #minetest-dev |
| 11:27 |
|
Guest37528 joined #minetest-dev |
| 12:11 |
|
proller joined #minetest-dev |
| 12:58 |
|
Megaf joined #minetest-dev |
| 13:22 |
|
proller joined #minetest-dev |
| 13:29 |
|
smoke_fumus joined #minetest-dev |
| 13:40 |
|
lanxu joined #minetest-dev |
| 13:42 |
|
hmmmm joined #minetest-dev |
| 13:44 |
|
AllegedlyDead joined #minetest-dev |
| 13:45 |
|
Ritchie joined #minetest-dev |
| 13:45 |
|
psedlak joined #minetest-dev |
| 13:45 |
|
Megaf joined #minetest-dev |
| 13:46 |
|
khonkhortisan joined #minetest-dev |
| 13:46 |
|
cj joined #minetest-dev |
| 13:48 |
|
Jordach_ joined #minetest-dev |
| 13:48 |
|
xyz joined #minetest-dev |
| 13:48 |
|
PilzAdam joined #minetest-dev |
| 13:49 |
|
sfan5 joined #minetest-dev |
| 13:50 |
|
robmyers joined #minetest-dev |
| 13:50 |
|
robmyers joined #minetest-dev |
| 13:59 |
|
Selat joined #minetest-dev |
| 14:00 |
Selat |
Hello. Why don't you like C++-style types casting? https://github.com/minetest/minetest/pull/1140 |
| 14:00 |
Selat |
There is no reply more than 2 weeks. |
| 14:02 |
|
ImQ009 joined #minetest-dev |
| 14:04 |
sfan5 |
Selat: ''We can’t automatically merge this pull request.'' rebase first |
| 14:50 |
Selat |
Now automerge should work. |
| 15:09 |
|
iqualfragile joined #minetest-dev |
| 15:38 |
Exio4 |
how is that "fixing" the casting? |
| 15:44 |
Selat |
According to the C++ standard such C-style type casting is ill-formed. Also it doesn't perform runtime check. |
| 15:45 |
Selat |
And in any way C-style type casting uses static_cast or reinterpret_cast. |
| 15:46 |
Selat |
So there are no benifits in using such type casting. |
| 15:47 |
Selat |
*benefits |
| 15:50 |
sfan5 |
why do we want runtime checks? |
| 15:50 |
|
proller joined #minetest-dev |
| 15:50 |
sfan5 |
what is checked? |
| 15:53 |
|
werwerwer_ joined #minetest-dev |
| 15:53 |
Exio4 |
runtime check, yeah |
| 15:53 |
Exio4 |
what is wrong with not checking something at runtime and having it in a type-safe way? |
| 15:53 |
sfan5 |
what is checked? |
| 15:53 |
sfan5 |
if it only checks for NULL we can spare it |
| 15:54 |
sfan5 |
if something is NULL it will crash or error after sometime anyway |
| 15:55 |
Exio4 |
i don't actually remember, but if you do void* sometype1 and then cast to sometype2 that pointer, it'll return NULL instead of the "broken data" iirc |
| 15:59 |
Selat |
It checks casting between derived classes. |
| 16:02 |
Selat |
I'm not sure that it's good idea to refuse runtime checks to have few nanoseconds speed advantage and forget about real source of lags. |
| 16:14 |
|
Selat_ joined #minetest-dev |
| 16:14 |
|
rsiska joined #minetest-dev |
| 16:17 |
|
Selat joined #minetest-dev |
| 16:35 |
|
Calinou joined #minetest-dev |
| 16:39 |
|
salamanderrake joined #minetest-dev |
| 16:43 |
sfan5 |
proller: it was only a small bugfix, but you are supposed to at least notify #minetest-dev before pushing |
| 16:55 |
Exio4 |
if(!str) return str; |
| 16:55 |
Exio4 |
what will this do, if null, return null? |
| 16:56 |
Exio4 |
or if "", return ""? |
| 17:04 |
|
Calinou joined #minetest-dev |
| 17:05 |
|
darkrose joined #minetest-dev |
| 17:05 |
|
SmugLeaf joined #minetest-dev |
| 17:05 |
|
celeron55_ joined #minetest-dev |
| 17:05 |
|
VanessaE joined #minetest-dev |
| 17:05 |
|
harrison joined #minetest-dev |
| 17:06 |
|
ImQ009 joined #minetest-dev |
| 17:06 |
|
Jordach joined #minetest-dev |
| 17:06 |
|
Ritchie joined #minetest-dev |
| 17:06 |
|
smoke_fumus joined #minetest-dev |
| 17:06 |
|
e1z0 joined #minetest-dev |
| 17:09 |
|
troller joined #minetest-dev |
| 17:10 |
|
kahrl joined #minetest-dev |
| 17:11 |
kahrl |
Exio4: both |
| 17:12 |
|
sfan5 joined #minetest-dev |
| 17:12 |
Exio4 |
i see |
| 17:13 |
celeron55_ |
commented on https://github.com/minetest/minetest/pull/1140 |
| 17:23 |
xyz |
I think it's safer than c-style cast because if you're doing something wrong it'll crash for sure |
| 17:27 |
sfan5 |
Exio4: both |
| 17:28 |
Exio4 |
[14:11:06] <+kahrl> Exio4: both |
| 17:28 |
Exio4 |
[14:27:02] <+sfan5> Exio4: both :P |
| 17:28 |
sfan5 |
oh |
| 17:28 |
sfan5 |
oops |
| 17:28 |
Exio4 |
the netsplit! |
| 17:35 |
Exio4 |
hmm, looks like it is now 16USD |
| 17:35 |
Exio4 |
if i could have 128 ARS irl i would be happy right now |
| 17:41 |
sfan5 |
Exio4: wrong channel |
| 17:43 |
Exio4 |
heh |
| 17:44 |
|
proller joined #minetest-dev |
| 17:44 |
|
Garmine joined #minetest-dev |
| 17:49 |
|
rubenwardy joined #minetest-dev |
| 18:10 |
Selat |
commented here https://github.com/minetest/minetest/pull/1140 |
| 18:11 |
sfan5 |
Selat: I know that your comment is meant ironic, but it still sounds a bit harsh |
| 18:15 |
xyz |
wow you managed to piss him off |
| 18:15 |
sfan5 |
who? me? |
| 18:15 |
xyz |
no, not you |
| 18:21 |
Selat |
Maybe I'm wrong, but spending more than half an hour on discussing such trifle is unusual. |
| 18:22 |
xyz |
no, it's minetest |
| 18:22 |
xyz |
you'll get used to it |
| 18:22 |
ShadowNinja |
I agree with sfan. |
| 18:36 |
|
Mitroman joined #minetest-dev |
| 18:45 |
ShadowNinja |
Comments? https://gist.github.com/ShadowNinja/9194308 |
| 18:45 |
|
sfan5 joined #minetest-dev |
| 18:45 |
|
xyz joined #minetest-dev |
| 18:46 |
ShadowNinja |
The prefix argument doesn't work, and I haven't been able to find out why. (although sometimes it does work...) |
| 18:46 |
ShadowNinja |
And I still don't see why it should be added. |
| 18:46 |
ShadowNinja |
sfan5: https://gist.github.com/ShadowNinja/9194308 |
| 18:48 |
sfan5 |
ShadowNinja: ??? |
| 18:48 |
VanessaE |
wouldn't it be better to fix it than to remove the feature? O_o |
| 18:50 |
VanessaE |
a lot of users confuse the "Server -!-" prefix for an actual username |
| 18:51 |
VanessaE |
that is, they think someone named "Server" is speaking. |
| 18:51 |
xyz |
there's no need to prepend anything |
| 18:51 |
xyz |
so this patch just removes this option |
| 18:51 |
VanessaE |
um, xyz: "prepend: optional, if it is set to false "Server -!- " will not be prepended to the message" |
| 18:52 |
VanessaE |
so I think the point is to be able to *remove* the "Server" prefix... |
| 18:52 |
VanessaE |
not add to it :P |
| 18:52 |
xyz |
wat |
| 18:52 |
VanessaE |
and this doesn't always work right. |
| 18:52 |
xyz |
did you check out his patch? |
| 18:52 |
VanessaE |
yes I did. |
| 18:52 |
ShadowNinja |
VanessaE: I made a patch a while ago that added the option to remove it. It worked at the time but doesn't seem to work most of the time anymore, and I have no idea why. |
| 18:53 |
xyz |
also wtf is the "prefix" argument? |
| 18:53 |
VanessaE |
his patch removes that ability, which didn't work anyway |
| 18:53 |
xyz |
I'm kinda out of loop |
| 18:53 |
ShadowNinja |
VanessaE: And I figure if you NEED the prefix you can just add "Server-!- ".. to your code. |
| 18:54 |
VanessaE |
ShadowNinja: that part I can agree with |
| 18:54 |
ShadowNinja |
xyz: minetest.chat_send_player("singleplayer", "Test") --> Server -!- Test. |
| 18:54 |
xyz |
ah |
| 18:54 |
xyz |
so well |
| 18:54 |
xyz |
anyway, I don't get VanessaE's problem here |
| 18:56 |
ShadowNinja |
It would be great if someone figured out what's wrong with it, but I don't really like the prefix option at all. |
| 18:58 |
xyz |
I agree |
| 18:58 |
VanessaE |
ok so I guess patch it to remove the prepend misfeature then. I've never been too fond of code adding extra bits to messages either; I prefer to have full control over what gets printed (at least, to a point) |
| 19:22 |
|
nore joined #minetest-dev |
| 19:35 |
|
EvergreenTree joined #minetest-dev |
| 19:35 |
|
EvergreenTree joined #minetest-dev |
| 19:36 |
|
rsiska joined #minetest-dev |
| 19:53 |
|
Miner_48er joined #minetest-dev |
| 20:18 |
|
proller joined #minetest-dev |
| 20:18 |
|
troller joined #minetest-dev |
| 20:47 |
|
EvergreenTree joined #minetest-dev |
| 20:47 |
|
EvergreenTree joined #minetest-dev |
| 20:47 |
|
domtron joined #minetest-dev |
| 21:25 |
|
zat joined #minetest-dev |
| 21:36 |
|
domtron joined #minetest-dev |
| 21:56 |
|
domtron joined #minetest-dev |
| 21:58 |
|
troller joined #minetest-dev |
| 22:06 |
|
domtron joined #minetest-dev |
| 22:10 |
|
domtron_ joined #minetest-dev |
| 22:12 |
|
zat joined #minetest-dev |
| 22:18 |
|
domtron joined #minetest-dev |
| 22:56 |
|
Weedy_lappy joined #minetest-dev |
| 22:56 |
|
Weedy_lappy joined #minetest-dev |
| 23:10 |
|
deltib joined #minetest-dev |
| 23:23 |
|
zat joined #minetest-dev |
| 23:47 |
|
zat1 joined #minetest-dev |
| 23:47 |
|
salamanderrake joined #minetest-dev |
| 23:47 |
|
salamanderrake_ joined #minetest-dev |
| 23:56 |
|
salamanderrake joined #minetest-dev |
