| Time |
Nick |
Message |
| 00:41 |
|
general3214 joined #minetest-dev |
| 00:48 |
|
EvergreenTree joined #minetest-dev |
| 00:53 |
EvergreenTree |
VanessaE, Fixed my pull request (I think) |
| 01:01 |
* VanessaE |
looks |
| 01:01 |
VanessaE |
you have to take the other 'end' out also, at line 285. |
| 01:03 |
EvergreenTree |
done |
| 01:04 |
VanessaE |
yes, that looks about right |
| 01:04 |
VanessaE |
did you test it? :) |
| 01:06 |
EvergreenTree |
Yep, it works |
| 01:07 |
VanessaE |
excellent. |
| 01:09 |
EvergreenTree |
Can any devs agree with #988? |
| 01:10 |
hmmmm |
vanessae, can you verify that it works properly? |
| 01:11 |
VanessaE |
hmmmm: I have a variant of it already inplace and working, but lemme check the "official" pull |
| 01:13 |
VanessaE |
yep, it seems good. |
| 01:13 |
VanessaE |
there's no checking for protection, but that's third-party-mod territory |
| 01:13 |
hmmmm |
it's 0942a9229d29004d36706fc9ad7d050eec835b09 that you checked, right? |
| 01:14 |
VanessaE |
yup |
| 01:14 |
VanessaE |
(and the associated pull for minetest_game) |
| 01:15 |
hmmmm |
you realize this'll be the first time I ever committed to minetest_game |
| 01:15 |
hmmmm |
heh |
| 01:15 |
VanessaE |
yep :) |
| 01:15 |
VanessaE |
but, it's only two lines. I'm sure you can handle it :D |
| 01:15 |
EvergreenTree |
There's always a first time |
| 01:16 |
VanessaE |
excuse me, 4 lines :P_ |
| 01:17 |
proller |
hmmmm, #892 #895 |
| 01:18 |
hmmmm |
I'll have to check out 895 better |
| 01:18 |
hmmmm |
you do a lot there |
| 01:18 |
hmmmm |
oh the weather stuff |
| 01:18 |
hmmmm |
892 we need to talk about |
| 01:19 |
proller |
it fixes weather |
| 01:19 |
proller |
if weather disabled - return static value |
| 01:19 |
hmmmm |
I know, there's a better way to do it though |
| 01:19 |
proller |
-33333c? |
| 01:19 |
VanessaE |
use the values from plants_lib :) |
| 01:20 |
hmmmm |
that was INT16_MIN |
| 01:20 |
proller |
and checks everywhere? |
| 01:20 |
hmmmm |
not a random value |
| 01:20 |
proller |
noooo! |
| 01:20 |
proller |
it must be checked in every call from lua |
| 01:20 |
hmmmm |
lemme look |
| 01:20 |
proller |
why to return this -intmax shit> |
| 01:20 |
proller |
? |
| 01:20 |
VanessaE |
hmmmm: oh, did you see where Pilz rather vocally dislikes the idea of putting lib6d into use in the stairs mod? :P |
| 01:21 |
hmmmm |
vanessae, no, show me later on |
| 01:21 |
VanessaE |
sure. |
| 01:21 |
proller |
hmmmm, i go to slleep now, will read log tomorrow |
| 01:21 |
hmmmm |
eh alright |
| 01:21 |
hmmmm |
I had a reason for doing that thou |
| 01:21 |
hmmmm |
though* |
| 01:22 |
hmmmm |
right, I didn't like how you put your weather stuff right in the emerge thread |
| 01:22 |
hmmmm |
it really doesn't belong there |
| 01:22 |
proller |
but it works |
| 01:22 |
proller |
your change dont works |
| 01:23 |
hmmmm |
right, and there's a reason why |
| 01:23 |
proller |
0c 0% everywhere |
| 01:23 |
proller |
can you fix it? |
| 01:23 |
hmmmm |
so why don't we figure out what's wrong with what I did |
| 01:23 |
hmmmm |
it shouldn't be 0c and 0%, no, I saw that problem and I thought I fixed it |
| 01:23 |
hmmmm |
that's due to uninitialized memory |
| 01:23 |
hmmmm |
do you get 0c 0% when weather is enabled or disabled? |
| 01:24 |
proller |
enabled |
| 01:25 |
hmmmm |
odd |
| 01:25 |
hmmmm |
but okay, I'll fix it by fixing fixing it, not just reverting the change |
| 01:25 |
hmmmm |
and by the way |
| 01:25 |
hmmmm |
+ if (p.Y < -(MAP_GENERATION_LIMIT-1000)) heat += 6000 * (1-((float)(p.Y - -MAP_GENERATION_LIMIT)/1000)); //hot core, later via realms, DISABLE BEFORE MERGING |
| 01:25 |
proller |
its not 0 on new blocks, and 0 on loaded |
| 01:25 |
proller |
its not problem |
| 01:26 |
proller |
bit its hooot! 8) |
| 01:26 |
hmmmm |
well |
| 01:26 |
hmmmm |
if I merge that somehow |
| 01:26 |
hmmmm |
I'll comment that out like you probably wanted |
| 01:26 |
proller |
btw your 30000c already melt part of my map |
| 01:26 |
hmmmm |
that's a bug |
| 01:27 |
proller |
because in my game stone melts at 3000c |
| 01:27 |
hmmmm |
it's supposed to check that on block initialize and say |
| 01:27 |
hmmmm |
"oh look, we have weather enabled but weather wasn't calculated for this block" |
| 01:27 |
hmmmm |
"let's do that now" |
| 01:27 |
hmmmm |
and you don't keep backups of your map? |
| 01:27 |
proller |
no |
| 01:28 |
proller |
not a problem, it was fun |
| 01:28 |
hmmmm |
lol |
| 01:29 |
proller |
away! |
| 01:35 |
hmmmm |
'night |
| 01:57 |
VanessaE |
hmmmm: what about turning cacti sideways also? |
| 01:58 |
hmmmm |
?? |
| 01:59 |
VanessaE |
the 6d code, as nely applied to tree trunks. |
| 01:59 |
VanessaE |
newly* |
| 02:00 |
hmmmm |
maybe, i'll have to checkitout |
| 02:00 |
VanessaE |
ok. |
| 02:05 |
EvergreenTree |
Huh, never thought about cacti being able to lay horizontal |
| 02:07 |
VanessaE |
another change I'd like to see, unless this is already possible: floats for healing values, so that I could make a node/item give, oh, 1/10 of a heart on use. |
| 02:10 |
kaeza |
it would be better to allow changing hp_max per player |
| 02:11 |
kaeza |
and perhaps let apples heal a percentage of the max hp |
| 02:12 |
kaeza |
other thing I would like comments on, is a global callback for when a player eats an item, to avoid re-defining all food items in mods |
| 02:19 |
|
deltib1 joined #minetest-dev |
| 02:24 |
|
deltib joined #minetest-dev |
| 02:31 |
|
deltib joined #minetest-dev |
| 02:40 |
|
SmugLeaf joined #minetest-dev |
| 02:55 |
|
dmitryk1 joined #minetest-dev |
| 02:57 |
|
dmitryk1 left #minetest-dev |
| 03:01 |
|
zat left #minetest-dev |
| 06:17 |
kaeza |
Minetest is crashing with SIGSEGV when pressing enter on a formspec containing a textlist[] element; gdb is not being friendly (presumably from stack overwriting) |
| 06:18 |
kaeza |
the bug is reproducible; this is enough to test it: http://pastebin.com/PsMm2kXD |
| 06:18 |
kaeza |
using latest git pulled a couple hours ago |
| 07:20 |
kahrl |
kaeza: can you check if 0b788892898013cd430c48b98e21a3fd111c3c7f caused that? |
| 07:21 |
kahrl |
in gdb I see acceptInput() being called twice which is likely due to that commit |
| 07:27 |
kahrl |
oh... umm it wasn't that commit I guess, it's a bug that has been there forever |
| 07:28 |
kahrl |
https://github.com/minetest/minetest/blob/master/src/guiFormSpecMenu.cpp#L2314 |
| 07:28 |
kahrl |
acceptInput() is called after quitMenu() |
| 07:29 |
kahrl |
someone did not read "This should be called when the menu wants to quit. WARNING: THIS DEALLOCATES THE MENU FROM MEMORY. Return immediately if you call this from the menu itself." |
| 07:29 |
VanessaE |
heh |
| 09:10 |
|
smoke_fumus joined #minetest-dev |
| 10:23 |
|
Zeitgeist_ joined #minetest-dev |
| 11:06 |
|
iqualfragile joined #minetest-dev |
| 11:18 |
|
jojoa1997 joined #minetest-dev |
| 11:19 |
|
Akien joined #minetest-dev |
| 11:31 |
|
iqualfragile joined #minetest-dev |
| 11:46 |
|
darkrose joined #minetest-dev |
| 11:47 |
|
zat joined #minetest-dev |
| 11:47 |
|
iqualfragile joined #minetest-dev |
| 12:02 |
|
EvergreenTree joined #minetest-dev |
| 13:20 |
|
hmmmm joined #minetest-dev |
| 13:33 |
|
ImQ009 joined #minetest-dev |
| 14:08 |
|
rubenwardy joined #minetest-dev |
| 14:22 |
|
iqualfragile_ joined #minetest-dev |
| 14:33 |
|
djdduty joined #minetest-dev |
| 14:50 |
|
zat1 joined #minetest-dev |
| 15:06 |
|
salamanderrake joined #minetest-dev |
| 15:45 |
|
EvergreenTree joined #minetest-dev |
| 15:51 |
|
Akien joined #minetest-dev |
| 15:56 |
|
rubenwardy_ joined #minetest-dev |
| 16:02 |
|
Jordach joined #minetest-dev |
| 16:02 |
|
PilzAdam joined #minetest-dev |
| 16:21 |
|
ecube joined #minetest-dev |
| 16:46 |
|
Gethiox joined #minetest-dev |
| 16:46 |
|
_rubenwardy_ joined #minetest-dev |
| 16:47 |
|
sapier joined #minetest-dev |
| 16:51 |
sapier |
kahrl shall I use httpfetch or httpfetch2 a base for async preparation? |
| 17:04 |
|
rubenwardy_ joined #minetest-dev |
| 17:12 |
PilzAdam |
the "You can also use Lua operators on vectors." part in lua-api.txt about vector functions should be removed, since ShadowNinja removed the metatable handling from it |
| 17:12 |
PilzAdam |
also there is a typo: https://forum.minetest.net/viewtopic.php?pid=117396#p117396 |
| 17:13 |
PilzAdam |
oh wait, the operators are already removed |
| 17:14 |
PilzAdam |
(the thread links to a wrong lua-api.txt version) |
| 17:16 |
PilzAdam |
will push in a few minutes: https://github.com/PilzAdam/minetest/commit/1afd3595505e1f1cbcf727682194ab755ac005f4 |
| 17:18 |
iqualfragile_ |
CURL_INCLUDE_DIR = CURL_INCLUDE_DIR-NOTFOUND |
| 17:18 |
iqualfragile_ |
why? |
| 17:18 |
sapier |
agreed |
| 17:18 |
sapier |
curl detection is broken on windows |
| 17:19 |
iqualfragile_ |
i am on debian |
| 17:19 |
sapier |
ok :-) |
| 17:19 |
iqualfragile_ |
it does detect CURL_LIBRARY = /usr/lib/x86_64-linux-gnu/libcurl.so |
| 17:19 |
sapier |
I assume you have libcurl-dev installed? |
| 17:40 |
sapier |
https://github.com/sapier/minetest/tree/async_events_plus_httpfetch kahrl could you have a look if I did merge this correct? (once you've time of course) |
| 18:00 |
|
EvergreenTree joined #minetest-dev |
| 18:07 |
PilzAdam |
wtf? https://github.com/minetest/minetest/pull/988 |
| 18:08 |
PilzAdam |
1) why are there no commits in this pull request 2) why does github think I merged it? |
| 18:09 |
sapier |
*g* did you sleep while merging it? ;-) |
| 18:10 |
PilzAdam |
I pushed that typo fix, and for some reason github thinks that 988 was related to it |
| 18:10 |
sapier |
funny |
| 18:11 |
PilzAdam |
EvergreenTree, you might want to fix your pull request |
| 18:11 |
PilzAdam |
https://github.com/minetest/minetest_game/pull/214 has also no commits |
| 18:12 |
sapier |
as you're here pilzadam you long ago complained about modmanager not beeing intuitive enough. 884 should improve this drasticaly what do you think about? |
| 18:13 |
|
werwerwer joined #minetest-dev |
| 18:13 |
PilzAdam |
can this wait until tomorow? |
| 18:14 |
sapier |
it's there for some months so I guess a day more or less wont matter |
| 18:40 |
|
Calinou joined #minetest-dev |
| 19:40 |
|
Jordach joined #minetest-dev |
| 20:10 |
|
EvergreenTree joined #minetest-dev |
| 20:11 |
EvergreenTree |
PilzAdam, Sorry about that, hmmmm merged it, and I forgot the pull request was still open |
| 20:11 |
EvergreenTree |
So I rebased, and thus the lack of commits in the request |
| 20:34 |
PilzAdam |
EvergreenTree, you should create new branches for pull requests; here is a short hint how to do that: http://dev.minetest.net/Git#Coding_a_feature |
| 20:36 |
PilzAdam |
github will keep the commits, even if you remove the branch after the pull request is merged |
| 20:36 |
PilzAdam |
its better for the pull request history |
| 21:00 |
|
Ritchie joined #minetest-dev |
| 21:08 |
|
Ritchie joined #minetest-dev |
| 21:13 |
|
Ritchie joined #minetest-dev |
| 21:19 |
|
Miner_48er joined #minetest-dev |
| 21:19 |
|
Ritchie joined #minetest-dev |
| 21:20 |
ShadowNinja |
What do you think about merging this? https://github.com/ShadowNinja/minetest/compare/pcall_errfunc |
| 21:21 |
ShadowNinja |
It adds tracebacks to C++ -> Lua calls with errors. |
| 21:21 |
ShadowNinja |
It fixed untraceable vector errors and the like. |
| 21:21 |
ShadowNinja |
fixes* |
| 21:22 |
sapier |
did you manage to cleanup the stack correctly? |
| 21:23 |
ShadowNinja |
sapier: Yes, I even cleaned it up a bit more by adding pops and removes to places where there weren't any. |
| 21:24 |
sapier |
any idea why this didn't cause errors before? |
| 21:27 |
ShadowNinja |
sapier: Hmmm? There weren't any trecebacks ever, except for the initial loading step. You just got the one line describing the error. there were a number of untraceable crashes, but the vector ones brought this to my attention. |
| 21:27 |
sapier |
not popping things from stack that have been added should have resulted in a stack overflow |
| 21:28 |
ShadowNinja |
sapier: The Lua GC prevented that I imagine. |
| 21:29 |
sapier |
could be I'd feel better if we knew it and wouldn't have to guess |
| 21:41 |
|
Zeitgeist_ joined #minetest-dev |
| 21:41 |
|
Zeitgeist_ joined #minetest-dev |
| 22:21 |
|
Gethiox2 joined #minetest-dev |
| 23:01 |
|
paramat joined #minetest-dev |
| 23:02 |
|
paramat left #minetest-dev |
| 23:35 |
zat |
ShadowNinja: did you see the bugfix to the rollback then? |
| 23:36 |
zat |
rather, check. |
| 23:38 |
|
Taoki joined #minetest-dev |
| 23:45 |
ShadowNinja |
zat: Did you fix the bignum bug? |
| 23:45 |
zat |
I did it the same day and I told you |
| 23:45 |
zat |
lol |
| 23:46 |
ShadowNinja |
Oh, um, right. Run make. |
| 23:55 |
* ShadowNinja |
likes |
| 23:55 |
ShadowNinja |
/rollback_check is instant. |
| 23:56 |
ShadowNinja |
zat: Can you have /rollback_check list the last 5-10 actions instead of only one? |
| 23:57 |
zat |
I took a look and I think I could, it would take modifying more files though, the lua interface expects only one action. |
| 23:57 |
zat |
I want to fix that anyway |
| 23:58 |
zat |
and probably extend its arguments so you can be more specific in what you want returned |
| 23:58 |
iqualfragile_ |
can we get anti-aleasing for minetest? |
| 23:59 |
VanessaE |
anti-aliasing? |
| 23:59 |
iqualfragile_ |
what she said |
