| Time |
Nick |
Message |
| 00:09 |
zat |
Nobody was talking about that Exio4 |
| 00:09 |
Exio4 |
forcing people to code in the same way |
| 00:11 |
zat |
I didnt really get what you meant actually |
| 00:11 |
|
Dakota joined #minetest-dev |
| 00:12 |
Exio4 |
the idea is making all the code somewhat similar, easier to mantain and read |
| 00:13 |
proller |
Exio4, how many lines of code for minetest you wrote? |
| 00:14 |
zat |
If an iterator is long enough that by following the same style would make it hard to understand, it is fine to change it a bit to ease readability. |
| 00:14 |
zat |
If someone else has a problem with it, it is just a pedant. |
| 00:14 |
zat |
is* |
| 00:16 |
Exio4 |
proller: less than 200 iirc |
| 01:46 |
|
NakedFury joined #minetest-dev |
| 02:19 |
|
OWNSyouAll joined #minetest-dev |
| 03:22 |
|
ch98 joined #minetest-dev |
| 04:03 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 04:12 |
|
IceCraft joined #minetest-dev |
| 05:31 |
|
Anchakor joined #minetest-dev |
| 06:07 |
|
darkrose joined #minetest-dev |
| 06:07 |
|
darkrose joined #minetest-dev |
| 06:43 |
|
Calinou joined #minetest-dev |
| 06:56 |
|
iqualfragile joined #minetest-dev |
| 07:31 |
|
healdropper joined #minetest-dev |
| 07:33 |
|
smoke_fumus joined #minetest-dev |
| 09:07 |
|
Semilevel joined #minetest-dev |
| 09:14 |
|
Gethiox joined #minetest-dev |
| 09:24 |
|
Semilevel joined #minetest-dev |
| 09:31 |
|
DemonRaiser joined #minetest-dev |
| 10:02 |
|
Semilevel joined #minetest-dev |
| 10:04 |
|
proller joined #minetest-dev |
| 10:38 |
|
Semilevel joined #minetest-dev |
| 10:44 |
|
Semilevel joined #minetest-dev |
| 11:10 |
|
Semilevel joined #minetest-dev |
| 11:13 |
|
proller joined #minetest-dev |
| 11:19 |
|
Ritchie_ joined #minetest-dev |
| 11:20 |
|
iqualfragile joined #minetest-dev |
| 11:23 |
|
ImQ009 joined #minetest-dev |
| 11:26 |
|
Semilevel joined #minetest-dev |
| 11:30 |
|
Akien joined #minetest-dev |
| 12:09 |
|
hmmmm joined #minetest-dev |
| 12:55 |
|
Ritchie_ joined #minetest-dev |
| 13:43 |
|
NakedFury joined #minetest-dev |
| 13:43 |
|
Semilevel joined #minetest-dev |
| 13:45 |
|
rubenwardy joined #minetest-dev |
| 13:55 |
|
celeron55 joined #minetest-dev |
| 14:19 |
VanessaE |
I'd like some opinions regarding adding this code to builtin (i.e. should I bother with a pull request): https://github.com/VanessaE/homedecor/blob/master/lib_6d.lua |
| 14:55 |
|
Jordach joined #minetest-dev |
| 14:56 |
|
ImQ009_ joined #minetest-dev |
| 15:20 |
|
zat joined #minetest-dev |
| 15:35 |
|
deltib joined #minetest-dev |
| 15:39 |
|
Semilevel joined #minetest-dev |
| 16:03 |
|
Calinou joined #minetest-dev |
| 16:15 |
|
Gethiox joined #minetest-dev |
| 16:25 |
ShadowNinja |
VanessaE: It looks good, but you shouldn't have to pass infinitestacks to it. It should determine it itself or creative should override it. |
| 16:26 |
VanessaE |
in homedecor, it used to. it occurred to me that there may be other ways to detect it besides the method homedecor uses. |
| 16:27 |
VanessaE |
pilz and I had this discussion before, and the result was that creative == infinite stacks, period, and fuck off if I want it some other way |
| 16:27 |
VanessaE |
so I put that ^^^ in to facilitate that. |
| 16:27 |
VanessaE |
so if used by some default mod, get-bool-creative -> infinitestacks. |
| 16:28 |
ShadowNinja |
UI will want to use is_creative(player) for that. |
| 16:28 |
VanessaE |
if used by some sane mod, try to detect if they really are or not e.g. unified inventory does not use infinite stacks even in creative mode. |
| 16:28 |
ShadowNinja |
Of course UI doesn't really support infinite stacks ATM. |
| 16:29 |
ShadowNinja |
You could add minetest.is_creative(player) or similar. |
| 16:29 |
VanessaE |
some folks here have a problem with having a default/builtin mod query other, third-party mods |
| 16:29 |
VanessaE |
that's why the code doesn't test for infinite stacks itself. |
| 16:37 |
|
Gethiox joined #minetest-dev |
| 16:38 |
ShadowNinja |
minetest.is_creative would be overriden by mods that change how creative mode works (eg, creative and UI) |
| 16:40 |
VanessaE |
that's nice and all but I'm trying to work within what we have now. I don't like proposing additional changes if I can avoid |
| 16:40 |
VanessaE |
it |
| 17:11 |
proller |
lib_6d.lua - looks good |
| 18:10 |
|
ImQ009 joined #minetest-dev |
| 18:42 |
|
werwerwer joined #minetest-dev |
| 19:06 |
|
zat joined #minetest-dev |
| 19:26 |
|
ritchie_ joined #minetest-dev |
| 19:36 |
|
djdduty joined #minetest-dev |
| 19:36 |
|
djdduty joined #minetest-dev |
| 19:45 |
|
Menche joined #minetest-dev |
| 19:52 |
|
ImQ009 joined #minetest-dev |
| 20:15 |
|
proller joined #minetest-dev |
| 20:20 |
|
neko259 joined #minetest-dev |
| 20:56 |
|
Gethiox2 joined #minetest-dev |
| 21:06 |
|
proller joined #minetest-dev |
| 21:16 |
|
Gethiox2 joined #minetest-dev |
| 21:22 |
|
zat joined #minetest-dev |
| 21:24 |
|
sapier1 joined #minetest-dev |
| 22:50 |
zat |
is it possible? I have spent hours, since I first asked... and cannot find such an option. |
| 23:03 |
VanessaE |
an option for what? |
| 23:06 |
zat |
an option for.... |
| 23:07 |
zat |
I just realized I typed this in the wrong channel |
| 23:07 |
zat |
thx for helping me realize Vane |
| 23:10 |
VanessaE |
lol |
