| Time |
Nick |
Message |
| 00:21 |
|
Taoki joined #minetest-dev |
| 00:37 |
|
iqualfragile joined #minetest-dev |
| 01:59 |
|
RealBadAngel joined #minetest-dev |
| 02:19 |
|
RealBadAngel joined #minetest-dev |
| 02:23 |
ShadowNinja |
Anyone know where I can find a string to IP address converter?... |
| 02:25 |
hmmmm |
i'm sure radio shack has one |
| 02:26 |
ShadowNinja |
Hahaha. |
| 02:32 |
|
BackupCoder joined #minetest-dev |
| 02:34 |
|
mrtux joined #minetest-dev |
| 03:50 |
|
ch98 joined #minetest-dev |
| 05:10 |
|
ch98 left #minetest-dev |
| 06:31 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 06:34 |
|
EdB joined #minetest-dev |
| 06:36 |
|
RealBadAngel joined #minetest-dev |
| 06:44 |
|
smoke_fumus joined #minetest-dev |
| 07:06 |
|
ecube joined #minetest-dev |
| 07:10 |
|
ffoxin joined #minetest-dev |
| 07:10 |
|
Miner_48er joined #minetest-dev |
| 07:15 |
|
Lynxx joined #minetest-dev |
| 07:46 |
|
iqualfragile joined #minetest-dev |
| 08:06 |
|
Calinou joined #minetest-dev |
| 08:07 |
|
darkrose joined #minetest-dev |
| 08:31 |
|
loggingbot_ joined #minetest-dev |
| 08:31 |
|
Topic for #minetest-dev is now Minetest core development and maintenance. Chit-chat goes to #minetest. Consider this instead of /msg celeron55. http://irc.minetest.ru/minetest-dev/ http://dev.minetest.net/ |
| 08:35 |
|
yno joined #minetest-dev |
| 08:38 |
|
Taoki joined #minetest-dev |
| 08:40 |
|
\n joined #minetest-dev |
| 08:41 |
|
dzho_ joined #minetest-dev |
| 08:41 |
|
thexyz_ joined #minetest-dev |
| 08:45 |
|
mrtux_ joined #minetest-dev |
| 08:48 |
|
nyuszika7h joined #minetest-dev |
| 08:49 |
|
RealBadAngel joined #minetest-dev |
| 08:49 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 08:52 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 08:55 |
|
Guest57391 joined #minetest-dev |
| 09:07 |
|
mrtux joined #minetest-dev |
| 09:07 |
|
yno joined #minetest-dev |
| 09:07 |
|
darkrose joined #minetest-dev |
| 09:07 |
|
ecube joined #minetest-dev |
| 09:07 |
|
BackupCoder joined #minetest-dev |
| 09:07 |
|
salamanderrake joined #minetest-dev |
| 09:07 |
|
BrandonReese joined #minetest-dev |
| 09:07 |
|
Anchakor1 joined #minetest-dev |
| 09:07 |
|
Kray joined #minetest-dev |
| 09:07 |
|
Anchakor joined #minetest-dev |
| 09:07 |
|
OWNSyouAll_DESKT joined #minetest-dev |
| 09:10 |
|
RealBadAngel joined #minetest-dev |
| 09:11 |
|
iqualfragile joined #minetest-dev |
| 09:12 |
|
yno_ joined #minetest-dev |
| 09:20 |
|
ecube_ joined #minetest-dev |
| 09:31 |
|
darkrose joined #minetest-dev |
| 09:31 |
|
darkrose joined #minetest-dev |
| 10:07 |
|
sapier joined #minetest-dev |
| 10:15 |
|
Jordach joined #minetest-dev |
| 10:33 |
|
around joined #minetest-dev |
| 10:37 |
|
Jordach joined #minetest-dev |
| 10:53 |
|
Calinou joined #minetest-dev |
| 11:13 |
|
PilzAdam joined #minetest-dev |
| 11:43 |
|
neko259 joined #minetest-dev |
| 11:58 |
|
Yepoleb joined #minetest-dev |
| 12:00 |
|
Taoki joined #minetest-dev |
| 12:50 |
|
VanessaE joined #minetest-dev |
| 13:08 |
|
iqualfragile joined #minetest-dev |
| 13:10 |
|
mrtux joined #minetest-dev |
| 13:46 |
|
iqualfragile joined #minetest-dev |
| 14:04 |
|
RealBadAngel joined #minetest-dev |
| 14:06 |
RealBadAngel |
hi, i have a problem. somebody knows where exactly players deserialized data like HP are passed to client side? |
| 14:08 |
RealBadAngel |
im tryin to save and load players breath, i do have it on server side but cannot pass it to player easily |
| 14:08 |
kahrl |
active object messages as well as stuff like TOCLIENT_HP |
| 14:09 |
kahrl |
isn't there a pull request about saving breath data? |
| 14:10 |
kahrl |
ah yeah yours ;) |
| 14:11 |
kahrl |
so it doesn't do that yet... hmm |
| 14:11 |
RealBadAngel |
i mean this situation, player data is saved on disk, loaded |
| 14:11 |
RealBadAngel |
then ammount of hearts transferred to client |
| 14:11 |
RealBadAngel |
question is where |
| 14:12 |
RealBadAngel |
i found obvious piece of code, but thats not it |
| 14:12 |
PilzAdam |
in TOSERVER_INIT2 |
| 14:12 |
PilzAdam |
in line 2105 the HP is send |
| 14:12 |
PilzAdam |
you can send the breath after that |
| 14:12 |
PilzAdam |
(of server.cpp, of course) |
| 14:13 |
RealBadAngel |
https://github.com/minetest/minetest/blob/master/src/content_cao.cpp#L672 |
| 14:13 |
kahrl |
it's weird that HP is sent twice like that |
| 14:13 |
RealBadAngel |
this is client side, set hp to whatever value you like and it wont change anything |
| 14:14 |
RealBadAngel |
players hp is passed elsewhere |
| 14:14 |
kahrl |
the m_hp field of GenericCAO is only used for punch damage prediction |
| 14:15 |
kahrl |
m_breath is not needed there |
| 14:16 |
kahrl |
(unless somebody wants to implement drowning damage prediction for GenericCAO) |
| 14:17 |
RealBadAngel |
im checkin PA's solution |
| 14:24 |
PilzAdam |
RealBadAngel, oh, and since you working on this already, can you add an if(hp>0) arround the drowing stuff, so the bar isnt shown if enable_damage is false? |
| 14:25 |
RealBadAngel |
no problemo |
| 14:34 |
|
iqualfragile joined #minetest-dev |
| 14:35 |
RealBadAngel |
it works but the very same way as my little hackish way i used (i defined m_breath_not_send defaulted to true, which caused auto send of breath) |
| 14:36 |
RealBadAngel |
ie when 4 bubbles were saved and send client starts with a few more (regenerated?) |
| 14:36 |
RealBadAngel |
like 5-6 |
| 14:38 |
kahrl |
I think that's because the client is running while receiving/processing media, and if it has not received the mapblock the player is standing in, it assumes the player is in CONTENT_IGNORE |
| 14:57 |
|
Calinou joined #minetest-dev |
| 14:58 |
|
ffoxin joined #minetest-dev |
| 15:00 |
RealBadAngel |
i have updated pull, https://github.com/minetest/minetest/pull/838 |
| 15:02 |
PilzAdam |
ehm |
| 15:02 |
PilzAdam |
<PilzAdam> RealBadAngel, oh, and since you working on this already, can you add an if(hp>0) arround the drowing stuff, so the bar isnt shown if enable_damage is false? |
| 15:02 |
PilzAdam |
not g_settings->getBool("enable_damage") |
| 15:03 |
PilzAdam |
the client's config isnt the same as the servers |
| 15:03 |
RealBadAngel |
ah, ok |
| 15:03 |
Calinou |
if hp is hidden on client, don't show air bar |
| 15:03 |
Calinou |
would work like that |
| 15:03 |
Calinou |
it's already hidden when damage is off |
| 15:03 |
RealBadAngel |
but hp can be 0? |
| 15:03 |
PilzAdam |
Calinou, "hidden" just means its 0 |
| 15:04 |
Calinou |
same thing :shrug: |
| 15:04 |
RealBadAngel |
hmm, lets try |
| 15:05 |
PilzAdam |
RealBadAngel, btw, make sure that empty lines are empty, i.e. no spaces or tabs |
| 15:06 |
RealBadAngel |
have you found any? |
| 15:07 |
PilzAdam |
https://github.com/minetest/minetest/pull/838/files#L11L214 |
| 15:07 |
PilzAdam |
its not easy to find them in the web interface, thats why you should check it locally |
| 15:07 |
PilzAdam |
git diff highlights them in red |
| 15:08 |
PilzAdam |
(or green) |
| 15:16 |
RealBadAngel |
ok, made those changes |
| 15:17 |
RealBadAngel |
seems to be working the same way now with checking for players hp |
| 15:17 |
|
Naked joined #minetest-dev |
| 15:18 |
|
SpeedProg joined #minetest-dev |
| 15:19 |
PilzAdam |
RealBadAngel, almost all your empty lines seem to have spaces or tabs |
| 15:19 |
RealBadAngel |
huh? |
| 15:20 |
PilzAdam |
https://github.com/minetest/minetest/pull/838/files#L9L253 |
| 15:20 |
RealBadAngel |
i could see just one and fixed it |
| 15:20 |
PilzAdam |
https://github.com/minetest/minetest/pull/838/files#L12L1141 |
| 15:20 |
PilzAdam |
https://github.com/minetest/minetest/pull/838/files#L12L2107 |
| 15:21 |
PilzAdam |
and thats just what I see in the web interface |
| 15:25 |
RealBadAngel |
easy to say |
| 15:25 |
RealBadAngel |
i cannot see it at all ;) |
| 15:32 |
RealBadAngel |
i fixed them |
| 15:33 |
RealBadAngel |
can somebody push it? |
| 15:35 |
kahrl |
why the strange brace style in https://github.com/minetest/minetest/pull/838/files#L6R2274? |
| 15:37 |
RealBadAngel |
what is strange in it?? |
| 15:37 |
kahrl |
it's not used anywhere else in minetest |
| 15:37 |
RealBadAngel |
but as you wish,,, |
| 15:38 |
|
hmmmm joined #minetest-dev |
| 15:39 |
RealBadAngel |
better? :) |
| 15:40 |
RealBadAngel |
hi hmmmm |
| 15:40 |
kahrl |
yep |
| 15:44 |
|
iqualfragile joined #minetest-dev |
| 15:54 |
|
Jordach joined #minetest-dev |
| 15:55 |
RealBadAngel |
so can anyone push it or tell me how push opened pull request? i know just how to commit directly |
| 16:00 |
kahrl |
git checkout master; git pull; wget https://github.com/minetest/minetest/pull/838.patch; git am 838.patch; git push upstream master |
| 16:00 |
kahrl |
but has somebody agreed to it yet? |
| 16:01 |
RealBadAngel |
have you anything against it? |
| 16:01 |
RealBadAngel |
i also added things that PA wished, so i assume hes ok with it |
| 16:02 |
kahrl |
I haven't fully looked at it, am busy with other things |
| 16:03 |
PilzAdam |
I wonder why you dont follow the style of lua-api.txt |
| 16:03 |
RealBadAngel |
what is different there? |
| 16:04 |
PilzAdam |
^ is missing |
| 16:04 |
RealBadAngel |
you couldnt tell that yesterday? |
| 16:04 |
RealBadAngel |
you saw it already and then it was ok |
| 16:05 |
PilzAdam |
huh, must have missed it |
| 16:05 |
RealBadAngel |
i dont see the style lookin at it |
| 16:05 |
RealBadAngel |
there are ^ - and * |
| 16:06 |
RealBadAngel |
entries below also doesnt have ^ |
| 16:07 |
PilzAdam |
there are still empty lines with tabs.... |
| 16:07 |
RealBadAngel |
and nobody cries about it ;) |
| 16:07 |
RealBadAngel |
i cant see any tabs in my editor |
| 16:07 |
PilzAdam |
there are also many lines with spaces/tabs at the end |
| 16:08 |
PilzAdam |
git diff highlights them by default |
| 16:10 |
RealBadAngel |
im not writing code in git diff, sorry bout that |
| 16:11 |
kahrl |
PilzAdam: it does in git diff --color, but that isn't the default |
| 16:14 |
|
Jordach joined #minetest-dev |
| 16:32 |
RealBadAngel |
if i can see tabs in code not related to mine shall i fix them too? |
| 16:32 |
PilzAdam |
no |
| 16:33 |
RealBadAngel |
i just found two tabs in empy lines in player.cpp |
| 16:34 |
RealBadAngel |
in Player::deSerialize |
| 16:34 |
PilzAdam |
there are tons of mistakes like this |
| 16:34 |
RealBadAngel |
im modyfing the code in this very function, so i can remove them now |
| 16:38 |
sapier |
could someone plz merge https://github.com/minetest/minetest/pull/825 |
| 16:42 |
PilzAdam |
sapier, testing |
| 16:45 |
RealBadAngel |
PilzAdam, can you check if any tabs or space errors left? |
| 16:46 |
PilzAdam |
no |
| 16:48 |
PilzAdam |
sapier, I think the gamemanger should be disabled by default |
| 16:48 |
PilzAdam |
or removed completly |
| 16:49 |
RealBadAngel |
why? i checked all the code i wrote and removed all the mistakes, i wanted just confirmation if i did it right |
| 16:49 |
PilzAdam |
RealBadAngel, I have better things to do that running git diff for you |
| 16:52 |
RealBadAngel |
propably yes. im just sayin i fixed them all checkin each line of code. are you ok with the commit now? |
| 16:59 |
|
sapier1 joined #minetest-dev |
| 17:02 |
|
Jordach joined #minetest-dev |
| 17:03 |
|
Jordach joined #minetest-dev |
| 17:12 |
PilzAdam |
sapier1, when I go into a configure window the activate checkbox is only shown when I click on a mod, even it is already selected |
| 17:12 |
PilzAdam |
and why have you removed the doubleclick to activate it? both ways should be possible |
| 17:16 |
sapier1 |
I'll look for first problem .. I won't say anything about last one this was what has been requested you can switch in settings what you want |
| 17:16 |
|
proller joined #minetest-dev |
| 17:16 |
PilzAdam |
hm? nobody has request that doubleclick should be removed |
| 17:17 |
PilzAdam |
just that there are both ways to active a mod |
| 17:17 |
sapier1 |
YOU said the doubleclick is unintuitive and useless |
| 17:17 |
PilzAdam |
yes, but it works if people have only a few mods so that the scrollbar isnt a problem |
| 17:18 |
sapier1 |
I do not add different ways to do same things as that is really a usability nightmare 1 action 1 way to do |
| 17:18 |
PilzAdam |
ummm |
| 17:18 |
sapier1 |
those ppl can enable it in settings |
| 17:18 |
PilzAdam |
thats stupid |
| 17:19 |
sapier1 |
no it isn't I know lots of programms adding more and more ways to do same thing until no one was capable of fixing it |
| 17:20 |
PilzAdam |
there should be many ways of doing things, so that people can do what suits their needs without chaning a config file |
| 17:20 |
PilzAdam |
thats what every GUI program does |
| 17:20 |
kahrl |
let's remove the minimize, maximize and close buttons on windows because you can right click the title bar |
| 17:21 |
sapier1 |
no there shouldn't if there are many ways if someone says "that doesn't" work you'll always try the other way to do it |
| 17:22 |
sapier1 |
I guess windows isn't exactly a good example for usability "start->shutdown" |
| 17:22 |
kahrl |
I meant the general thing, not the OS |
| 17:23 |
sapier1 |
I never use the rightclick for title bar |
| 17:24 |
|
Calinou joined #minetest-dev |
| 17:25 |
sapier1 |
if you want it that bad I guess you'll be able to enable it yourself, I won't do it |
| 17:26 |
PilzAdam |
why are you so close minded? |
| 17:27 |
sapier1 |
because I'm annoyed to get stupid new requirements about working features every day ... you WANTED old behaviour I restored old one now you want mixed mode behaviour ... YOUR problem |
| 17:29 |
sapier1 |
you behave like minetest was your baby if it is anyones baby it's celerons your opinion is ONE opinion but you don't have any right to speak for minetest community neither do I |
| 17:29 |
Calinou |
PilzAdam asking other people why they are closed minded |
| 17:29 |
Calinou |
._. |
| 17:43 |
|
gin_xi joined #minetest-dev |
| 17:58 |
RealBadAngel |
PilzAdam, so, do you have anything more against https://github.com/minetest/minetest/pull/838/ ? i fixed all the tabs/spaces and added your ideas. |
| 18:01 |
PilzAdam |
seems good now |
| 18:06 |
RealBadAngel |
can we merge it? |
| 18:12 |
PilzAdam |
yes |
| 18:13 |
PilzAdam |
then merge #839, #833 and #773 and bump the protocol version |
| 18:43 |
RealBadAngel |
does any of above contain new TOSERVER or TOCLIENT? |
| 18:44 |
PilzAdam |
no |
| 18:44 |
RealBadAngel |
ok |
| 18:44 |
PilzAdam |
only serialization of items/nodes |
| 18:44 |
RealBadAngel |
describe it in protocol changes? |
| 18:45 |
PilzAdam |
you also have to move the variables in the serialize() methods arround |
| 18:45 |
PilzAdam |
and yes, add a note in clienserver.h |
| 18:46 |
RealBadAngel |
move variables? |
| 18:46 |
RealBadAngel |
that are your commits, im not familiar what you have done there |
| 18:46 |
PilzAdam |
basically move them above the comment that says that new things should be added under it |
| 18:46 |
RealBadAngel |
ah |
| 18:47 |
PilzAdam |
I can make the bump commit then |
| 18:47 |
RealBadAngel |
if you can |
| 18:47 |
RealBadAngel |
im rather short with time now, going to work in 45 minutes |
| 18:47 |
RealBadAngel |
night shift today |
| 18:48 |
RealBadAngel |
about my changes to protocol: 2 new ones: TOSERVER_BREATH and TOCLIENT_BREATH |
| 18:51 |
|
BlockMen joined #minetest-dev |
| 18:51 |
PilzAdam |
I wonder if its needed to bump the itemdef version |
| 18:51 |
BlockMen |
lua control for breathing is added? |
| 18:51 |
BlockMen |
great! :) |
| 18:54 |
|
salamanderrake joined #minetest-dev |
| 18:58 |
PilzAdam |
kahrl, should I create a new itemdef version like this https://gist.github.com/PilzAdam/6046081 or just add everything to version 2 like its done in nodedef? |
| 19:04 |
kahrl |
wait why does it write sound_place in version 3 but not read it? |
| 19:05 |
PilzAdam |
oh |
| 19:05 |
kahrl |
I'd say keep the version number 2 |
| 19:08 |
PilzAdam |
that doesnt work |
| 19:09 |
PilzAdam |
it makes range 0 in my client when connecting to VanessaE's server |
| 19:13 |
kahrl |
ah, I got confused a little by serialize() using protocol_version and deSerialize() using version |
| 19:13 |
kahrl |
so, add version 3 and fix the sound_place problem? does that work? |
| 19:15 |
PilzAdam |
yes |
| 19:16 |
BlockMen |
umm..player:get_breath() returns 65535 ?? |
| 19:17 |
PilzAdam |
https://gist.github.com/PilzAdam/6046126 |
| 19:17 |
PilzAdam |
BlockMen, everything > 10 means "bar not shown" |
| 19:18 |
BlockMen |
oh, i thought that was -1 |
| 19:18 |
PilzAdam |
-1 in an unsigned variable isnt -1 |
| 19:25 |
sfan5 |
(uint16_t) -1 == (uint16_t) 65535 |
| 19:28 |
PilzAdam |
stuff can be added to the new protocol version in the next few days |
| 20:12 |
|
neko259 joined #minetest-dev |
| 20:26 |
|
darkrose joined #minetest-dev |
| 20:30 |
celeron55_ |
a protocol version bump doesn't mean the old formats could be dropped; it just means the old format's read/write function can be "archived" in a way |
| 22:29 |
VanessaE |
seeing some kind of connection oddity lately: a player signs on, then times out after a while -- but the server doesn't remove the player (leaving a zombie basically) if they try to sign back on too quickly. The zombie gets removed after the second connect attempt times out. |
| 22:29 |
VanessaE |
I'm not sure how long this has been going on; first time I noticed it. |
| 22:49 |
|
sapier1 left #minetest-dev |
| 22:56 |
|
BlockMen left #minetest-dev |
| 23:02 |
|
ecube joined #minetest-dev |
| 23:12 |
sokomine |
hi hmmm. is there any chance of that node-replacement-list for place_schematic? that would be really helpful i think! just another parameter that tells the game to use node xyz wherever the schematic said it ought to be abc |
| 23:13 |
sokomine |
it makes structures far more intresting when you can alter the materials they're made out of |
| 23:20 |
|
dzho joined #minetest-dev |
| 23:28 |
|
hdastwb joined #minetest-dev |
| 23:34 |
hdastwb |
who came up with these: http://dev.minetest.net/Code_style_guidelines ? "or" is unambiguously easier to read and easier to type than "||"; I would think the only reason to choose || over or would be because one uses a stupid language like Java that doesn't give one a choice |
| 23:35 |
PilzAdam |
hdastwb, MSVC |
| 23:38 |
Exio4 |
hdastwb: i see || and && easy to read as "or" and "and" |
| 23:38 |
hdastwb |
http://en.cppreference.com/w/cpp/header/ciso646 there's a header for that, though or is part of the standard even though MSVC doesn't seem to respect that |
| 23:39 |
Exio4 |
the only reason to use or/and over ||/&& for me is if there isn't support for ||/&& in that language |
| 23:39 |
Exio4 |
it is a code style guideline, people thinks different |
| 23:41 |
hdastwb |
why does the style guideline seem harsher on templates than macros? macros are much easier to screw up code with |
| 23:42 |
Exio4 |
macros are a nice way to inline small things |
| 23:42 |
hdastwb |
why not use inline functions? that's what they're for, and they're type-safe too |
| 23:44 |
Exio4 |
so, you would make the MYMAX/MYMIN inline functions? |
| 23:44 |
Exio4 |
or small things like https://github.com/minetest/minetest/blob/master/src/pathfinder.cpp#L42 ? |
| 23:46 |
proller |
better weather! https://github.com/proller/minetest/compare/weather |
| 23:51 |
hdastwb |
I think MYMAX and MYMIN should be inline functions; that way, you don't have bugs when inputs are double-evaluated and you'll get more meaningful errors when the inputs are different types |
| 23:53 |
Exio4 |
can you actually make "multi-type" inline functions? |
| 23:53 |
hdastwb |
that's what templates are for |
| 23:54 |
hdastwb |
compile-time abstraction without the type-unsafety (to some extent) |
| 23:56 |
Exio4 |
whatever, i don't actually see inline functions like something that is really needed, more than adding useless syntatic sugar to the code |
| 23:57 |
hdastwb |
MYMAX would become "template <typename T> T MYMAX(T a, T b) {return a > b ? a : b;}" |
| 23:57 |
PilzAdam |
hdastwb, why do you even bother? we wont change our code style guidelines |
| 23:57 |
hdastwb |
MYMAX and MYMIN don't even need to be defined, because there's already std::max and std::min |
| 23:59 |
Exio4 |
i guess the thing about the guidelines that say "Do not be too C++y" aren't that clear |
