| Time |
Nick |
Message |
| 00:22 |
|
Jdog joined #minetest-dev |
| 01:30 |
|
nephele_ joined #minetest-dev |
| 05:14 |
|
calcul0n joined #minetest-dev |
| 05:46 |
|
calcul0n_ joined #minetest-dev |
| 06:37 |
|
proller joined #minetest-dev |
| 07:14 |
|
mizux joined #minetest-dev |
| 07:40 |
|
mizux_ joined #minetest-dev |
| 07:57 |
|
NetherEran joined #minetest-dev |
| 08:00 |
|
Beton joined #minetest-dev |
| 08:00 |
|
ShadowNinja joined #minetest-dev |
| 09:44 |
|
_Zaizen_ joined #minetest-dev |
| 09:47 |
|
Zughy joined #minetest-dev |
| 09:48 |
Zughy |
hey there: if I run git via command line, is GitHub obtaining some data of mine anyway? I really don't want to send any sort of unrequested data to Microsoft |
| 09:49 |
Zughy |
I mean, if I want to collaborate to Minetest |
| 09:50 |
Zughy |
(with pull requests) |
| 09:57 |
sfan5 |
depends on what exactly you run and what you consider "some data" |
| 09:59 |
|
ANAND joined #minetest-dev |
| 09:59 |
sfan5 |
e.g. if you clone the repository github (microsoft) will see that just like a webpage visit |
| 10:02 |
sfan5 |
if you clone the repository, produce some patches and email (or whatever) them here without signing up for github, any data given to microsoft would be minimal |
| 10:02 |
sfan5 |
(though that does make reviews and discussion more difficult) |
| 10:03 |
Zughy |
I meant something more than the IP, but I take it as a no |
| 10:06 |
Zughy |
'cause I've been really wanting to contribute to Minetest but this thing always stopped me a bit; I mean Minetest being on GitHub rather than GitLab (I know there is a mirror, but ruben told me it's better if I use the former and I understand) |
| 10:06 |
Zughy |
gonna clone it and work on something then :) |
| 10:54 |
|
Fixer joined #minetest-dev |
| 11:21 |
PGimeno |
I'm in your same situation too Zughy, I removed my GH account so the only way for me to contribute is if my patches are adopted by someone else, like in #8468 |
| 11:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/8468 -- Make automatic_rotate relative, allow setting rotation by ClobberXD |
| 11:27 |
|
longerstaff13 joined #minetest-dev |
| 11:31 |
Zughy |
PGimeno, it doesn't sound fun at all.. |
| 11:31 |
Zughy |
any change merge requests can be considered on GitLab too? I'm having troubles authenticating myself for some reason on GitHub when I push, idk |
| 11:31 |
Zughy |
*any change |
| 11:32 |
Zughy |
*chance FFS |
| 11:34 |
sfan5 |
uh well, you cannot push to github without registering an account there (which is what I assumed you wanted to avoid) |
| 11:35 |
sfan5 |
you can open a merge request on gitlab too, we just need a place where we can see the changes and download them as .patch file |
| 11:35 |
Zughy |
nah, I have it already. Apparently it was an issue with 2FA |
| 11:41 |
|
lisac__ joined #minetest-dev |
| 11:47 |
Zughy |
do you core devs receive any notification when someone opens issues or pull requests both on GitHub and GitLab? |
| 11:47 |
sfan5 |
github yes, gitlab no |
| 11:50 |
sfan5 |
merging #9789, #9859 in 5 minutes |
| 11:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/9789 -- Inf value documented in rollback commands by Zughy |
| 11:50 |
ShadowBot |
https://github.com/minetest/minetest/issues/9859 -- Allow placing auto-rotating nodes on other nodes in on_rightclick by yamanq |
| 12:04 |
PGimeno |
I don't think you can submit MRs to GitLab's minetest |
| 12:12 |
Zughy |
I tried with MTG a few weeks ago and it was possible PGimeno |
| 12:13 |
Zughy |
so worst case scenario I can link them in a GH or in a forum post |
| 12:13 |
Zughy |
I saw some devs having a "my pull requests" topic on the forum, so why not |
| 12:15 |
ANAND |
I was just wrestling with 2FA issues on GH this morning :) |
| 12:15 |
Zughy |
oh, wait, you're right. Why merge and issues are enabled for MTG but not for MT? |
| 12:17 |
PGimeno |
because no one remembered to disable them n MTG¿ |
| 12:17 |
PGimeno |
? |
| 12:18 |
Zughy |
the latest issue is from 1 year ago and the latest merge too (aside mine) |
| 12:18 |
Zughy |
rip |
| 12:23 |
Zughy |
so, just for a better understanding: is it possible to enable merges on GL or we have to stick with GH? |
| 12:27 |
PGimeno |
#7901 |
| 12:27 |
ShadowBot |
https://github.com/minetest/minetest/issues/7901 -- Accepting PRs/patches from non-Github users |
| 14:10 |
rubenwardy |
PGimeno: https://gitlab.com/minetest/minetest/-/merge_requests |
| 14:10 |
rubenwardy |
I receive notifications |
| 14:11 |
rubenwardy |
so does nerzhul |
| 14:11 |
rubenwardy |
and anyone that is in the org and has selected to receive notification |
| 14:30 |
|
erlehmann joined #minetest-dev |
| 15:30 |
PGimeno |
rubenwardy: thanks, I didn't know that, they used to be disabled |
| 15:32 |
|
Wuzzy joined #minetest-dev |
| 16:07 |
|
Fixer_ joined #minetest-dev |
| 16:14 |
|
Zughy joined #minetest-dev |
| 16:22 |
|
Edgy1 joined #minetest-dev |
| 16:26 |
Zughy |
hey guys, what does player sao stand for? The sao part |
| 16:28 |
PGimeno |
Server Active Object |
| 17:27 |
Zughy |
ty :) |
| 17:28 |
Krock |
again this discussion? |
| 17:28 |
Krock |
Zughy: stands for the series, ofc. |
| 17:28 |
Zughy |
that's unfortunately the first thing that crossed my mind |
| 17:30 |
Zughy |
btw it'd be nice to have some sort of file to help developers understanding the code structure (if it doesn't exist already) |
| 17:30 |
Zughy |
because, you know, tons of classes.. and things like server.cpp not inside the server folder |
| 17:31 |
Krock |
network auth: https://github.com/minetest/minetest/blob/master/src/clientiface.h#L39 |
| 17:31 |
sfan5 |
having an IDE (or text editor) that can take you to the place of definition by just clicking is immensely helpful |
| 17:31 |
Krock |
^ |
| 17:31 |
Krock |
though with lots of action queues that's not always a fast method |
| 17:32 |
Krock |
modding is usually a good entry into figuring out how things are connected |
| 17:33 |
Krock |
from that point it'll be easy to figure out what's actually behind the API |
| 17:33 |
Krock |
but please don't ask me about liquid flow or light spreading |
| 17:36 |
|
Wuzzy joined #minetest-dev |
| 17:36 |
sfan5 |
>src/hud.cpp and src/client/hud.cpp both exist |
| 17:37 |
sfan5 |
oh god why |
| 17:37 |
sfan5 |
Krock: do you happen to know why the statbar textures are supposedly 12x12? they draw as 24x24 on my system |
| 17:38 |
sfan5 |
nvm |
| 17:39 |
sfan5 |
it appears what Wuzzy in game#2655 has been misinterpreted |
| 17:39 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2655 -- heart.png and bubble.png are distorted |
| 17:39 |
sfan5 |
MTG's textures shouldn't be scaled down to 12x12 but rather scaled up to 24x24 so they are a multiple of the default size |
| 17:40 |
Wuzzy |
Correct. |
| 17:40 |
sfan5 |
but An0n3m0us put work into scaling them down to 12x12 which confused me |
| 17:40 |
Wuzzy |
16×16 → 12×12 |
| 17:40 |
Zughy |
yeah it is useful sfan5 , but sometimes it's not enough |
| 17:41 |
Wuzzy |
probably just removed the empty pixels at the border, so there is no visible distortion |
| 17:41 |
Wuzzy |
the current 16×16 texutre has empty pixels around the heart |
| 17:41 |
Wuzzy |
probably to emulate some sort of padding... idk |
| 17:45 |
Wuzzy |
sfan5: is 12×12 really an issue even if 24×24 is the default? given that 24 is multiple of 12... The screenshot clearly shows the heart texture renders crisp, with no distortion at all. so why is it a problem? |
| 17:46 |
Wuzzy |
("the screenshot" = the screenshot posted by An0n3m0us in game#2655) |
| 17:46 |
ShadowBot |
https://github.com/minetest/minetest_game/issues/2655 -- heart.png and bubble.png are distorted |
| 18:09 |
sfan5 |
Wuzzy: no it's not an issue, but it means e.g. the bubble texture has to be modified to work at 12x |
| 18:09 |
Wuzzy |
which is what An0n3m0us did? |
| 18:10 |
sfan5 |
yes, but I prefer the looks to remain identical |
| 18:11 |
|
Fixer joined #minetest-dev |
| 18:25 |
|
Taoki joined #minetest-dev |
| 18:34 |
|
fluxflux joined #minetest-dev |
| 18:52 |
Wuzzy |
me too ? |
| 18:58 |
sfan5 |
the gui scaling filter makes it look less pixel-y, not sure if that's desired |
| 18:59 |
sfan5 |
but if that isn't a problem the output of the guiscalingfilter can be saved to png (its 24x24) and be used to replace the texture |
| 19:16 |
|
longerstaff13 joined #minetest-dev |
| 19:32 |
Zughy |
how can I obtain the new item in hand with Player::getWieldedItem()? It always returns the previous slot |
| 19:32 |
Zughy |
and also what's the difference between selected and hand? |
| 19:43 |
sfan5 |
which slot it returns probably depends on when you call it |
| 19:44 |
sfan5 |
selected and hand infuence the behaviour of the item returned |
| 19:44 |
sfan5 |
since in some cases you want to get the item that is actually used for digging/attacking even if the player is holding nothing at all |
| 19:55 |
Zughy |
ty |
| 21:15 |
Zughy |
hey sfan5 : all in a single commit https://gitlab.com/zughy-friends-minetest/minetest/-/commit/08be7818cf79646cee387c7cda149c850ecf01a4 |
| 21:16 |
sfan5 |
the first issue I see is that some(?) lines use spaces, Minetest only uses tabs |
| 21:17 |
Zughy |
oh sure, let me fix and squash it |
| 21:18 |
sfan5 |
the second is: why does the engine expect on_wield to sometimes return an item? |
| 21:18 |
sfan5 |
and the third is missing documentation in lua_api.txt |
| 21:22 |
Zughy |
..well, it seems fair (about 1 and 3). I'll fix it tomorrow, I wasn't that much aware of the guidelines, my bad |
| 21:26 |
|
Taoki joined #minetest-dev |
| 21:41 |
Zughy |
so wait, I should remove the try-catch? Because in all honesty we didn't manage to understand that part so we simply looked at similar functions |
| 21:43 |
sfan5 |
lines 106-112 check if the function returned an item, read it and pass the changed item back to the caller |
| 21:43 |
sfan5 |
you can remove that and then also change " ScriptApiItem::item_OnWield(ItemStack &item" to " ScriptApiItem::item_OnWield(const ItemStack &item" |
| 21:44 |
|
_Zaizen_ joined #minetest-dev |
| 21:48 |
Zughy |
ooooh right |
| 21:52 |
Zughy |
I'll have a friend of mine creating a PR on GitHub to not bother you guys "privately" here |
| 21:54 |
sfan5 |
that's fine too and makes the whole process easier for us |
| 22:09 |
|
longerstaff13 joined #minetest-dev |
| 22:20 |
|
Taoki joined #minetest-dev |
| 22:33 |
|
ssieb joined #minetest-dev |
| 22:34 |
|
nore joined #minetest-dev |
| 22:48 |
|
Miner_48er joined #minetest-dev |
