Minetest logo

IRC log for #minetest-dev, 2018-01-09

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:15 turtleman joined #minetest-dev
00:22 rubenwardy web#111
00:22 ShadowBot https://github.com/minetest/m​inetest.github.io/issues/111 -- Update customize page by rubenwardy
00:26 * VanessaE growls at Krock across the aether.
00:51 basicer Anyone have any luck building 0.5.0 on MINGW?
01:09 Foz joined #minetest-dev
01:23 Lone-Star just run linux in a vm, a whole lot easier than trying to build in a windows environment
01:28 basicer I ran it on travis, it builds okay, but it doesnt run.
01:29 basicer * built it on travis.
01:29 Lone-Star prolly a missing lib?
01:31 Lone-Star or check if the bin is executable
01:31 basicer something to do with pthread
01:33 Lone-Star ahh, seems mingw cant find the path to pthread
01:39 Lone-Star or is missing support for pthreads
01:48 pgimeno_ oops, I missed #6243 until now
01:48 ShadowBot https://github.com/minetest/minetest/issues/6243 -- Load dependencies and description from mod.conf by rubenwardy
01:50 pgimeno_ I guess it has some interrelationships with my latest PR
01:53 * pgimeno_ sighs and goes to bed
01:54 rubenwardy :)
01:57 pgimeno_ hm, something that occurred to me before I go... would the modpacks fix be considered a bacpatchable PR? I guess it's probably too complex for that, but it's a bugfix in a sense
01:57 pgimeno_ backportable* not backpatchable
01:58 pgimeno_ I'm not familiar with this project's backport policies if there are any. I'm only kind of familiar with the ones from PostgreSQL since I followed their lists for a while.
01:59 paramat possibly, any bugfix has a chance
02:02 pgimeno_ k, thanks
02:42 paramat joined #minetest-dev
02:46 YuGiOhJCJ joined #minetest-dev
02:50 ssieb joined #minetest-dev
02:56 YuGiOhJCJ joined #minetest-dev
03:26 Lone-Star joined #minetest-dev
04:21 Hijiri daily reminder #6688
04:21 ShadowBot https://github.com/minetest/minetest/issues/6688 -- Custom particle generators for particle spawners by raymoo
04:58 Darcidride joined #minetest-dev
05:10 Lunatrius` joined #minetest-dev
07:19 nerzhul joined #minetest-dev
07:29 YuGiOhJCJ joined #minetest-dev
07:46 YuGiOhJCJ joined #minetest-dev
10:39 nerzhul joined #minetest-dev
11:15 Darcidride joined #minetest-dev
11:19 Darcidride joined #minetest-dev
11:31 nerzhul joined #minetest-dev
11:48 nerzhul joined #minetest-dev
12:18 Jordach joined #minetest-dev
12:25 Fixer joined #minetest-dev
13:08 nerzhul joined #minetest-dev
15:07 twoelk joined #minetest-dev
15:27 rubenwardy Hijiri: I am very interested in that PR, just busy with exams atm'
15:30 RobbieF joined #minetest-dev
15:34 RobbieF left #minetest-dev
15:38 clavi joined #minetest-dev
15:42 Megaf https://github.com/minetest/minetest/issues/6899
15:42 Megaf I dont know how to properly name the issue
15:42 Megaf #6899
15:42 ShadowBot https://github.com/minetest/minetest/issues/6899 -- https://github.com/minetest/minetest/pull/6648 Breaks many mods.
15:42 Megaf feel free to edit it
15:46 nerzhul joined #minetest-dev
15:49 pgimeno_ hi nerzhul! can you explain what problem does #6898 not solve and why? I am scratching my head at your comment.
15:49 ShadowBot https://github.com/minetest/minetest/issues/6898 -- Allow distinguishing mods by modpack by pgimeno
16:10 rubenwardy left #minetest-dev
16:40 ThomasMonroe joined #minetest-dev
17:24 Krock joined #minetest-dev
17:36 Raven262 joined #minetest-dev
17:46 pgimeno_ any idea why github has revealed my GH real email address?
17:50 Krock pgimeno_, this means that you're using the real email address in your local git client. GH can only correct/hide those which are from the Web editor
18:01 Krock merging rather trivial #6896 in 5 minutes
18:01 ShadowBot https://github.com/minetest/minetest/issues/6896 -- Fix off-by-one in log output line length by pgimeno
18:02 pgimeno_ thanks
18:04 rubenwardy joined #minetest-dev
18:13 nerzhul joined #minetest-dev
18:24 Darcidride_ joined #minetest-dev
18:27 * VanessaE pokes Krock with an errant callback
18:27 * red-001 makes LuaJIT allocate too much memory
18:28 VanessaE red-001: that's no big feat :P
18:30 * Krock reads
18:32 Krock VanessaE, I see the problem but how are we going to solve it? The on_placenode callback seems obvious for all nodes that were placed using item_place_node, which is used by rotate_node.
18:32 VanessaE it didn't before....
18:32 Krock The after_place_node is however only for new placed nodes, for constructing purposes or whatever
18:32 VanessaE that function strictly used set_node() originally
18:33 Krock like "it works, don't touch it"?
18:35 VanessaE more like "saw no reason to use place functions in a helper that was already being called by a place callback"
18:39 Krock sounds like moving MTG's on_place stuff to after_place_node
18:39 VanessaE anyway I think you should revert your commit since the fix is worse than the bug...
18:40 VanessaE if you wanna trigger the needed callbacks, do so from outside of the rotate function
18:41 VanessaE I wish I understood MT's codebase better, I'd have more constructive suggestions.
19:02 Krock VanessaE, well, I can't find any opportunity to run these callbacks without causing an endless loop for that particular mod. All the 21 occurrences in my mods/ and 18 in games/ use it as on_place, which means that none of them can make use of the after_place_node - after the node was successfully added. And there's no non-hacky way for rotate_node to detect whether it was called from after_place_node or on_place
19:02 Krock TL;DR: this is getting real complicated
19:14 VanessaE then leave it "broken" (revert your commit) and document it as such?
19:15 VanessaE better to have a known deficiency in the API than hundreds of broken calls.
19:16 VanessaE but still, why can't this be fixed in the engine?
19:16 VanessaE or in the code that handles placing nodes
19:17 VanessaE doing it from rotate_node is wrong, and sooner or later there'll be another function that appears to behave wrong in the same way
19:21 ssieb joined #minetest-dev
19:22 pgimeno_ is it a problem in one specific mod?
19:39 VanessaE no.
19:39 VanessaE https://github.com/minetest/minetest​/issues/6899#issuecomment-356348282
20:07 Krock joined #minetest-dev
20:21 Darcidride_ joined #minetest-dev
20:27 YuGiOhJCJ joined #minetest-dev
20:53 compunerd joined #minetest-dev
22:08 Gael-de-Sailly joined #minetest-dev
22:10 antims joined #minetest-dev
22:46 Lone-Star joined #minetest-dev
23:00 paramat joined #minetest-dev
23:11 Fixer joined #minetest-dev
23:52 Xio joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext