Minetest logo

IRC log for #minetest-dev, 2017-12-22

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:03 paramat joined #minetest-dev
00:08 Sonos joined #minetest-dev
00:14 Shara joined #minetest-dev
00:16 basicer why not?
00:19 Hijiri If they point the client to a different server list then that list won't have any servers since no servers report to it
00:43 sofar you can fetch and merge server lists
01:06 red-001 sofar, ver_string is just the suffix
01:06 red-001 like 0.4.16 or beta.35.3
01:07 red-001 you can detect that a client isn't minetest based on it but getting with a media server would be more accurate
01:07 red-001 getting it*
01:08 sofar yeah, I'm thinking of seeing if that data can be easily recovered somehow
01:08 sofar then again, it can be turned off to easily in a build
01:08 red-001 don't think me send the full version string over the standard protocol
01:08 red-001 something, something stop people from using it to version check
01:30 EvergreenTree joined #minetest-dev
02:10 SonosFuer joined #minetest-dev
02:28 EvergreenTree joined #minetest-dev
03:15 paramat joined #minetest-dev
03:38 CBugDCoder joined #minetest-dev
03:55 bulldog1_ joined #minetest-dev
05:28 Fritigern joined #minetest-dev
05:54 Fritigern joined #minetest-dev
06:12 Fritigern joined #minetest-dev
07:10 nerzhul joined #minetest-dev
07:37 Fritigern joined #minetest-dev
07:48 compunerd joined #minetest-dev
08:01 ensonic joined #minetest-dev
08:25 Darcidride joined #minetest-dev
08:54 YuGiOhJCJ joined #minetest-dev
08:57 YuGiOhJCJ joined #minetest-dev
09:41 celeron55 joined #minetest-dev
09:50 Darcidride joined #minetest-dev
10:08 rubenwardy Merging #6816 and #6817 as trivial bug fixes in 15
10:08 ShadowBot https://github.com/minetest/minetest/issues/6816 -- mainmenu: Fix error if config setting menu_last_game does not name a … by nOOb3167
10:09 ShadowBot https://github.com/minetest/minetest/issues/6817 -- msvc: Fix condition where an attempt to take the address of zero-th e… by nOOb3167
10:28 Raven262 joined #minetest-dev
10:28 rubenwardy Merging...
10:32 nerzhul joined #minetest-dev
10:35 rubenwardy Done
10:35 rubenwardy Also, almost trivial fix
10:36 rubenwardy #6818
10:36 ShadowBot https://github.com/minetest/minetest/issues/6818 -- Fix rounding error in g/set_node caused by truncation to float by rubenwardy
10:41 rubenwardy Messed up the message, force pushed
11:16 Jordach joined #minetest-dev
11:26 Fixer joined #minetest-dev
11:27 rubenwardy Huh
11:28 rubenwardy Unit test fails on read/getF1000
11:41 EvergreenTree joined #minetest-dev
11:44 rubenwardy !tell paramat please may you not add unnecessary prefixes to commits? Eg: Vector functions: Fix vector.direction() function, improve documentat…
11:44 ShadowBot rubenwardy: O.K.
12:05 rubenwardy Anyone know of a portable way or testing if a character is valid for a text file?
12:06 rubenwardy I guess something like isPrintable || isWhitespace
12:06 rubenwardy Hmmmm
12:18 rubenwardy Now, how to check for serialised version without hacks 🤔
12:49 EvergreenTree joined #minetest-dev
12:59 YuGiOhJCJ joined #minetest-dev
13:01 ThomasMonroe joined #minetest-dev
13:04 YuGiOhJCJ joined #minetest-dev
13:14 nop joined #minetest-dev
13:16 CBugDCoder joined #minetest-dev
13:21 Krock joined #minetest-dev
13:32 fwhcat joined #minetest-dev
13:32 ensonic joined #minetest-dev
13:45 lisac joined #minetest-dev
14:13 SonosFuer joined #minetest-dev
16:05 Taoki joined #minetest-dev
16:14 ensonic joined #minetest-dev
17:00 YuGiOhJCJ joined #minetest-dev
17:02 YuGiOhJCJ joined #minetest-dev
17:08 Darcidride_ joined #minetest-dev
17:30 ensonic joined #minetest-dev
17:49 twoelk joined #minetest-dev
17:53 nerzhul joined #minetest-dev
18:23 Raven262 joined #minetest-dev
18:51 RobbieF joined #minetest-dev
19:25 Puka joined #minetest-dev
20:00 KaadmY joined #minetest-dev
20:00 KaadmY joined #minetest-dev
20:11 Krock joined #minetest-dev
20:32 RobbieF left #minetest-dev
20:40 EvergreenTree joined #minetest-dev
21:56 sfan5 merging game#1666 in 5 minutes
21:56 ShadowBot https://github.com/minetest​/minetest_game/issues/1666 -- Creative: Use icons for buttons. by kaeza
22:03 DI3HARD139 joined #minetest-dev
22:32 paramat joined #minetest-dev
23:07 EvergreenTree joined #minetest-dev
23:07 paramat i think we should start closing the lower priority 'adoption needed' PRs. they're wastng dev time because if open we have to reassess them over and over again
23:08 paramat i propose: a neglected PR is closed after a month, as per guidelines, unless it is high priority, in which case it is labelled 'adoption needed'
23:08 rubenwardy yeah
23:08 rubenwardy agreed
23:08 rubenwardy there's lots with possible close
23:09 rubenwardy lets close loads on the 31st to meet my 100 PRs by Jan 1st goal ;)
23:09 ThomasMonroe paramat, the PR for the refresh button just need some adjustment and it could get merged
23:09 paramat currently all neglected PRs are being labelled 'adoption needed' then hang around for months with no interest. we're being far too lenient, maybe this is why the guidelines state the 1 month rule
23:10 ThomasMonroe the search and refresh just need to be closer together
23:10 rubenwardy also, #6818 is fairly simple
23:10 ShadowBot https://github.com/minetest/minetest/issues/6818 -- Fix rounding error in g/set_node caused by truncation to float by rubenwardy
23:10 rubenwardy yeah
23:11 Warr1024 if you love them, set them free.  The bugs that people ACTUALLY care about will come back to you.
23:11 rubenwardy exactly
23:11 rubenwardy I
23:12 rubenwardy I
23:12 rubenwardy ARGH
23:12 paramat closed PRs are not lost at least. we could even label neglected low-priority ones 'adoption needed' and also close them, just so the label can be used in a search
23:12 rubenwardy I'd argue the keeping them open is more damaging then having them as future reference material
23:12 paramat we have 33 adoption needed, that's one third
23:12 rubenwardy as it looks like we ignore PRs (which we have in the past) rather than them being incomplete
23:12 rubenwardy (which we probably still do)
23:13 rubenwardy (reviewing big PRs is painful and time consuming)
23:13 paramat 6818 seems good, let me look again, i'll probably +1
23:14 Warr1024 every issue tracker has 2 regions: those bugs that are getting closer to resolution, and those that are getting further away.  The ones that are getting progressively buried are nothing but compost, and it's actually more dishonest than anything to keep them around as if anyone is actually paying attention to them...
23:15 paramat wise
23:15 Warr1024 when you cut the dying section of the backlog loose, you give the community an opportunity to give you feedback about what they REALLY care about, too...
23:17 Warr1024 For an issue to remain in the backlog, somebody needs to either work on it, OR keep resubmitting it.  If it's not even worth that to them, then it's not worth it to you...
23:18 Warr1024 I once had someone ask me if a bug that I had submitted 2 years ago was still relevant to me.  I told them that I didn't even remember bugs I'd submitted 2 weeks ago, and I had no way to know if it was still reproducible, but clearly it hadn't bothered me if I'd lived with it for 2 years.
23:19 Warr1024 Ironically, in the end, they decided to keep the bug anyway :-/
23:31 twoelk it becomes family if it just hangs around long enough
23:48 paramat +1 for 6818

| Channels | #minetest-dev index | Today | | Google Search | Plaintext