Minetest logo

IRC log for #minetest-dev, 2014-09-12

| Channels | #minetest-dev index | Today | | Google Search | Plaintext

All times shown according to UTC.

Time Nick Message
00:00 ShadowNinja We've already found two wrong bugs...
00:02 kahrl got it! gist coming in a second
00:02 ShadowNinja It's at EOF.
00:03 ShadowNinja Oh...
00:05 kahrl https://gist.github.com/kahrl/b4a0337320beeaa48227
00:05 ShadowNinja \o/ fixed!  Thanks for all the help kahrl!
00:08 proller why not autolock ?
00:08 ShadowNinja proller: Becuase m_clients isn't a JMutex, it's a ClientInterface.
00:09 kahrl proller: ClientInterface only has public Lock and Unlock methods, but the mutex is private
00:09 proller too hard to make mutex public  ?
00:09 kahrl idk, I didn't write that code
00:09 kahrl I already said it's ugly ;)
00:11 proller but why to make continue-uglying fixes ?
00:12 kahrl you're free to fix it in freeminer
00:13 kahrl but I don't want to make massive changes to server-related locks in a commit / pull request that is about settings
00:14 ShadowNinja Right now it's a branch, no PR and multiple commits.  I'll make one soon though so I don't forget it.
00:18 kahrl ShadowNinja: why not fix both typos at once? :)
00:20 ShadowNinja kahrl: Double-tapping?
00:22 kahrl yes
00:22 kahrl not sure about the dash, but either with or without should be fine
00:24 kahrl it seems "Double tapping" is most common
00:24 kahrl but Double-tapping is common too
00:26 ShadowNinja kahrl: While you're here, any thoughts on https://github.com/minetest/minetest/pull/1606 ?
00:27 ShadowNinja (Or, for that matter, any of my pulls)
00:28 kahrl I haven't really formed an opinion on it yet
00:29 kahrl but is there any way to allow the irc mod to keep working? it's a very popular mod
00:35 kahrl code-wise there's too much macro stuff going on for my taste
00:40 ShadowNinja kahrl: This patch makes the IRC mod work, the user just has to add irc to their secure_trusted_mods: http://sprunge.us/eWUf
00:40 ShadowNinja I'll try to reduce the macros since the concensus seems to be that they're used too much.
00:41 kahrl ah, I didn't check the latest changes
00:48 kahrl ShadowNinja: create_schematic should check the filename too
00:49 kahrl and everything that reads a schematic specifier probably
00:49 ShadowNinja kahrl: Alright, thanks.
01:19 ShadowNinja hmmmm: replacements = {{"oldname", "convert_to"}, ...} -- Why didn't you use {["old_name"]="convert_to"}?  It would require far less tables and seems like it would work just as well.
01:20 kahrl ShadowNinja: don't blame hmmmm on that one, that was me
01:21 VanessaE don't go changing that now
01:21 ShadowNinja kahrl: Ah, then why did you do it?
01:21 VanessaE but DO go ahead and fix the fact that it can't handle stacks.
01:21 kahrl ShadowNinja: the reason is that with the latter, you can't specify multiple different replacement for the same item, with the former you can
01:21 ShadowNinja VanessaE: But changing it compatibly would make it faster and more memory efficient.
01:22 kahrl replacements*
01:22 ShadowNinja kahrl: So it choses randomly ammong them?
01:22 kahrl no, in the order they appear
01:22 kahrl and speed doesn't really matter in register_craft
01:23 VanessaE ShadowNinja: if you're gonna change anything about that, make it able to properly replace whole stacks of oldname with an equal quantity of convert_to.
01:23 ShadowNinja kahrl: I'm talking about create_schematic.
01:23 kahrl oh!
01:23 VanessaE OH
01:23 kahrl well in that case, yes blame hmmmm :P
01:23 VanessaE haha
01:24 kahrl but I guess he just followed register_craft's example
01:24 ShadowNinja create_schematic is fixed now and the macros are reduced.
01:25 ShadowNinja kahrl: But if you have {{"X", "Y"}, {"X", "Z"}} then won't there be no X left by the time the second replacement is run?
01:25 kahrl ShadowNinja: no, the first one just replaces one of the X's
01:26 ShadowNinja Oh.  I don't think that's what create_schematic does though.
01:26 kahrl probably not
01:30 ShadowNinja It literally just does for k, v in pairs(...) do dschem.replacements[v[1]] = v[2] end, so it can't have a purpose.
01:31 kahrl it does mean it's syntactically in sync with crafting replacements, though
01:31 kahrl consistency is good in an API
01:35 ShadowNinja kahrl: It does something different though, and it results in needing a lot more tables.  Also, the code for reading the sub-tables is longer and slower.
01:36 ShadowNinja +14 -7 and It supports both methods.
01:38 ShadowNinja http://sprunge.us/GRbh?diff
01:40 kahrl ShadowNinja: seems good, ask hmmmm if he's okay with it though
01:40 ShadowNinja (that needs proper documentation of course)
01:42 Miner_48er joined #minetest-dev
02:05 hmmmm ShadowNinja, that was PilzAdams
02:05 hmmmm PilzAdam's rather
02:05 hmmmm I am not able to see that link
02:06 ShadowNinja hmmmm: https://gist.github.com/Shad​owNinja/051520b509f2e939184c
02:07 hmmmm looks good
02:07 hmmmm there's another thing that does replacements too in that file, look for another
02:24 ShadowNinja hmmmm: I changed it to use a static function and updated the docs, gist updated.
02:25 ShadowNinja I'll push as soon as you give the word.
02:26 hmmmm sure
02:34 blaise what is this? 21:27:17: ERROR[ServerThread]: ServerEnv: Trying to store id=16399 statically but block (5,0,5) already contains 520 objects. Forcing delete.
02:34 blaise the number is counting up
02:34 blaise same location,
02:34 blaise it was at 519
02:34 blaise now it's at 523
02:34 blaise so manny objects
02:34 blaise I go there and there's nothing there
02:35 blaise well, "air" I suppose
02:40 blaise 21:36:18: ERROR[ServerThread]: ServerEnvironment::deactivateFarObjects(): id=18096 m_static_exists=true but static data doesn't actually exist in (5,0,5)
02:40 blaise interesting
02:41 VanessaE ^^^^ this is consistent with what I experienced on some of my servers.
02:41 blaise I placed cobble in it, and it still happened..
02:41 blaise when I put cobble above it and dug the cobble, it stopped it
02:42 blaise at 5, 1, 5
02:42 blaise weird, no?
02:43 VanessaE 5,1,5 are mapblock coordinates
02:43 blaise yes I know
02:43 VanessaE multiply by 16 to get world coordinates
02:44 VanessaE is anyone looking into this?
02:44 blaise it's relatively close to my spawn area
02:44 VanessaE /clearobjects is not sufficient to remove these errant objects
02:44 VanessaE because they just don't exist
02:44 blaise indeed,
02:45 * VanessaE wanders off for a bit
02:45 blaise but I placed a cobble block in the 5, 0, 5 and nothing happened,
02:45 blaise dug it out, nothing happened
02:45 blaise when I put cobble directly above it in 5, 1, 5 it still happend
02:45 blaise when I dug the cobble, it stopped what ever was occuring
02:47 blaise I believe what ever caused that anomaly was what was causing my lag
02:47 blaise I'm down to about 0.5 to 0.6 seconds with me logged in over the lan
03:06 OldCoder joined #minetest-dev
03:27 blaise it's back
03:27 blaise 22:26:56: ERROR[ServerThread]: ServerEnv: Trying to store id=23871 statically but block (5,0,5) already contains 524 objects. Forcing delete.
03:27 blaise crap
03:27 blaise OldCoder: hello.. :)
03:28 Zeno` joined #minetest-dev
03:29 Zeno` I thought I'd better let people know I'm attempting to clean up main.cpp
03:29 OldCoder blaise, Hi!!
03:37 sol_invictus joined #minetest-dev
04:05 RealBadAngel hi
04:05 RealBadAngel https://github.com/minetest/minetest/pull/1617/
04:05 RealBadAngel ive updated node highlighting pull
04:07 RealBadAngel it should look better at night or when underground, effect depends now on light level not just time of day
04:09 OldCoder joined #minetest-dev
04:30 RealBadAngel https://www.youtube.com/watch?v=i8DeXIERQ4Q
05:05 Hunterz joined #minetest-dev
07:00 NakedFury joined #minetest-dev
07:32 book` joined #minetest-dev
08:40 Amaz joined #minetest-dev
09:29 jin_xi joined #minetest-dev
09:49 Zeno` well, it's busy
09:49 Zeno` RealBadAngel, I like the new node highlights
09:51 Zeno` I think at night the nodes should become brighter, but I don't mind how it is right now (in the youtube link)
09:52 Zeno` Much less distracting (for me) than the node boxes being lit up
09:53 RealBadAngel its not just at night, effect depends on the lights around
09:53 Zeno` yeah, I just noticed that
09:53 Zeno` in any case I like the effect
09:54 RealBadAngel im also adding setting to disable crack animations, highlighting + dig particles does look way better than cracks + selection boxes
09:57 Zeno` I'll wait to see the video
10:56 PenguinDad joined #minetest-dev
10:58 ImQ009 joined #minetest-dev
11:02 proller joined #minetest-dev
11:23 proller joined #minetest-dev
12:22 proller joined #minetest-dev
12:25 Hunterz joined #minetest-dev
12:35 NakedFury joined #minetest-dev
12:39 Megaf Hi everyone
12:39 Megaf ShadowNinja: Hi
12:40 Megaf Folks, I'd like to suggest something on clearobjects. They all could have a tag, then the clearobjects would just read the map db and clear objects tagged on runtime
12:41 Megaf [04:29:34] <Zeno`> I thought I'd better let people know I'm attempting to clean up main.cpp
12:41 Megaf Thanks a million Zeno`
12:41 Megaf as a player and pseudo developer I apreciate that.
12:42 Megaf [03:44:28] <VanessaE>  /clearobjects is not sufficient to remove these errant objects
12:42 Megaf hm, And maybe there could be two types of objects clearing, one that clears floating things and text on signs. And one that cleans everything that is not a node?
12:43 Megaf all change in code in mods would be tagging them or creating a default and standard type of entity
12:43 Megaf I believe you already are doing something like that.
12:44 Zeno` Megaf, I'm about half way through. I just want to understand it and as it was it was too unwieldly. Through the process I've found a couple of bugs (not fixed but commented) and also redundant code (doing things more than once)
12:45 Megaf Zeno`: Please, as important as clean up is comenting the code, so other developers whiling to help wont be lost.
12:45 Megaf I know all this takes lots of time and pacience and can be frustrating at times
12:45 PenguinDad Megaf: but don't except to much from the main.cpp clean up
12:46 Megaf Zeno`: You doing that in a fork?
12:46 Megaf Or another branch?
12:58 Zeno` PenguinDad, why not?
12:58 Zeno` I think understandable is... good
13:00 Zeno` And my cleanup is still messy but at least it's getting understandable now. I'm only restructuring atm (splitting stuff into functions) and will refactor after that's done but already there are "strange" things that pop out just because thing are in functions
13:00 Zeno` I don't think it's a worthless task
13:02 Zeno` Megaf, https://github.com/Zeno-/minetest/b​lob/refactor_main/src/main.cpp#L722    keep in mind that this is nowhere near finished (see comment at top of source file)
13:36 AnotherBrick joined #minetest-dev
13:39 casimir joined #minetest-dev
14:30 Megaf RealBadAngel: https://github.com/minetest/minete​st/pull/1617#issuecomment-55410661
14:37 Zeno` you might be right with option #2 Megaf
14:37 Zeno` the thing I don't like about node boxes being highlighted is that it looks like a debugging setting
14:38 Amaz https://github.com/minetest/minete​st/pull/1617#issuecomment-55411224
14:38 Zeno` And that's another option, Amaz :)
14:38 Amaz :D
14:39 Zeno` I really hate the node boxes ("outline") being displayed as they current are
14:39 Zeno` currently*
14:40 Megaf Amaz: I like your idea
14:40 Amaz It works nicely.
14:40 Amaz I'm using that patch now, and I really like it.
14:41 Amaz RBA's patch with the speed set to 0
14:41 hmmmm joined #minetest-dev
14:42 Zeno` There will be no consensus on this because it's all pretty subjective, so I live the idea of adding a speed setting as suggested by Amaz
14:44 Amaz It's also pretty awesome with a setting of 20.
15:16 OldCoder joined #minetest-dev
15:31 Weedy joined #minetest-dev
15:31 Weedy joined #minetest-dev
15:33 SmugLeaf joined #minetest-dev
15:33 SmugLeaf joined #minetest-dev
15:34 Weedy joined #minetest-dev
15:34 Weedy joined #minetest-dev
15:40 Calinou joined #minetest-dev
15:44 monty joined #minetest-dev
15:56 superdave1 joined #minetest-dev
16:10 JZTech101 joined #minetest-dev
16:11 JZTech101 joined #minetest-dev
16:15 khonkhortisan joined #minetest-dev
16:19 Krock joined #minetest-dev
16:27 casimir joined #minetest-dev
16:29 OldCoder joined #minetest-dev
16:38 rubenwardy joined #minetest-dev
16:44 RealBadAngel Megaf, option #2 wont work. it wont be visible on all nodes
16:46 VanessaE RealBadAngel: I told ya, you'll have to give users some kind of configurable lighting range :)
16:46 VanessaE <user1>  it's too dark!  <user2> no way, gtfo its too bright!
16:50 OldCoder joined #minetest-dev
16:52 RealBadAngel i will fine tune to look nicely on all kind of nodes
16:52 RealBadAngel instant color is not an option
16:52 RealBadAngel and it will be pulsating
16:53 RealBadAngel also, its gonna be menu setting, dont like, dont turn it on
16:55 VanessaE remember it needs to be a spinbox, so that the user can't accidentally totally disable all selection highlighting
16:55 VanessaE selectbox -> pulsating highlight -> both -> selectbox...
16:55 proller joined #minetest-dev
16:56 RealBadAngel so what if he disables that?
16:57 RealBadAngel two left handed user? turn it on again
16:57 VanessaE then we have to field complaints that "I dont see the thing Im pointing at HALP"
16:57 VanessaE in other words, don't let the user turn it off entirely if there's no logical reason - they can already do that with F1 anyway
16:58 VanessaE don't give them a second way to disable selectboxes
16:58 VanessaE s/selectboxes/selection features/
16:59 RealBadAngel atm it will stay as config setting only
16:59 RealBadAngel main menu looks like trashcan
17:00 VanessaE heh
17:00 RealBadAngel i dont have any place to add gfx settings at all
17:00 VanessaE make a new tab then :P
17:01 RealBadAngel i need a tab with whole page that can be scrolled
17:01 RealBadAngel that damn dropbox with drivers was enough for me
17:03 RealBadAngel btw, im testing now gameplay with just highlighting and dig particles, as for me it looks way better
17:06 Calinou joined #minetest-dev
17:18 proller joined #minetest-dev
17:21 Amaz joined #minetest-dev
17:21 Amaz joined #minetest-dev
17:35 nore joined #minetest-dev
17:36 VanessaE ok, yet another person with that Win8 000[.*]007b error in the 64 bit build, and before that missing OpenAL
17:36 VanessaE wtf folks?
17:36 VanessaE FIX THIS SHIT
17:37 VanessaE I may sound like MegaF here :P and I generally hate Windows, but this shit must not be allowed to persist.
17:37 sfan5 VanessaE: BlockMen decided not to include OpenAL with his builds
17:38 VanessaE sfan5: and those are the official builds being downloaded from minetest.net?
17:38 VanessaE why?
17:38 sfan5 yes
17:38 sfan5 why? dunno, ask him
17:38 VanessaE why are they STILL there is my question.
17:38 VanessaE users have a hard enough time installing Minetest, nevermind googling around for OpenAL
17:38 sfan5 still there?
17:39 sfan5 dunno
17:39 sfan5 I've heard on many occasions that the MinGW builds work without any hassle
17:39 sfan5 but it's not my decision which buils to put in bold
17:39 * VanessaE grumbles
17:40 VanessaE [09-12 13:38] <grendal_prime> did not whats the difference  <---- see what I mean?
17:40 Megaf it seems like there's no official builds at all
17:40 sfan5 there are
17:40 sfan5 did you look at http://minetest.net/download ?
17:40 VanessaE sfan5: that's the whole point here
17:41 VanessaE the official builds are not working for more people than was the case for 0.4.9
17:41 VanessaE and no one is addressing this
17:41 VanessaE and the problem isn't some bug in minetest for once :P
17:41 VanessaE '
17:41 sfan5 I would
17:41 sfan5 but
17:41 sfan5 <sfan5> it's not my decision which buils to put in bold
17:41 VanessaE I know.
17:42 VanessaE but there are other devs in here whose decision it IS to do that
17:42 sfan5 technically it's celeron55's decision which build should be the recommended one
17:42 VanessaE well now he's been pinged.
17:42 sfan5 at least I don't think we have someone for those decisions
17:43 sfan5 (I'm aware, I thought about putting a zero-width space somewhere to not highlight him, but this issue should be addressed anyway so I didn't)
17:43 * Megaf volunteers to be in charge of decisions
17:43 Amaz joined #minetest-dev
17:44 VanessaE Megaf: you?
17:44 VanessaE HAHHHHH
17:44 * VanessaE falls over
17:44 PenguinDad lol
17:44 Megaf at least I will have some decisions... At the moment we have none
17:44 Megaf no one is in charge of anything
17:45 Megaf and everyone is in charge of nothing
17:49 VanessaE sfan5: it needs addressed immediately - I expect we're about to get flooded with Minecraft refugees and there needs to be a no-fuss install to point people at.
18:00 Krock joined #minetest-dev
18:07 Krock joined #minetest-dev
18:49 BlockMen joined #minetest-dev
18:49 BlockMen sfan5, wut? http://irc.minetest.ru/minet​est-dev/2014-09-12#i_3909357
18:49 sfan5 BlockMen: am I not correct=
18:50 BlockMen yes. i dont know where you got that from
18:50 BlockMen it seems i forgot to put the file into the zip
18:51 sfan5 umm
18:51 sfan5 all of your builds don't have OpenAL
18:51 BlockMen no?
18:51 sfan5 if someone has problems you tell them to install openal
18:51 kaeza joined #minetest-dev
18:51 sfan5 at least thats what I observed
18:51 BlockMen i include them in my builds, and i told them that it is better in general
18:52 BlockMen *to install openal
18:52 sfan5 oh
18:52 BlockMen so, should i update the download?
18:53 sfan5 nah
18:53 sfan5 leave it as is
18:53 BlockMen y?
18:53 VanessaE doesn't matter about openal anyway if the official 64 bit build is busted on win8.
18:53 BlockMen ^?
18:53 BlockMen VanessaE, can you provide more informations?
18:53 VanessaE BlockMen: A number of users are greeted with some error code, 00[.*]00fb
18:54 VanessaE and this is allegedly on 64 bit machines/64 bit win8.  the 32 bit build works in those cases
18:54 VanessaE The MSVC build, specifically.
18:58 BlockMen sfan5, why not?
19:13 kaeza joined #minetest-dev
19:28 celeron55 what?
19:28 celeron55 is there no openal in recommended builds?
19:28 celeron55 if that is the case, fix that shit
19:28 celeron55 it's not a common library on windows
19:29 sfan5 afaik the msvc build lack openal dlls
19:29 sfan5 there's also some error with windows 8
19:29 BlockMen it for 64 builds, it seems i forgot to include it :\
19:29 celeron55 the recommended download should work directly on a freshly installed windows 7
19:30 celeron55 that is my requirement
19:30 BlockMen and for the win8 thing i would need more infos, since it works for jordach
19:30 BlockMen and i will update the download in a few min
19:31 sfan5 I can test on win8
19:36 Miner_48er joined #minetest-dev
19:45 Amaz Any hope of this pull request getting merged soon? https://github.com/minetest/minetest_game/pull/294
19:46 VanessaE celeron55: <offtopic>  about the original jungle tree, do you know if it was based on any particular tree such as the strangler fig (as wrapped around something else anyway)?
19:47 VanessaE s/know/remember/
19:48 PilzAdam joined #minetest-dev
19:49 sfan5 BlockMen made a new 64-bit build, but it is 1) flagged as malware by chrome and 2) produces error 0x000007b like VanessaE reported
19:50 NakedFury joined #minetest-dev
19:50 BlockMen now the interesting question is: what is the difference between sfan5's win8 and Jordachs's win8
19:51 sfan5 the windows
19:51 VanessaE metro vs classic or whatever it's called?
19:51 sfan5 win8 is always metro and classic
19:51 sfan5 anyway
19:52 sfan5 if this doesn't get sorted out we could make the 64-bit MinGW build the default
19:52 BlockMen sfan5, the 64 bit builds are not highlighted at all...
19:53 BlockMen so there is no "default"
19:53 sfan5 yes
19:53 sfan5 the left on is de facto the default
20:05 kahrl joined #minetest-dev
20:08 Krock Btw, is there a chance to add a link on the minetest site which leads to my Win32 indev builds? http://minetest.net/download#unofficial_builds
20:09 celeron55 VanessaE: yes it was based on a few photos i found on the internet
20:10 VanessaE celeron55:  ok
20:10 celeron55 i wasn't searching for any particular tree though
20:11 BlockMen ok, the msvc 64bit build is updated
20:11 BlockMen works on win8 now aswell (tested by sfan5)
20:12 BlockMen idk what makes chrome think its "bad", maybe the combination of dropbox and "zip with executable"...
20:12 BlockMen its not confirmed to be shown for github (the official download)
20:14 celeron55 VanessaE: i tried to search for it, but no result seemed like what i was using
20:15 VanessaE celeron55: no worries.
20:33 BlockMen googles "Safe Browsing" claims to use blacklists. would they really put dropbox.com on it?
21:01 BlockMen left #minetest-dev
21:38 proller joined #minetest-dev
21:38 diemartin joined #minetest-dev
21:45 blaise joined #minetest-dev
21:45 celeron55_ joined #minetest-dev
21:48 VargaD joined #minetest-dev
21:48 mberends joined #minetest-dev
21:50 Miner_48er joined #minetest-dev
21:51 VanessaE joined #minetest-dev
21:58 proller joined #minetest-dev
22:12 realbadangel_ joined #minetest-dev
22:13 Taoki_1 joined #minetest-dev
22:19 Megaf_ joined #minetest-dev
22:20 Ritchie_ joined #minetest-dev
22:21 ImQ009_ joined #minetest-dev
22:21 sfan5 joined #minetest-dev
22:21 CraigyDavi` joined #minetest-dev
22:23 superdave joined #minetest-dev
22:27 proller joined #minetest-dev
22:32 khonkhortisan_ joined #minetest-dev
22:33 kahrl_ joined #minetest-dev
22:36 VargaD joined #minetest-dev
22:37 sfan5_ joined #minetest-dev
22:38 CraigyDavi`` joined #minetest-dev
22:39 ImNotQ009 joined #minetest-dev
22:39 blaaaaargh joined #minetest-dev
22:42 JZTech101 joined #minetest-dev
22:42 le683 joined #minetest-dev
22:43 mrtux joined #minetest-dev
22:45 Miner_48er joined #minetest-dev
22:48 ImQ009 joined #minetest-dev
22:49 hintss joined #minetest-dev
22:49 celeron55 joined #minetest-dev
22:50 VanessaE joined #minetest-dev
22:51 ImQ009 joined #minetest-dev
22:55 sfan5 joined #minetest-dev
22:57 Taoki joined #minetest-dev
23:05 PenguinDad joined #minetest-dev
23:12 CraigyDavi joined #minetest-dev
23:13 JZTech103 joined #minetest-dev
23:14 blaaaaargh joined #minetest-dev
23:18 PilzAdam joined #minetest-dev
23:23 mrtux joined #minetest-dev
23:27 celeron55 joined #minetest-dev
23:28 JZtech101 joined #minetest-dev
23:38 deltib joined #minetest-dev
23:38 PenguinDad joined #minetest-dev
23:42 rmilan joined #minetest-dev
23:42 hax404_ joined #minetest-dev
23:43 GhostDoge joined #minetest-dev
23:44 superdave1 joined #minetest-dev

| Channels | #minetest-dev index | Today | | Google Search | Plaintext