Time  Nick        Message
01:59 cheapie     TIL that rollback bug I inadvertently created like 6 years ago is still there
01:59 cheapie     ...I should probably fix that one
01:59 cheapie     Eek, even more than that, 10 years ago apparently
02:01 cheapie     https://github.com/luanti-org/luanti/commit/380e1504eb2445fd43c03c87d23b8e41e85a7871 - it's the result of me coming across code written by someone who didn't seem to really understand indexing, and then trying to fix it while I *also* didn't really understand indexing :P
02:04 cheapie     Really should probably be in index on `action`(`x`,`y`,`z`,`timestamp`) and a second one on `action`(`timestamp`,`actor`) or maybe `action`(`actor`,`timestamp`), to match the sorts of queries /rollback_check and /rollback do, respectively
02:04 cheapie     s/in index/an index/
02:06 cheapie     The one I had ended up putting in there actually isn't too terrible for /rollback_check (but I don't think the coverage of the actor column is doing anything for that) but /rollback is pretty awful like this.
14:46 MTDiscord   Command sent from Discord by luatic:
14:46 MTDiscord   !tell cheapie Thanks for the hint, I'll check it out. (Frankly I've never personally cared much about rollback since I feel it makes, has to make, some game-specific decisions for 'attributing' causes of things happening in-world but quite a few servers use it so if we can easily improve performance, let's do that.)
14:46 MinetestBot MTDiscord: yeah, yeah
15:06 MTDiscord   <luatic> cheapie: Looking at the queries, timestamp, actor should be the way to go.
15:06 MTDiscord   <luatic> As an additional index.
15:13 MTDiscord   <luatic> cheapie: #15707
15:13 ShadowBot   https://github.com/minetest/minetest/issues/15707 -- Restore proper rollback database indexing by appgurueu
15:52 MinetestBot 02[git] 04sfan5 -> 03luanti-org/luanti: Update github URL references (#15705) 13b5e084c https://github.com/luanti-org/luanti/commit/b5e084c9a50526f0dfd8a0602a2607e636e83cb9 (152025-01-24T15:50:39Z)
15:52 MinetestBot 02[git] 04grorp -> 03luanti-org/luanti: Add setting callbacks for Camera and TouchControls (#15700) 1341dfac9 https://github.com/luanti-org/luanti/commit/41dfac96c109c234ded442f110b90c43b4c3e379 (152025-01-24T15:50:51Z)
15:52 MinetestBot 02[git] 04appgurueu -> 03luanti-org/luanti: Restore proper rollback database indexing (#15707) 137c6ade0 https://github.com/luanti-org/luanti/commit/7c6ade0fc5d4fccb3af190f54ca869a799fc3782 (152025-01-24T15:50:59Z)
16:51 cheapie     luatic: That was fast, and pretty much exactly what I would have sent in too :P
16:51 MinetestBot cheapie: Jan-24 14:46 UTC <MTDiscord> Thanks for the hint, I'll check it out. (Frankly I've never personally cared much about rollback since I feel it makes, has to make, some game-specific decisions for 'attributing' causes of things happening in-world but quite a few servers use it so if we can easily improve performance, let's do that.)