Time |
Nick |
Message |
00:56 |
|
ireallyhateirc2 joined #minetest |
00:57 |
|
x_3 joined #minetest |
00:58 |
|
figboot joined #minetest |
00:59 |
|
Lunatrius` joined #minetest |
01:00 |
|
Norkle_ joined #minetest |
01:01 |
|
sugarbee1 joined #minetest |
01:04 |
|
Pexin joined #minetest |
01:08 |
|
LainExperiments joined #minetest |
01:49 |
|
LainExperiments joined #minetest |
01:59 |
cheapie |
TIL that rollback bug I inadvertently created like 6 years ago is still there |
01:59 |
cheapie |
...I should probably fix that one |
01:59 |
cheapie |
Eek, even more than that, 10 years ago apparently |
02:01 |
cheapie |
https://github.com/luanti-org/luanti/commit/380e1504eb2445fd43c03c87d23b8e41e85a7871 - it's the result of me coming across code written by someone who didn't seem to really understand indexing, and then trying to fix it while I *also* didn't really understand indexing :P |
02:04 |
cheapie |
Really should probably be in index on `action`(`x`,`y`,`z`,`timestamp`) and a second one on `action`(`timestamp`,`actor`) or maybe `action`(`actor`,`timestamp`), to match the sorts of queries /rollback_check and /rollback do, respectively |
02:04 |
|
diemartin joined #minetest |
02:04 |
cheapie |
s/in index/an index/ |
02:06 |
cheapie |
The one I had ended up putting in there actually isn't too terrible for /rollback_check (but I don't think the coverage of the actor column is doing anything for that) but /rollback is pretty awful like this. |
02:09 |
|
LainExperiments joined #minetest |
02:11 |
|
silverwolf73828_ joined #minetest |
02:44 |
|
Can0xfBows joined #minetest |
02:57 |
|
liceDibrarian joined #minetest |
03:00 |
|
SFENCE_arch joined #minetest |
03:13 |
|
Verticen joined #minetest |
05:00 |
|
MTDiscord joined #minetest |
05:22 |
|
liceDibrarian joined #minetest |
05:47 |
|
Kimapr joined #minetest |
06:25 |
|
SFENCE_arch joined #minetest |
06:40 |
|
Kimapr_ joined #minetest |
08:04 |
|
amfl2 joined #minetest |
08:12 |
|
tibtoblezob joined #minetest |
08:36 |
|
MTDiscord joined #minetest |
09:01 |
|
ireallyhateirc joined #minetest |
09:22 |
|
gregon joined #minetest |
09:30 |
|
tarsovbak joined #minetest |
09:31 |
|
PoochInquisitor joined #minetest |
09:42 |
|
kimapr joined #minetest |
10:14 |
|
Kimapr_ joined #minetest |
10:42 |
|
kimapr joined #minetest |
10:47 |
|
kimapr joined #minetest |
11:03 |
|
Alnotz joined #minetest |
11:34 |
|
pgimeno joined #minetest |
12:10 |
|
SFENCE joined #minetest |
12:13 |
|
mrkubax10 joined #minetest |
13:36 |
|
Leopold joined #minetest |
13:38 |
|
PoochInquisitor joined #minetest |
13:44 |
|
Guest25 joined #minetest |
14:06 |
|
gregon joined #minetest |
14:13 |
|
tarsovbak joined #minetest |
14:36 |
|
diemartin joined #minetest |
14:46 |
MTDiscord |
Command sent from Discord by luatic: |
14:46 |
MTDiscord |
!tell cheapie Thanks for the hint, I'll check it out. (Frankly I've never personally cared much about rollback since I feel it makes, has to make, some game-specific decisions for 'attributing' causes of things happening in-world but quite a few servers use it so if we can easily improve performance, let's do that.) |
14:46 |
MinetestBot |
MTDiscord: yeah, yeah |
15:06 |
MTDiscord |
<luatic> cheapie: Looking at the queries, timestamp, actor should be the way to go. |
15:06 |
MTDiscord |
<luatic> As an additional index. |
15:13 |
MTDiscord |
<luatic> cheapie: #15707 |
15:13 |
ShadowBot |
https://github.com/minetest/minetest/issues/15707 -- Restore proper rollback database indexing by appgurueu |
15:32 |
|
ireallyhateirc joined #minetest |
15:37 |
|
mrkubax10 joined #minetest |
15:52 |
MinetestBot |
[git] sfan5 -> luanti-org/luanti: Update github URL references (#15705) b5e084c https://github.com/luanti-org/luanti/commit/b5e084c9a50526f0dfd8a0602a2607e636e83cb9 (2025-01-24T15:50:39Z) |
15:52 |
MinetestBot |
[git] grorp -> luanti-org/luanti: Add setting callbacks for Camera and TouchControls (#15700) 41dfac9 https://github.com/luanti-org/luanti/commit/41dfac96c109c234ded442f110b90c43b4c3e379 (2025-01-24T15:50:51Z) |
15:52 |
MinetestBot |
[git] appgurueu -> luanti-org/luanti: Restore proper rollback database indexing (#15707) 7c6ade0 https://github.com/luanti-org/luanti/commit/7c6ade0fc5d4fccb3af190f54ca869a799fc3782 (2025-01-24T15:50:59Z) |
16:18 |
|
jaca122 joined #minetest |
16:51 |
cheapie |
luatic: That was fast, and pretty much exactly what I would have sent in too :P |
16:51 |
MinetestBot |
cheapie: Jan-24 14:46 UTC <MTDiscord> Thanks for the hint, I'll check it out. (Frankly I've never personally cared much about rollback since I feel it makes, has to make, some game-specific decisions for 'attributing' causes of things happening in-world but quite a few servers use it so if we can easily improve performance, let's do that.) |
18:27 |
|
mrkubax10 joined #minetest |
18:56 |
|
Desour joined #minetest |
19:20 |
|
LainExperiments joined #minetest |
19:21 |
|
greeter joined #minetest |
19:42 |
|
mrkubax10 joined #minetest |
20:06 |
|
Verticen joined #minetest |
20:06 |
|
SFENCE joined #minetest |
20:11 |
|
tibtoblezob joined #minetest |
20:24 |
|
liceDibrarian joined #minetest |
21:01 |
|
jaca122 joined #minetest |
21:04 |
|
illwieckz joined #minetest |
21:18 |
|
silverwolf73828_ joined #minetest |
21:22 |
|
liceDibrarian joined #minetest |
21:34 |
|
diceLibrarian2 joined #minetest |
22:00 |
|
simon816 joined #minetest |
23:23 |
|
Talkless joined #minetest |
23:30 |
|
Talkless joined #minetest |
23:33 |
|
panwolfram joined #minetest |