Time Nick Message 00:33 kyle56 and now! for something no one asked for!! My list of the top 3 most anticipated features coming to minetest 5.9.0! number 3, pointability override. number 2, set_bone_override(), and number 1! URL buttons. 03:52 Blockhead256 !tell kyle56: sounds good. You could post it over in the "New feature hypte thread" -> https://forum.minetest.net/viewtopic.php?t=29936 03:52 MinetestBot Blockhead256: Do not put an : at the end of nickname 03:52 Blockhead256 !tell kyle56 sounds good. You could post it over in the "New feature hypte thread" -> https://forum.minetest.net/viewtopic.php?t=29936 03:52 MinetestBot Blockhead256: I'll pass that on when kyle56 is around 03:52 Blockhead256 thank you MinetestBot 03:52 Blockhead256 mwah 11:41 shaft Requesting review of https://github.com/minetest/minetest_game/pull/3123 and merge of https://github.com/minetest-mods/mesecons/pull/669 14:59 shaft I have a stupid issue 15:00 MTDiscord Welcome to the club 15:00 MTDiscord Meetings are on the 32nd of each month 15:00 shaft I added universal wood support to my mod Tables and Chairs. I did it with minetest.register_on_mods_loaded and now the inventory recipes tab doesn't show the recipes anymore. 15:01 shaft I suspect it's doing the same thing 15:01 shaft Can I set some priority flag or something? 15:02 ireallyhateirc I think recipes can be only registered before runtime 15:02 ireallyhateirc and "on_mods_loaded" is after that 15:03 shaft registering works just fine anytime. They are craftable 15:03 shaft Just don't show up in the recipes list 15:05 ireallyhateirc perhaps the code that is responsible for getting recipe list runs before all mods get loaded? 15:06 ireallyhateirc try not using minetest.register_on_mods_loaded and see what happens 15:06 MTDiscord shaft: chances are the mod that shows recipes also uses register_on_mods_loaded 15:06 shaft I have a better idea 15:06 MTDiscord and ends up running before your mod, because it registers first 15:06 shaft I hijack register_nodes 15:06 MTDiscord if what lars says is correct, just insert your callback at the front of the stack 15:07 MTDiscord one possible hack would be to do something like table.insert(1, minetest.registered_on_mods_loaded, function(...) ... end) to ensure that you run "first" 15:07 MTDiscord (what wsor said) 15:14 shaft That works but not with my crafting mod. (because it's a mod and thus not guaranteed to be loaded first) 15:14 shaft May not work with other inventory mods too 15:16 MTDiscord what 15:17 MTDiscord this is for the mod that registers recipes in on_mods_loaded, not for the crafting mod 15:17 MTDiscord the crafting mod wants to run last, not first, to catch all recipes 15:17 MTDiscord otherwise it could hook the recipe registration functions 15:19 MTDiscord the mod that registers recipes wants to run its on_loaded before the crafting mod's on_loaded runs 15:22 shaft No, you're right. 15:25 shaft btw table.insert has the table as first argument luatic 15:25 shaft Works great 15:28 MTDiscord yeah shaft you're right, i mixed the order up there 15:30 sfan5 sounds like the crafting mod should be using minetest.after(0) 15:33 shaft But MTGs inventory mod isn't either. It's fine. I think prepending to minetest.registered_on_mods_loaded is a great solution. 15:34 sfan5 no, it's a hack 15:34 shaft How? 15:35 shaft Even if I fixed up my crafting mod and I may do that, I still can't expect all games and mods by other people to do the same thing, so I have to do it this way for my furniture mod 15:36 MTDiscord minetest loading in general is a hack, it gets worse when your doing mapgen things, given they dont actually error, just silently fail 15:39 sfan5 it is a solution for you in your mods, but multiple mods cannot truly be "first" and this might also depends on the loading order relative to the crafting mod. so in short, the craftings mods still have to be fixed or it will just be bandaid 15:40 ireallyhateirc would be great if MT offered a way to specify mod loading order, afaik currently we have only " Allow game to specify first and last mod in mod loading order (#14177) " 15:40 ShadowBot https://github.com/minetest/minetest/issues/14177 -- Allow game to specify first and last mod in mod loading order. by sfence 15:41 shaft Yes but inventory mods will append and mods that add recipes prepend and then the order is good enough 15:42 shaft I don't expect people to make a mod for furniture mod. 15:42 shaft my furniture mod 15:43 shaft I expect woods to be added during the "regular" mod loading 15:45 sfan5 ireallyhateirc: and what happens if two mods want to load first? 15:46 sfan5 there's a reason the PR only defined this for games 15:46 MTDiscord something like "reverse dependencies" as in "load before this mod" could be considered but tbh i think this would result in a mess 15:47 shaft Who even cares, who's really first? Some people may think they absolutely have to be first but then someone makes a mod that has to load before that person. 15:47 ireallyhateirc you mean in my imaginary feature? I guess mods could declare what they need and based on that they'd get loading order 15:47 MTDiscord i agree with sfan5 that the authors of mods need to provide proper APIs - or run at proper points in time 15:48 MTDiscord in this case, what would be needed would rather be hooking of recipe registration, which can already be done. or, assuming recipes can't / aren't registered after on_mods_loaded, minetest.after(0, ...) as sfan said. 15:48 ireallyhateirc sfan5, though I'm not a maintainer of a mod soup so I don't really know what exactly would be needed or if there's a use case 15:48 MTDiscord ireallyhateirc: this just sounds like our current dependency-based system with extra steps. 15:58 ireallyhateirc well I guess solving problems like having two mods that want to modify default:foobar is the responsibility of a maintainer of the mod soup 16:04 shaft Anyway, who will handle my PR? https://github.com/minetest/minetest_game/pull/3123 16:04 shaft I really want those cacti fixed. 16:04 shaft Just the thought that someone is generating upside down cacti somewhere on earth horrifies me. 16:04 MTDiscord i'm kinda tempted to just smack the approve button, but first i'll have to ensure there's no jia tanning happening here lol. the joys of binary files... 16:05 shaft Yes, please test 16:06 MTDiscord I will, just let me finish some engine things first 16:06 shaft okay 17:07 shaft My wishlist for 5.9: texture aliasing, fallback styling for ui elements, glTF support 17:08 MTDiscord given only one of those has a pr unlikely, also if the core devs decide to start feature freeze any time soon gltf wont make it in as its a feature 17:10 shaft Come on. Texture aliasing shouldn't be too much work and is absolutely crucial 17:10 shaft My texture pack basically can't do shit except support tiny mods and MTG without it. 17:11 MTDiscord there only 81 other prs to pick from before one that doesnt exist. also that one issue is only one in 1.2k 17:11 shaft Gotta prioritize right 17:11 MTDiscord if you want to improve the odds, write the pr 17:12 shaft Merge my fucking PRs before telling me to create new ones 17:12 MTDiscord you dont have any engine prs 17:12 MTDiscord i mean, convincing devs that something is high value / low effort is also a good idea to improve the odds, but doesn't really help when the devs already have plenty of stuff going on :P 17:13 shaft Mhttps://github.com/minetest-mods/mesecons/pull/669 17:13 shaft https://github.com/minetest/minetest_game/pull/3123 17:13 MTDiscord anyways i'll test your MTG PR now 17:13 MTDiscord you made prs two both orgs/repos that are known to take forever with prs lol 17:14 shaft That's always your excuse. Then make it quicker 17:15 MTDiscord im not a member of either of those. the orgs im a part of and cdb are much faster 17:33 MacroFaxSax shaft: STFU 17:34 shaft what's wrong with you? you always bitch about nothing 17:35 MacroFaxSax Don't cry now. :/ 17:39 MinetestBot 02[git] 04mruncreative -> 03minetest/minetest_game: Fix upside down nodes in large cactus schematic (#3123) 135116192 https://github.com/minetest/minetest_game/commit/511619253facd524df75ae44537d7b2c4e30a8db (152024-06-02T17:38:35Z) 17:39 MTDiscord shaft: we need no "excuses", i don't get what you're complaining about here; your MTG PR hasn't even been waiting for a single day 17:40 MTDiscord and yes, it's definitely important that different orgs and teams have different load and different expected response times 17:40 shaft I'm not trying to offend. Just being pushy, so we push forward 17:41 MTDiscord being pushy doesn't have any advantage over polite probing 17:42 shaft Polite probing does even less 17:43 definitelya shaft: So you are a troll after all. 17:43 shaft With the amount of work I put into my packages and PRs, definitely not 17:46 sfan5 fortunately quality of work cannot compensate for good manners 17:47 ROllerozxa "you attract more bees with honey than with vinegar" 17:48 shaft Bees are annoying as fuck, yet you keep them. Same with me 17:48 MTDiscord speaking from personal experience, yes sometimes i forget, or prioritize poorly, etc etc, and then i appreciate a polite reminder. 17:48 MTDiscord if however someone is being "pushy" or rude, this will slightly annoy me, especially if i planned to get to them anyways. 17:48 MTDiscord this will make me (or other devs) less inclined to work with you, as you've already seen in the past, and will continue to see in the future, if you don't improve your manners. 17:49 MTDiscord when we have to choose between working with someone who respects us and our time and someone who doesn't - or at least doesn't communicate this properly - we're inclined to pick the former. 17:50 shaft I just couldn't think of a better pun than "pushy". Don't take my words apart 17:50 shaft I do respect you and your work 17:52 MTDiscord happy to hear that, however it doesn't come across that way if you write things like "That's always your excuse. Then make it quicker", which sounds pretty demanding (note: in reply to someone who isn't involved in reviewing your PRs) 17:55 shaft I mean your (plural as a community). Maybe I should say our. 17:55 shaft It's our excuse. (me included) 17:57 MTDiscord phrasing it that way would certainly have helped, but still i think it doesn't go in the right direction 17:58 MTDiscord a better idea would be to actually suggest and discuss ways to reduce wait times - if that is deemed necessary. do we need more reviewers? if so, where can we get them in the long run? do we need to triage stricter? etc etc. 18:02 shaft I did that. I already proposed myself to review packages on contentDB occasionally. 18:03 MTDiscord contentdb already has an average 2 day turn around time, now the bus factor on the other hand 18:04 MTDiscord shaft: even if that had a positive impact on CDB, that would've hardly impacted engine or MTG dev 18:06 MTDiscord (not to mention that, even if a team is severely understaffed (which the CDB team doesn't seem to be?), a solid foundation of trust first needs to be established) 18:06 shaft Well if I can't do it then you need to do it and I don't see how it's any different for those repos 18:07 shaft you (plural) 18:12 MTDiscord anyways, minetest engine org, and minetest-mods org slowness has been discussed at length before. while still not ideal, both seem to at least gotten somewhat better 18:24 MTDiscord now if you want to see a trival pr that takes about two seconds to approve and has been in hell for two weeks ............. https://github.com/minetest/minetest/pull/14680 18:25 MTDiscord let me guess it's GX's PR 18:25 MTDiscord yes lol 18:26 MTDiscord pokes lars to review it 18:55 ireallyhateirc Minetest doesn't need .mtl files produced by Blender? 18:55 MTDiscord correct 18:56 ireallyhateirc great, time to trash them :) 19:05 MinetestBot 02[git] 04grorp -> 03minetest/minetest: Allow toggling fullscreen without restart and add keybind (#14714) 13833bb54 https://github.com/minetest/minetest/commit/833bb542fce78e2f94ca1b568c0b988234155621 (152024-06-02T19:05:16Z) 19:05 MinetestBot 02[git] 04grorp -> 03minetest/minetest: Document keymap_toggle_block_bounds, remove unimplemented BLOCK_BOUND… 13508b5cc https://github.com/minetest/minetest/commit/508b5ccc6386de700d39ff6e885d3dc553fd7d28 (152024-06-02T19:05:35Z) 20:03 shaft I found a real issue: Even when the formspec isn't being rewritten, sometimes it doesn't react to clicks. I first thought my mouse was being fucky but it's not the case. Like when you spam on an item in your inventory it only reacts to every third click but the scrollbar is sometimes not activating too. 20:03 shaft In MTG inventory. 20:04 shaft The thing with the item only being picked up is the same in VoxeLibre. 20:04 shaft But the scrollbar behaviour is weird 20:10 shaft ENGINE BUG. 20:11 shaft I just had my mouse over a wide scrollbar clicked on it and the little scroller wouldn't move to it. 20:12 shaft And it happens especially often when you just moved the curser on top of the scrollbar! 20:19 shaft You can try reproducing it in my mod commit 5c4909d7e86698c642c074d9d128fa22f2079516 https://gitgud.io/blut/simple_crafting/ 20:20 shaft The world scrollbar in the main menu works fine though, so it can't be an engine bug. 20:21 shaft What a pain. 20:22 shaft Does the main menu use formspec? 20:25 MTDiscord yes 20:25 MTDiscord file an issue with a minimally reproducable example please 20:25 shaft But the main menu works. It must be with the games then right? 20:26 MTDiscord main menu has basically the same formspec api as games do 20:36 Mantar did you click a tab? 5.8.0 has a bug where the formspec loses focus when you click a tab and nothing works until you click the formspec again 20:36 MTDiscord shaft: this sounds an awful lot like #14702 20:36 ShadowBot https://github.com/minetest/minetest/issues/14702 -- Fix scrolling in scroll containers by appgurueu 20:37 shaft The fuck 20:37 MTDiscord if it is the tab bug, you could try #14661 - but that wouldn't explain losing "every third click" or something like that, so the former seems more plausible 20:37 ShadowBot https://github.com/minetest/minetest/issues/14661 -- Fix inventory items unresponsive after tab interaction until LMB click on formspec by sfence 20:38 MTDiscord shaft: could you check whether one of these PRs fixes your issue? 20:39 shaft No idea. Am I supposed to compile all of those and test? 20:39 shaft I'm playing with an appimage on linux mint 20:39 MTDiscord finally, there is also in principle the option of another, overlapping element preventing the event from "getting through"; but again this should be consistent. hence why i think 14702 is most likely. 20:40 MTDiscord shaft: yes, you'd have to compile these to test 20:41 MTDiscord anyways afk 20:41 shaft But yes, not all events come through it seems. When I click on an inventory item slowly, it picks it up but when I spam the mouse button it picks it up on the first click does nothing on the second, and places it down on the third 20:42 shaft I'm not sure this is related to the scrollbar though or intented behaviour 20:42 shaft It just feels weird 20:42 Mantar that is weird 21:48 shaft Damn I'm retarded. A fucking scrollcontainer was overlapping just slightly on the left. I don't know why though. The scrollbar had position x 3 width 0.4 and the overlapping scrollbar had position x 4.5 21:50 shaft * The scrollbar had position x 3 width 0.4 and the overlapping scroll_container had position x 4.5 21:50 shaft How does that math even work? 21:51 shaft Why is 3+0.4 > 4.5 21:53 shaft I feel the width and height don't use the same units as the x and y 21:53 shaft Can someone explain that? 21:53 shaft https://content.minetest.net/packages/shaft/simple_crafting/ 21:54 shaft That's the mod. Just install and you'll notice the left edge of the scrollbar doesn't work because the right scrollcontainer overlaps with it. 21:54 shaft But why? 21:56 Mantar which coordinate system are you using? 21:57 shaft formspec 21:58 MTDiscord you mod uses formspec v1, have fun with that hell hole 21:59 shaft Why are there different formspecs? 21:59 Mantar yeah the old coord system was a terrible kludgey mess, you want to switch to the new coord system if possible 21:59 shaft Can't you use the newest one by default? 21:59 MTDiscord >= v2 21:59 MTDiscord nope 22:00 shaft PLEASE 22:00 Mantar because the system was cobbled together all nibbly bibbly, and then mods began using it, so the MT team couldn't remove the old system, they had to build a new one alongside it 22:00 MTDiscord formspecs are client side, so typically you want to pick the minum minetest version you want to support 22:00 MTDiscord see https://github.com/minetest/minetest/blob/master/doc/lua_api.md#version-history 22:00 Mantar recent FS versions are much nicer and more sensible 22:01 MTDiscord i mean, fs1 to fs2 was the big improvement due to cords system. after that its just the same terrible formspec system 22:01 Mantar MT can't assume you want the new version though or old mods will break 22:01 MTDiscord you can write for the latest version and then let fs51 handle back compat ish 22:03 shaft I put formspec_version[7] before size but nothing changes 22:03 MTDiscord 5.4 is a good minium minetest version to pick for support, becuase you get all the useful new formspec elements, and also thats when the new node alpha params became a thing 22:07 shaft do you need to prepend formspec before everything or just the size element? 22:08 shaft Where do I need to put it in my mod? 22:12 shaft why does mtg not contain "formspec_version["? 22:20 shaft Okay prepending formspec_version[7] to the entire inventory formspec works but it screws it up. Am I supposed to remake the inventory or can I just throw a container or window on top of it that is formspec 7? 22:27 shaft real_coordinates[true] after size does just that. Thank god 23:24 shaft damn I'm so tired now. Thanks for helping me out wsor. I'll go to bed now 23:29 Mantar 'night 23:41 ireallyhateirc is there a way to disable Minetest's map overgeneration?