Time  Nick        Message
02:47 Bluebird    Ok, so I've run into a problem with `minetest.register_on_player_hpchange()`. The short of it is that the 'hp_change' argument isn't the actual amount of damage done --- it's the amount that the player's HP will change by, never allowing HP to go below 0.
02:48 Bluebird    This means I can't use 'hp_change' to know how much damage *would* be done by the weapon, in the usual case.
02:50 Bluebird    ATM I'm thinking that I'm going to have to save the 'damage' obtained from minetest.register_on_punchplayer(), and retrieve it later in minetest.register_on_hpchange().
02:50 MTDiscord   <Warr1024> I ran into similar issues.  It seems like the closest-to-sane thing to do is just lie to the engine, tell it the player has oodles of HP, then divert the damage to an alternate system.  Unfortunately, that means you have to do all the work of establishing an alternate standard and maintaining an API.
02:50 Bluebird    Except that ... will not work if the damage is caused by a mob, I think?
02:51 MTDiscord   <Warr1024> hooking up the damage on punchplayer only works for damage done by mobs, and won't cover stuff like falling or environment damage.
02:51 Bluebird    Yes, your right (I hit enter too quicky, I see what you're saying)
02:55 Bluebird    Darn. I'm already using the max allowed HP range (0 - 65535) for players.
02:56 Bluebird    I may end up having to rethink the other problem that caused me to start looking into this.
16:51 MinetestBot 02[git] 04Desour -> 03minetest/minetest: GUIEditBox: Use primary selection 13062b4d0 https://github.com/minetest/minetest/commit/062b4d036a38d21539f56d7ef8000dae094c46cf (152023-04-27T16:50:17Z)
16:51 MinetestBot 02[git] 04Desour -> 03minetest/minetest: GUIChatConsole: Use primary selection 13e9e8eed https://github.com/minetest/minetest/commit/e9e8eed36065609b927b0a5a316771b887d1b316 (152023-04-27T16:50:17Z)
16:52 MinetestBot 02[git] 04Desour -> 03minetest/minetest: Reduce number of recursively included headers 138b73743 https://github.com/minetest/minetest/commit/8b73743baacb710500b0efef5fbc4ba65d0ed28b (152023-04-27T16:50:33Z)
16:52 MinetestBot 02[git] 04Desour -> 03minetest/minetest: Use json forward-declarations 137f6b09d https://github.com/minetest/minetest/commit/7f6b09dce82be5c2a881c075ca76c5ac8f84ad52 (152023-04-27T16:50:33Z)
19:41 fluxionary  is it considered a bug that if 1 item is aliased to another, they don't stack? i don't see any issues discussing this.
19:58 MTDiscord   <Jonathon> no idea if its considered a bug, but its something that some mods exist to patch/some mods check for this while others do not
19:58 MTDiscord   <Jonathon> seems worthwhile to file an issue as a feature request if nothing else
20:29 fluxionary  how would mods patch for fix this?
20:29 fluxionary  oh i see https://content.minetest.net/packages/SFENCE/items_update/
20:34 sfan5       nodes updates when aliased so why shouldn't items?
20:34 sfan5       update*
20:40 MTDiscord   <Jonathon> never bothered to look why (yes, sorry), just know its an issue
21:25 fluxionary  alright i'll create an issue for it
21:27 MTDiscord   <Jonathon> i suppose its probably best to file it as a bug, always can change the labels later