Time Nick Message 02:01 rubenwardy !title https://twitter.com/fsf/status/1505621504762990593 02:01 MinetestBot No title found. 02:10 Pexin twitter hasnt been a website for a while now. NothingButApp 06:53 bluejay55 Yo 06:53 bluejay55 Wait actually lemme try something 10:09 MTDiscord Anybody know what is the lua code for noclip? I think that doesn’t exist but giving a try is a good idea. 10:18 sfan5 noclip is implement in C++ in the client 10:18 sfan5 +ed 10:20 MTDiscord yeah i know, is there a way to make it in lua 10:24 sfan5 nope 10:25 MTDiscord okay. 10:31 MTDiscord Hm, i have a doubt, can we write mods in C++? 10:53 ROllerozxa well you could, but it would have to be an engine fork 14:48 Philaire Heyo ! 14:57 MTDiscord Of course you can write mods in C++. You just can't run them [in Minetest]. 15:05 MTDiscord @Trahaswi What are you trying to do? 15:51 MTDiscord trying to make minetest user abilities in lua, such as noclip, fast, etc… I know that’s useless, but i want to try to do something, which is mind blowing. 15:51 MTDiscord Why not just grant and revoke the privs? 15:53 MTDiscord I suppose if you want to try to make a kind of noclip with the Lua API, you should try messing around with the player's collision properties 16:00 MinetestBot 02[git] 04x2048 -> 03minetest/minetest: Add API to control shadow intensity from the game/mod (#11944) 130f25fa7 https://github.com/minetest/minetest/commit/0f25fa7af655b98fa401176a523f269c843d1943 (152022-03-26T15:58:26Z) 18:59 MinetestBot 02[git] 04appgurueu -> 03minetest/minetest_game: Fix incorrectly negated comparisons 13638099c https://github.com/minetest/minetest_game/commit/638099c9999e46b9a7204858b2a7c7a1efb2f94c (152022-03-26T18:58:07Z) 19:34 erle appgurueu what is the result of this change? 19:34 erle like what bug does it fix? 19:46 Krock erle: code quality change only 19:47 erle Krock so no change in behaviour ig? 19:48 sfan5 honest question: why are you bothering the PR author instead of figuring out the implications yourself? 19:49 MTDiscord ^this 19:49 sfan5 (not to mention that he described the issue with the old code in the PR description) 19:50 Krock https://pastebin.com/raw/J4CgzmQ9 19:51 Krock "not" is evaluated before "==", hence the previous code was not working properly. this paste demonstrates this in the "lua"/"luajit" command line interpreter 19:52 Krock pretty sure the code worked previously because the API functions are tolerant to "nil" parameters 20:00 erle sfan5 i am bothering the PR author precisely because i could not figure it out myself and because appgurueu/luatic is one of the best lua explainers i have encountered. 20:01 sfan5 I'm surprised that you couldn't figure it out then 20:01 erle in general, i think a commit message that leaves dumbos like me with the question “what problem does this commit address” needs some work. but obviously a lot of people disagree with me here and think that domain knowledge should be taken for granted. 20:01 erle Krock, thanks 20:02 erle sfan5 i obviously didn't think too much about it. but the sentence that krock wrote would have helped me (i.e. "not" is evaluated before "==", hence the previous code was not working properly) 20:04 erle sfan5 just to spell it out: i am not lazy. i just think differently about problems and sometimes that means i get stuck on basic stuff like this and sometimes it means i find bugs that a lot of other ppl don't find. 20:04 erle everyone has blind spots 20:04 erle and apparently lua operator precedence was mine here 20:05 erle also i never looked at the PR, only at the git log 20:05 erle (that is arguably my fault, but also could have been avoided, well …) 20:24 MTDiscord Indeed I should probably have mentioned the implications (fixing pointed thing type checks) of this in the extended description instead of just leaving it in the related GH PR & issue. It also improves upon code quality tho. 20:39 erle i am not against the patch, but yeah, i think if it's important enough to mention in the PR it could be included in the commit msg 20:39 erle damn, now i wish again we had an easy way to search contentdb source code 20:40 erle would be neat to be able to figure out where else that construct is used 21:30 * Desour finds it funny and interesting that one can lift objects with collide_with_objects by flying below them and then upwards, and that it's just client-side. (but he doesn't think it's worth opening or searching for an issue)