Time Nick Message 00:23 erlehmann rubenwardy what would be the “standard” response to a bunch of players connecting from the same IP? like 40 01:13 MTDiscord Are they actually playing...? 01:43 erlehmann Warr1024 no it is just lag 01:55 MTDiscord Ah. I was wondering if there was a legit case of a ton of players from one place, like maybe an apartment building on effectively CGNAT or something. If they were at least attempting to play, that might be interesting... 03:15 Lesha_Vel hello 10:32 MTDiscord Desour: Fun fact: There was an attempt to overwrite it in a malicious PR, see https://github.com/joe7575/techage/pull/71 13:35 MTDiscord Wait I thought hybrid dog was one of the good modders, I can't believe he went to the dark side 13:43 CieNTi what is the dark side ? 13:44 MTDiscord Trying to hack into servers through malicious prs in mods or the game engine itself 13:44 CieNTi ough 13:45 MTDiscord Let's say there's a mod everyone uses, someone dumps a hidden bootstrap for base64 compiled code then decompiles it into a string and then runs it. The next time all those players and servers update they get affected 13:45 MTDiscord Ridiculous to even have the thought of doing that 13:47 MTDiscord I think the actual worst case scenario is somehow someone figures out how to trick the engine into turning off FFI safety mode completely, but that would require too much code not to be noticed unless the owner of the repo is just letting it be treated as a dumping ground 15:59 mazes_83 luatic are you joe7575 ? I tried to understand how malicious was this PR, in vain 16:35 MTDiscord Luatic does not have that alias 17:04 MTDiscord No, I'm not Joe 17:08 MTDiscord Wow that happened recently too, for some reason my brain was like jan 4 2021 17:09 MTDiscord No joe has a youtube channel https://www.youtube.com/channel/UCUH30AYhjaIOnHGeaUKToPA it's always fascinating to see what he's cooking up 22:20 Desour_ did you know? sometimes it can be important for security reasons to write stuff in one line 22:21 Desour_ debug.sethook really shouldn't be in the non-insecure env 22:22 erlehmann Desour_ explain 22:24 Desour_ well, debug.sethook can hook on function calls, returns, and lines https://www.lua.org/manual/5.1/manual.html#pdf-debug.sethook . so, if I now need to make some function atomar, i can write and read a lock variable atomarily in one line, multiple lines would be insecure 22:25 Desour_ ie. "assert(not a); a = b;" vs. "assert(not a); \n a = b;" 22:25 Desour_ or "a,b = b,a" vs. "a,b = b,\n a" 22:26 Desour_ funny, right? 22:37 rubenwardy Aren't those still separate statements 22:37 Desour_ that doesn't matter 22:40 Desour_ it seems the hook is called after every finished line with an expression or so 22:45 Desour_ oh no, I'm stupid 22:46 MinetestBot 02[git] 04x2048 -> 03minetest/minetest: Render shadows on entities. 132bba53b https://github.com/minetest/minetest/commit/2bba53b2c3f0045c326f6c7578104ffaef53ceac (152022-03-07T22:45:26Z) 22:46 MinetestBot 02[git] 04x2048 -> 03minetest/minetest: Apply shadow texture to wield-based entities 134e39cde https://github.com/minetest/minetest/commit/4e39cdef946e137519551bc77234bae2ee35a7f3 (152022-03-07T22:45:26Z) 22:47 Desour_ ok, I misunderstood the mask thing. you can just set it to "" and use the count to hook at every instruction 23:11 MTDiscord Question: is the 64000 node limit hardcoded into just the server, or the server and the client? Meaning, if I host a server of the fork/pr that breaks the limit, will I need a special client to take advantage of it? 23:13 erlehmann MisterE explain how to “break” the limit 23:13 erlehmann please 23:13 erlehmann i think your question is ill-formed unless you explain what you intend to do 23:14 MTDiscord erl, I think sfan5 will understand 23:14 kabou Erlehmann I think he means https://github.com/minetest/minetest/pull/11843 23:15 erlehmann well i was thinking of https://github.com/minetest/minetest/issues/6101 23:15 erlehmann and confused 23:15 erlehmann because the node limit is not 64000 but like about half of that 23:15 MTDiscord And now my msg is getting buried :| 23:16 erlehmann look, are you talking about number of registered nodes or map size? 23:16 erlehmann the fact that already two people understood you in an entirely different way seems an indicator for me that clarification could help 23:16 MTDiscord map size 23:17 * kabou is such an understanding personality 23:17 erlehmann ah, map size, the topic where everyone has opinions! 23:18 MTDiscord I just want to know, does the PR require a change to the client or just the server? 23:18 kabou did you try it at all? 23:19 erlehmann MisterE, you can easily test how far you can get by editing max_map_generation_limit or how its called to be higher than 31007 or whatever the adjusted value is now 23:19 kabou the preliminary answer is a mere make away 23:19 MTDiscord No, just interested in it. 23:19 MTDiscord I'm not great at building minetest, but it is within my grasp 23:20 kabou well if you're not interested enough to try it, you're hardly interested 23:20 kabou building minetest is very doable 23:20 erlehmann MisterE i suggest to look in the code that actually handles positions. TL;DR: it's a mess. 23:21 MTDiscord good point. Ill let you know how it goes. I figured if the answer was already known then they could just tell me 23:21 erlehmann and it's very unlikely that an unmodified client will be able to go further than about ±32680 or so 23:21 erlehmann i mean, you can obviously go further 23:21 kabou you can get the patch for the PR at https://github.com/minetest/minetest/patch/11843 23:21 erlehmann but a) there is nothing out there 23:21 MTDiscord I figure, bpt we will see how it goes 23:22 erlehmann b) there exists code that crashes if you go to specific positions 23:22 erlehmann if you want a quick check, install waspsaliva (a cheat client) and use the .teleport CSM command 23:23 erlehmann you can teleport a lot out of bounds with it and it is fine 23:23 erlehmann but there is nothing, as i said 23:25 MTDiscord Its no good to me now if the client won't see anything