Time  Nick       Message
20:50 scr267     sfan5, sorry maybe I can pester you here instead of on github ;)
20:50 sfan5      hi
20:51 scr267     I just thought that it might be useful to add validation of input since the functions are basically 'public'... not 100% sure how classes and their scopes work in LUA though... hard for me to comment clearly on that.
20:52 scr267     Also, I'll definitely look into the biome_lib issue to see if I can figure out why its sending an empty value.
20:53 scr267     Don't want to give you more work however, so er... I could create a pull request if you like.
20:53 scr267     But if you really think its innapropriate then I'll leave it at that. :)
20:54 sfan5      there isn't a really a nice way to check if the functions works other than calling them for every possible input value and checking that they don't crash
20:54 sfan5      doing so would be fine in an optionally-enabled validation mode IMO
20:55 scr267     This is off topic but is Lua strictly typed like C++?
20:55 rubenwardy no lol
20:55 scr267     I just thought that could avoid pitfalls like this, but ... even then we can't guarantee null values.
20:55 rubenwardy also, the C++ code should check that lua provides the correct types.  Lua provides `lua_check*` for this purpose
20:56 scr267     Ok.
20:56 scr267     Fair enough, thanks for your input !  :)
20:56 rubenwardy "should" doesn't mean it always does
20:57 rubenwardy have you found instances where it doesn't? Is that what you mean by "validation of input"?
20:58 scr267     rubenwardy, no but I keep running into issues with various mods and/or APIs where some functions receive null values and crash the server.
20:59 scr267     Probably some bad combination between various versions of mods.