Time  Nick          Message
22:41 shivajiva     does set_hp(hp, reason) trigger the on_punch event when reducing hp or does the screen flash red for another reason?
22:41 rubenwardy    No
22:41 sfan5         i don't think those two are connected
22:41 rubenwardy    The screen flashes red when the hp decreases
22:42 shivajiva     thanks
22:43 shivajiva     rubenwardy: so the spike trap won't trigger the loop for killedplayers?
22:43 rubenwardy    Huh?
22:44 rubenwardy    I suggest changing it to use punch
22:44 rubenwardy    Hmmm
22:44 rubenwardy    It would be cool if placing a spike trap stored the placers name, then that turned up in the kill score thing
22:44 shivajiva     that's what I'm looking at
22:45 shivajiva     needs a separate trapdeath table to register diff traps ;)
22:46 shivajiva     following your coding style for ctf
22:47 shivajiva     hooking ondie for reason.node matching a trap
22:47 shivajiva     well that was my approach
22:48 rubenwardy    CTF should probably be looking at kill reasons really
22:48 rubenwardy    It doesn't currently
22:49 rubenwardy    That would allow you to get the type of damage
22:49 rubenwardy    And the spike pos
22:49 rubenwardy    And also the punch type
22:49 rubenwardy    In one bit of code
22:50 rubenwardy    Reason is passed to dieplayer, so makes sense
22:51 shivajiva     I can't see you letting me hook hpchange lol
22:51 rubenwardy    ?
22:51 shivajiva     carries reason for change
22:51 rubenwardy    Register_on_dieplayer would be better
22:51 shivajiva     exactly :)
22:52 rubenwardy    I added hp change reasons to the engine after implementating the kill board in ctf
22:52 shivajiva     confines the processing to the actual event for the reward
22:52 rubenwardy    Hence why CTF doesn't use ut
22:53 rubenwardy    You can have it so death by node damage events will show the node inventory image in the hist
22:53 rubenwardy    And then it will support showing lava, trap, etc deaths
22:54 shivajiva     yes it has possibilities :)
22:56 shivajiva     for some reason I find I can only read ctf code at night, doesn't make sense in the daytime ;)
23:07 longerstaff13 o/ shivajiva
23:12 shivajiva     Hiya longer :)
23:13 longerstaff13 how ya been?