Time  Nick         Message
01:40 Sokomine     fixer: ui doesn't lag for me - with neither my hw or internet connection beeing great
10:15 IhrFussel    minetest.get_node() doesn't return the whole node def? You have to use minetest.registered_nodes[node.name] to get it?
10:16 IhrFussel    Looks like it
10:16 IhrFussel    I tried local def = minetest.get_node(pos) if def.walkable == false then blah end but it returned false even for nodes that are CLEARLY walkable
10:18 IhrFussel    Sorry the other way around
10:20 IhrFussel    The condition skipped even 'walkable = false' nodes
10:33 ANAND        IhrFussel: Yes, get_node only returns {name = "mod_name:node_name", param1, param2}
10:34 IhrFussel    Would it be a lot faster if I copied the whole nodes table to a local one? Cause I have to look up nodes lots of times in that mod
10:51 IhrFussel    I mean my server has well over 3,000 nodes defined... I guess it's rather slow to lookup a global table with 3,000+ entries each second
10:52 IhrFussel    Although I don't look through the table each time... I only fetch one entry by its name... maybe it's not that slow after all
10:53 IhrFussel    I don't loop through the table*
11:55 IhrFussel    !tell tenplus1 Is there a reason why you don't localize the minetest.registered_nodes global table in mobs redo? #lua told me that it will speed up the table lookups a little (not sure by how much)
11:55 MinetestBot  IhrFussel: yeah, yeah
11:57 IhrFussel    I mean he uses the global table 22 times in his api.lua and I guess he could speed up the mod a bit by replacing those with local references
12:49 rubenwardy   IhrFussel: get_node returns the node, not the node def.   register_node is badly named
12:49 rubenwardy   ~book nodes
12:50 rubenwardy   !book basic op
12:50 MinetestBot  rubenwardy: Basic Map Operations - https://rubenwardy.com/minetest_modding_book//en/map/environment.html
12:50 IhrFussel    For performance reasons?
12:50 rubenwardy   yes, and also because it doesn't make sense to return unrelated things
12:52 rubenwardy   it's kinda like how you don't do    ItemStack().inventory_image
12:52 rubenwardy   you do   ItemStack():get_definition().inventory_image
12:52 rubenwardy   although stacks and items are at least named differently
12:55 rubenwardy   Minetest should make a distinction between
12:55 rubenwardy   Node -> content_id (node name), param1, param2}      only
12:55 rubenwardy   NodeDef -> the full table, looked up by the content ID / name
13:01 IhrFussel    But there is no get_definition() for nodes right?
13:01 IhrFussel    Not sure if that would be helpful
13:02 rubenwardy   there isn't because node is a table not an object
13:02 rubenwardy   Minetest doesn't implement that many objects
13:08 * VanessaE   looks around for tenplus1
13:15 VanessaE     there, contentdb entry updated for homdecor
13:16 VanessaE     rubenwardy: you still need to fix the "edit" page layout for when there's lots of "provides", depends, etc.
13:30 rubenwardy   There's an issue for that
13:30 rubenwardy   I'm currently in the middle of writing my dissertation, so don't have that much time
13:38 xerox123     good luck
13:39 xerox123     not sure if thats something you say good luck for
13:39 xerox123     ¯\_(ツ)_/¯
13:45 VanessaE     I hope it goes well.
13:49 Krock        o/ kaeza re-entered the game
14:10 MinetestBot  tenplus1: Apr-21 11:55 UTC <IhrFussel> Is there a reason why you don't localize the minetest.registered_nodes global table in mobs redo? #lua told me that it will speed up the table lookups a little (not sure by how much)
14:10 tenplus1     hi folks
14:10 tenplus1     hey Krock :P
14:11 _Xenon       Hi ten
14:12 tenplus1     hey xenon, how's you ?
14:12 _Xenon       Good good, what about you?
14:12 tenplus1     just home from work :) chilling with coffee now :D
14:13 _Xenon       Heh :)
14:13 tenplus1     checking out Vanessa's latest Homedecor pull :)
14:14 VanessaE     tenplus1: be sure you sync now
14:14 VanessaE     I pushed a small fix this morning
14:14 tenplus1     hi Vanessa, am trying to figure out how to do just that in notabug :D
14:14 tenplus1     I updated wardrobe 10 mins ago, will redo it when I sync... if I figure it out :D
14:15 tenplus1     git confuses me sometimes
14:15 VanessaE     shoudl be:  git pull https://gitlab.com/VanessaE/homedecor_modpack.git master
14:15 tenplus1     lemmie try
14:17 VanessaE     I toldya you shoulda just gone to gitlab, but noooooOOOOOOOooooo you just HAD to buck the trend and stand out :D
14:17 tenplus1     conflicts... pfft...  will delete everything and download yours fresh
14:17 tenplus1     gitlab is crap, sorry... the interface annoys the hell outta me :)
14:17 VanessaE     yeah, that'll be easier
14:17 tenplus1     ehehe
14:18 VanessaE     I only had to mess with depends.txt in the wardrobe mod
14:18 VanessaE     (point to homedecor_common instead of homedecor)
14:18 VanessaE     (that's the "api" mod I mentioned before)
14:19 * tenplus1   tango's with turtle :P
14:20 VanessaE     CWz: what, do I need to resurrect that one, too? :P
14:20 VanessaE     (wrong channel()
14:21 CWz          Ello tenplus1
14:22 tenplus1     o//
14:22 tenplus1     hi CWz
14:24 tenplus1     updated my fork on notabug, added wardrobe changes :)
14:26 VanessaE     shall I sync?
14:26 tenplus1     removed un-needed functions and uses homedecor api instead, yeah :)
14:26 VanessaE     done.
14:28 tenplus1     could we have the homedecor_common have intllib support and remove the homedecor_i18n mod
14:28 VanessaE     I thought about that actually
14:28 tenplus1     all the important stuffs should be in the common mod
14:28 Krock        hi tenplus1
14:28 VanessaE     not really sure if it would be better that way or not.
14:29 VanessaE     of course, if it were up to me, I'd rip out the i18n crap altogether...  locale stuff should be client-side, not server-side.  but I guess that isn't possible yet.
14:29 rubenwardy   it is in 5.0.0
14:29 tenplus1     yaaaaay
14:29 tenplus1     hi ruben...
14:29 VanessaE     wait what?
14:30 Krock        inb4 client-side translations
14:30 Krock        although it's not gettext but a re-implementation
14:30 tenplus1     how do we use it ?
14:30 VanessaE     well, pull requests welcome :)
14:30 Krock        https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L219
14:30 Krock        example 5.0.0 mod: https://github.com/SmallJoker/upgrade_packs
14:31 VanessaE     https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L2514
14:31 VanessaE     huh.
14:32 VanessaE     from this, it looks like conversion to client-side translations would be pretty trivial
14:32 Krock        it is
14:32 VanessaE     all my mods that use it already have "S = homedecor.i18n.somethingorother" at the start
14:32 Krock        but currently it requires the translation files to be in the simple a=b  notation
14:32 tenplus1     easy to fix :D sweet
14:32 VanessaE     I think homedecor's locale files are done like that, Krock
14:33 VanessaE     but someone else can mess with translations :P
14:33 Krock        and the file termination must be .<lang_code>.tr to make it work
14:33 VanessaE     it was enough for me to wrap my head around the big split
14:33 tenplus1     Ilike the big slit :) not players can use what parts they want
14:33 VanessaE     and THAT didn't get the translations moved over per-modf
14:34 VanessaE     but since they all depend on homedecor_common and _i18n it doesn't matter
14:34 VanessaE     tenplus1: exactly.
14:35 tenplus1     would still remove homedecor_i18n, no need for a separate mod for translations, that's what intllib is
14:35 VanessaE     yeah
14:35 VanessaE     someone else can do that :)
14:35 tenplus1     many mods in general have dependency nightmares
14:35 tenplus1     if I get tiume today I'll tinker with is
14:35 tenplus1     *it
14:35 VanessaE     also, I'm open to existing depends being made optional where possible
14:35 VanessaE     I tried to keep them minimal, but some stuff just has to depend on other stuff, for now anyway
14:36 tenplus1     dont want another farming;moreores;toolranks issue with dependency circles :) heh
14:36 VanessaE     heh
14:37 VanessaE     fwiw, I already marked homedecor as only for use with 5.0.0+ so we're free to fuck with all we want :)
14:37 VanessaE     rubenwardy: there's no 5.0.1 option in contentdb
14:37 rubenwardy   The API is the same
14:37 VanessaE     ok.
14:38 tenplus1     will slowly move all my mods over to 5.0.1 eventually... just time...
14:38 tenplus1     if no-one's mods works with 0.4.16 then all the crappy clones wont work :D
14:38 rubenwardy   I should probably make it more clear
14:38 VanessaE     good. :)
14:41 rubenwardy   What's clearer
14:41 rubenwardy   0.4.16-17
14:41 rubenwardy   Or something else
14:41 rubenwardy   0.4.16 and 0.4.17
14:42 VanessaE     16-17
14:42 tenplus1     0.4.16+
14:42 VanessaE     or that
14:42 rubenwardy   16+ would include 5.0.0
14:42 tenplus1     hrm...
14:42 rubenwardy   0.4.16-0.4.17
14:42 rubenwardy   With spaces
14:42 VanessaE     I think I'd just leave-out 0.4.x at this point
14:43 VanessaE     there's no reason to use it now
14:43 tenplus1     5.0.1 is the new stable base that all mods should be built on now
14:43 rubenwardy   It's needed to hide releases which don't support 5.0.0
14:43 VanessaE     exactly.
14:43 VanessaE     rubenwardy: well, fair enough
15:04 Calinou      small heads up: moreblocks HEAD now requires Minetest 5.0.0 or later
15:04 Calinou      (if you're on 0.4.17, use More Blocks 1.3.0)
15:04 tenplus1     hi cal, thx
15:04 VanessaE     sounds fair
15:04 tenplus1     what's changed ?
15:04 Calinou      I just removed the deprecated depends.txt/description.txt, that's why
15:05 tenplus1     ahh
15:05 VanessaE     that's something else I need to work on
15:05 VanessaE     should be easy to make a conversion script
15:06 VanessaE     though I'm NOT a fan of cramming all the depends into one long line
15:07 rubenwardy   it kinda sucks for lots of mods
15:08 rubenwardy   I'd like to support multiline text to make that nicer
15:08 rubenwardy   maybe     depends ``= mod1\n      mod2\n      mod3\n    ```
15:09 rubenwardy   which is similar to how YML/JS does it IIRC
15:09 VanessaE     why not just multiple depends=  entries?
15:09 VanessaE     that would be much easier to read
15:09 rubenwardy   hmmm
15:09 rubenwardy   that could work
15:09 VanessaE     basically s/^/^depends =/ >> mod.conf
15:09 VanessaE     or whatever
15:10 VanessaE     it would be trivial to convert to, readable, easy to deal with
15:10 rubenwardy   maybe have    depends+=    for append
15:11 VanessaE     why?
15:11 rubenwardy   the issue with just adding this is that it is valid to have settings appearing multiple times
15:11 rubenwardy   like, through user mistake
15:11 VanessaE     wouldn't it be implied?
15:11 rubenwardy   so you don't want it to do this for all settings
15:11 VanessaE     well no,
15:11 VanessaE     but we're talking about depends here
15:11 VanessaE     and for most mods, there's at least 2
15:12 VanessaE     (hell, these days, more like 3-4, since lots of stuff uses e.g. unified dyes, or basic materials, along with default et. al)
15:16 tenplus1     why not include those inside homedecor_modpack ?
15:16 Calinou      interesting, texture packs still use description.txt
15:16 Calinou      (mod.conf is ignored there)
15:16 VanessaE     because they're separate from and independent of HD.
15:16 tenplus1     oh
15:18 Calinou      there :) https://i.imgur.com/oudeHqB.png
15:18 VanessaE     still rocking Misa64 eh :)
15:18 Calinou      I pushed it to GitHub last month: https://github.com/Calinou/misa
15:19 Calinou      I also added most 0.4.17/5.0.0 textures (still missing coral textures)
15:20 VanessaE     HDX needs some updates too
15:20 Calinou      https://github.com/Calinou/misa/blob/master/GALLERY.md
15:20 Calinou      I managed to make savannas look quite nice (and less bright compared to default, so it fits Misa more)
15:23 BillyS       Okay, minetest is cursed.  I overrode minetest.is_protected, but even though the function is being called and returns 'true', I can still dig / place nodes
15:23 BillyS       Any idea?
15:23 tenplus1     hi billy
15:24 BillyS       hi 11
15:24 BillyS       :P
15:24 tenplus1     VanessaE: I've removed homedecor_int8 and moved intllib support into common, also fixed mesecon global warning
15:24 VanessaE     thanks :)
15:25 VanessaE     I take it you changed that for all mods in the pack?
15:25 tenplus1     yup, notabug updated :P
15:26 VanessaE     :D
15:27 VanessaE     "Some files were not shown because too many files changed in this diff"
15:27 VanessaE     D:
15:27 VanessaE     stupid notabug :P
15:27 BillyS       Odd
15:27 tenplus1     ehehe, I like it... is simplez
15:27 VanessaE     fuck it.  git pull.
15:27 VanessaE     :)
15:27 BillyS       In most area mods it looks like that is all that is changed
15:27 BillyS       aieeee
15:27 VanessaE     there, pulled and pushed.
15:28 tenplus1     kewl :)
15:29 BillyS       Oh gawsh
15:29 tenplus1     billy, do you have protection_bypass privs ? that will let you place./remove anything even if it's protected
15:30 BillyS       tenplus1: I'm writing my own version of a protection mod :P
15:30 Krock        yapm
15:30 Krock        Yet Another Protection Mod?
15:30 tenplus1     lol
15:30 BillyS       And for some reason "minetest.register_on_protection_violation" isn't being called
15:30 tenplus1     show us code
15:30 BillyS       Krock: No, it's part of the ctf ripoff I'm making
15:30 BillyS       For PK
15:30 Krock        Player Kills
15:30 BillyS       Persistant Kingdoms
15:30 BillyS       But that's the idea
15:30 tenplus1     wb Ganome
15:31 BillyS       tenplus1: https://paste.ubuntu.com/p/5Zv3jFQZ7X/
15:32 BillyS       That's the relevant part
15:32 BillyS       And I know that new_is_protected does return true when it's supposed to
15:33 tenplus1     line 34 checks for new_is_protected and returns true every time it's found... shoudnt you return new_is_protected(pos,name)
15:34 VanessaE     tenplus1: https://forum.minetest.net/viewtopic.php?f=11&t=2041&p=349269#p349269
15:34 BillyS       tenplus1: No, because if it isn't protected (new_is_protected returns false) it needs to return old_is_protected
15:35 BillyS       Also, I'm running this on MT 5
15:35 BillyS       dunno if it does protection differently
15:35 tenplus1     what I read is if new_is_protected function found then always return true
15:35 tenplus1     intead try: if new_is_protected then return new_is_protected(pos, name) end
15:36 tenplus1     and it'll return only the result of that function
15:37 BillyS       ..what
15:37 BillyS       new_is_protected(pos, name) should call the function
15:37 BillyS       And check it's output
15:38 tenplus1     'tis okie
15:38 BillyS       See https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L4747
15:39 tenplus1     I read a bit wrong :Dehehe
15:40 BillyS       ah, okay :P
15:42 VanessaE     tenplus1: oops, you left an empty dir
15:43 tenplus1     I did ?
15:43 VanessaE     yeah
15:43 VanessaE     homedecor_i18n/textures  homedecor_i18n/models
15:43 VanessaE     hm.
15:43 VanessaE     nope, untracked on my end
15:43 tenplus1     ehehehe
15:43 VanessaE     must be a glitch local
15:44 BillyS       OH DERP
15:44 BillyS       I was playing as an admin
15:45 * BillyS     facepalms
15:45 tenplus1     lolol, you have 'protection_bypass' ?
15:45 BillyS       Oddly enough, no
15:46 BillyS       But when I played as a normal player it worked
15:46 tenplus1     yay
15:47 BillyS       oh wait
15:47 BillyS       there was another protection mod
15:47 BillyS       And it gave me protection_bypass
15:47 BillyS       darnit sparky
15:47 tenplus1     sparky ?
15:47 BillyS       i r c s p a r k y
15:48 BillyS       Don't want to ping
15:48 BillyS       He originally made and hosted this subgame
15:48 tenplus1     ehehe
15:48 BillyS       Then he quit and I took up the slack
15:57 tenplus1     wb kaeza
16:07 * tenplus1   is off to nom pizza :)
16:07 tenplus1     laters
16:35 kaeza        Yummy.
16:35 kaeza        o/ Krock
16:35 Krock        o\
16:35 * rubenwardy is cooking gammon and roast potatoes
16:35 VanessaE     mmmmmm
17:10 xerox123     having a bbq
17:55 Fixer        r o a s t  p o t a t o e s
17:56 rubenwardy   you say potatoes, I say potatoes
17:57 * VanessaE   throws some sweet potatoes at rubenwardy  :)
17:57 Fixer        potatoes agree
17:57 rubenwardy   <3
17:57 rubenwardy   sweet potatoes are good in vegetarian curries
17:58 rubenwardy   with chickpeas, spinach, and greek yoghurt
17:59 Krock        can confirm
18:01 Krock        well, not the part with spinach. don't eat it with spinach.
18:02 rubenwardy   good source of fibre ?
18:50 kaeza        Mortadella sandwiches and mate for now. Maybe rice with whatever at night.
18:51 kaeza        Rice++
18:52 VanessaE     mate?
18:52 kaeza        https://en.wikipedia.org/wiki/Mate_%28drink%29
18:53 VanessaE     hm
19:28 BillyS       Do formspec textlists work with multi-line pieces of text?
19:29 rubenwardy   you should split them into multiple lines
19:29 Krock        no, it looks weird
19:29 BillyS       Hmm, okay
19:29 BillyS       thx
19:36 BillyS       Also, the formspec corrdinate system is cursed and needs holy waer poured all over it.  In case anyone didn't mention that. :)
19:36 BillyS       *water
19:38 Krock        can't help it. fixing it would break the layout of mods
19:40 BillyS       ah
19:40 BillyS       hmm
19:40 BillyS       Add a "fixed" option to minetest.show_formspec
19:40 BillyS       :P
19:45 kaeza        There's An Issue About That™
19:46 kaeza        https://github.com/minetest/minetest/issues/3872
21:36 rdococ       The formspec coordinate system is... a bit broken, to say the least.