Time  Nick       Message
01:03 VanessaE   or pester someone to add those materials to mtg :P
01:42 ircSparky  does 5.0 have a timeline for release?
01:45 rubenwardy https://github.com/minetest/minetest/milestone/9
01:47 ircSparky  danke
13:08 IhrFussel  The 'to crat grid' buttons in u_i are really so DANG unoptimized... now I removed even the '10' option and only 1, 5 are left and the server STILL lags 1-2 secs at times with those buttons in the profiler taking up to 1 second
13:09 IhrFussel  'to craft grid'*
13:10 IhrFussel  I'm not even sure which recipes can take so long to craft 5 items!
13:51 jas_       something something crafting in general, not u_i's fault?  it's a suspicion of mine, unfounded, but i've had problems with crafting lagging the network before; where it doesn't happen in singleplayer.
13:51 jas_       specifically, crafting in bulk, over a network, lagging everything.
13:52 jas_       (the most frustrating part of this for me has been that it occurs sometimes, and other times does not, and i cannot make heads nor tails.)
14:04 IhrFussel  Not network...internal mod lag from the server
14:05 IhrFussel  I just tested it...pressed '5' button for default:stick and lag went up a bit immediately
14:11 IhrFussel  WHAT THE HECK
14:12 IhrFussel  I just crafted 5 sofas...they require 3 wool, 3 sticks and 3 wooden slabs... and as soon as I press the '5' button more than once I get 2 seconds!! lag
14:12 IhrFussel  EACH TIME
14:13 IhrFussel  This can be easily used to lockup servers
14:13 IhrFussel  Now imagine stock u_i has a '99' button!
14:18 IhrFussel  Okay wait... I think it only happens with certain recipes
14:18 IhrFussel  The sofa recipe looks like this:
14:19 IhrFussel  W = wool, WS = wooden slab, S = stick
14:19 IhrFussel  WWW, WSWSWS, SSS
14:19 IhrFussel  Now what I see is that the wooden slabs are NOT moved into the craft grid... only wool and sticks
14:23 IhrFussel  And the extreme lag only happens after the first time you press the button ... then suddenly the stacks decrease slower from your inventory ... 1st try it counts them down at a rate of 1 per server step I think and 2nd try suddenly only several per second
14:26 IhrFussel  I guess I will have to make a video later to show what I mean exactly
14:39 IhrFussel  About to make the video now
14:49 IhrFussel  I think I already found the reason for it but there might be more cases where the buttons lag the server so much ... in the case of the sofa the recipe I chose wants 'moreblocks wooden slab 8/16' but I have only 'stairs wooden slab' ... If I switch to the 2nd recipe that wants 'stairs wooden slab' then the lag is less/gone
14:56 NathanS21  doesn't moreblocks register a bunch of aliases, maybe they are part of the problem.
14:57 IhrFussel  Okay so the actual bug seems to happen when 1 row of items is MISSING from your inventory... like when you only have the items for the 2nd row of the recipe and the first row is missing then the loop gets slower
14:57 IhrFussel  u_i doesn't check if you have the required items for the recipe
14:58 NathanS21  that's kinda silly.
14:58 IhrFussel  It just loops through the whole recipe n times and takes what you got
14:58 NathanS21  the loop should probably exit as soon as it can't get an item.
14:59 sofar      does it lag the server, or (more likely) just the client?
15:00 IhrFussel  Watch the video I linked
15:00 IhrFussel  It shows the server lag
15:02 IhrFussel  Yes it is confirmed!
15:02 IhrFussel  As soon as one item is missing in your inventory the loop gets slower
15:03 IhrFussel  If you have all required items ready even after 5 times it's slmost instantly moved
15:04 IhrFussel  Making another video...will be a bit longer
15:09 IhrFussel  https://ihrfussels-server.de/craftlag2.mp4
15:09 IhrFussel  As soon as I add books to my inventory the moving is pretty much instant
15:19 IhrFussel  I think the best solution would be to check BEFORE the loop even starts if the player has enough items for the recipe to craft...but not sure how complex that would be
15:20 IhrFussel  For now regular players can only craft 1 at a time...this causes max lag of 0.3 secs which is acceptable
15:36 IhrFussel  But I'm not sure why a 'item in slot missing' check can take so much longer
15:49 rubenwardy In crafting, I build a hash map of item names to counts
15:49 rubenwardy Which can be used for fast checks like this
15:50 lumberJ    using crafting right now ;)
16:18 rubenwardy https://twitter.com/weinert_ralf/status/1099987080850087936
16:18 rubenwardy interesting thread