Time Nick Message 00:06 MTDiscord If someone else also agrees that it should be localstorage, I will change it 00:06 MTDiscord Id rather not bikeshed further beyond that 00:16 MTDiscord That is an interesting reason. I'm someone who would not want to see the notice ever again lol. But I don't have the technical expertise on session vs local storage to care one way or the other. 00:19 MTDiscord I don't think this needs much expertise; the question boils down to: * You want to see the notice again in every new session, regardless of whether you closed it in the last session? -> sessionStorage * You don't want to see the notice ever again if you closed it? -> localStorage I too would prefer the latter, maybe with an exception for the "about" page. 00:19 MTDiscord localStorage persists between sessions right? that would make more sense so I don't need to dismiss it every time 00:20 MTDiscord It could be reasonable to show the notice for every session, as long as the notice isn't in the way of any content. 00:20 MTDiscord To be clear: sessionStorage is across the browser session, not tab session 00:20 MTDiscord You can open and close the site without seeing the notice again until you restart your browser 00:22 MTDiscord It looks like this: https://private-user-images.githubusercontent.com/24834740/400321045-2305b762-2cf6-4da8-8286-96e9c4b3754b.png 00:23 MTDiscord (I agree with luatic that it should be localStorage) 00:23 MTDiscord @Josiah (Sie/Sie) see this PR for a screenshot. It is at the top of the page. 00:23 MTDiscord (it is injected before the content; scrolls with the content, not sticky) 00:24 MTDiscord does this really need to be on every page? 00:24 MTDiscord There are more advantages than disadvantages 00:25 MTDiscord 1) Its easier to inject globally 2) If a user never sees the page we choose, they wont see the notice 00:25 MTDiscord also > Content and URLs may change quickly without notice. id argue this isnt really true, its not changing much more than a regular (active) wiki. old links are being redirected 00:26 MTDiscord may 00:26 MTDiscord And new URLs may change 00:26 MTDiscord Thanks. I don't find it that intrusive, but I don't want to be blamable for any bikeshedding lol. 00:26 MTDiscord Its a warning, not a guarantee, after al 00:26 MTDiscord It sounds like others prefer the dismissal to persist between browser sessions. 00:26 MTDiscord Then so it shall be 00:27 MTDiscord the one thing i do feel firmly on is that we should have a adter x time/x happens it will be reverted, since this doesnt make sense to be up for all time 00:28 MTDiscord Yes, this is not supposed to stick around 00:28 MTDiscord We should put removal on the roadmap 00:28 MTDiscord yeah, but based on what/when 00:29 MTDiscord Does that need to go in the notice itself 00:29 MTDiscord like removed when issue #69420 is done, or something 00:29 MTDiscord nah, just in the roadmap or something should be fine 00:40 MTDiscord I would say the short term roadmap needs to be completed at least, if not the medium 00:40 MTDiscord Notice PR is updated, btw 00:47 MTDiscord i added it to the roadmap, in medium term 00:48 MTDiscord also what does > Categorize information by target audience (API users, engine developers, server owners, players, etc.) even mean in reality? 00:48 MTDiscord nesting? something else? 00:48 MTDiscord Yes 00:48 MTDiscord Currently its a monolithic list 00:49 MTDiscord I was working on that for a second but I need to abandon some projects for now 00:49 MTDiscord hmmm, may kick that to a random list or something 00:50 MTDiscord in terms of stuff on short term needing to be done to revert 00:50 MTDiscord That is a farily important organization task 00:51 MTDiscord For instance, compiling on linux/windows should go together with other compiling instructions. There are like 5 different world/db-related pages that should go together. The random history bits need a misc section. Content metadata (name rights, cdb, forks, etc) should go together. etc. etc. 00:54 MTDiscord fair enough. 01:04 MTDiscord hey if there are updates to issue 66 feel free to add it to GitHub, I'm not gonna be checking Discord too much this week 03:16 MTDiscord I don't think we should show the notice on every session, I get very annoyed by that 03:26 MTDiscord Well its already been changed so ou don't have to worry about that 03:48 MTDiscord 🙂 03:59 MTDiscord Your reviews have been attended to