Time Nick Message 00:18 MTDiscord And its not even very proprietary 04:41 MTDiscord OK, finally rebuilt my personal site in vanilla HTML, I was getting anxious about that. Only mentioning it because now I have the skills to work on the stylesheet for this, and I'll continue chipping away at the spell-check issues as well. Obv with Xmas my availability will be spotty but I'm officially done working for the year and excited about this project, so hopefully I can find the time! Not tonight though, calling it for the 04:41 MTDiscord day 🙂 11:08 MTDiscord merging https://github.com/minetest/dev.luanti.org/pull/98 in 5m 12:31 MTDiscord merging PR 99 in 5m 16:23 MTDiscord i say we conditionally merge https://github.com/minetest/dev.luanti.org/pull/93, on the condition it may be changed/reverted/etc in the future. it should be easy enough to throw a :not([alt*="fullscreen:"]) on the end of the selector or something if needed. thoughts? 16:25 MTDiscord I pulled the change locally and looked at some other pages with images and such and I don't think it's that bad of a change 16:25 MTDiscord I'd say merge it, and if there's a page with images that it will not work well with we'll see when that page exists 16:27 MTDiscord merging PR 💯 (https://github.com/minetest/dev.luanti.org/pull/100) in 5m 16:28 MTDiscord merging https://github.com/minetest/dev.luanti.org/pull/93 in 5 then 16:31 MTDiscord (ROllerozxa: please don't squash :) 16:32 MTDiscord unfortunately all other merge options are disabled... 16:32 MTDiscord everything is squashed 16:35 MTDiscord really should be splitting things into seperate prs if you care 16:35 MTDiscord it's a bit more convenient to do a NOSQUASH PR that simply gets rebase merged than making individual PRs for everything though 16:36 MTDiscord I really would like it to be possible to have PRs we can merge without squashing, especially if we're going to be pushing everything through PRs in the future 16:36 MTDiscord [nosq] PRs are such a lovely thing to have 16:36 MTDiscord I wouldn't worry about squash vs nonsquash, the git history is there in the commit list in each PR and reverts are probably gonna be very rare and don't need to be picked apart too much 16:36 MTDiscord quoting sfan5 16:36 MTDiscord > sorry for the wild collection but I'm not going to create fifteen PRs. 16:36 MTDiscord https://github.com/minetest/minetest/pull/12378 16:36 MTDiscord What does nosq mean? 16:37 MTDiscord "no squash" 16:37 MTDiscord What is the value in nosq PRs? 16:37 MTDiscord you shouldn't need to rely on people to keep their fork branches - usually they are deleted after merge and if we move the repo to another forge then all PRs associated with github forks will be gone and all that is left is the git history as we have merged 16:38 MTDiscord my point is in docs, how often are people really going to do 15 different things that are that trival? 16:38 MTDiscord well yeah that is fair 16:38 MTDiscord Agreed, I don't rely on others keeping their forks. Stepping back, how important is it that we keep such a granular git history? 16:40 MTDiscord i think if we see this being a multi person common thing, then yeah can re enable it. but for one ofs, just making another pr is 🤷 16:41 MTDiscord for context the odds are 1/108 or 0.925925925% 16:42 MTDiscord where did you get that number...? 16:42 MTDiscord oh, total commits to the repo 16:44 MTDiscord well that is because I have been a good boy and PR everything as discretely [sic] as possible even though some of them could have been one [nosq] PR of stuff I had been working on at once 16:44 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320431721673523290/image.png?ex=6769935e&is=676841de&hm=8b988aba36b9341cec55baa026de276e8c1b02bb27a5ace1285467eafc06ad4c& 16:44 MTDiscord Sorry, why do we want nosq again? 16:45 MTDiscord Why and when, I guess 16:45 MTDiscord well I guess it depends on how good we want the commit history to be if it needs to be looked back upon 16:45 MTDiscord I want this because it allows me to be lazy: I can add unrelated trivial/obvious changes to a PR without having bad Git history in the end 16:47 MTDiscord fwiw #94 #91 #81 #98 would have been candidates for not squashing too 16:47 MTDiscord but it's not a big problem, I can live without too :) 16:48 MTDiscord yeah if we're in agreement that keeping the git history to discrete changes isn't necessary and we can be fast and loose with it then it wouldn't be an issue for me either 16:50 MTDiscord If I make a PR to add Prettier, put all existing content through Prettier and add CI now, would it be accepted? 16:54 MTDiscord where in settings are you supposed to adjust merge options? 16:55 MTDiscord also i should be able to disable this, right? 16:55 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320434478174175314/image.png?ex=676995f0&is=67684470&hm=7ffeffa774834c62c80f11f5384050fd3975263b6d2aa91aca588638d15556c4& 16:56 MTDiscord found it, do we want to try enabling it? 16:56 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320434758383046818/image.png?ex=67699632&is=676844b2&hm=365d27dbef07dec93f2eab87ebd06c82f6be1b295cb86b6de271f5d25ec59e12& 17:05 MTDiscord eh, why not. ive enabled it for "experimental" purposes lets say 17:05 MTDiscord do the usual [no sq]: in titles or whatever 17:05 MTDiscord let revisit this in like i dunno a week or two to see how much its used? 17:12 MTDiscord roller: reminder to check things off https://github.com/minetest/dev.luanti.org/issues/15 when merging migration prs 17:15 MTDiscord I would love that, but maybe start with a few files so we can discuss formatting options 17:15 MTDiscord I only allow squash mergjng but I use the PR title as commit message, that's industry standard and I have no idea why it isn't default 17:16 MTDiscord We can also add "works on #15" to the PR description for easy linking 🙂 17:16 MTDiscord will do 👍 I ended up checking off the node pages I had migrated through the Nodes page after I did that 17:17 MTDiscord Yeah, in my 4 years at Microsoft we've never needed anything more than a commit title to know what to look for, I think squash vs no-squash is splitting hairs if that's the core goal 17:18 MTDiscord How does squashing slow you down? 17:23 MTDiscord ? It doesn't. But if I cared about the resulting Git history and created separate PRs to avoid my commits being squashed, that would slow me down. 17:24 MTDiscord (I didn't so far, and as ROllerozxa said, we don't necessarily need to care about the Git history) 17:38 webchattester I wonder whether this works 17:38 MTDiscord wild 17:39 MTDiscord no 17:39 wsor4035 left already 17:40 MTDiscord (that was me, I found a webchat link on the IRC wiki page) 17:40 MTDiscord ah 17:40 MTDiscord yeah libera's web chat should still be functional, but -dev would need you to register before you can speak iirc 18:44 MTDiscord merging https://github.com/minetest/dev.luanti.org/pull/101 in 5m 18:45 MTDiscord (thanks grorp for taking care of importing the most important pages from the wiki :) 18:49 MTDiscord ...I forgot to disable the squash for this PR. I'll remember it next time 18:53 MTDiscord side eyes 18:54 MTDiscord will do, I was making redirects on the wiki 18:54 MTDiscord ah you did it already 18:57 MTDiscord fyi, working on importing this stuff 18:57 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320465172845953106/image.png?ex=6769b286&is=67686106&hm=6648c8a6d3d6175dbcbaadb3ba88b32b9fc92a336ae8903f52c57329ec3574e8& 18:57 MTDiscord also chat window is basically worthless, so going to just make it an alias of chat 19:00 MTDiscord (For IRC folks, it's Chat through Creative_mode pages, alphabetically, from wiki.luanti.org) 19:06 MTDiscord (skipping controls) 19:06 MTDiscord i think we should prefer linking to cdb over the forum when possible, thoughts? 19:07 MTDiscord definitively 19:08 MTDiscord (this is what I would do when I used to edit the regular wiki too) 19:12 MTDiscord https://wiki.luanti.org/Creative_mode to much of a mtg ism? strike it from the list? 19:12 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320468983152906310/image.png?ex=6769b612&is=67686492&hm=595bb621bcc8671eb449c0129b9fd7740e09978d5dae5c39cbb9e9720225e859& 19:12 MTDiscord though the engine still has a concept of creative 19:13 MTDiscord eh, ill just ignore it in my pr for now 19:15 MTDiscord should s/notabug/codeburg or something like that 19:15 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320469812056555520/image.png?ex=6769b6d8&is=67686558&hm=70e7388de599ac7595dd27a41f0d26d38aea12e03fc7565efae40f59737ad27e& 19:15 MTDiscord notabug shouldnt be recommended 19:16 MTDiscord unless someone wants to look at https://github.com/minetest/dev.luanti.org/pull/102 first (holler now if so), otherwise merging in 10 19:17 MTDiscord the coordinates page name is typo'd (cordinates) 19:17 MTDiscord otherwise looks good to merge as it is 19:18 MTDiscord https://tenor.com/view/tom-and-jerry-dunce-gif-10694047 19:18 MTDiscord fixed 19:19 MTDiscord roller, if you want to do redirects? marked them off the list 19:19 MTDiscord gonna make some redirects but I've got my own import PR to open 19:21 MTDiscord merging https://github.com/minetest/dev.luanti.org/pull/103 in 5m after I've done the redirects 19:22 MTDiscord looks good 19:25 MTDiscord going to do the above next, yes hands and hearts articles are very mtg ism, but they can be expanded to engine stuff since both of those are engine constructs 19:25 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320472353557184542/image.png?ex=6769b936&is=676867b6&hm=120bec47a459a64b47cde8fceb9f142fc138d67d65aab086ed36498780287bf9& 19:26 MTDiscord also just noticed that creating texture packs has underscores in the page name 19:26 MTDiscord Rollerozxa: read the world boundaries page, improved well 👍 19:27 MTDiscord thank you 😄 yes I expanded upon it a bit from the old wiki page 19:27 MTDiscord want me to fix that, or you? 19:27 MTDiscord I can do that 19:28 MTDiscord thanks 19:28 MTDiscord yeah wouldn't import that, doesn't seem to have any valuable non-MTG info 19:28 MTDiscord if we want a page about creative mode, would have to write a new one 19:28 MTDiscord yeah 19:31 MTDiscord also getting started has a mtg image on it. im not bothering to save it 19:32 MTDiscord no worries, it's okay 19:32 MTDiscord (I was the one who put that screenshot there) 19:32 MTDiscord (...two years ago) 19:33 MTDiscord https://tenor.com/view/shame-bell-game-of-thrones-walk-of-atonement-cersei-lannister-gif-16635977892557113898 19:33 MTDiscord more like "completely rewritten" than "expanded" 19:34 MTDiscord sure, but i think they are worth transfering over. 19:36 MTDiscord I assuming you're gonna be importing the FAQ page next? 19:37 MTDiscord its in this batch, but yeah, already done 19:39 MTDiscord I see 19:39 MTDiscord I can look at the newly imported pages and improve them a bit 19:44 MTDiscord https://github.com/minetest/dev.luanti.org/pull/104 holler if you want to look, else merge in 10 19:53 MTDiscord roller 👆 more redirects 19:53 MTDiscord will do 19:54 MTDiscord and merging https://github.com/minetest/dev.luanti.org/pull/106 in 5m 19:54 MTDiscord if grorp wants to do some more they are free to do so now 😄 19:55 MTDiscord struck form the list 20:10 MTDiscord merging if the corrections look ok 20:11 MTDiscord seems fine 20:11 MTDiscord 👀 20:11 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320483961977307187/image.png?ex=6769c405&is=67687285&hm=b40fafa507c8e0663f8b3c5874d0590e2f27f9dd61515865e03ce3cca0fece21& 21:29 MTDiscord why doesn't the api.luanti.org search bar actually work? >I search for game.conf > no results. >I search google for game.conf + luanti > brings me to the page in api.luanti.org that has game.conf 21:31 MTDiscord I don't think it includes dots in the search index, unsure if there's a setting to change that 21:32 MTDiscord or maybe it's because of this 21:32 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320504245837103124/image.png?ex=6769d6e9&is=67688569&hm=3a20f8b444b31387a2735f22682e9b89fbc4714f165a670cb26a8e3467b23ee6& 22:44 MTDiscord doesnt the search thing just do titles or something? 22:46 MTDiscord idk, its using https://www.fusejs.io/ 22:48 MTDiscord api.luanti.org uses lunr as far as I can tell 22:53 MTDiscord it does nicely bind it to the window for us https://github.com/alex-shpak/hugo-book/blob/7c78a39c531aa2492ed7e92f2ce9dfb2c8c0d3fa/assets/search.js#L76 so one could screw with it if they want 23:14 MTDiscord lol 23:14 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320529902981611530/screenshot.png?ex=6769eecf&is=67689d4f&hm=c5fd5b7f71d2df35d174a77cff509ade973fe1b52fca241f4eb4eef07a77110d& 23:15 MTDiscord yeah i know, i think someone (wuzzy?) might've pointed that out before. now that it's accessible in a git repo, it should be easy to fix. 23:21 MTDiscord well wuzzy was also the one who did the bulk rename of the regular wiki 23:21 MTDiscord merging https://github.com/minetest/dev.luanti.org/pull/107 in 5m 23:25 MTDiscord seems like the hugo comments don't work btw 23:25 MTDiscord https://dev.luanti.org/translation/mods-and-games/#example 23:26 MTDiscord https://cdn.discordapp.com/attachments/926231483155378176/1320532881927307305/visible-hugo-comment.png?ex=6769f195&is=6768a015&hm=6a31be9dd13a65641896ce6a0af71de834f062383bc4f2a5cb79faec40658e16& 23:26 MTDiscord oops 23:26 MTDiscord the heck is this syntax 23:26 MTDiscord why are we not using stock HTML comments for this 23:26 MTDiscord because hugo hates any inline html 23:26 MTDiscord including comments? 23:27 MTDiscord any sensible markdown parser should just strip HTML comments without complaining at all 23:27 MTDiscord yup 23:27 MTDiscord we can disable this: https://github.com/minetest/dev.luanti.org/issues/96 23:33 MTDiscord disabling the HTML sanitiser is okay 23:34 MTDiscord (the content is stored in the repo, it's about as "trusted input" as it can be) 23:49 MTDiscord has anyone used math yet? 23:49 MTDiscord as in, inline latex math or something - does it work? 23:49 MTDiscord Sorry about the comment syntax, it worked on my machine ™️ 23:49 MTDiscord I won't be very available this week, good luck folks 23:51 MTDiscord gah writing a lua primer is hard 23:51 MTDiscord i feel that if i properly construct everything bottom up it won't be well-motivated