Time Nick Message 00:06 MTDiscord How does everyone feel about the current state of the Template/HOWTO PR? ( @GreenXenith that includes you) 00:06 MTDiscord I think its missing a lot but it can be filled in later 00:07 MTDiscord Could you mark it as ready for review then? (ie unmark it as Draft) 00:08 MTDiscord benrob: dunno if you looked at github lately, thoughts on reject/etc label? 00:08 MTDiscord I mean, I guess I can but I feel like that's bad practice 00:08 MTDiscord done 00:08 MTDiscord @wsor Seems reasonable 00:08 MTDiscord We inherent either some github default tags or MT ones 00:09 MTDiscord So we might have those already 00:09 MTDiscord App hasn't contested after 2 days, are we good if I merge the new Template? 00:12 MTDiscord @wsor Maybe instead of just "rejected" we should have more specific labels: "out of scope", "poor quality", and "abandoned" 00:13 MTDiscord i dont care what its named, just the concept 00:13 MTDiscord Again, none of these need to be permanent, but they should give someone scanning the issues/PRs an idea of why something was closed 00:13 MTDiscord i.e. label to tell dont re open vs re open if commited to again 00:14 MTDiscord maybe don't add "poor quality", that seems more like something that'd just be worked on 00:16 MTDiscord Merging https://github.com/minetest/minetest_docs/pull/20 in 5 00:18 MTDiscord @wsor WIP and Ready For Review tags seem redundant, as Github has draft PRs 00:18 MTDiscord It's either a draft, and thus WIP, or not, and thus ready for review 00:18 MTDiscord why the heck are you pinging me about that? 00:19 MTDiscord I figured you had been the one managing the tags 00:19 MTDiscord .....havent touched them in this org if i recall correctly 00:19 MTDiscord Also, why do we have a documentation tag, it's all documentation 00:20 MTDiscord lol 00:20 MTDiscord is there a audit log in github? 00:20 MTDiscord If it's not documentation, then it's meta or build system related, which should be the tags we add 00:20 MTDiscord a lot of tags are stock 00:21 MTDiscord wsor: Commit audit or settings? 00:21 MTDiscord like to see who added the tags 00:26 MTDiscord should have squashed that 00:27 MTDiscord #feeds works though 00:28 MTDiscord ¯_(ツ)_/¯ 00:31 MTDiscord I'd like to close 26 as wontfix since we don't have any other good options 00:33 MTDiscord sure 08:27 MTDiscord This is a kludge. Can't we have something like a macro for it? asciidoc === function_name Description of the function. ==== Usage ---- return_values = function_name(argument1, argument2) ---- ==== Arguments [%autowidth, frame=none] |=== | `argument1` | `type` | Argument description. | `argument1` | `type` | Argument description. |=== OR _None_ ==== Returns [%autowidth, frame=none] |=== | `return_name` | `type` 08:27 MTDiscord | Return value description. |=== 08:28 MTDiscord this formatting should be done by stylesheets, not by Adoc kludges 08:29 MTDiscord I can live with the headers, those are required. The usage is missing a [source,lua] I believe. But the [%autowidth, frame=none] should be set as a default for all tables or the like. 08:51 MTDiscord already asked for a macro, not happening til later 08:51 MTDiscord usage doesnt have a source on purpose 08:52 MTDiscord Im also not sure why you call it a kludge 08:52 MTDiscord Its just asciidoc 08:52 MTDiscord its a perfectly valid way to write it 08:52 MTDiscord its just tedious 08:52 MTDiscord kludge is the wrong word entirely 13:14 MTDiscord Sure, make it less tedious, and more readable, that's always** the goal 14:15 MTDiscord It's not a kludge, its per table styling. It will render into various formats just fine, it's not like it's HTML specific or anything (afaik) 14:17 MTDiscord This is mushing model & view together 14:17 MTDiscord And while it may not be HTML-specific, it certainly is rendering-specific 14:19 MTDiscord Since when was AsciiDoc a styling free language? It's got plenty of knobs to tweak things on a global and per-block basis if needed 14:20 MTDiscord Its not nitty gritty tweaking for most things, but its there 14:21 MTDiscord That being said, setting autowidth and noframe globally would be nice 14:21 MTDiscord Something like emphasis or strikethrough is both styling and semantics 14:22 MTDiscord "autowidth" and "frame" carry no semantics whatsoever, they are purely visuals 14:23 MTDiscord There are times when we'll need to set something purely visual (e.g. [horizontal]), we just need to avoid things that are specific to a single renderer. 14:24 MTDiscord But, if we can set things on a global level thats better 14:25 MTDiscord I didn't see a good way of doing that though from within asciidoc, but maybe its about time we got ourselves an HTML style 15:42 MTDiscord I vote not whatever I'm using for nodecast haha 16:13 MTDiscord i think #12 is done