Time Nick Message 00:00 MTDiscord Maybe interesting idea: Add instrumentation to get_objects_inside_radius to sample some query times. This could be probabilistic for minimal overhead. We could also track some stats (how many entities these return on average, how many calls are made per step on average, etc.) 00:49 MTDiscord Looks like there's a setting to dump them to the log interval, all good 00:51 MTDiscord That said, I do like the idea of better profiling tooling in general, will research what's easy, I know we have that Lua jit profiler working now, and can get solid flame graphs data, just need to package it all nicely 13:06 MTDiscord Does anyone run Minetest on Haiku anymore? We have support for it in the build, which implies we should be testing it. 13:26 sfan5 we can't test everything we have theoretical support for 13:31 MTDiscord But you're paying for that support with build complexity. 13:32 MTDiscord You're paying and you don't even know whether it works. 13:33 MTDiscord The macro that the build sets is deprecated, and I was going to follow the compiler's recommendation to replace it with a different macro, but now I'm questioning whether the macro is even necessary at all. There's no way to find out probably without attempting the build on a Haiku system. 13:33 MTDiscord I'll leave it be for now. 13:40 sfan5 which macro? 13:45 MTDiscord The _BSD_SOURCE macro for glibc feature testing. The compiler recommends to replace it with _DEFAULT_SOURCE, but that macro has slightly different behavior, so we're not guaranteed 100% that it won't introduce an issue, I think. 13:45 sfan5 uh, does haiku even use glibc? 13:46 MTDiscord Maybe whatever it uses alse has a _BSD_SOURCE? Maybe it's not deprecated on whatever it uses, then. I wouldn't spend too much time on it. There are other things that are much easier to test. 13:46 sfan5 yeah 17:23 Krock Will merge #15415 #15466 #15477 in 15 minutes 17:23 ShadowBot https://github.com/minetest/minetest/issues/15415 -- Add `core.spawn_tree_on_vmanip` by cx384 17:23 ShadowBot https://github.com/minetest/minetest/issues/15466 -- Main menu: Fix server selection by appgurueu 17:23 ShadowBot https://github.com/minetest/minetest/issues/15477 -- Network: Fix serialization version checks by SmallJoker 17:26 Krock ignore the first. will re-review later. 17:40 Krock done