Time Nick Message 08:36 SFENCE_arch i did some License info replacements in #15321. Do we want it to be part of 5.10 milestone? 08:36 ShadowBot https://github.com/minetest/minetest/issues/15321 -- Replace licensing text in headers (LGPL 2.1). by sfence 14:22 sfan5 no hurry imo 14:29 MTDiscord About -400KB if my calculations are correct 😉 14:49 grorp #15294 has one approval, so I could merge it. It's not a simple PR though, so perhaps somebody wants to give it another review? sfan5, you requested your review earlier. 14:49 ShadowBot https://github.com/minetest/minetest/issues/15294 -- Rename to Luanti by grorp 14:59 sfan5 I wanted to still test backwards compat with run_in_place=0 15:00 grorp ok 👍 15:39 sfan5 merging #15315, #15316 in like 5m 15:39 ShadowBot https://github.com/minetest/minetest/issues/15315 -- Revert "Use EGL over GLX" by sfan5 15:39 ShadowBot https://github.com/minetest/minetest/issues/15316 -- `core.after`: Improve documentation details about how `time` is handled by Desour 16:25 Wuzzy in the Minetest Wiki and Minetest Developer Wiki (still not renamed btw), is it possible to search for "Minetest" but skip all instances of "Minetest Game"? Would make the renaming so much easier 16:26 Wuzzy Also, is there a way to ignore all non-English pages in the search? They clutter up my results as well 16:27 Wuzzy I've already did a ton of replacements in both wikis so far, but i got no idea what ive overlooked 17:23 MTDiscord Wuzzy: you can do a export of the wiki contents and run grep or similar on the XML data and filter to how you please locally 21:29 [MatrxMT] Can I make a wish and add a PR in the 5.11 milestone as I did with 5.10? It'd be #14427, mostly because I fear the author might enjoy a bath in frustration after all this time 21:29 ShadowBot https://github.com/minetest/minetest/issues/14427 -- Dual wielding (revival) by Andrey2470T 21:30 [MatrxMT] I'm not even interested in what the PR introduces, for my personal projects I mean 21:32 MTDiscord IIRC Andrey was working on a generic HUD mesh API that should supercede that entirely 21:33 [MatrxMT] Oh I thought they changed idea in the end. But I'm probably wrong, sooo.. Never mind 21:34 MTDiscord I wouldnt know ... @andrey2470t? 21:34 [MatrxMT] I'll keep my wish for something else :^] 21:36 MTDiscord should our conf file parser support BOMs? some "editors" produce them which can lead to funny surprises 21:37 MTDiscord bom? 21:37 MTDiscord unicode byte order mark 21:38 MTDiscord ah, thanks 21:38 MTDiscord specifically we just had someone on discord who used libre office to edit their mod.conf (lol) and put depends = ... on the first line, and due to the BOM that was then parsed as ["depends"] = ... so their dependencies weren't registered properly 21:40 MTDiscord If we wanted to be all fancy we could even try to detect encoding this way, but I think it would be good enough to check for a UTF-8 BOM and skip that if present (and error if a UTF-16 BOM is present so that mismatched encodings can be detected). Thoughts? 21:41 MTDiscord Detecting non-plain-text and throwing a meaningful error could be nice too. 21:41 MTDiscord I think we do want to support UTF-8 generally 21:42 MTDiscord Either skipping the BOM, using the BOM, or disallowing text files that contain one could all be sane options. 21:42 MTDiscord It's not 100% reliable to detect invalid plaintext files, but I think there are ways to detect invalid byte sequences in UTF-8, as not ever byte sequence is valid. 21:43 MTDiscord indeed 21:45 MTDiscord tbh we should probably reject utf8 in setting keys but i'd be afraid this breaks someone's german setting names or something 21:46 MTDiscord s/utf8/unicode that is not printable ascii 22:10 MTDiscord @Zughy I may probably continue working on the mesh HUD, but I doubt it will get ready to 5.11, since this is a non-trivial feature and there's even no a PR yet. Also tbh I don't see any interest in the dual wielding itself from others during many months (is it worth to suffer on this feature at all and on a whole code which it requires to refactor/alter in order to obtain the maximal flexibility and benefit from that if it doesn't 22:10 MTDiscord just get any feedback/review as it is probably not the high-priority?) 22:10 [MatrxMT] I think you'll obtain more interest from modders than core devs in general 22:11 MTDiscord As a modder/gamedev, I hate the idea of adding yet another Minecraft-ism and opinionated game feature when the fundamental basis of it (configurable HUD meshes) is far more useful to everyone and more in-line with the values of an engine 22:11 [MatrxMT] I probably agree 22:13 MTDiscord And from a time investment standpoint: Both features will take time to complete (since it sounds like the dual wield needs refactoring); So you could spend some time finishing the lesser PR (which fewer will use) for 5.11, then get the better PR in 5.13, or spend the time working on the better PR (which more will use) in time for 5.12. Those are examples, of course. 22:15 MTDiscord But modders are not mostly the reviewers of the engine code and also only the core devs can approve and merge PRs. So, if they are not interested, how would that feature be brought in the engine? 22:15 MTDiscord That is a whole different can of worms :^) 22:17 MTDiscord Fortunately, in this particular instance, coredevs and modders should be far more interested in a general hud mesh API than a hyper-specific one 22:18 MTDiscord ("Should" being the operative word ... a loud minority may disagree) 22:27 MTDiscord I think it is worth to open an issue for a start for discussing on the details on the general code refactoring and a new API spec 22:31 MTDiscord Although actually I already implemented a big part of the API, but it is to know more exact whether it is done in a correct manner now or not 22:31 MTDiscord Good for a draft PR then, yeah? 22:32 MTDiscord Well or I can create immediately a draft PR 23:25 Juri pebkac or does the util/wireshark/minetest.lua from master not work with wireshark 4.4.1 ? 23:26 Juri i'm in the wrong irc channel again, right? 23:33 [MatrxMT] andrey2470t: I suggest you to create an issue first, as I'd like to avoid labelling that PR as "Roadmap: needs approval" 23:49 MTDiscord Zughy: ok, then I'll do so 23:52 [MatrxMT] thank you :)