Time Nick Message 04:12 MTDiscord Thank you all for your help. You teach me new things about C++ and libraries I never know of... :) 08:09 sfan5 i wonder why the voxelarea tests are all so broken 08:10 sfan5 the code clearly relies on MaxEdge having higher coords than MinEdge but literally half of the test just casually violate this 08:11 sfan5 and then the tests check that the right bogus values come out 08:11 sfan5 programmer must have been half asleep 09:29 sfan5 planning to merge #15238 later 09:29 ShadowBot https://github.com/minetest/minetest/issues/15238 -- Use execvp in fs::RecursiveDelete() by sfan5 13:03 MTDiscord planning on merging #15121 #15216 #14685 in the evening 13:03 ShadowBot https://github.com/minetest/minetest/issues/15121 -- [no sq] Add binary glTF (.glb) support + other glTF improvements by appgurueu 13:03 ShadowBot https://github.com/minetest/minetest/issues/15216 -- Refactor `matrix4.h` by appgurueu 13:03 ShadowBot https://github.com/minetest/minetest/issues/14685 -- [no squash] Add animated glTF support by appgurueu 14:25 MTDiscord Ooh glTF animation support. It's all coming together. 14:39 sfan5 just found out that it's not actually possible to create an empty vmanip that contains data 14:39 sfan5 would be useful for calling generate_ores or generate_decorations or place_schematic_on_vmanip in a vacuum 14:40 sfan5 https://github.com/sfan5/we_env/blob/eb179d7297e477be20a9c8ab97fd28f0c70c6089/init.lua#L135-L140 I thought I was being clever but this actually just tries to load those blocks 15:02 pgimeno is minetest using gmpxx.h? 15:06 pgimeno the reason I ask is because there's a new gmpxx interface that has been announced in the GMP mailing list, https://github.com/nakatamaho/gmpxx_mkII with one important highlight: "Header-Only Library: This library eliminates the need for the libgmpxx library, simplifying integration and deployment." 15:10 sfan5 i dont see a reference anywhere 15:27 sfan5 merging #15238, #15029, #15040 in 11m 15:27 ShadowBot https://github.com/minetest/minetest/issues/15238 -- Use execvp in fs::RecursiveDelete() by sfan5 15:27 ShadowBot https://github.com/minetest/minetest/issues/15029 -- Fix collisions with long dtime, in particular with bouncing by kno10 15:27 ShadowBot https://github.com/minetest/minetest/issues/15040 -- Separate anticheat settings [#2] by zmv7 15:27 sfan5 nevermind not the last one, it's missing a second approval 15:39 sfan5 oh and actually not the second one either since appguru said he wants to review it 😅 15:40 sfan5 Instead i'll merge #15216 15:40 ShadowBot https://github.com/minetest/minetest/issues/15216 -- Refactor `matrix4.h` by appgurueu 15:48 [MatrxMT] Below 100 PRs again, yeyy 16:05 Desour I see, I see, stack_max = 99 for PRs 16:19 MTDiscord Two less when lmd merges them tonight 16:19 MTDiscord Since sfan beat em to the punch on one of them 17:57 [MatrxMT] there's no way we can add SDL without issues, I'm removing the PRs/issues associated with it and creating a revert issue 17:57 [MatrxMT] (in time) 18:02 nekobit anyone into graphics want to look at #15221? this code was hacked in but ive tested it and the elastic scrolling feels nice. It can be disabled now, so if it sucks, it can be disabled 18:02 ShadowBot https://github.com/minetest/minetest/issues/15221 -- Smooth Scrollbar improvements and Elastic scrolling by swagtoy 18:04 nekobit im actually on the fence of disabling elastic scrolling by default, but its a pretty good indicator when you hit the end of something 18:04 nekobit and itll feel much nicer on mobile 18:08 nekobit even if you don't care for elastic scrolling, the removal of the clamp is still a major bugfix 18:10 nekobit I might also set the scroll bar handle to use Target position so it offers immediate feedback 18:10 nekobit when using the scroll wheel? 18:31 Desour it would be good if #15115 gets merged before the next release. the performance issue is a bit more likely to happen since this version (because of correct distance check with bounding sphere 0f7ee12) 18:31 ShadowBot https://github.com/minetest/minetest/issues/15115 -- Add a setting to group transparency sorted triangles by buffer by Desour 18:32 MTDiscord agreed. but note that we have all feature freeze long for that. 18:33 Desour it's a tradeoff, so I wasn't sure how feature freeze applies 18:34 Desour (notice the bug label ;)) 18:34 MTDiscord well, in my book it doesn't have the "feature" tag ;) 18:34 MTDiscord and it's definitely not very terrible in terms of breakage since it's a setting and to the contrary fixes things (performance) 18:35 * Desour removes feature flag from one of his PRs 18:35 MTDiscord :P 18:35 MTDiscord to me the tradeoff should probably be made in favor of performance, so i would probably agree with the default 18:35 nekobit is mine considered a feature? 18:36 MTDiscord case in point: my little brother complained to me about bad fps in certain places in a server he's playing in. 18:36 MTDiscord i looked into it and sure enough it was caused by the transparency sorting; disabling that made fps go from ~20 to ~40 again. 18:36 Desour has he tried with transparency sort distance setting set to 0? 18:36 Desour nekobit: yes 18:37 MTDiscord he then told his friends on that server about it and they also observed significant fps gains when disabling it 18:39 Desour @luatic: good to see you have some lab animals ;) 18:40 MTDiscord yes yes ;P 18:45 MTDiscord planning on merging #15121 and #14685 in 15m 18:45 ShadowBot https://github.com/minetest/minetest/issues/15121 -- [no sq] Add binary glTF (.glb) support + other glTF improvements by appgurueu 18:45 ShadowBot https://github.com/minetest/minetest/issues/14685 -- [no squash] Add animated glTF support by appgurueu 19:04 MTDiscord postponing the latter for a bit. got to resolve some merge conflicts arising after the merge of the former first. 19:10 MTDiscord alright, that was an easy rebase. making sure unit tests still pass and rebuilding to recheck the ingame tests just to make sure however. 19:26 MTDiscord once CI passes i'll merge. 19:40 MTDiscord it is done. 19:42 MTDiscord WOO 19:43 MTDiscord finally we can put #9673 to rest :) 19:43 ShadowBot https://github.com/minetest/minetest/issues/9673 -- Support for more modern mesh format(s) (.gltf) 19:54 [MatrxMT] crazy things in this 5.10 19:55 [MatrxMT] But it sounds like #14343 won't make it in time. Like, two approvals on something that big, do we really want to risk it? (To be clear, I love what it introduces, I'm just erring on the side of caution) 19:55 ShadowBot https://github.com/minetest/minetest/issues/14343 -- Ambient light and server control for it by Andrey2470T 19:56 [MatrxMT] same for #14135, since the author has shown no activities for two weeks 19:57 ShadowBot https://github.com/minetest/minetest/issues/14135 -- Add persistent unique identifiers for objects by sfence 19:57 [MatrxMT] *activity 21:42 sfan5 "do we really want to risk it" imo no 21:48 MTDiscord I think the former (ambient light) is probably close to the finish line and could be high value. 21:49 MTDiscord The only remaining concern I currently have is whether the quantization of light is acceptable. 21:49 * [MatrxMT] had just changed the milestone; started sweating 21:49 sfan5 that's especially why we shouldn't rush it 21:49 sfan5 light_decode_table has a precision of u8, we shouldn't carelessly throw that way 21:49 sfan5 away* 21:49 MTDiscord agreed 21:50 MTDiscord I mean if we stick to this faster paced schedule it's no drama if it has to wait for 5.11 I suppose 21:50 [MatrxMT] I'll remove 14135 as well then 21:52 [MatrxMT] #14659 has the prerequisites for being merged, so that leaves us with no features left in the milestone. Yey, we're on time! 21:52 ShadowBot https://github.com/minetest/minetest/issues/14659 -- [no sq] Generic IPC mechanism between Lua envs by sfan5 21:55 [MatrxMT] about #15193, we'll run more tests on Wednesday. It'd be nice to know what/how to test exactly though, since both the suggestions seem more like wild guesses? 21:55 ShadowBot https://github.com/minetest/minetest/issues/15193 -- Different globalstep compared to <5.9? 22:01 [MatrxMT] last but not least, why the pipeline is failing in #15078? And what's left to do sfan5? 22:01 ShadowBot https://github.com/minetest/minetest/issues/15078 -- [no-sq] Return SRP-style hash from `minetest.get_password_hash` by red-001 22:27 MTDiscord I cannot figure out how to turn on water reflections 22:28 MTDiscord Waving water is enabled 22:28 MTDiscord oh im stupid 22:28 MTDiscord Im on 5.9.1 22:28 MTDiscord sorry