Time Nick Message 06:30 MTDiscord sfan5: Your code didnt compile btw, just pinging you incase ur on 06:30 MTDiscord Im going to juse use a c++ template enable_if, which does the job similar to your weird [[maybe_unused]] hack 06:31 MTDiscord also im pretty sure there are specified type intrinsics for char array types 06:32 MTDiscord Oh, and if you're bored, take a look at the video in #15221. I copied it from Osu! but i wasn't sure if everyone was going to like it. 06:32 ShadowBot https://github.com/minetest/minetest/issues/15221 -- [DRAFT] Smooth Scrollbar improvements and Elastic scrolling by swagtoy 06:33 MTDiscord or https://files.catbox.moe/krmg8x.mp4 09:01 MTDiscord hello, merging #15207 09:01 ShadowBot https://github.com/minetest/minetest/issues/15207 -- Network: offload often changed constants to source file by SmallJoker 12:36 pgimeno it strikes me as odd that *_PROTOCOL_VERSON_MAX was renamed to LATEST_PROTOCOL_VERSION yet *_PROTOCOL_VERSION_MIN was not renamed to something like e.g. EARLIEST_SUPPORTED_PROTOCOL_VERSION 12:37 pgimeno it makes code that uses *_PROTOCOL_VERSION_MIN and LATEST_PROTOCOL_VERSION harder to understand 12:37 pgimeno pinging Krock ^ 16:05 Mantar min/latest? sounds normal for minetest, where we don't use over/under or above/below, but instead do above/under 16:45 MTDiscord Also extra points for switching from THING_MIN/THING_MAX to MOST_THING/LEAST_THING to ensure that THING-related things don't lexically sort near one another. 16:48 Krock pgimeno: I chose to pick what resulted in the least changed lines. Thing is that min and max are both subject to the handshake between server and client 16:51 Krock I intentionally kept the PR open for a few days to collect feedback 16:53 Krock yours is one way to look at it. I think that "latest" does express very well that it equals the current development progress, whereas "max" can be rather seen as a hard limit; and not a variable that is changed twice or three times a year 17:15 MTDiscord sfan5: are you there? 17:15 MTDiscord wondered if you could help me live with your suggestion 17:30 Krock probably just afk. 17:31 MTDiscord sfan5bros..... we lost .... 17:31 MTDiscord drop your stocks... 23:15 MTDiscord Can still anybody review and test #15061 please? I've made a few changes in the PR and that gave a much higher gain in the performance than as it was before. Generally, the reason was in the bad batching by texture within mapblock and also I took away the grouping the buffers in the ClientMap::renderMap() by a mistake. So that created a big count of unnecessary textures switches and multiple of buffers. 23:15 ShadowBot https://github.com/minetest/minetest/issues/15061 -- Texture atlas for mapblocks meshes by Andrey2470T 23:18 MTDiscord Now with the view range = 190 and with all disabled visual effects, I get at middle 380-430 FPS and 1-2 drawtime against 120-170 with the drawtime in dozens of milliseconds 23:19 MTDiscord If there are no transparent blocks around, I can get even until 480 in the best case