Time Nick Message 03:08 MTDiscord done, hopefully i tested correctly this time. sorry about previouslyt 12:12 [MatrxMT] luatic re https://github.com/minetest/minetest/issues/15053#issuecomment-2308804643: it's low priority if anyone starts reviewing the formspec/HUD replacement PR - something that hasn't happened yet 12:13 [MatrxMT] considering the amount of things we already have for 5.10 though, it'd make more sense schedule it for 5.11 13:04 MTDiscord Zughy: I just consider it low priority personally, e.g. I probably won't review a corresponding PR. 13:05 MTDiscord I still think that the priority doesn't depend only on review of the replacement, because as said, so far this feature seems redundant to me - 9-slice is more flexible. 13:09 MTDiscord ignoring a pr is not fun and discourages developers. You should form a plan and stick to it if you can. If that means clearly stating that this pr won't get merged for a while and maybe ever, that's much better. 13:12 [MatrxMT] which is why I proposed 5.11 13:12 MTDiscord I haven't ignored the feature request (there is no PR yet, though it seems the issue author has already implemented this). 13:12 MTDiscord I commented on it, to point out that I consider it low priority, which is the basis of this discussion. 13:13 MTDiscord I hope this communicates clearly enough that I won't get to reviewing a PR for it unless a miracle happens or my mind is changed, because there are plenty of PRs to review which I consider higher priority. 13:15 [MatrxMT] I think it's pretty clear, don't worry :P 13:16 MTDiscord By the way, I must admit, unfortunately it's not that easy - "reject or accept". Ideally it would be, but with too little time what practically happens is that I do sort of a "pre-screening" to see what I spend my time on. 13:16 MTDiscord After this pre-screening, I don't have enough confidence to say "this PR is bad and should be rejected" - such a definitive judgment would require more time investment. 13:36 [MatrxMT] Minetest as a venture capital company when? Let me hear those cryptos 15:16 rubenwardy @luatic currently it's not possible to use Minetest with a keyboard only as you can't see focus. Adding outline styling and using it by default for focus would make it not low priority 15:21 MTDiscord How would you use Minetest without a mouse for normal gameplay, though? 15:23 MTDiscord I don't think it's possible to bind looking around to a keyboard... and even then, I don't think any game had looking with just keyboard with continously variable pitch. 15:23 rubenwardy You can bind the arrow keys to rotate the camera 15:23 rubenwardy Also with a gamepad we'll need visible focus 15:24 MTDiscord For gamepads you're right 15:24 MTDiscord Although I think many games do a cursor moved with an analog stick 15:26 MTDiscord Also I haven't seen the "arrow keys camera control" thing 17:04 MTDiscord yeah lars, sorry, that was an irresponsible comment. 18:08 [MatrxMT] #15035 is pretty trivial if you want to get rid of a PR easily 18:08 ShadowBot https://github.com/minetest/minetest/issues/15035 -- DOCS: clarify `stepheight` upper limit by Zughy 18:11 Mantar I have mousekeys enabled which allows me to look around using the keypad, actually 18:12 Mantar (it's a little funky with key release though) 18:14 MTDiscord i was going to raise mine as more trival, but instead ill raise https://github.com/minetest/minetest/labels/Trivial 😛 20:12 MTDiscord I got a packet log for the server freeze crash I mentioned earlier. One immediately obvious thing is I don't have a ratelimit on a formspec button that writes to player meta. So there may not be any engine issue to account for unless a lua limit doesn't work 20:13 sfan5 feel free to privately share with me 20:57 MTDiscord Sfan5: be a few hours till I can test flickering issue again, how does one force opengl3 for testing? 20:58 sfan5 conclusion: nothing actionable for the engine, just a flood of formspec actions 20:58 sfan5 best we could do is rate-limiting formspec submissions as part of the anticheat code 20:59 sfan5 wsor4035: no hurry. make sure you enable sdl & opengl3 in cmake and then use video_driver = opengl3. you can verify it in the verbose log 21:01 MTDiscord I assume the video_driver is for minetest.conf? And will do in a few hours 21:02 sfan5 yes 21:03 MTDiscord Thanks 22:52 v-rob Some thoughts on https://github.com/minetest/minetest/pull/14263#issuecomment-2309025916 please. This has been a problem for some time. 22:54 v-rob Take your pick: Merging experimental and/or dead code | Merging a huge PR | Merge nothing and make v-rob's life hard 22:54 v-rob Or, I guess: Live with formspecs until the crack of doom 22:58 v-rob Or also: Make everything an unreviewable mess 22:58 v-rob Yeah, lots of bad options. 23:00 MTDiscord while not great for reviewing, everything in one branch is easier to test as a modder 23:04 MTDiscord if i was going to think of large prs before set_sky (8964) and hypertext (8680) both of those only touch ~20 files, of which part 1 is already double 23:05 v-rob For development, I would DEFINITELY prefer one big PR. I'd still be dealing with interactive rebase to keep commits clean and reviewable, but I wouldn't have to worry so much about making a useful PR out of a subset of the code.