Time Nick Message 04:16 SFENCE Noisytoot: 0.5.10 means 5.10 10:41 sfan5 given 5.9 is essentially ready should I import the translations yet? 10:45 [MTMatrix] It's two month long feature freeze, sure 12:17 rubenwardy Merging #14944 12:17 rubenwardy in 10 12:17 ShadowBot https://github.com/minetest/minetest/issues/14944 -- Disable SDL2 for 5.9.0 by rubenwardy 14:33 rubenwardy So, translations update and release today? 15:06 sfan5 if you do the rest sure :) 15:06 sfan5 i'll update weblate now 15:07 nrz finally ! 15:17 sfan5 commits here https://github.com/minetest/minetest/commits/ci/ 15:17 sfan5 will push to master after CI and a brief check 15:32 rubenwardy generate_from_settingtypes needs a run as well 15:33 sfan5 didn't we do that already? 15:34 sfan5 ah there's one setting missing 15:37 sfan5 all done 15:41 rubenwardy #14956 web#307 15:41 ShadowBot https://github.com/minetest/minetest.github.io/issues/307 -- Update credits for 5.9.0 by rubenwardy 15:41 ShadowBot https://github.com/minetest/minetest/issues/14956 -- Use JSON file for credits by rubenwardy 15:42 sfan5 : 15:42 sfan5 πŸ‘ 15:42 MTDiscord i'd like to merge #14955 in 10m 15:42 ShadowBot https://github.com/minetest/minetest/issues/14955 -- Fix empty tables / text lists emitting row events by appgurueu 15:44 rubenwardy looks good 15:44 rubenwardy I suppose if a mod depends on this behaviour, they could do " " instead of "" 15:45 rubenwardy have you "Correct special strings on Weblate (`LANG_CODE`)" 15:45 rubenwardy oh I can just check that 15:47 rubenwardy looks correct, except for Toki Pona (tok) which was missing. I suppose that's not enabled anyway 15:48 MTDiscord gg for 5.9 to all devs 15:48 MTDiscord (i've seen that you're doing the releasing stuff) 15:49 MTDiscord Do I get credits for weblate translation anywhere? Aside of the commit log ofc 15:50 rubenwardy unfortunately we don't have translator credits currently 15:51 MTDiscord Ok 15:51 rubenwardy definitely something you'd want to automate 15:51 MTDiscord shouldn't be difficult to make gather_git_credits.py collect translation credits from the git log in addition to code changes, if anyone were interested in doing that 15:53 rubenwardy merging #14955 15:53 ShadowBot https://github.com/minetest/minetest/issues/14955 -- Fix empty tables / text lists emitting row events by appgurueu 15:54 rubenwardy oh nevermind 15:54 rubenwardy luatic: it's been 10 15:54 MTDiscord done 15:54 rubenwardy nice 15:55 rubenwardy #14957 15:55 ShadowBot https://github.com/minetest/minetest/issues/14957 -- Release 5.9.0 by rubenwardy 16:00 rubenwardy am I ok to push to master + push tag + then merge master into stable-5? 16:03 sfan5 looks good 16:07 rubenwardy how do I merge from master to stable-5? 16:08 sfan5 its on the wiki page 16:08 rubenwardy aha 16:11 rubenwardy I can't test the windows builds so someone else will have to do that 16:12 * sfan5 afk to water some plants 16:13 rubenwardy I'm sure it's fine 16:13 * rubenwardy waits for the android build 16:14 sfan5 I tested the "turn sdl off" PR artifact on real windows fwiw 16:30 MTDiscord still waiting for test on Windows? 16:33 Krock rubenwardy: wine can test the Windows builds pretty well 16:33 rubenwardy ahhhhhhhh 16:34 rubenwardy Android build code 48 has already been used by 5.8.1, but the master branch wasn't bumped 16:35 SFENCE I have native windows on second ntb, better to test here then in wine I think. Wine is good, but sometimes something works on Windows and not in Wine. 16:36 rubenwardy we should just generate build codes based on major.minor.patch 16:50 sfan5 rubenwardy: I guess we should write down "verify the android versionCode was not used by another patch release" in the checklist 16:52 [MTMatrix] how do we solve this now? is just building manually with a different version code the solution? 16:53 Krock push fix and re-tag 16:54 Krock SFENCE: but if it works in wine, we can be pretty sure that it also works on Windows :) 16:59 rubenwardy I think sfan5 likes this PR https://rwdy.uk/1ItT3.png 17:00 rubenwardy technically should be >= two approvals 17:00 rubenwardy I've already sent the launchpad build off so may have to be 5.9.1 for android 17:00 rubenwardy we can just build with a fixed versionCode but would confuse F-Droid 17:06 luatic the channel topic could use a change 17:06 sfan5 have fun 17:06 Krock /kick Krock 17:09 luatic while you're here Krock, you mentioned a while ago that you were working on a changelog, would you like some help with that? 17:09 rubenwardy !dev Changelog 17:09 ShadowBot Changelog - Minetest Developer Wiki -- http://dev.minetest.net/Changelog 17:09 rubenwardy it's here already 17:10 luatic great 17:10 sfan5 now that the release is done would be nice if we could get #14825 in soon it receives immediate real-world use 17:10 ShadowBot https://github.com/minetest/minetest/issues/14825 -- Rework object attachment handling to fix bugs by sfan5 17:11 Krock luatic: thanks for the offer. I already finished it about 2 or 3 weeks ago 8) (engine only, no MTG) 17:11 Krock sfan5: great reminder. I'll test it quickly 17:11 luatic i suppose i could work on a blog post 17:12 rubenwardy that would be great 17:22 rubenwardy so for the android issue, looks like f-droid does override the version code anyway 17:24 sfan5 then we can ignore that, great. 17:25 Krock how about the PlayStore? 17:25 sfan5 we control what is uploaded there 17:26 rubenwardy I can make a build locally with a fixed versionCode 17:32 rubenwardy luatic: there may be some newer things missing from the changelog, as Krock last updated 27th July it appears 17:32 nrz amazing for the release, great job, i can now rebase my PR to ensure they are fixed/merged πŸ™‚ 17:35 sfan5 also here's a tiny PR which just needs an opinion #14897 17:35 ShadowBot https://github.com/minetest/minetest/issues/14897 -- Render clouds as flat when thickness is zero by sfan5 17:38 rubenwardy makes sense to me 17:40 MTDiscord seems these prs can be merged in now? https://github.com/minetest/minetest/pulls?q=is%3Aopen+is%3Apr+label%3A%22%3E%3D+Two+approvals+%E2%9C%85+%E2%9C%85%22 17:41 MTDiscord also was a descision ever reached on the new way of doing releases for 5.10? based off the suggestion 17:42 sfan5 as far as I'm concerned we can write it down and abide by it in the future 17:46 rubenwardy I've set a due date for 5.10.0 in 2-3 months at the end of October, lets start feature freeze on time and not delay the release for features 17:48 rubenwardy if we want a big feature in for a release, we should get it ready for merge in the first half of the dev cycle. Ideally first few weeks 17:49 rubenwardy and not delay the release for it 17:49 rubenwardy ex #14557 17:49 ShadowBot https://github.com/minetest/minetest/issues/14557 -- Add static glTF support by JosiahWI 17:51 sfan5 I plan to re-review that, it's probably ready 17:53 MTDiscord sfan5 we had a bug report from a beta tester and I don’t think we investigated it yet. 17:53 MTDiscord I may be forgetting. Lars probably knows more. 17:59 sfan5 rubenwardy: hows the builds status 18:00 Krock will merge #14882 #14877 #14820 #14179 in 15 minutes 18:00 ShadowBot https://github.com/minetest/minetest/issues/14882 -- Add sam to testentities by appgurueu 18:00 ShadowBot https://github.com/minetest/minetest/issues/14877 -- Improve fs::PathStartsWith to handle empty strings by asrelo 18:00 ShadowBot https://github.com/minetest/minetest/issues/14820 -- Optionally hide player names on the serverlist by Emojigit 18:00 ShadowBot https://github.com/minetest/minetest/issues/14179 -- Add possibility to easier override HP and breath engine logic by Lua. by sfence 18:01 Krock #14948 too, while I'm at it 18:01 ShadowBot https://github.com/minetest/minetest/issues/14948 -- Lua API: fix OOB array access in find_nodes_near by SmallJoker 18:07 rubenwardy sfan5: android build is uploaded and awaiting Google review 18:08 rubenwardy I'll upload apks when I'm back at my laptop tomorrow/late tonight 18:10 sfan5 windows and osx? 18:10 Krock will merge #14959 too, so that the development can continue there asap. implicit approval from my side. 18:10 ShadowBot https://github.com/minetest/minetest/issues/14959 -- Revert "Disable SDL2 for 5.9.0 (#14944)" by rubenwardy 18:14 rubenwardy Windows and MacOS are both done on CI now right? 18:14 sfan5 yea 18:16 Krock merging 18:16 Krock or are there objections? I suppose 5.9.0 patches can be added to stable-5 if necessary? 18:17 sfan5 it's fine 18:18 Krock thanks 18:18 sfan5 too late to withdraw 5.9.0 now and we've solved the android thing anyway 18:20 Krock #14179 needs re-review after potentially large rebase 18:21 ShadowBot https://github.com/minetest/minetest/issues/14179 -- Add possibility to easier override HP and breath engine logic by Lua by sfence 18:21 Krock done 18:21 Krock 5/6 merged 18:42 Krock sfan5: the documented workaround for clearing the settings does not work on Android 6. https://pastebin.com/raw/PydYWxsB 18:44 sfan5 super old android versions unfortunately have a broken run-as 18:47 MTDiscord Those versions of Android should be able to remove it without run-as 18:47 MTDiscord IIRC 18:50 Krock o shit. this might be one of the last few tests on Android 6. The battery is about to give up. 19:29 sfan5 fyi for people with access: I plan to publish the two draft security advisories tomorrow https://github.com/minetest/minetest/security/advisories 19:53 sfan5 question: who thought that naming a file world.mt was a good idea when we usually use .txt to keep files (presumably) user-editable? 19:56 Krock sfan5: or rather .conf? 19:56 sfan5 well okay 19:56 sfan5 still a weird chice 19:56 sfan5 +o 19:57 Krock I suppose we could rename it but the legacy code will have to stay forever 21:44 sfan5 uh 21:45 sfan5 so now we have a release without official builds, website not updated and no forum post? 21:59 Desour a secret shadow release (βŒβ– _β– ) 22:58 MTDiscord i just realized while working on the blog post that the default for num_emerge_threads is 1. we might want to change that. 22:59 MTDiscord unless the mapgen shelf bug has been fixed, probably not 23:00 MTDiscord #9357 23:00 ShadowBot https://github.com/minetest/minetest/issues/9357 -- Mapgen: "Unfinished" y-slices with num_emerge_threads > 1 23:04 luatic welp 23:04 luatic the warning mentioned in that issue isn't quite there anymore for some reason 23:05 luatic bummer, this impedes the multithreaded mapgen shill i was writing for the blog post. 23:06 Desour the good thing of the mapgen thread is that it doesn't block the server thread 23:06 luatic yeah i'm aware 23:06 luatic but it reduces from "multithreaded mapgen" to "async mapgen on another thread" 23:07 MTDiscord it never was about multithreading, iirc, but 🀷 23:07 luatic (which is still great but not as great as being able to tell server owners they can finally put those n cores to good use...) 23:08 rubenwardy It does put more cores to use 23:08 rubenwardy Just not n cores, yet 23:26 rubenwardy finishing release now 23:50 rubenwardy @luatic: are you likely to have the blog post done on monday? Wondering about delaying discord/matrix/mastodon announcements for that 23:55 luatic rubenwardy: should be possible to get it done today, yes