Time  Nick       Message
17:46 sfan5      something like that yes
18:25 sfan5      if you think about it that doesn't actually work because there's no guaranteed relation between parent and child id
18:25 sfan5      or between objects created early and later
18:25 sfan5      but someone at the time said it helped so we skipped the arguing and merged the "fix"
18:26 sfan5      merging #14663, #14675, #14678 in 10m
18:26 ShadowBot  https://github.com/minetest/minetest/issues/14663 -- Restore vector type check by OgelGames
18:26 ShadowBot  https://github.com/minetest/minetest/issues/14675 -- Allow removal of item definition fields by appgurueu
18:26 ShadowBot  https://github.com/minetest/minetest/issues/14678 -- Update SDL for mingw builds by sfan5
18:26 MTDiscord  <luatic> sfan5: yeah, that's what's confusing me. is there anything stopping us from converting to an unordered map for an expected ~2x performance boost
18:27 sfan5      you will make the people who wanted the original fix sad
18:27 MTDiscord  <jordan4ibanez> Welp, get them some tissues and fire up that pr machine
18:36 MTDiscord  <luatic> alright i think what it was supposed to fix
18:37 MTDiscord  <luatic> i think both the server and the client should make sure to send attached entities according to a topological order
18:38 MTDiscord  <luatic> well in the case of the client s/send/process
18:38 MTDiscord  <luatic> e.g. ensure parents are processed first
18:39 Krock      except that you can attach and detach objects on the fly
18:39 Krock      so re-ordering will be necessary during runtime
18:41 MTDiscord  <luatic> yes of course
18:42 MTDiscord  <luatic> but topological ordering is linear time
18:42 MTDiscord  <luatic> you could run it every step; it wouldn't be an issue
18:43 MTDiscord  <luatic> i'm willing to go out on a limb and say i can fix the issue in ideally < 50 loc while probably improving serverside performance ;)
18:43 MTDiscord  <luatic> though that will have to wait till thursday
21:00 [MTMatrix] <Zughy> Feature freeze when? It'd be better not to delay the release even more
22:03 Mantar     Not to suggest delaying the release or anything, but somebody asked about #13019 yesterday. It's been sitting since February.
22:03 ShadowBot  https://github.com/minetest/minetest/issues/13019 -- Add trailgen mapgen: v6-like with biome API support by Cartmic
23:35 MTDiscord  <greenxenith> #14680 trivial doc pr btw
23:35 ShadowBot  https://github.com/minetest/minetest/issues/14680 -- Fix and clarify skybox texture order documentation by GreenXenith