Time  Nick       Message
08:47 rubenwardy I agree with reverting inventory changes if needed. The inventory code should be heavily unit tested imo, it's been a huge source of regressions in the past
09:05 sfan5      unit testing UI code is sadly a bit harder
15:17 sfan5      reviews needed: #14568, #14539
15:17 ShadowBot  https://github.com/minetest/minetest/issues/14568 -- Add minetest.get_gen_notify to mapgen env by sfan5
15:17 ShadowBot  https://github.com/minetest/minetest/issues/14539 -- Gate disabling of fog or camera update behind 'debug' priv by sfan5
15:32 pgimeno    wouldn't 14568 fall within the new merge rule?
15:32 sfan5      touches API
15:42 pgimeno    and doesn't it count as trivial? it's just a forgotten function
15:43 sfan5      I guess
15:43 sfan5      depends on how strictly you interpret the rules
15:44 pgimeno    I know it doesn't count but LGTM
16:52 grorp      more PR promotion: is there someone who wants to review #14348 (stale for 2mo) and #14475 (stale for 1mo)?
16:52 ShadowBot  https://github.com/minetest/minetest/issues/14348 -- Expose analog joystick input to the Lua API by grorp
16:52 ShadowBot  https://github.com/minetest/minetest/issues/14475 -- Add physics overrides for walk speed and Fast Mode (adoption) by grorp