Time  Nick       Message
10:12 MTDiscord  <andrey2470t> sfan5, as to my PR: why do you suggest to add only an ambient light level, but not color? The artificial and natural colors relate to other light components, they can not fully substitute the ambient one. So, setting the ambient light color is necessary.
10:13 MTDiscord  <andrey2470t> And the ambient light exist dependently from the remain light sources
10:17 MTDiscord  <andrey2470t> And in order to apply the ambient light to particles, it is necessary to adjust m_color property of the Particle class. I need only to find out how it should be done.
10:33 sfan5      did you see the other PR I referenced?
10:34 sfan5      nvm it seems you did
10:35 sfan5      how does the general color "offset" added by it not replace ambient light color?
12:26 MTDiscord  <andrey2470t> Well, do I have to worry about which conflicts that PR would cause if it gets merged first? If it is done, I will do the corresponding changes then.
16:00 MTDiscord  <herowl> I am pretty sure that the offset is just sun color offset independent of day/night ratio. From reading the changes in the PR it seems that it won't work underground.
16:01 MTDiscord  <herowl> And underground is one of the main concerns.
18:13 [MTMatrix] <Zughy> Isn't #14508 a little too rich, feature-wise?
18:13 ShadowBot  https://github.com/minetest/minetest/issues/14508 -- Various visual effects by GefullteTaubenbrust2
18:26 rubenwardy yeah, that's a very kitchen-sink PR
18:46 Krock      a very shiny and nice-looking kitchen sink tho
18:46 rubenwardy agreed
18:47 sfan5      should be reasonable to split up
19:15 [MTMatrix] <Zughy> We should tell them, but I don't know how you'd like to see it split