Time  Nick       Message
16:57 grorp      cute little PR looking for love: #14466
16:57 ShadowBot  https://github.com/minetest/minetest/issues/14466 -- Remove excessive touchscreengui.h includes by grorp
18:59 Krock      will merge #12595 in 15 minutes. I can also wait if someone else would like to test it first.
18:59 ShadowBot  https://github.com/minetest/minetest/issues/12595 -- [NO SQUASH] Inventory: Fix order of callbacks when swapping items by SmallJoker
19:13 Krock      merging
19:45 sfan5      other PRs in need of reviews: #14423 #14433 #14427 #14416 #14364 #14348 #14347 #14230
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14423 -- [no sq] Server bug fixes and unit tests by sfan5
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14433 -- Move values the mainmenu caches to dedicated file(s) by sfan5
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14427 -- Dual wielding (revival) by Andrey2470T
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14416 -- Translation updater: Add comment propagation by srifqi
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14364 -- Hypertext: accept em as a length unit by y5nw
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14348 -- Expose analog joystick input to the Lua API by grorp
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14347 -- Item meta pointing range by cx384
19:45 ShadowBot  https://github.com/minetest/minetest/issues/14230 -- Docker image workflow (publish on `ghcr.io`) by AFCMS
19:52 [MTMatrix] <Zughy> Also waiting for feedback about the name for months. Celeron seems gone?
20:17 MTDiscord  <luatic> sfan5: #14347 already has my approval, if you now give it your second approval you can go ahead and merge it
20:17 ShadowBot  https://github.com/minetest/minetest/issues/14347 -- Item meta pointing range by cx384
20:17 sfan5      oops, looks like I got confused about approval count last time
20:19 MTDiscord  <luatic> btw Zughy: would it make sense to tag PRs marked as "ready for reviews" by core devs as one approval? should we maybe add a new tag "core dev PR" or something?
20:19 MTDiscord  <luatic> searching for one approval PRs is useful, but currently we can't conveniently search for "implicitly"-approved coredev PRs
20:20 [MTMatrix] <Zughy> As far as I remember the author approval is not implicit, so that's why it's best to check with them first
20:20 [MTMatrix] <Zughy> adding another tag would make things more bureaucratic
20:21 MTDiscord  <luatic> okay, if i approve my own PR, can i tag it as "one approval" to convey that?
20:21 MTDiscord  <luatic> (i will generally mark my own PRs where I think there's still necessary work to be done as drafts)
20:21 sfan5      that also sounds quite bureaucratic
20:22 sfan5      my personal expection is that coredevs will merge their own PRs (unless there's a reason not to) once they reach one approval, within a reasonable time
20:22 MTDiscord  <luatic> it's less about merging and more about discovery
20:23 MTDiscord  <luatic> i am hoping for a good way to find PRs by core devs
20:25 sfan5      you can script github using the api :)
20:25 MTDiscord  <luatic> indeed
20:25 MTDiscord  <luatic> well for now i think i will use the workaround described in https://github.com/orgs/community/discussions/53454, that should be good enough
20:28 Desour     since we're advertising PRs right now, I'll leave #13355 here. maybe I won't have to rebase it again
20:28 ShadowBot  https://github.com/minetest/minetest/issues/13355 -- [MANUAL SQUASH] Precompiled headers support by Desour