Time Nick Message 08:15 MTDiscord Please re-review #13020 08:15 ShadowBot https://github.com/minetest/minetest/issues/13020 -- 3d line rendering. by Andrey2470T 08:23 MTDiscord I assume it makes sense to close it, if it is not being reviewed so long and not gonna be reviewed further 08:58 sfan5 merging #13370, #14153 in about 10m 08:58 ShadowBot https://github.com/minetest/minetest/issues/13370 -- Rework server stepping and dtime calculation by Desour 08:58 ShadowBot https://github.com/minetest/minetest/issues/14153 -- [no squash] Address some clang-tidy warnings by sfan5 11:12 MTDiscord Hello! Could you look at mine PR? A day passed... They only added a label... When I made the first PR, after half an hour there was already a response from the developers... #14157 11:12 ShadowBot https://github.com/minetest/minetest/issues/14157 -- Fix bug with text and added function to save chat in debug.txt by FoxLoveFire 11:13 MTDiscord I apologize for my lack of patience 12:01 MTDiscord Andrey01, please do not close it... development moves very slowly around here. Just keep asking and otherwise be paitent. 12:03 pgimeno +1, I'd really love to have a fishing line for the fishing mod 12:03 pgimeno I'm sure it will eventually happen 12:09 MTDiscord I don't really understand why my PR is just ignored by everyone for many months (starting since Jule), however all remain PRs get a review more or less or even just any feeback from someone. And even those which is far not on the roadmap. 12:14 celeron55 i'd say you're on the exact right track by linking it here and reminding the review process stopped without reason - now the right thing to do is to give it more time 12:14 celeron55 (it's probably the worst time of the year to ask for any reviews to happen, though) 12:21 celeron55 the PR doesn't look to me to be in a particularly bad place. personally i assumed it was taken care of already but there it is still no doubt. if anything, you should have notified here earlier 12:23 celeron55 overall it's very difficult to define when a new feature with new visuals, new api and a new network protocol is good enough. i can see why people might have been avoiding it 12:23 MTDiscord I notified here a few times earlier asking about reviewing it 14:30 grorp andrey2470t: I left a review on #13020. There's a lot left to be done :) 14:30 ShadowBot https://github.com/minetest/minetest/issues/13020 -- 3d line rendering. by Andrey2470T 16:17 MTDiscord @grorp I see. Thanks. 18:48 sfan5 planning to push https://github.com/minetest/minetest/commit/5405a558fd1bd76c4d04aa409c43ef31e3f39640 in 15m or whenever 18:55 Krock LGTM 19:42 Krock sfan5: I'd like to inform you that your plans are overdue 22:41 sfan5 indeed 22:41 sfan5 I went and watched a movie instead 22:42 MTDiscord was it good? 22:43 sfan5 yes 22:43 MTDiscord what was it? 22:45 sfan5 https://en.wikipedia.org/wiki/Die_Hard a christmas-appropriate movie 22:45 MTDiscord a true classic