Time Nick Message 13:41 sfan5 https://github.com/Archtec-io/bugtracker/issues/137 13:41 sfan5 ^ oh wow, look at all the references here 13:42 sfan5 maybe we have a discoverability problem because nobody can look at the terminal output on windows 13:42 sfan5 (I always run Minetest in a terminal here) 13:47 Desour the warnings were also printed to chat iirc 13:47 Desour I've also ignored them for years 13:47 Desour or used that one setting to mute deprecation warnings 13:49 Desour a broken node will be more noticable than just a warnings. having both at once would be nice imo 13:51 MTDiscord Desour: There is a setting for whether warnings are printed to chat; I have it on. 13:52 MTDiscord "chat_log_level" 13:52 MTDiscord <.niklp> I think the major issue is that modders often look in the serverlog, but only very rarely into the client log 13:52 Desour ah, chat_log_level is error by default 13:52 Desour I don't remember when I've changed that, so I assumed I was using defaults x) 13:54 MTDiscord Are we abandoning MSVC builds? I thought I heard something about that but I can't quite remember 14:04 rubenwardy Any chance you could readd the use_texture_alpha warning? But at node def time. Would help people find these issues 14:06 Desour it was at client nodedef load time iirc. warning at server node def time would require the server to read textures 14:47 MTDiscord irr#266 #14132 14:47 ShadowBot https://github.com/minetest/minetest/issues/14132 -- Debug Assertion Failure in MSVC xutility 14:47 ShadowBot https://github.com/minetest/irrlicht/issues/266 -- Invalid comparator: vector3df/vector2df operator< 14:47 MTDiscord I want that Unconfirmed Bug label replaced with a Bug label. 🙂 14:49 MTDiscord Unless someone else especially wants to try to fix it I am planning to add it to my TODO. 15:09 MTDiscord I read the result of the test wrong. I guess I'll need to keep trying. 15:11 rubenwardy Desour: can't you just warn when it's a Boolean and not a string 15:35 MTDiscord <.niklp> Many of those nodes set no use_texture_alpha param in their def 16:48 Desour rubenwardy: I thought the issue was that mods don't provide use_texture_alpha at all. bools could of course cause a deprecation warning 17:03 MTDiscord IIRC we've had a separate deprecation warning for a while about mods not specifying use_texture_alpha and having it auto-detected. 17:57 sfan5 if the api docs say booleans are deprecated then yes we should warn for that 18:09 MTDiscord re Debug Assertion Failure in MSVC: I don't think the problem is a NaN. It was a pretty good hypothesis, but the evidence seems to be pointing away from it. 18:15 MTDiscord It's the morelights_chain_ceiling.obj model from the morelights mod. 18:16 MTDiscord What evidence is pointing away from it? 18:19 MTDiscord I added assertions for isnan to the operator< implementation this morning and none of them triggered, and now I applied your patch with some modifications and still got the same error as before. 18:19 MTDiscord If there were a NaN we should have been able to detect or deal with it. 19:14 MTDiscord Looks like sfan5 beat me to it. Very nice. 19:42 MTDiscord Custom comparators are full of surprises 20:05 sfan5 merging #12388, #14117, #14127, #14128 in 15m 20:05 ShadowBot https://github.com/minetest/minetest/issues/12388 -- Extend bone override capabilities by appgurueu 20:05 ShadowBot https://github.com/minetest/minetest/issues/14117 -- Fix touch input on Linux by grorp 20:05 ShadowBot https://github.com/minetest/minetest/issues/14127 -- Enable segment heap on Windows by sfan5 20:05 ShadowBot https://github.com/minetest/minetest/issues/14128 -- Fix TouchScreenGUI ignoring server-sent pitch changes by grorp 20:05 sfan5 I hope someone has tested 12388, if not our users will be the testers 20:07 sfan5 given all the recent PRs by sfence I don't think there's hope we can properly test everything 20:08 jonadab "You never find all the bugs until the end users get their hands on it." 20:15 [MTMatrix] Users as Guinea pigs 20:16 [MTMatrix] (Don't harm Guinea pigs; users maybe) 20:36 sfan5 anyone available to quickly look and give a +1? for this: https://github.com/minetest/minetest/commit/3f8284d62a9d906ac8b08499d585b9fe23043214 20:36 sfan5 conceptually trivial 20:37 sfan5 ...except I forgot to rename them properly 20:39 sfan5 I guess I'll just create a pr 20:58 lhofhansl sfan5: I just noticed that #14127 crashes Minetest on exit from a Game. :( 20:58 ShadowBot https://github.com/minetest/minetest/issues/14127 -- Enable segment heap on Windows by sfan5 20:58 lhofhansl (see comment on the PR) 21:55 sfan5 I'll check 22:02 sfan5 can confirm, but only happens after an in-game session 22:02 sfan5 0x00007ff79cca5c32 in LogStream::~LogStream() () 22:06 sfan5 https://github.com/minetest/minetest/blob/04dc4a10f03c2f7d28ae59c772bc726a9b6856cc/src/log.h#L293 there reference here looks a bit suspicious regarding destruction order, other than that no idea 22:06 sfan5 needs more debugging 23:12 MTDiscord Is there any reason why we don't use script_log_unique for all deprecation warnings?