| Time |
Nick |
Message |
| 01:49 |
|
ShadowBot joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 06:44 |
|
calcul0n joined #minetest-dev |
| 09:50 |
|
pgimeno joined #minetest-dev |
| 09:53 |
|
calcul0n_ joined #minetest-dev |
| 10:36 |
|
sugarbeet joined #minetest-dev |
| 10:48 |
|
appguru joined #minetest-dev |
| 13:06 |
|
calcul0n joined #minetest-dev |
| 14:09 |
|
Wuzzy joined #minetest-dev |
| 15:08 |
|
pgimeno_ joined #minetest-dev |
| 17:22 |
|
Pexin joined #minetest-dev |
| 17:29 |
|
vampirefrog joined #minetest-dev |
| 17:54 |
|
Desour joined #minetest-dev |
| 18:05 |
Wuzzy |
I just want to remind you that there are still at least 3 untranslatable strings in the settings menu: "Accessibility", "Movement" and "(Use system language)". |
| 18:05 |
Wuzzy |
just giving u a heads-up in case this gets forgotten in the action |
| 18:05 |
rubenwardy |
are you sure? Accessibility is called with `gettext` |
| 18:05 |
|
grorp joined #minetest-dev |
| 18:06 |
Wuzzy |
well its not in Weblate for some reason |
| 18:06 |
Wuzzy |
despite it being updated recently |
| 18:06 |
rubenwardy |
so is use system language |
| 18:06 |
rubenwardy |
maybe the extract string script doesn't work with some functions? |
| 18:07 |
rubenwardy |
local gettext = fgettext_ne |
| 18:07 |
rubenwardy |
I suppose it doesn't like this |
| 18:07 |
Wuzzy |
either that, or the script was run earlier than i thought |
| 18:08 |
Wuzzy |
oh sorry. "(Use system language)" is available. It's only "Accessibility" and "Movement" then, apparently |
| 18:09 |
Wuzzy |
rubenwardy: Yep you're right. updatepo.sh lists many function calls but not "gettext()" |
| 18:09 |
Wuzzy |
surprising |
| 18:16 |
erle |
Wuzzy given that you have a test lua file, would you appreciate help with making actual unit tests for the translation thing? |
| 18:16 |
Wuzzy |
mod_translation_updater.py? |
| 18:17 |
erle |
yes that one |
| 18:22 |
Wuzzy |
@rubenwardy: Here's my bugfix PR: https://github.com/minetest/minetest/pull/13977 |
| 18:23 |
Wuzzy |
erle, okay...what exactly am i supposed to do? you want me to write a new testing script or something or just the dummy lua file? |
| 18:24 |
rubenwardy |
Danke |
| 18:24 |
erle |
Wuzzy if you can state your expectations of input and output i can help you make a test case in this file even (it will only be executed when run with a test runner, like pytest) |
| 18:26 |
Wuzzy |
it has been ages ago i've written unit tests so my knowledge is quite rusty... so yeah thanks. would be a commented lua file be ok with you? |
| 18:26 |
erle |
well you could give me a single thing and i could make a test case and then you say if you appreciate it or not |
| 18:27 |
erle |
like ”when given this string, the translation should be like that” |
| 18:27 |
erle |
or something |
| 18:27 |
erle |
i do not understand too much of translations unfortunately |
| 18:28 |
erle |
but i think it is important to actually have tests to prevent regressions and explain what is happening here |
| 18:28 |
erle |
because those regexes look like magic to me rn |
| 18:28 |
erle |
so i guess a very small commented lua file would be great! |
| 18:28 |
erle |
(like don't put too much effort into it) |
| 18:35 |
erle |
btw https://docs.python.org/3/library/unittest.html#organizing-test-code |
| 18:35 |
|
grorp joined #minetest-dev |
| 18:38 |
grorp |
merging #13970, #13969 in 10 min |
| 18:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/13970 -- Fix auto_install_spec being used as a table by grorp |
| 18:38 |
ShadowBot |
https://github.com/minetest/minetest/issues/13969 -- Fix misrendered fall_damage_add_percent calculation formula by MisterE123 |
| 18:43 |
Wuzzy |
erle, where do i put the file? (just a quick and dirty dummy but with comments) |
| 18:43 |
erle |
https://mister-muffin.de/paste i guess |
| 18:43 |
erle |
webinterface here https://mister-muffin.de/post.htm |
| 18:44 |
Wuzzy |
ah tnaks. finally a pastebin that does not suck lol |
| 18:44 |
Wuzzy |
https://mister-muffin.de/p/jQrD.txt |
| 18:47 |
erle |
i see. so what would be the expected output, for say, a file that only has this line: S("@@=@@") |
| 18:47 |
erle |
> -- All strings MUST trigger an error and not appear in the resulting *.tr file |
| 18:48 |
erle |
if you trigger an error, does that mean you also halt then? |
| 18:48 |
Desour |
apropos core.features flag, as asked for yesterday, here's one: #13978 |
| 18:48 |
ShadowBot |
https://github.com/minetest/minetest/issues/13978 -- Add minetest.features.sound_parameter_table_has_start_time by Desour |
| 18:49 |
erle |
Desour now i wonder if there is some better way for future changes. like providing a dummy parameter metatable for functions or so. |
| 18:49 |
erle |
(i have no idea) |
| 18:51 |
Desour |
btw. this feature is also not listed in the changelog yet. will edit |
| 18:53 |
|
appguru joined #minetest-dev |
| 19:01 |
grorp |
Desour: regarding #13978, maybe s/sound_parameter_table_has_start_time/sound_parameter_table_start_time/? "has" seems strange to me, and it makes the name even longer. |
| 19:01 |
ShadowBot |
https://github.com/minetest/minetest/issues/13978 -- Add minetest.features.sound_parameter_table_has_start_time by Desour |
| 19:03 |
Desour |
ok |
| 19:04 |
Desour |
done |
| 19:08 |
grorp |
thanks |
| 19:15 |
Desour |
done with changelog changes |
| 19:15 |
Desour |
bye |
| 22:22 |
|
fluxionary joined #minetest-dev |
| 23:07 |
|
appguru joined #minetest-dev |
| 23:35 |
|
panwolfram joined #minetest-dev |
| 23:50 |
|
srifqi joined #minetest-dev |
| 23:55 |
srifqi |
hello. merging #13977 in around 5 minutes |
| 23:55 |
ShadowBot |
https://github.com/minetest/minetest/issues/13977 -- Fix bad translation function names in builtin by Wuzzy2 |
