| Time |
Nick |
Message |
| 00:34 |
|
proller joined #minetest-dev |
| 00:53 |
|
proller joined #minetest-dev |
| 00:59 |
|
proller joined #minetest-dev |
| 01:11 |
|
proller joined #minetest-dev |
| 01:14 |
|
Noisytoot joined #minetest-dev |
| 01:24 |
|
proller joined #minetest-dev |
| 01:58 |
|
YuGiOhJCJ joined #minetest-dev |
| 02:02 |
|
fluxionary joined #minetest-dev |
| 03:45 |
|
YuGiOhJCJ joined #minetest-dev |
| 04:48 |
|
fluxionary joined #minetest-dev |
| 05:00 |
|
MTDiscord joined #minetest-dev |
| 07:26 |
|
YuGiOhJCJ joined #minetest-dev |
| 08:11 |
|
libera-staff joined #minetest-dev |
| 10:21 |
|
YuGiOhJCJ joined #minetest-dev |
| 10:49 |
|
YuGiOhJCJ joined #minetest-dev |
| 11:14 |
|
appguru joined #minetest-dev |
| 13:30 |
erle |
would there be any issue with exposing minimap_color server-side? i ask because i am made a very simple photography mod https://mister-muffin.de/p/W912.png |
| 13:35 |
|
appguru joined #minetest-dev |
| 13:36 |
MTDiscord |
<warr1024> Is that minimap_color computed from a texture? It would probably have to involve handling the actual textures server-side (something I'd expect from modlib rather than minetest) and there would be no way to know what texturepack the client is using. |
| 13:37 |
MTDiscord |
<warr1024> tbh after seeing what minetestmapper goes through to estimate map colors, and how much manual work you still have to do to correct things, I've been considering just adding map RGBA to every node definition in NodeCore to spit out the colors.txt file automatically... |
| 13:37 |
erle |
if you look at src/script/common/c_content.cpp |
| 13:39 |
erle |
933#ifndef SERVER |
| 13:39 |
erle |
934push_ARGB8(L, c.minimap_color); // I know this is not set-able w/ register_node, |
| 13:39 |
erle |
935lua_setfield(L, -2, "minimap_color"); // but the people need to know! |
| 13:39 |
erle |
936#endif |
| 13:39 |
erle |
src/nodedef.cpp |
| 13:39 |
erle |
366:minimap_color = video::SColor(0, 0, 0, 0); |
| 13:39 |
erle |
821:minimap_color = tsrc->getTextureAverageColor(tiledef[0].name); |
| 13:40 |
erle |
i mean it's nice because it means you can make minimap CSM |
| 13:40 |
erle |
i guess |
| 13:43 |
MTDiscord |
<warr1024> Oh, nice, getTextureAverageColor is already part of the engine ... yes, even if this could only be used with "base" textures, it'd be really nice to have this accessible by the Lua API. We already have a need for it to produce those colors.txt files for minetestmapper. |
| 14:00 |
erle |
yeah and mcl_maps too |
| 14:00 |
erle |
i could even make minetest-mapper style maps with xmaps if this was exposed |
| 14:00 |
erle |
and i could also improve my photo mods |
| 14:26 |
|
grorp joined #minetest-dev |
| 14:26 |
|
grorp left #minetest-dev |
| 14:40 |
|
grorp joined #minetest-dev |
| 15:38 |
|
Sharpman joined #minetest-dev |
| 15:42 |
Sharpman |
@Warr1020 Would getTextureAverageColor respect foliaged color of the block or it would be just gray.. like in the MT mapper colors.txt? THX |
| 15:56 |
erle |
uh you can just see that on the minimap |
| 16:06 |
|
Sharpman joined #minetest-dev |
| 16:19 |
|
grorp1 joined #minetest-dev |
| 19:11 |
MTDiscord |
<jordan4ibanez> pitch range in sound spec |
| 19:21 |
MTDiscord |
<jordan4ibanez> Maybe when you actually place a node, it resets the animation or hyper speeds to the 0 position of the hand so that the sound can be linked to placing everytime |
| 19:41 |
jonadab |
The colors.txt files for the mapper don't _need_ to be produced from within the game; a separate command line tool would be fine. |
| 19:42 |
erle |
i think you are missing the point here |
| 19:42 |
jonadab |
Although whatever it is, ought to be able to parse module lua in order to match up node names with texture image files... |
| 19:42 |
jonadab |
Which the game already does. |
| 19:42 |
sfan5 |
here's a tip: https://github.com/minetest/minetestmapper/blob/master/util/generate_colorstxt.py |
| 19:42 |
jonadab |
erle: Possible. I came in part way through the conversation. |
| 19:43 |
erle |
jonadab it started with me realizing that this thing could be better if minimap_color was exposed on the server https://mister-muffin.de/p/xnLL.png – and then warr1024 realized it might even be more useful. mcl_maps currently ALSO needs an external file for the colors. |
| 19:44 |
jonadab |
Ah, I see. |
| 19:59 |
|
nrz joined #minetest-dev |
| 20:20 |
|
Desour joined #minetest-dev |
| 20:21 |
rubenwardy |
sfan5 are you ok with merging #13818 now? |
| 20:21 |
ShadowBot |
https://github.com/minetest/minetest/issues/13818 -- Debundle Minetest Game by rollerozxa |
| 20:22 |
rubenwardy |
then maybe release on 19th |
| 20:26 |
sfan5 |
a bit late to ask now but uh |
| 20:26 |
sfan5 |
do have have a proper main menu flow/UX to lead users to CDB yet? |
| 20:27 |
MTDiscord |
<greenxenith> Isnt there a thing on the main page that takes you to CDB if you dont have games installed? |
| 20:28 |
sfan5 |
i dont know |
| 20:28 |
MTDiscord |
<rollerozxa> yes, that's what #13550 did |
| 20:28 |
ShadowBot |
https://github.com/minetest/minetest/issues/13550 -- Improve UX when no game exists and drop `default_game` by rollerozxa |
| 20:29 |
sfan5 |
oh hey I reviewed that |
| 20:29 |
MTDiscord |
<greenxenith> lol |
| 20:30 |
rubenwardy |
- no games and no world: user is directed to install a game from CDB |
| 20:30 |
rubenwardy |
- no games and MTG world: user is directed to install MTG, and is left in the CDB game's page |
| 20:30 |
rubenwardy |
- MTG games: shows update in content tab that migrates install to CDB |
| 20:30 |
erle |
what exactly happens if other games are installed and mtg suddenly vanishes? |
| 20:31 |
MTDiscord |
<greenxenith> Why would MTG suddenly vanish? Isnt it in the same directory as the other games? |
| 20:31 |
erle |
because of that update |
| 20:31 |
rubenwardy |
amend 2) to be "mtg not installed and mtg world" |
| 20:31 |
erle |
now i get it |
| 20:31 |
rubenwardy |
if you have other games and not MTG, it'll still show the dialog if you have MTG worlds |
| 20:32 |
rubenwardy |
GreenXenith: if MTG is no longer included by package managers it's likely to be removed on update |
| 20:32 |
MTDiscord |
<greenxenith> My MTG is installed through my package manager but my MTG is still in my data dir |
| 20:33 |
rubenwardy |
Oh I remember, I wanted to check that auto installs kept ?reason=new or ?reason=update |
| 20:33 |
MTDiscord |
<greenxenith> er, sorry, Minetest is installed* |
| 20:33 |
erle |
anyone in contact with distro maintainers? or is it a “it will sort itself out, pray and spray” situation? |
| 20:34 |
MTDiscord |
<greenxenith> I have Minetest installed via apt, but MTG is in my home data dir. But maybe that is just due to years of other config |
| 20:34 |
sfan5 |
idea: someone with a hand for it could edit the no game installed text to be a bit nicer |
| 20:34 |
sfan5 |
something like "Minetest is all about games. Install one to play or check out servers online." |
| 20:34 |
sfan5 |
(imagine the cursive parts are clickable links) |
| 20:35 |
MTDiscord |
<greenxenith> That would be for next release though, yeah? |
| 20:35 |
erle |
the text that is currently ”You have no games installed. Install a game.”? it is so dry, the only thing missing is “you have 20 seconds to comply” |
| 20:35 |
sfan5 |
also the note to stop installing MTG needs to be at the top of the release notes |
| 20:36 |
|
appguru joined #minetest-dev |
| 20:37 |
celeron55 |
erle: traditionally minetest has mostly just tried to do sane things and hope the distro maintainers didn't set up too difficult traps for themselves. if you'd like to contact some, feel free to |
| 20:38 |
MTDiscord |
<greenxenith> so.. is it ok to merge the debundle PR? |
| 20:38 |
erle |
celeron55 the issue here is mostly: is it okay for the dev team if a distro maintainer screws up and then minetest_game ends up being installed by the user in the homedir? because that would mean that any future engine change that affects minetest_game could break something and it could not be automatically unbroken. |
| 20:39 |
erle |
so given that old enough minetest_game (~2 years) and new minetest already crash, i just want to point out that this is a possibility |
| 20:39 |
erle |
(each user would have to update from cdb obviously) |
| 20:40 |
celeron55 |
my stance on distros is: there are too many distros, MT cannot be responsible for them, it would take all of the project's resources and all progress would stop |
| 20:40 |
erle |
well you don't have to care. i don't. |
| 20:41 |
erle |
i just think this transition can be done only once and everything either needs to be accounted for or explicitly viewed as “nothing of value lost” scenario. |
| 20:42 |
MTDiscord |
<greenxenith> Package managers arent going to have an issue "accidentally installing" MTG somewhere wrong ... MTG was just included in the package. They dont touch the stuff inside the package. So now the worst case is juts that MTG in the system dirs disappears beacuse it gets overwritten by our new version of the package |
| 20:42 |
MTDiscord |
<greenxenith> just that* |
| 20:42 |
erle |
yes |
| 20:43 |
erle |
if that's okay, then next topic |
| 20:44 |
celeron55 |
it would of course be polite to link the PR to known maintainers, as it specially affects packaging |
| 20:44 |
Desour |
if we want to make sure to get rid of mtg, writing an e-mail to all the package maintainers wouldn't hurt. it shouldn't be too hard to get most mail addresses, as maintainers are usually noted in package metadata |
| 20:44 |
sfan5 |
at this point? not sure, there's not much actionable stuff in there |
| 20:44 |
sfan5 |
and too unclear |
| 20:45 |
celeron55 |
well i'm sure they'll figure it out in time |
| 20:45 |
celeron55 |
as long as some big bold letters are used in the changelog, it'll work out fine enough |
| 20:47 |
celeron55 |
it can also be that some maintainers will insist on continuing to package and recommend minetest_game |
| 20:48 |
celeron55 |
it won't be a disaster |
| 20:48 |
ROllerozxa |
heh, probably something debian would do |
| 20:48 |
ROllerozxa |
anyways if packagers just do `make install` for their packaging then MTG will not get included in the package anymore |
| 20:48 |
Desour |
or they don't read the changelog and only become active if something visibly breaks |
| 20:49 |
MTDiscord |
<greenxenith> all this to say ... the PR is fine to merge, right? :)) |
| 20:49 |
ROllerozxa |
adding it as a bold note at the top of the release notes sounds like a good idea, even for non-packagers it is probably an important change in this release |
| 20:49 |
ROllerozxa |
greenxenith: it has 4 approvals now so I better hope so |
| 20:52 |
erle |
maximum approval |
| 20:53 |
celeron55 |
don't tell me you're so scared to press the button that i have to do it |
| 20:53 |
erle |
meanwhile i noticed that deprecating ${} makes items with both inline wield_image and inline inventory_image twice as heavy, because the image has to be included twice. were there any problems with it that could not be solved with it having a recursion limit of 3 or so? |
| 20:54 |
erle |
(for context, i am using raycast to make renderings of ingame scenes, so the picture is not 16×16) |
| 20:58 |
MTDiscord |
<greenxenith> Now add color :^) |
| 21:01 |
erle |
that was my original plan, but then i noticed that the minimap_color of nodes is only exposed to CSMs apparently. i should file an issue for both of those things ig. |
| 21:02 |
MTDiscord |
<greenxenith> Or you could map all textures and read the pixels on a face :^) |
| 21:02 |
MTDiscord |
<greenxenith> (mostly joking) |
| 21:03 |
|
grorp joined #minetest-dev |
| 21:07 |
grorp |
I'll press the button in 10 min if nobody objects or does it before me |
| 21:07 |
grorp |
I'm probably just an impatient person :) |
| 21:11 |
erle |
grorp do the funni! |
| 21:18 |
ROllerozxa |
oh my |
| 21:19 |
grorp |
wow |
| 21:20 |
MTDiscord |
<greenxenith> he did the thing |
| 21:20 |
ROllerozxa |
I feel like I am witnessing history take place right in front of me |
| 21:22 |
|
nore joined #minetest-dev |
| 21:23 |
erle |
we did it, minetest_game is no more! |
| 21:23 |
erle |
(next up: bundle nodecore) |
| 21:33 |
|
grorp joined #minetest-dev |
| 22:01 |
rubenwardy |
grorp: auto_install_spec seems to be a string but line 710 assumes it's a table with `author` and `name`. Results in a bad error message |
| 22:02 |
rubenwardy |
did you mean to support both id and table forms? |
| 23:33 |
|
panwolfram joined #minetest-dev |
| 23:55 |
|
srifqi joined #minetest-dev |
| 23:56 |
srifqi |
ah, i missed the party |
| 23:56 |
srifqi |
anyway, merging #13504, #13887, and #13939 in around 4 minutes |
| 23:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/13504 -- Move `world_format.txt` to `world_format.md` and refactor by Bituvo |
| 23:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/13887 -- Lump MT_LOGCOLOR environ together with other color environs by corpserot |
| 23:56 |
ShadowBot |
https://github.com/minetest/minetest/issues/13939 -- Extract updateClouds method from updateFrame by JosiahWI |
