Time Nick Message 05:25 dani-0tb hello! 11:09 sfan5 merging #13913 in 15m 11:09 ShadowBot https://github.com/minetest/minetest/issues/13913 -- Fix issues in Minetest's English texts by srifqi 11:24 sfan5 done 11:24 sfan5 will probably do a translation update later then 15:09 Desour it's 15:09 UTC, dev meeting? 15:15 srifqi it should be 15:18 sfan5 what's on the agenda? 15:19 sfan5 https://dev.minetest.net/Meetings#2023-10-29 15:21 srifqi PR stuffs 15:21 srifqi maybe an evaluation in preparation of 5.8.0 release? 15:24 MTDiscord I'd like some input/opinions on two points: 1. Do we need to backup MTG before migrating it to CDB? (#13906) 2. Do you agree with the revert proposed by #13942 for the release? 15:24 ShadowBot https://github.com/minetest/minetest/issues/13906 -- Offer ContentDB updates for leftover bundled Minetest Game by grorp 15:24 ShadowBot https://github.com/minetest/minetest/issues/13942 -- Revert "Don't trigger a key event if a key with the same associated char was pressed (#13773)" by erlehmann 15:26 erle i maintain that the people who can still input a + on their keyboard either have a keypad or a layout like german QWERTZ (or shift is handled specially somehow now, i don't know) 15:30 srifqi 1. I think that we don't have to create a backup for MTG. The player/user needs to deliberately upgrade to the CDB version (not automatic). 15:30 srifqi 2. I'm not sure about it. 15:32 erle well what kind of keyboard layouts do you all have? 15:33 erle and can you input a +? 15:33 srifqi i'm using laptop without external keyboard 15:33 erle and how do you input a + sign? 15:33 erle in minetest 15:33 srifqi Shift + = 15:35 erle srifqi and that *works*? 15:35 srifqi Right Shift specifically if i want to change the render distance without going down/descend (Left Shift) 15:35 erle so what if you press left shift? 15:35 srifqi yes, Shift + = equals + 15:35 srifqi Left Shift still works, but i also descend when in fly mode 15:36 erle i guess then this is two changes interacting here 15:36 erle wait, can you bind / ? 15:36 erle i assume you need to press shift for that 15:36 Desour '/' is bound by default, to chatcommand 15:36 srifqi it is bound to chat command, yes 15:37 erle yes but can you *input* it and *bind* it? 15:37 srifqi ? 15:37 erle like how does it work that the keybinding dialog does not bind shift? 15:37 erle if you press shift and another key 15:37 erle if i press iso level 3 shift and b (which results in +) it tries to bind either b or iso level 3 shift 15:37 srifqi i can bind ? (Shift + /) 15:38 erle so if i understand correctly, in the keybinding dialog ONLY pressing shift binds shift and pressing shift and another key binds the *character*? 15:38 srifqi yes, i guess 15:38 erle did you try it? 15:39 erle i mean + is bound by default 15:41 sfan5 1. no IMO (already commented) 2. The bug it fixes looked quite minor to me so should be okay 15:41 srifqi i tried binding ? 15:41 erle btw i think grorp and v-rob are right about keyboard handling 15:41 erle srifqi thanks 15:42 erle it should be based on physical things at some point (but then the mapping must work properly, which it does not now, regardless of if you use SLD or not) 15:42 erle SDL 15:43 Krock sorry; forgot about the meeting. 15:44 Krock @grorp 1. I don't think a backup is needed. It's their fault if they modified it on purpose without renaming or version contol 15:45 Krock 2. that will un-fix #13770 which also has valid reasons to exist 15:45 ShadowBot https://github.com/minetest/minetest/issues/13770 -- Keypad input doubles as digit input 15:45 erle Krock then it will hit the users who are likely to know the *least* about technical matters 15:46 erle Krock the fix causes 2 regressions which means it is arguably botched 15:46 Krock whole we're at it - shouldn't this depend on numlock? 15:46 Krock *while 15:46 erle should what depend on it? if there is a + character? does + on numlock do other stuff for you? (it does not for me) 15:47 Krock I'm not talking about the + which has obviously no effect 15:47 erle well then what is ”this” which should depend on numlock? 15:47 Krock but the arrow keys and digits that can be switched in between using NumLock 15:47 Krock can you pelase fucking wait until I finish typing??? 15:48 erle sorry i see no typing notifications in my client (but i can research how this works on irc) 15:48 Krock from how I understand the original issue - NumLock did not make any effect on these keys? 15:49 Krock s/make/take/ 15:50 Krock I suppose this issue could be fixed by treating the numpad like their original keys but in regard to the NumLock state...? 15:50 erle Krock it looks like fixing this without regressions needs both explicit support for key combinations making chars AND distinguishing keys physically. just doing one of those things leads to regressions probably 15:50 erle if this is indeed numlock related i do not know 15:51 erle the submitter of the issue does not actually mention num lock 15:52 erle Krock i'll check quickly if numlock changes anything rn, maybe the submitter did not know 15:57 Krock SKeyInput::Char depends on NumLock 15:57 Krock SKeyInput::Key does not 16:00 erle Krock does that mean the submitter could just toggle numlock and get something working? 16:00 erle ; numlockx on 16:00 erle X Error of failed request: BadValue (integer parameter out of range for operation) 16:00 erle it seems i can not into numlock sorry :( 16:02 Krock that might be the easiest solution, yes. 16:06 erle then i wonder if the whole thing was bogus from the start hehe 16:07 erle but in the end, ig minetest will have to a) support binding physical keys b) support binding *multiple* of them c) support binding *combinations* of them 16:09 Krock and in Y2345 Minetest will be feature-complete 16:10 * sfan5 afk 16:12 erle Krock i think all of that will come with the proper SDL work anyway 16:12 erle Krock it just needs to be batched to be done all at once (or in defined steps) so that you don't get a broken in-between state 16:14 MTDiscord Numlock didn't work for me in that issue. Did you check with SDL2? 16:17 Krock @savilli works for me with master + #13942 reverted 16:17 ShadowBot https://github.com/minetest/minetest/issues/13942 -- Revert "Don't trigger a key event if a key with the same associated char was pressed (#13773)" by erlehmann 16:17 Krock also without SDL2 16:24 erle Test assertion failed: did_destruct 16:24 erle at test_lua.cpp:100 16:24 erle [FAIL] testLuaDestructors - 0ms 16:24 erle this is on x86, am i compiling minetest wrong maybe? 16:25 MTDiscord So both IrrDeviceSDL and IrrDeviceLinux produce an event with KeyInput.Char=0 if numlock is enabled? 16:25 MTDiscord Or you're not a linux user? 16:26 Krock @savilli I can only confirm that IrrDeviceLinux gives Char=0 when numlock is disabled (because there is no printable character for these control keys) 16:27 Krock and Char != 0 when pressing down with NumLock enabled (i.e. keys 0-9) 16:27 erle well that seems like it was originally an user error then? 16:28 Krock they might've expected that numblock keys are entirely handled differently which is arguable 16:31 MTDiscord Krock: but did you check IrrDeviceSDL? 16:32 erle savilli thanks https://github.com/minetest/minetest/pull/13942/commits/e41f8365e14eced57f2390603b0e45ce3845eb84 16:33 erle savilli if you want better email please tell 16:33 MTDiscord The original issue was reported on windows, may be broken there too 16:35 MTDiscord But I think windows is not important if we're migrating to SDL anyways, but SDL should be tested 16:37 MTDiscord Supporting binding physical keys should be easy, right? 16:39 MTDiscord We can bind to chars by default, but allow to bind to physical keys by using a special prefix in minetest.conf. It wouldn't be very user-friendly, but would fix both issues. 16:42 grorp Merging #13943 in 10 min 16:42 ShadowBot https://github.com/minetest/minetest/issues/13943 -- Fix hypertext[] sometimes calculating incorrect scrollbar height by grorp 17:34 ROllerozxa I made an issue #13945 for the unused settings translation strings so it doesn't get forgotten 17:34 ShadowBot https://github.com/minetest/minetest/issues/13945 -- Exclude setting names and descriptions in the temporary settings category in translations 17:36 sfan5 if we can fix that quickly before the next translation update that would be good 18:36 erle savilli the problem with physical keys, as v-rob and me figured out a while ago is that not every physical key on every keyboard is reported the same 18:37 erle savilli v-rob wrote this progrem for SDL recently: https://gist.github.com/v-rob/4ef28c7ae9f45fcf697dbc0f3a64ee5c 18:38 erle when you use it to check scancodes and keycodes for different keyboards you may find that it works or that it does not, who knows. but it should help you with your “this is easy, rigfht?” intuition 18:38 erle this is SDL though 18:38 erle it's just this whole thing is messy 18:39 erle like i said before, for some reason the num lock key on my cheap dutch QWERTY keyboard is detected as a tab key. 19:19 [MTMatrix] Every meeting point has bren skipped 19:19 [MTMatrix] *been 19:20 [MTMatrix] Can I have an answer about 19:20 [MTMatrix] "Final answer about internal discussion n°71" ? 19:21 MTDiscord There was a meeting? 19:21 [MTMatrix] I personally haven't changed my mind 19:23 MTDiscord Which discussion is discussion 71 19:25 [MTMatrix] If you have access to "Discussions", go to number 71 19:26 MTDiscord Ah, didn't know github discussions were a thing 19:27 rubenwardy discussions is only visible to those in the 'engine', 'game', and 'triagers' groups 19:29 MTDiscord I'd rather not suggest myself :)) 19:29 MTDiscord Subject*